this belongs to the Impl not a specific model

[simgrid.git] / src / surf / disk_s19.cpp

diff --git a/src/surf/disk_s19.cpp b/src/surf/disk_s19.cpp
index b0471f3..d376ba2 100644 (file)
--- a/src/surf/disk_s19.cpp
+++ b/src/surf/disk_s19.cpp
@@ -3,6 +3,7 @@
 /* This program is free software; you can redistribute it and/or modify it
  * under the terms of the license (GNU LGPL) which comes with this package. */
 
+#include "simgrid/sg_config.hpp"
 #include <simgrid/kernel/routing/NetPoint.hpp>
 #include <simgrid/kernel/routing/NetZoneImpl.hpp>
 #include <simgrid/s4u/Engine.hpp>
@@ -14,6 +15,12 @@
 #include "src/surf/disk_s19.hpp"
 
 XBT_LOG_EXTERNAL_DEFAULT_CATEGORY(res_disk);
+/***********
+ * Options *
+ ***********/
+static simgrid::config::Flag<std::string> cfg_disk_solver("disk/solver",
+                                                          "Set linear equations solver used by disk model", "maxmin",
+                                                          &simgrid::kernel::lmm::System::validate_solver);
 
 /*********
  * Model *
@@ -28,6 +35,15 @@ void surf_disk_model_init_S19()
 }
 
 namespace simgrid::kernel::resource {
+/*********
+ * Model *
+ *********/
+
+DiskS19Model::DiskS19Model(const std::string& name) : DiskModel(name)
+{
+  set_maxmin_system(lmm::System::build(cfg_disk_solver.get(), true /* selective update */));
+}
+
 
 DiskImpl* DiskS19Model::create_disk(const std::string& name, double read_bandwidth, double write_bandwidth)
 {
@@ -49,52 +65,9 @@ void DiskS19Model::update_actions_state(double /*now*/, double delta)
   }
 }
 
-DiskAction* DiskS19Model::io_start(const DiskImpl* disk, sg_size_t size, s4u::Io::OpType type)
-{
-  auto* action = new DiskS19Action(this, static_cast<double>(size), not disk->is_on());
-  get_maxmin_system()->expand(disk->get_constraint(), action->get_variable(), 1.0);
-  switch (type) {
-    case s4u::Io::OpType::READ:
-      get_maxmin_system()->expand(disk->get_read_constraint(), action->get_variable(), 1.0);
-      break;
-    case s4u::Io::OpType::WRITE:
-      get_maxmin_system()->expand(disk->get_write_constraint(), action->get_variable(), 1.0);
-      break;
-    default:
-      THROW_UNIMPLEMENTED;
-  }
-  if (const auto& factor_cb = disk->get_factor_cb()) { // handling disk variability
-    action->set_rate_factor(factor_cb(size, type));
-  }
-  return action;
-}
-
 /************
  * Resource *
  ************/
-void DiskS19::set_read_bandwidth(double value)
-{
-  DiskImpl::set_read_bandwidth(value);
-  if (get_read_constraint()) {
-    get_model()->get_maxmin_system()->update_constraint_bound(get_read_constraint(), get_read_bandwidth());
-  }
-}
-
-void DiskS19::set_write_bandwidth(double value)
-{
-  DiskImpl::set_write_bandwidth(value);
-  if (get_write_constraint()) {
-    get_model()->get_maxmin_system()->update_constraint_bound(get_write_constraint(), get_write_bandwidth());
-  }
-}
-
-void DiskS19::set_readwrite_bandwidth(double value)
-{
-  DiskImpl::set_readwrite_bandwidth(value);
-  if (get_constraint()) {
-    get_model()->get_maxmin_system()->update_constraint_bound(get_constraint(), get_readwrite_bandwidth());
-  }
-}
 
 void DiskS19::apply_event(kernel::profile::Event* triggered, double value)
 {
@@ -128,8 +101,24 @@ DiskS19Action::DiskS19Action(Model* model, double cost, bool failed)
 {
 }
 
-void DiskS19Action::update_remains_lazy(double /*now*/)
+DiskAction* DiskS19::io_start(sg_size_t size, s4u::Io::OpType type)
 {
-  THROW_IMPOSSIBLE;
+  auto* action = new DiskS19Action(get_model(), static_cast<double>(size), not is_on());
+  get_model()->get_maxmin_system()->expand(get_constraint(), action->get_variable(), 1.0);
+  switch (type) {
+    case s4u::Io::OpType::READ:
+      get_model()->get_maxmin_system()->expand(get_read_constraint(), action->get_variable(), 1.0);
+      break;
+    case s4u::Io::OpType::WRITE:
+      get_model()->get_maxmin_system()->expand(get_write_constraint(), action->get_variable(), 1.0);
+      break;
+    default:
+      THROW_UNIMPLEMENTED;
+  }
+  if (const auto& factor_cb = get_factor_cb()) { // handling disk variability
+    action->set_rate_factor(factor_cb(size, type));
+  }
+  return action;
 }
+
 } // namespace simgrid::kernel::resource