-/* Copyright (c) 2011-2017. The SimGrid Team. All rights reserved. */
+/* Copyright (c) 2011-2023. The SimGrid Team. All rights reserved. */
/* This program is free software; you can redistribute it and/or modify it
* under the terms of the license (GNU LGPL) which comes with this package. */
+#include "src/mc/VisitedState.hpp"
+#include "src/mc/explo/Exploration.hpp"
+#include "src/mc/mc_config.hpp"
+#include "src/mc/mc_private.hpp"
+
#include <unistd.h>
#include <sys/wait.h>
-
#include <memory>
-
#include <boost/range/algorithm.hpp>
-#include "xbt/log.h"
-#include "xbt/sysdep.h"
-
-#include "src/mc/VisitedState.hpp"
-#include "src/mc/mc_comm_pattern.hpp"
-#include "src/mc/mc_private.hpp"
-#include "src/mc/mc_smx.hpp"
-#include "src/mc/remote/RemoteClient.hpp"
-
XBT_LOG_NEW_DEFAULT_SUBCATEGORY(mc_VisitedState, mc, "Logging specific to state equality detection mechanisms");
-namespace simgrid {
-namespace mc {
-
-static int snapshot_compare(simgrid::mc::VisitedState* state1, simgrid::mc::VisitedState* state2)
-{
- simgrid::mc::Snapshot* s1 = state1->system_state.get();
- simgrid::mc::Snapshot* s2 = state2->system_state.get();
- int num1 = state1->num;
- int num2 = state2->num;
- return snapshot_compare(num1, s1, num2, s2);
-}
+namespace simgrid::mc {
/** @brief Save the current state */
-VisitedState::VisitedState(unsigned long state_number) : num(state_number)
+VisitedState::VisitedState(unsigned long state_number, unsigned int actor_count, RemoteApp& remote_app)
+ : heap_bytes_used_(remote_app.get_remote_process_memory().get_remote_heap_bytes())
+ , actor_count_(actor_count)
+ , num_(state_number)
{
- simgrid::mc::RemoteClient* process = &(mc_model_checker->process());
- this->heap_bytes_used = mmalloc_get_bytes_used_remote(
- process->get_heap()->heaplimit,
- process->get_malloc_info());
-
- this->actors_count = mc_model_checker->process().actors().size();
-
- this->system_state = simgrid::mc::take_snapshot(state_number);
- this->original_num = -1;
+ this->system_state_ = std::make_shared<simgrid::mc::Snapshot>(state_number, remote_app.get_page_store(),
+ remote_app.get_remote_process_memory());
}
void VisitedStates::prune()
{
while (states_.size() > (std::size_t)_sg_mc_max_visited_states) {
XBT_DEBUG("Try to remove visited state (maximum number of stored states reached)");
- auto min_element = boost::range::min_element(states_,
- [](std::unique_ptr<simgrid::mc::VisitedState>& a, std::unique_ptr<simgrid::mc::VisitedState>& b) {
- return a->num < b->num;
- });
+ auto min_element = boost::range::min_element(
+ states_, [](const std::unique_ptr<simgrid::mc::VisitedState>& a,
+ const std::unique_ptr<simgrid::mc::VisitedState>& b) { return a->num_ < b->num_; });
xbt_assert(min_element != states_.end());
// and drop it:
states_.erase(min_element);
}
}
-/** \brief Checks whether a given state has already been visited by the algorithm.
- */
-std::unique_ptr<simgrid::mc::VisitedState> VisitedStates::addVisitedState(
- unsigned long state_number, simgrid::mc::State* graph_state, bool compare_snpashots)
+/** @brief Checks whether a given state has already been visited by the algorithm. */
+std::unique_ptr<simgrid::mc::VisitedState>
+VisitedStates::addVisitedState(unsigned long state_number, simgrid::mc::State* graph_state, RemoteApp& remote_app)
{
- std::unique_ptr<simgrid::mc::VisitedState> new_state =
- std::unique_ptr<simgrid::mc::VisitedState>(new VisitedState(state_number));
- graph_state->system_state = new_state->system_state;
- XBT_DEBUG("Snapshot %p of visited state %d (exploration stack state %d)",
- new_state->system_state.get(), new_state->num, graph_state->num);
-
- auto range =
- boost::range::equal_range(states_, new_state.get(), simgrid::mc::DerefAndCompareByActorsCountAndUsedHeap());
-
- if (compare_snpashots)
- for (auto i = range.first; i != range.second; ++i) {
- auto& visited_state = *i;
- if (snapshot_compare(visited_state.get(), new_state.get()) == 0) {
- // The state has been visited:
-
- std::unique_ptr<simgrid::mc::VisitedState> old_state =
- std::move(visited_state);
-
- if (old_state->original_num == -1) // I'm the copy of an original process
- new_state->original_num = old_state->num;
- else // I'm the copy of a copy
- new_state->original_num = old_state->original_num;
-
- if (dot_output == nullptr)
- XBT_DEBUG("State %d already visited ! (equal to state %d)",
- new_state->num, old_state->num);
- else
- XBT_DEBUG("State %d already visited ! (equal to state %d (state %d in dot_output))",
- new_state->num, old_state->num, new_state->original_num);
-
- /* Replace the old state with the new one (with a bigger num)
- (when the max number of visited states is reached, the oldest
- one is removed according to its number (= with the min number) */
- XBT_DEBUG("Replace visited state %d with the new visited state %d",
- old_state->num, new_state->num);
-
- visited_state = std::move(new_state);
- return old_state;
- }
+ auto new_state =
+ std::make_unique<simgrid::mc::VisitedState>(state_number, graph_state->get_actor_count(), remote_app);
+
+ graph_state->set_system_state(new_state->system_state_);
+ XBT_DEBUG("Snapshot %p of visited state %ld (exploration stack state %ld)", new_state->system_state_.get(),
+ new_state->num_, graph_state->get_num());
+
+ auto [range_begin, range_end] = boost::range::equal_range(states_, new_state.get(), [](auto const& a, auto const& b) {
+ return std::make_pair(a->actor_count_, a->heap_bytes_used_) < std::make_pair(b->actor_count_, b->heap_bytes_used_);
+ });
+
+ for (auto i = range_begin; i != range_end; ++i) {
+ auto& visited_state = *i;
+ if (visited_state->system_state_->equals_to(*new_state->system_state_.get(),
+ remote_app.get_remote_process_memory())) {
+ // The state has been visited:
+
+ std::unique_ptr<simgrid::mc::VisitedState> old_state = std::move(visited_state);
+
+ if (old_state->original_num_ == -1) // I'm the copy of an original process
+ new_state->original_num_ = old_state->num_;
+ else // I'm the copy of a copy
+ new_state->original_num_ = old_state->original_num_;
+
+ XBT_DEBUG("State %ld already visited ! (equal to state %ld (state %ld in dot_output))", new_state->num_,
+ old_state->num_, new_state->original_num_);
+
+ /* Replace the old state with the new one (with a bigger num)
+ (when the max number of visited states is reached, the oldest
+ one is removed according to its number (= with the min number) */
+ XBT_DEBUG("Replace visited state %ld with the new visited state %ld", old_state->num_, new_state->num_);
+
+ visited_state = std::move(new_state);
+ return old_state;
}
+ }
- XBT_DEBUG("Insert new visited state %d (total : %lu)", new_state->num, (unsigned long) states_.size());
- states_.insert(range.first, std::move(new_state));
+ XBT_DEBUG("Insert new visited state %ld (total : %lu)", new_state->num_, (unsigned long)states_.size());
+ states_.insert(range_begin, std::move(new_state));
this->prune();
return nullptr;
}
-}
-}
+} // namespace simgrid::mc
