-/* Copyright (c) 2013-2014. The SimGrid Team.
+/* Copyright (c) 2013-2020. The SimGrid Team.
* All rights reserved. */
/* This program is free software; you can redistribute it and/or modify it
* copyright file COPYRIGHT in the top level MVAPICH2 directory.
*
*/
-
-#include "../colls_private.h"
+
+#include "../colls_private.hpp"
+#include <algorithm>
+
extern int mv2_reduce_intra_knomial_factor;
extern int mv2_reduce_inter_knomial_factor;
#define SMPI_DEFAULT_KNOMIAL_FACTOR 4
// int mv2_reduce_knomial_factor = 2;
-
-
-
-static int MPIR_Reduce_knomial_trace(int root, int reduce_knomial_factor,
+
+
+
+static int MPIR_Reduce_knomial_trace(int root, int reduce_knomial_factor,
MPI_Comm comm, int *dst, int *expected_send_count,
int *expected_recv_count, int **src_array)
{
int mask=0x1, k, comm_size, src, rank, relative_rank, lroot=0;
- int orig_mask=0x1;
+ int orig_mask=0x1;
int recv_iter=0, send_iter=0;
int *knomial_reduce_src_array=NULL;
comm_size = comm->size();
lroot = root;
relative_rank = (rank - lroot + comm_size) % comm_size;
- /* First compute to whom we need to send data */
+ /* First compute to whom we need to send data */
while (mask < comm_size) {
if (relative_rank % (reduce_knomial_factor*mask)) {
*dst = relative_rank/(reduce_knomial_factor*mask)*
}
mask /= reduce_knomial_factor;
- /* Now compute how many children we have in the knomial-tree */
- orig_mask = mask;
+ /* Now compute how many children we have in the knomial-tree */
+ orig_mask = mask;
while (mask > 0) {
for(k=1;k<reduce_knomial_factor;k++) {
if (relative_rank + mask*k < comm_size) {
mask /= reduce_knomial_factor;
}
- /* Finally, fill up the src array */
- if(recv_iter > 0) {
- knomial_reduce_src_array = static_cast<int*>(smpi_get_tmp_sendbuffer(sizeof(int)*recv_iter));
- }
+ /* Finally, fill up the src array */
+ if(recv_iter > 0) {
+ knomial_reduce_src_array = new int[recv_iter];
+ }
- mask = orig_mask;
- recv_iter=0;
+ mask = orig_mask;
+ recv_iter=0;
while (mask > 0) {
for(k=1;k<reduce_knomial_factor;k++) {
if (relative_rank + mask*k < comm_size) {
*expected_recv_count = recv_iter;
*expected_send_count = send_iter;
- *src_array = knomial_reduce_src_array;
- return 0;
+ *src_array = knomial_reduce_src_array;
+ return 0;
}
-
-namespace simgrid{
-namespace smpi{
-int Coll_reduce_mvapich2_knomial::reduce (
- void *sendbuf,
+
+namespace simgrid {
+namespace smpi {
+int reduce__mvapich2_knomial(
+ const void *sendbuf,
void *recvbuf,
int count,
MPI_Datatype datatype,
MPI_Comm comm)
{
int mpi_errno = MPI_SUCCESS;
- int rank, is_commutative;
+ int rank;
int src, k;
MPI_Request send_request;
int index=0;
MPI_Aint true_lb, true_extent, extent;
- MPI_Status status;
+ MPI_Status status;
int recv_iter=0, dst=-1, expected_send_count, expected_recv_count;
int *src_array=NULL;
- void **tmp_buf=NULL;
- MPI_Request *requests=NULL;
-
if (count == 0) return MPI_SUCCESS;
datatype->extent(&true_lb, &true_extent);
extent = datatype->get_extent();
- is_commutative = (op==MPI_OP_NULL || op->is_commutative());
+ bool is_commutative = (op == MPI_OP_NULL || op->is_commutative());
if (rank != root) {
- recvbuf=(void *)smpi_get_tmp_recvbuffer(count*(MAX(extent,true_extent)));
+ recvbuf = (void*)smpi_get_tmp_recvbuffer(count * std::max(extent, true_extent));
recvbuf = (void *)((char*)recvbuf - true_lb);
}
}
- MPIR_Reduce_knomial_trace(root, mv2_reduce_intra_knomial_factor, comm,
+ MPIR_Reduce_knomial_trace(root, mv2_reduce_intra_knomial_factor, comm,
&dst, &expected_send_count, &expected_recv_count, &src_array);
if(expected_recv_count > 0 ) {
- tmp_buf = static_cast<void**>(xbt_malloc(sizeof(void *)*expected_recv_count));
- requests = static_cast<MPI_Request*>(xbt_malloc(sizeof(MPI_Request)*expected_recv_count));
- for(k=0; k < expected_recv_count; k++ ) {
- tmp_buf[k] = smpi_get_tmp_sendbuffer(count*(MAX(extent,true_extent)));
- tmp_buf[k] = (void *)((char*)tmp_buf[k] - true_lb);
+ unsigned char** tmp_buf = new unsigned char*[expected_recv_count];
+ MPI_Request* requests = new MPI_Request[expected_recv_count];
+ for (k = 0; k < expected_recv_count; k++) {
+ tmp_buf[k] = smpi_get_tmp_sendbuffer(count * std::max(extent, true_extent));
+ tmp_buf[k] = tmp_buf[k] - true_lb;
}
while(recv_iter < expected_recv_count) {
for(k=0; k < expected_recv_count; k++ ) {
smpi_free_tmp_buffer(tmp_buf[k]);
}
- xbt_free(tmp_buf);
- xbt_free(requests);
+ delete[] tmp_buf;
+ delete[] requests;
}
- if(src_array != NULL) {
- xbt_free(src_array);
- }
+ if(src_array != NULL) {
+ delete[] src_array;
+ }
if(rank != root) {
send_request=Request::isend(recvbuf,count, datatype, dst,
Request::waitall(1, &send_request, &status);
- smpi_free_tmp_buffer((void *)((char*)recvbuf + true_lb));
+ smpi_free_tmp_buffer(static_cast<unsigned char*>(recvbuf) + true_lb);
}
/* --END ERROR HANDLING-- */
