simgrid::xbt::signal<void(s4u::Storage&)> Storage::on_destruction;
simgrid::xbt::signal<void(s4u::Storage&)> Storage::on_state_change;
-Storage::Storage(std::string name, surf::StorageImpl* pimpl) : pimpl_(pimpl), name_(name)
+Storage::Storage(std::string name, surf::StorageImpl* pimpl) : pimpl_(pimpl), name_(std::move(name))
{
- simgrid::s4u::Engine::get_instance()->storage_register(name, this);
+ simgrid::s4u::Engine::get_instance()->storage_register(name_, this);
}
-Storage* Storage::by_name(std::string name)
+Storage* Storage::by_name(const std::string& name)
{
return Engine::get_instance()->storage_by_name(name);
}
-Storage* Storage::by_name_or_null(std::string name)
+Storage* Storage::by_name_or_null(const std::string& name)
{
return Engine::get_instance()->storage_by_name_or_null(name);
}
return simgrid::simix::simcall([this] { return pimpl_->get_properties(); });
}
-const char* Storage::get_property(std::string key)
+const char* Storage::get_property(const std::string& key)
{
return this->pimpl_->get_property(key);
}
-void Storage::set_property(std::string key, std::string value)
+void Storage::set_property(const std::string& key, std::string value)
{
simgrid::simix::simcall([this, key, value] { this->pimpl_->set_property(key, value); });
}
sg_size_t Storage::read(sg_size_t size)
{
- IoPtr i = IoPtr(io_init(size, Io::OpType::READ))->start()->wait();
- return i->get_performed_ioops();
+ return IoPtr(io_init(size, Io::OpType::READ))->start()->wait()->get_performed_ioops();
}
IoPtr Storage::write_async(sg_size_t size)
sg_size_t Storage::write(sg_size_t size)
{
- IoPtr i = IoPtr(io_init(size, Io::OpType::WRITE))->start()->wait();
- return i->get_performed_ioops();
+ return IoPtr(io_init(size, Io::OpType::WRITE))->start()->wait()->get_performed_ioops();
}
} /* namespace s4u */