Directly fill vectors at construction.

[simgrid.git] / include / simgrid / s4u / Host.hpp

diff --git a/include/simgrid/s4u/Host.hpp b/include/simgrid/s4u/Host.hpp
index 45bfeb1..ffe5016 100644 (file)
--- a/include/simgrid/s4u/Host.hpp
+++ b/include/simgrid/s4u/Host.hpp
@@ -40,14 +40,14 @@ class XBT_PUBLIC Host : public simgrid::xbt::Extendable<Host> {
   friend simgrid::vm::VirtualMachineImpl; // creates the the pimpl_cpu
 
 public:
-  explicit Host(std::string name);
+  explicit Host(const std::string& name);
 
   /** Host destruction logic */
 protected:
   virtual ~Host();
 
 private:
-  bool currentlyDestroying_ = false;
+  bool currently_destroying_ = false;
 
 public:
   /*** Called on each newly created host */
@@ -66,9 +66,9 @@ public:
   Host& operator=(Host const&) = delete;
 
   /** Retrieve a host from its name, or return nullptr */
-  static Host* by_name_or_null(std::string name);
+  static Host* by_name_or_null(const std::string& name);
   /** Retrieve a host from its name, or die */
-  static s4u::Host* by_name(std::string name);
+  static s4u::Host* by_name(const std::string& name);
   /** Retrieves the host on which the running actor is located */
   static s4u::Host* current();
 
@@ -95,10 +95,10 @@ public:
   /** Returns if that host is currently up and running */
   bool is_on() const;
   /** Returns if that host is currently down and offline */
-  bool is_off() const { return not is_on(); }
+  XBT_ATTRIB_DEPRECATED_v325("Please use !is_on()") bool is_off() const { return not is_on(); }
 
-  const char* get_property(std::string key) const;
-  void set_property(std::string key, std::string value);
+  const char* get_property(const std::string& key) const;
+  void set_property(const std::string& key, const std::string& value);
   std::unordered_map<std::string, std::string>* get_properties();
 
   void set_state_profile(kernel::profile::Profile* p);
@@ -188,14 +188,15 @@ public:
   /** @deprecated See Host::is_on() */
   XBT_ATTRIB_DEPRECATED_v323("Please use Host::is_on()") bool isOn() { return is_on(); }
   /** @deprecated See Host::is_off() */
-  XBT_ATTRIB_DEPRECATED_v323("Please use Host::is_off()") bool isOff() { return is_off(); }
+  XBT_ATTRIB_DEPRECATED_v323("Please use Host::is_off()") bool isOff() { return not is_on(); }
   /** @deprecated See Host::get_property() */
   XBT_ATTRIB_DEPRECATED_v323("Please use Host::get_property()") const char* getProperty(const char* key)
   {
     return get_property(key);
   }
   /** @deprecated See Host::set_property() */
-  XBT_ATTRIB_DEPRECATED_v323("Please use Host::set_property()") void setProperty(std::string key, std::string value)
+  XBT_ATTRIB_DEPRECATED_v323("Please use Host::set_property()") void setProperty(const std::string& key,
+                                                                                 const std::string& value)
   {
     set_property(key, value);
   }