-/* Copyright (c) 2007-2020. The SimGrid Team. All rights reserved. */
+/* Copyright (c) 2007-2021. The SimGrid Team. All rights reserved. */
/* This program is free software; you can redistribute it and/or modify it
* under the terms of the license (GNU LGPL) which comes with this package. */
#include "smpi_op.hpp"
#include "src/smpi/include/smpi_actor.hpp"
-#include <memory>
+#include <vector>
XBT_LOG_EXTERNAL_DEFAULT_CATEGORY(smpi_pmpi);
- static const void* smpi_get_in_place_buf(const void* inplacebuf, const void* otherbuf,std::unique_ptr<unsigned char[]>& tmp_sendbuf, int count, MPI_Datatype datatype){
+static const void* smpi_get_in_place_buf(const void* inplacebuf, const void* otherbuf,
+ std::vector<unsigned char>& tmp_sendbuf, int count, MPI_Datatype datatype)
+{
if (inplacebuf == MPI_IN_PLACE) {
- tmp_sendbuf = std::make_unique<unsigned char[]>(count * datatype->get_extent());
- simgrid::smpi::Datatype::copy(otherbuf, count, datatype, tmp_sendbuf.get(), count, datatype);
- return tmp_sendbuf.get();
+ tmp_sendbuf.resize(count * datatype->get_extent());
+ simgrid::smpi::Datatype::copy(otherbuf, count, datatype, tmp_sendbuf.data(), count, datatype);
+ return tmp_sendbuf.data();
}else{
return inplacebuf;
}
CHECK_ROOT(7)
CHECK_REQUEST(9)
- smpi_bench_end();
const void* real_sendbuf = sendbuf;
int real_sendcount = sendcount;
MPI_Datatype real_sendtype = sendtype;
- if ((comm->rank() == root) && (sendbuf == MPI_IN_PLACE)) {
- real_sendcount = 0;
- real_sendtype = recvtype;
+ if (comm->rank() == root){
+ if (sendbuf == MPI_IN_PLACE) {
+ real_sendcount = 0;
+ real_sendtype = recvtype;
+ } else if(recvtype->size() * recvcount != sendtype->size() * sendcount){
+ XBT_WARN("MPI_(I)Gather : received size at root differs from sent size : %zu vs %zu", recvtype->size() * recvcount , sendtype->size() * sendcount);
+ return MPI_ERR_TRUNCATE;
+ }
}
+
+ smpi_bench_end();
+
int rank = simgrid::s4u::this_actor::get_pid();
TRACE_smpi_comm_in(rank, request == MPI_REQUEST_IGNORED ? "PMPI_Gather" : "PMPI_Igather",
int rank = simgrid::s4u::this_actor::get_pid();
int dt_size_recv = recvtype->is_replayable() ? 1 : recvtype->size();
- auto* trace_recvcounts = new std::vector<int>();
+ auto trace_recvcounts = std::make_shared<std::vector<int>>();
if (comm->rank() == root) {
for (int i = 0; i < comm->size(); i++) // copy data to avoid bad free
trace_recvcounts->push_back(recvcounts[i] * dt_size_recv);
CHECK_COUNT(5, recvcount)
CHECK_REQUEST(8)
- smpi_bench_end();
if (sendbuf == MPI_IN_PLACE) {
sendbuf = static_cast<char*>(recvbuf) + recvtype->get_extent() * recvcount * comm->rank();
sendcount = recvcount;
sendtype = recvtype;
}
+
+ if(recvtype->size() * recvcount != sendtype->size() * sendcount){
+ XBT_WARN("MPI_(I)Allgather : received size from each process differs from sent size : %zu vs %zu", recvtype->size() * recvcount, sendtype->size() * sendcount);
+ return MPI_ERR_TRUNCATE;
+ }
+
+ smpi_bench_end();
+
int rank = simgrid::s4u::this_actor::get_pid();
TRACE_smpi_comm_in(rank, request == MPI_REQUEST_IGNORED ? "PMPI_Allgather" : "PMPI_Iallggather",
int rank = simgrid::s4u::this_actor::get_pid();
int dt_size_recv = recvtype->is_replayable() ? 1 : recvtype->size();
- auto* trace_recvcounts = new std::vector<int>();
+ auto trace_recvcounts = std::make_shared<std::vector<int>>();
for (int i = 0; i < comm->size(); i++) { // copy data to avoid bad free
trace_recvcounts->push_back(recvcounts[i] * dt_size_recv);
}
CHECK_ROOT(8)
CHECK_REQUEST(9)
- smpi_bench_end();
if (recvbuf == MPI_IN_PLACE) {
recvtype = sendtype;
recvcount = sendcount;
}
+
+ if((comm->rank() == root) && (recvtype->size() * recvcount != sendtype->size() * sendcount)){
+ XBT_WARN("MPI_(I)Scatter : sent size to each process differs from receive size");
+ return MPI_ERR_TRUNCATE;
+ }
+
+ smpi_bench_end();
+
int rank = simgrid::s4u::this_actor::get_pid();
TRACE_smpi_comm_in(rank, request == MPI_REQUEST_IGNORED ? "PMPI_Scatter" : "PMPI_Iscatter",
int rank = simgrid::s4u::this_actor::get_pid();
int dt_size_send = sendtype->is_replayable() ? 1 : sendtype->size();
- auto* trace_sendcounts = new std::vector<int>();
+ auto trace_sendcounts = std::make_shared<std::vector<int>>();
if (comm->rank() == root) {
for (int i = 0; i < comm->size(); i++) { // copy data to avoid bad free
trace_sendcounts->push_back(sendcounts[i] * dt_size_send);
CHECK_BUFFER(5, recvbuf, count)
CHECK_TYPE(4, datatype)
CHECK_COUNT(3, count)
- CHECK_OP(5)
+ CHECK_OP(5, op, datatype)
CHECK_ROOT(7)
CHECK_REQUEST(8)
CHECK_BUFFER(2, inoutbuf, count)
CHECK_TYPE(4, datatype)
CHECK_COUNT(3, count)
- CHECK_OP(5)
+ CHECK_OP(5, op, datatype)
smpi_bench_end();
op->apply(inbuf, inoutbuf, &count, datatype);
CHECK_TYPE(4, datatype)
CHECK_COUNT(3, count)
CHECK_REQUEST(7)
- CHECK_OP(5)
+ CHECK_OP(5, op, datatype)
smpi_bench_end();
- std::unique_ptr<unsigned char[]> tmp_sendbuf;
+ std::vector<unsigned char> tmp_sendbuf;
const void* real_sendbuf = smpi_get_in_place_buf(sendbuf, recvbuf, tmp_sendbuf, count, datatype);
int rank = simgrid::s4u::this_actor::get_pid();
CHECK_TYPE(4, datatype)
CHECK_COUNT(3, count)
CHECK_REQUEST(7)
- CHECK_OP(5)
+ CHECK_OP(5, op, datatype)
smpi_bench_end();
int rank = simgrid::s4u::this_actor::get_pid();
- std::unique_ptr<unsigned char[]> tmp_sendbuf;
+ std::vector<unsigned char> tmp_sendbuf;
const void* real_sendbuf = smpi_get_in_place_buf(sendbuf, recvbuf, tmp_sendbuf, count, datatype);
TRACE_smpi_comm_in(rank, request == MPI_REQUEST_IGNORED ? "PMPI_Scan" : "PMPI_Iscan",
CHECK_TYPE(4, datatype)
CHECK_COUNT(3, count)
CHECK_REQUEST(7)
- CHECK_OP(5)
+ CHECK_OP(5, op, datatype)
smpi_bench_end();
int rank = simgrid::s4u::this_actor::get_pid();
- std::unique_ptr<unsigned char[]> tmp_sendbuf;
+ std::vector<unsigned char> tmp_sendbuf;
const void* real_sendbuf = smpi_get_in_place_buf(sendbuf, recvbuf, tmp_sendbuf, count, datatype);
TRACE_smpi_comm_in(rank, request == MPI_REQUEST_IGNORED ? "PMPI_Exscan" : "PMPI_Iexscan",
CHECK_TYPE(4, datatype)
CHECK_NULL(3, MPI_ERR_COUNT, recvcounts)
CHECK_REQUEST(7)
- CHECK_OP(5)
+ CHECK_OP(5, op, datatype)
for (int i = 0; i < comm->size(); i++) {
CHECK_COUNT(3, recvcounts[i])
CHECK_BUFFER(1, sendbuf, recvcounts[i])
smpi_bench_end();
int rank = simgrid::s4u::this_actor::get_pid();
- auto* trace_recvcounts = new std::vector<int>();
+ auto trace_recvcounts = std::make_shared<std::vector<int>>();
int dt_send_size = datatype->is_replayable() ? 1 : datatype->size();
int totalcount = 0;
trace_recvcounts->push_back(recvcounts[i] * dt_send_size);
totalcount += recvcounts[i];
}
- std::unique_ptr<unsigned char[]> tmp_sendbuf;
+ std::vector<unsigned char> tmp_sendbuf;
const void* real_sendbuf = smpi_get_in_place_buf(sendbuf, recvbuf, tmp_sendbuf, totalcount, datatype);
TRACE_smpi_comm_in(rank, request == MPI_REQUEST_IGNORED ? "PMPI_Reduce_scatter" : "PMPI_Ireduce_scatter",
CHECK_TYPE(4, datatype)
CHECK_COUNT(3, recvcount)
CHECK_REQUEST(7)
- CHECK_OP(5)
+ CHECK_OP(5, op, datatype)
smpi_bench_end();
int count = comm->size();
int rank = simgrid::s4u::this_actor::get_pid();
int dt_send_size = datatype->is_replayable() ? 1 : datatype->size();
- auto* trace_recvcounts = new std::vector<int>(recvcount * dt_send_size); // copy data to avoid bad free
- std::unique_ptr<unsigned char[]> tmp_sendbuf;
+ auto trace_recvcounts = std::make_shared<std::vector<int>>(recvcount * dt_send_size); // copy data to avoid bad free
+ std::vector<unsigned char> tmp_sendbuf;
const void* real_sendbuf = smpi_get_in_place_buf(sendbuf, recvbuf, tmp_sendbuf, recvcount * count, datatype);
TRACE_smpi_comm_in(
new simgrid::instr::VarCollTIData(request == MPI_REQUEST_IGNORED ? "reducescatter" : "ireducescatter", -1, 0,
nullptr, -1, trace_recvcounts, simgrid::smpi::Datatype::encode(datatype), ""));
- auto* recvcounts = new int[count];
+ std::vector<int> recvcounts(count);
for (int i = 0; i < count; i++)
recvcounts[i] = recvcount;
if (request == MPI_REQUEST_IGNORED)
- simgrid::smpi::colls::reduce_scatter(real_sendbuf, recvbuf, recvcounts, datatype, op, comm);
+ simgrid::smpi::colls::reduce_scatter(real_sendbuf, recvbuf, recvcounts.data(), datatype, op, comm);
else
- simgrid::smpi::colls::ireduce_scatter(real_sendbuf, recvbuf, recvcounts, datatype, op, comm, request);
- delete[] recvcounts;
+ simgrid::smpi::colls::ireduce_scatter(real_sendbuf, recvbuf, recvcounts.data(), datatype, op, comm, request);
TRACE_smpi_comm_out(rank);
smpi_bench_begin();
CHECK_COUNT(5, recvcount)
CHECK_REQUEST(8)
- smpi_bench_end();
int rank = simgrid::s4u::this_actor::get_pid();
int real_sendcount = sendcount;
MPI_Datatype real_sendtype = sendtype;
-
- std::unique_ptr<unsigned char[]> tmp_sendbuf;
+
+ std::vector<unsigned char> tmp_sendbuf;
const void* real_sendbuf = smpi_get_in_place_buf(sendbuf, recvbuf, tmp_sendbuf, recvcount * comm->size(), recvtype);
if (sendbuf == MPI_IN_PLACE) {
real_sendtype = recvtype;
}
+ if(recvtype->size() * recvcount != real_sendtype->size() * real_sendcount){
+ XBT_WARN("MPI_(I)Alltoall : receive size from each process differs from sent size : %zu vs %zu", recvtype->size() * recvcount, real_sendtype->size() * real_sendcount);
+ return MPI_ERR_TRUNCATE;
+ }
+
+ smpi_bench_end();
+
TRACE_smpi_comm_in(rank, request == MPI_REQUEST_IGNORED ? "PMPI_Alltoall" : "PMPI_Ialltoall",
new simgrid::instr::CollTIData(
request == MPI_REQUEST_IGNORED ? "alltoall" : "ialltoall", -1, -1.0,
smpi_bench_end();
int send_size = 0;
int recv_size = 0;
- auto* trace_sendcounts = new std::vector<int>();
- auto* trace_recvcounts = new std::vector<int>();
+ auto trace_sendcounts = std::make_shared<std::vector<int>>();
+ auto trace_recvcounts = std::make_shared<std::vector<int>>();
int dt_size_recv = recvtype->size();
const int* real_sendcounts = sendcounts;
maxsize = (recvdispls[i] + recvcounts[i]) * dt_size_recv;
}
- std::unique_ptr<unsigned char[]> tmp_sendbuf;
- std::unique_ptr<int[]> tmp_sendcounts;
- std::unique_ptr<int[]> tmp_senddispls;
+ std::vector<unsigned char> tmp_sendbuf;
+ std::vector<int> tmp_sendcounts;
+ std::vector<int> tmp_senddispls;
const void* real_sendbuf = smpi_get_in_place_buf(sendbuf, recvbuf, tmp_sendbuf, maxsize, MPI_CHAR);
if (sendbuf == MPI_IN_PLACE) {
- tmp_sendcounts = std::make_unique<int[]>(size);
- std::copy(recvcounts, recvcounts + size, tmp_sendcounts.get());
- real_sendcounts = tmp_sendcounts.get();
- tmp_senddispls = std::make_unique<int[]>(size);
- std::copy(recvdispls, recvdispls + size, tmp_senddispls.get());
- real_senddispls = tmp_senddispls.get();
+ tmp_sendcounts.assign(recvcounts, recvcounts + size);
+ real_sendcounts = tmp_sendcounts.data();
+ tmp_senddispls.assign(recvdispls, recvdispls + size);
+ real_senddispls = tmp_senddispls.data();
real_sendtype = recvtype;
}
+ if(recvtype->size() * recvcounts[comm->rank()] != real_sendtype->size() * real_sendcounts[comm->rank()]){
+ XBT_WARN("MPI_(I)Alltoallv : receive size from me differs from sent size to me : %zu vs %zu", recvtype->size() * recvcounts[comm->rank()], real_sendtype->size() * real_sendcounts[comm->rank()]);
+ smpi_bench_begin();
+ return MPI_ERR_TRUNCATE;
+ }
+
int dt_size_send = real_sendtype->size();
for (int i = 0; i < size; i++) { // copy data to avoid bad free
int send_size = 0;
int recv_size = 0;
- auto* trace_sendcounts = new std::vector<int>();
- auto* trace_recvcounts = new std::vector<int>();
+ auto trace_sendcounts = std::make_shared<std::vector<int>>();
+ auto trace_recvcounts = std::make_shared<std::vector<int>>();
const int* real_sendcounts = sendcounts;
const int* real_senddispls = senddispls;
const MPI_Datatype* real_sendtypes = sendtypes;
unsigned long maxsize = 0;
for (int i = 0; i < size; i++) { // copy data to avoid bad free
- if (recvtypes[i] == MPI_DATATYPE_NULL) {
- delete trace_recvcounts;
- delete trace_sendcounts;
+ if (recvtypes[i] == MPI_DATATYPE_NULL)
return MPI_ERR_TYPE;
- }
recv_size += recvcounts[i] * recvtypes[i]->size();
trace_recvcounts->push_back(recvcounts[i] * recvtypes[i]->size());
if ((recvdispls[i] + (recvcounts[i] * recvtypes[i]->size())) > maxsize)
maxsize = recvdispls[i] + (recvcounts[i] * recvtypes[i]->size());
}
- std::unique_ptr<unsigned char[]> tmp_sendbuf;
- std::unique_ptr<int[]> tmp_sendcounts;
- std::unique_ptr<int[]> tmp_senddispls;
- std::unique_ptr<MPI_Datatype[]> tmp_sendtypes;
+ std::vector<unsigned char> tmp_sendbuf;
+ std::vector<int> tmp_sendcounts;
+ std::vector<int> tmp_senddispls;
+ std::vector<MPI_Datatype> tmp_sendtypes;
const void* real_sendbuf = smpi_get_in_place_buf(sendbuf, recvbuf, tmp_sendbuf, maxsize, MPI_CHAR);
if (sendbuf == MPI_IN_PLACE) {
- tmp_sendcounts = std::make_unique<int[]>(size);
- std::copy(recvcounts, recvcounts + size, tmp_sendcounts.get());
- real_sendcounts = tmp_sendcounts.get();
- tmp_senddispls = std::make_unique<int[]>(size);
- std::copy(recvdispls, recvdispls + size, tmp_senddispls.get());
- real_senddispls = tmp_senddispls.get();
- tmp_sendtypes = std::make_unique<MPI_Datatype[]>(size);
- std::copy(recvtypes, recvtypes + size, tmp_sendtypes.get());
- real_sendtypes = tmp_sendtypes.get();
+ tmp_sendcounts.assign(recvcounts, recvcounts + size);
+ real_sendcounts = tmp_sendcounts.data();
+ tmp_senddispls.assign(recvdispls, recvdispls + size);
+ real_senddispls = tmp_senddispls.data();
+ tmp_sendtypes.assign(recvtypes, recvtypes + size);
+ real_sendtypes = tmp_sendtypes.data();
+ }
+
+
+ if(recvtypes[comm->rank()]->size() * recvcounts[comm->rank()] != real_sendtypes[comm->rank()]->size() * real_sendcounts[comm->rank()]){
+ XBT_WARN("MPI_(I)Alltoallw : receive size from me differs from sent size to me : %zu vs %zu", recvtypes[comm->rank()]->size() * recvcounts[comm->rank()], real_sendtypes[comm->rank()]->size() * real_sendcounts[comm->rank()]);
+ smpi_bench_begin();
+ return MPI_ERR_TRUNCATE;
}
for (int i = 0; i < size; i++) { // copy data to avoid bad free