/* Functions related to the java task instances. */
-/* Copyright (c) 2007-2019. The SimGrid Team. All rights reserved. */
+/* Copyright (c) 2007-2020. The SimGrid Team. All rights reserved. */
/* This program is free software; you can redistribute it and/or modify it
* under the terms of the license (GNU LGPL) which comes with this package. */
+#include "simgrid/Exception.hpp"
#include "simgrid/s4u/Host.hpp"
#include "src/kernel/context/Context.hpp"
const char *name = nullptr; /* the name of the task */
if (jname)
- name = env->GetStringUTFChars(jname, 0);
- msg_task_t task = MSG_task_create(name, static_cast<double>(jflopsAmount), static_cast<double>(jbytesAmount), jtask);
+ name = env->GetStringUTFChars(jname, nullptr);
+ msg_task_t task = MSG_task_create(name, jflopsAmount, jbytesAmount, jtask);
if (jname)
env->ReleaseStringUTFChars(jname, name);
jobjectArray jhosts, jdoubleArray jcomputeDurations_arg,
jdoubleArray jmessageSizes_arg)
{
- int host_count = static_cast<int>(env->GetArrayLength(jhosts));
+ int host_count = env->GetArrayLength(jhosts);
- jdouble* jcomputeDurations = env->GetDoubleArrayElements(jcomputeDurations_arg, 0);
+ jdouble* jcomputeDurations = env->GetDoubleArrayElements(jcomputeDurations_arg, nullptr);
msg_host_t* hosts = new msg_host_t[host_count];
double* computeDurations = new double[host_count];
for (int index = 0; index < host_count; index++) {
}
env->ReleaseDoubleArrayElements(jcomputeDurations_arg, jcomputeDurations, 0);
- jdouble* jmessageSizes = env->GetDoubleArrayElements(jmessageSizes_arg, 0);
+ jdouble* jmessageSizes = env->GetDoubleArrayElements(jmessageSizes_arg, nullptr);
double* messageSizes = new double[host_count * host_count];
for (int index = 0; index < host_count * host_count; index++) {
messageSizes[index] = jmessageSizes[index];
env->ReleaseDoubleArrayElements(jmessageSizes_arg, jmessageSizes, 0);
/* get the C string from the java string */
- const char* name = env->GetStringUTFChars(jname, 0);
+ const char* name = env->GetStringUTFChars(jname, nullptr);
msg_task_t task = MSG_parallel_task_create(name, host_count, hosts, computeDurations, messageSizes, jtask);
env->ReleaseStringUTFChars(jname, name);
return;
}
msg_error_t rv;
- try {
- rv = MSG_task_execute(task);
- } catch (simgrid::kernel::context::Context::StopRequest& e) {
+ if (not simgrid::ForcefulKillException::try_n_catch([&rv, &task]() { rv = MSG_task_execute(task); })) {
jxbt_throw_by_name(env, "org/simgrid/msg/ProcessKilledError", "Process killed");
}
}
JNIEXPORT jstring JNICALL Java_org_simgrid_msg_Task_getName(JNIEnv * env, jobject jtask) {
- msg_task_t task = jtask_to_native(jtask, env);
+ const_msg_task_t task = jtask_to_native(jtask, env);
if (not task) {
jxbt_throw_notbound(env, "task", jtask);
}
JNIEXPORT jobject JNICALL Java_org_simgrid_msg_Task_getSender(JNIEnv * env, jobject jtask) {
- msg_process_t process;
-
- msg_task_t task = jtask_to_native(jtask, env);
+ const_msg_task_t task = jtask_to_native(jtask, env);
if (not task) {
jxbt_throw_notbound(env, "task", jtask);
return nullptr;
}
- process = MSG_task_get_sender(task);
+ auto const* process = MSG_task_get_sender(task);
if (process == nullptr) {
return nullptr;
}
JNIEXPORT jobject JNICALL Java_org_simgrid_msg_Task_getSource(JNIEnv * env, jobject jtask)
{
- msg_host_t host;
- msg_task_t task = jtask_to_native(jtask, env);
+ const_msg_task_t task = jtask_to_native(jtask, env);
if (not task) {
jxbt_throw_notbound(env, "task", jtask);
return nullptr;
}
- host = MSG_task_get_source(task);
+ auto const* host = MSG_task_get_source(task);
if (host == nullptr) {
return nullptr;
}
JNIEXPORT jdouble JNICALL Java_org_simgrid_msg_Task_getFlopsAmount(JNIEnv * env, jobject jtask)
{
- msg_task_t ptask = jtask_to_native(jtask, env);
+ const_msg_task_t ptask = jtask_to_native(jtask, env);
if (not ptask) {
jxbt_throw_notbound(env, "task", jtask);
jxbt_throw_notbound(env, "task", jtask);
return;
}
- const char *name = env->GetStringUTFChars((jstring) jname, 0);
+ const char* name = env->GetStringUTFChars((jstring)jname, nullptr);
env->SetObjectField(jtask, jtask_field_Task_name, jname);
MSG_task_set_name(task, name);
jxbt_throw_notbound(env, "task", jtask);
return;
}
- MSG_task_set_priority(task, static_cast<double>(priority));
+ MSG_task_set_priority(task, priority);
}
JNIEXPORT void JNICALL Java_org_simgrid_msg_Task_setFlopsAmount (JNIEnv *env, jobject jtask, jdouble computationAmount)
jxbt_throw_notbound(env, "task", jtask);
return;
}
- MSG_task_set_flops_amount(task, static_cast<double>(computationAmount));
+ MSG_task_set_flops_amount(task, computationAmount);
}
JNIEXPORT void JNICALL Java_org_simgrid_msg_Task_setBytesAmount (JNIEnv *env, jobject jtask, jdouble dataSize)
return;
}
env->SetDoubleField(jtask, jtask_field_Task_messageSize, dataSize);
- MSG_task_set_bytes_amount(task, static_cast<double>(dataSize));
+ MSG_task_set_bytes_amount(task, dataSize);
}
JNIEXPORT void JNICALL Java_org_simgrid_msg_Task_sendBounded(JNIEnv * env,jobject jtask, jstring jalias,
/* Add a global ref into the Ctask so that the receiver can use it */
MSG_task_set_data(task, (void *) env->NewGlobalRef(jtask));
- const char* alias = env->GetStringUTFChars(jalias, 0);
- msg_error_t res =
- MSG_task_send_with_timeout_bounded(task, alias, static_cast<double>(jtimeout), static_cast<double>(maxrate));
+ const char* alias = env->GetStringUTFChars(jalias, nullptr);
+ msg_error_t res = MSG_task_send_with_timeout_bounded(task, alias, jtimeout, maxrate);
env->ReleaseStringUTFChars(jalias, alias);
if (res != MSG_OK)
{
msg_task_t task = nullptr;
- const char *alias = env->GetStringUTFChars(jalias, 0);
+ const char* alias = env->GetStringUTFChars(jalias, nullptr);
msg_error_t rv;
- try {
- rv = MSG_task_receive_ext(&task, alias, (double)jtimeout, /*host*/ nullptr);
- } catch (simgrid::kernel::context::Context::StopRequest& e) {
+ if (not simgrid::ForcefulKillException::try_n_catch(
+ [&rv, &task, &alias, &jtimeout]() { rv = MSG_task_receive_with_timeout(&task, alias, (double)jtimeout); })) {
jxbt_throw_by_name(env, "org/simgrid/msg/ProcessKilledError", "Process killed");
}
env->ReleaseStringUTFChars(jalias, alias);
return nullptr;
}
- const char* mailbox = env->GetStringUTFChars(jmailbox, 0);
+ const char* mailbox = env->GetStringUTFChars(jmailbox, nullptr);
msg_comm_t comm = MSG_task_irecv(task, mailbox);
env->ReleaseStringUTFChars(jmailbox, mailbox);
{
msg_task_t task = nullptr;
- const char *alias = env->GetStringUTFChars(jalias, 0);
- msg_error_t res = MSG_task_receive_ext_bounded(&task, alias, static_cast<double>(jtimeout), /*host*/ nullptr,
- static_cast<double>(rate));
+ const char* alias = env->GetStringUTFChars(jalias, nullptr);
+ msg_error_t res = MSG_task_receive_with_timeout_bounded(&task, alias, jtimeout, rate);
if (env->ExceptionOccurred())
return nullptr;
if (res != MSG_OK) {
return nullptr;
}
- const char* mailbox = env->GetStringUTFChars(jmailbox, 0);
- msg_comm_t comm = MSG_task_irecv_bounded(task, mailbox, static_cast<double>(rate));
+ const char* mailbox = env->GetStringUTFChars(jmailbox, nullptr);
+ msg_comm_t comm = MSG_task_irecv_bounded(task, mailbox, rate);
env->ReleaseStringUTFChars(jmailbox, mailbox);
env->SetLongField(jcomm, jtask_field_Comm_bind, (jlong) (uintptr_t)(comm));
return nullptr;
jobject jcomm = env->NewObject(comm_class, jtask_method_Comm_constructor);
- const char* mailbox = env->GetStringUTFChars(jmailbox, 0);
+ const char* mailbox = env->GetStringUTFChars(jmailbox, nullptr);
msg_task_t task = jtask_to_native(jtask, env);
return nullptr;
jcomm = env->NewObject(comm_class, jtask_method_Comm_constructor);
- mailbox = env->GetStringUTFChars(jmailbox, 0);
+ mailbox = env->GetStringUTFChars(jmailbox, nullptr);
task = jtask_to_native(jtask, env);
static void msg_task_cancel_on_failed_dsend(void*t) {
msg_task_t task = (msg_task_t) t;
- JNIEnv *env =get_current_thread_env();
- jobject jtask_global = (jobject) MSG_task_get_data(task);
-
- /* Destroy the global ref so that the JVM can free the stuff */
- env->DeleteGlobalRef(jtask_global);
+ JNIEnv* env = get_current_thread_env();
+ if (env) {
+ jobject jtask_global = (jobject)MSG_task_get_data(task);
+ /* Destroy the global ref so that the JVM can free the stuff */
+ env->DeleteGlobalRef(jtask_global);
+ /* Don't free the C data here, to avoid a race condition with the GC also sometimes doing so.
+ * A rare memleak is seen as preferable to a rare "free(): invalid pointer" failure that
+ * proves really hard to debug.
+ */
+ }
MSG_task_set_data(task, nullptr);
}
JNIEXPORT void JNICALL Java_org_simgrid_msg_Task_dsend(JNIEnv * env, jobject jtask, jstring jalias)
{
- const char *alias = env->GetStringUTFChars(jalias, 0);
+ const char* alias = env->GetStringUTFChars(jalias, nullptr);
msg_task_t task = jtask_to_native(jtask, env);
JNIEXPORT void JNICALL Java_org_simgrid_msg_Task_dsendBounded(JNIEnv * env, jobject jtask, jstring jalias,
jdouble maxrate)
{
- const char *alias = env->GetStringUTFChars(jalias, 0);
+ const char* alias = env->GetStringUTFChars(jalias, nullptr);
msg_task_t task = jtask_to_native(jtask, env);
/* Pass a global ref to the Jtask into the Ctask so that the receiver can use it */
MSG_task_set_data(task, (void *) env->NewGlobalRef(jtask));
- MSG_task_dsend_bounded(task, alias, msg_task_cancel_on_failed_dsend,static_cast<double>(maxrate));
+ MSG_task_dsend_bounded(task, alias, msg_task_cancel_on_failed_dsend, maxrate);
env->ReleaseStringUTFChars(jalias, alias);
}
JNIEXPORT jboolean JNICALL Java_org_simgrid_msg_Task_listen(JNIEnv * env, jclass cls, jstring jalias)
{
- const char *alias = env->GetStringUTFChars(jalias, 0);
+ const char* alias = env->GetStringUTFChars(jalias, nullptr);
int rv = MSG_task_listen(alias);
env->ReleaseStringUTFChars(jalias, alias);
JNIEXPORT jint JNICALL Java_org_simgrid_msg_Task_listenFrom(JNIEnv * env, jclass cls, jstring jalias)
{
- const char *alias = env->GetStringUTFChars(jalias, 0);
+ const char* alias = env->GetStringUTFChars(jalias, nullptr);
int rv = MSG_task_listen_from(alias);
env->ReleaseStringUTFChars(jalias, alias);
