some more "fixes" for sonar

[simgrid.git] / src / smpi / smpi_deployment.cpp

diff --git a/src/smpi/smpi_deployment.cpp b/src/smpi/smpi_deployment.cpp
index e832caa..e910160 100644 (file)
--- a/src/smpi/smpi_deployment.cpp
+++ b/src/smpi/smpi_deployment.cpp
@@ -23,21 +23,19 @@ typedef struct s_smpi_mpi_instance{
   xbt_bar_t finalization_barrier;
 } s_smpi_mpi_instance_t;
 
-
 /** \ingroup smpi_simulation
  * \brief Registers a running instance of a MPI program.
  *
  * FIXME : remove MSG from the loop at some point.
  * \param name the reference name of the function.
- * \param code the main mpi function (must have the same prototype than the main function of any C program: int ..(int argc, char *argv[]))
+ * \param code the main mpi function (must have a int ..(int argc, char *argv[])) prototype
  * \param num_processes the size of the instance we want to deploy
  */
 void SMPI_app_instance_register(const char *name, xbt_main_func_t code, int num_processes)
 {
   SIMIX_function_register(name, code);
 
-  s_smpi_mpi_instance_t* instance =
-      (s_smpi_mpi_instance_t*)xbt_malloc(sizeof(s_smpi_mpi_instance_t));
+  s_smpi_mpi_instance_t* instance = (s_smpi_mpi_instance_t*)xbt_malloc(sizeof(s_smpi_mpi_instance_t));
 
   instance->name = name;
   instance->size = num_processes;
@@ -48,7 +46,7 @@ void SMPI_app_instance_register(const char *name, xbt_main_func_t code, int num_
 
   process_count+=num_processes;
 
-  if(!smpi_instances){
+  if(smpi_instances==NULL){
     smpi_instances = xbt_dict_new_homogeneous(xbt_free_f);
   }
 
@@ -56,18 +54,18 @@ void SMPI_app_instance_register(const char *name, xbt_main_func_t code, int num_
   return;
 }
 
-
 //get the index of the process in the process_data array
 void smpi_deployment_register_process(const char* instance_id, int rank, int index,MPI_Comm** comm, xbt_bar_t* bar){
 
-  if(!smpi_instances){//no instance registered, we probably used smpirun.
+  if(smpi_instances==NULL){//no instance registered, we probably used smpirun.
     index_to_process_data[index]=index;
     *bar = NULL;
     *comm = NULL;
     return;
   }
 
-  s_smpi_mpi_instance_t* instance = static_cast<s_smpi_mpi_instance_t*>(xbt_dict_get_or_null(smpi_instances, instance_id));
+  s_smpi_mpi_instance_t* instance =
+     static_cast<s_smpi_mpi_instance_t*>(xbt_dict_get_or_null(smpi_instances, instance_id));
   xbt_assert(instance, "Error, unknown instance %s", instance_id);
 
   if(instance->comm_world == MPI_COMM_NULL){