[pvs] Two or more case-branches perform the same actions.

[simgrid.git] / teshsuite / smpi / privatization / privatization.c

diff --git a/teshsuite/smpi/privatization/privatization.c b/teshsuite/smpi/privatization/privatization.c
index 9a9e963..ec4509a 100644 (file)
--- a/teshsuite/smpi/privatization/privatization.c
+++ b/teshsuite/smpi/privatization/privatization.c
@@ -5,22 +5,20 @@
 
 
 static int myvalue = 0;
-static void test_opts(int* argc, char **argv[]){
-  int found = 0, ret;
+static void test_opts(int argc, char* const argv[])
+{
+  int found = 0;
   static struct option long_options[] = {
-  {"long",     no_argument, 0,  0 },
+  {(char*)"long",     no_argument, 0,  0 },
   {0,         0,                 0,  0 }
   };
   while (1) {
-    ret = getopt_long_only(*argc, *argv, "s",
-                long_options, NULL);
+    int ret = getopt_long_only(argc, argv, "s", long_options, NULL);
     if(ret==-1)
       break;
 
     switch (ret) {
       case 0:
-        found++;
-      break;
       case 's':
         found ++;
       break;
@@ -39,7 +37,7 @@ int main(int argc, char **argv)
 
     MPI_Init(&argc, &argv);
     /* test getopt_long function */
-    test_opts(&argc, &argv);
+    test_opts(argc, argv);
 
     MPI_Comm_rank(MPI_COMM_WORLD, &me);