/* Functions related to the java task instances. */
-/* Copyright (c) 2007-2019. The SimGrid Team. All rights reserved. */
+/* Copyright (c) 2007-2022. The SimGrid Team. All rights reserved. */
/* This program is free software; you can redistribute it and/or modify it
* under the terms of the license (GNU LGPL) which comes with this package. */
#include "simgrid/Exception.hpp"
#include "simgrid/s4u/Host.hpp"
-#include "src/kernel/context/Context.hpp"
#include "jmsg.hpp"
#include "jmsg_host.h"
JNIEXPORT void JNICALL Java_org_simgrid_msg_Task_create(JNIEnv * env, jobject jtask, jstring jname,
jdouble jflopsAmount, jdouble jbytesAmount)
{
- const char *name = nullptr; /* the name of the task */
-
- if (jname)
- name = env->GetStringUTFChars(jname, 0);
- msg_task_t task = MSG_task_create(name, jflopsAmount, jbytesAmount, jtask);
- if (jname)
- env->ReleaseStringUTFChars(jname, name);
+ jstring_wrapper task_name(env, jname);
+ msg_task_t task = MSG_task_create(task_name, jflopsAmount, jbytesAmount, jtask);
/* bind & store the task */
jtask_bind(jtask, task, env);
{
int host_count = env->GetArrayLength(jhosts);
- jdouble* jcomputeDurations = env->GetDoubleArrayElements(jcomputeDurations_arg, 0);
- msg_host_t* hosts = new msg_host_t[host_count];
- double* computeDurations = new double[host_count];
+ jdouble* jcomputeDurations = env->GetDoubleArrayElements(jcomputeDurations_arg, nullptr);
+ auto* hosts = new msg_host_t[host_count];
+ auto* computeDurations = new double[host_count];
for (int index = 0; index < host_count; index++) {
jobject jhost = env->GetObjectArrayElement(jhosts, index);
hosts[index] = jhost_get_native(env, jhost);
}
env->ReleaseDoubleArrayElements(jcomputeDurations_arg, jcomputeDurations, 0);
- jdouble* jmessageSizes = env->GetDoubleArrayElements(jmessageSizes_arg, 0);
- double* messageSizes = new double[host_count * host_count];
+ jdouble* jmessageSizes = env->GetDoubleArrayElements(jmessageSizes_arg, nullptr);
+ auto* messageSizes = new double[host_count * host_count];
for (int index = 0; index < host_count * host_count; index++) {
messageSizes[index] = jmessageSizes[index];
}
env->ReleaseDoubleArrayElements(jmessageSizes_arg, jmessageSizes, 0);
/* get the C string from the java string */
- const char* name = env->GetStringUTFChars(jname, 0);
+ jstring_wrapper name(env, jname);
msg_task_t task = MSG_parallel_task_create(name, host_count, hosts, computeDurations, messageSizes, jtask);
- env->ReleaseStringUTFChars(jname, name);
/* associate the java task object and the native task */
jtask_bind(jtask, task, env);
}
msg_error_t rv = MSG_task_cancel(ptask);
-
- jxbt_check_res("MSG_task_cancel()", rv, MSG_OK, "unexpected error , please report this bug");
+ xbt_assert(rv == MSG_OK, "MSG_task_cancel() unexpectedly failed with error code %d. Please report this bug", rv);
}
JNIEXPORT void JNICALL Java_org_simgrid_msg_Task_execute(JNIEnv * env, jobject jtask)
}
JNIEXPORT jstring JNICALL Java_org_simgrid_msg_Task_getName(JNIEnv * env, jobject jtask) {
- msg_task_t task = jtask_to_native(jtask, env);
+ const_msg_task_t task = jtask_to_native(jtask, env);
if (not task) {
jxbt_throw_notbound(env, "task", jtask);
}
JNIEXPORT jobject JNICALL Java_org_simgrid_msg_Task_getSender(JNIEnv * env, jobject jtask) {
- msg_process_t process;
-
- msg_task_t task = jtask_to_native(jtask, env);
+ const_msg_task_t task = jtask_to_native(jtask, env);
if (not task) {
jxbt_throw_notbound(env, "task", jtask);
return nullptr;
}
- process = MSG_task_get_sender(task);
+ auto const* process = MSG_task_get_sender(task);
if (process == nullptr) {
return nullptr;
}
JNIEXPORT jobject JNICALL Java_org_simgrid_msg_Task_getSource(JNIEnv * env, jobject jtask)
{
- msg_host_t host;
- msg_task_t task = jtask_to_native(jtask, env);
+ const_msg_task_t task = jtask_to_native(jtask, env);
if (not task) {
jxbt_throw_notbound(env, "task", jtask);
return nullptr;
}
- host = MSG_task_get_source(task);
+ auto const* host = MSG_task_get_source(task);
if (host == nullptr) {
return nullptr;
}
JNIEXPORT jdouble JNICALL Java_org_simgrid_msg_Task_getFlopsAmount(JNIEnv * env, jobject jtask)
{
- msg_task_t ptask = jtask_to_native(jtask, env);
+ const_msg_task_t ptask = jtask_to_native(jtask, env);
if (not ptask) {
jxbt_throw_notbound(env, "task", jtask);
jxbt_throw_notbound(env, "task", jtask);
return;
}
- const char *name = env->GetStringUTFChars((jstring) jname, 0);
+ jstring_wrapper name(env, static_cast<jstring>(jname));
env->SetObjectField(jtask, jtask_field_Task_name, jname);
MSG_task_set_name(task, name);
-
- env->ReleaseStringUTFChars((jstring) jname, name);
}
JNIEXPORT void JNICALL Java_org_simgrid_msg_Task_setPriority(JNIEnv * env, jobject jtask, jdouble priority)
}
/* Add a global ref into the Ctask so that the receiver can use it */
- MSG_task_set_data(task, (void *) env->NewGlobalRef(jtask));
+ MSG_task_set_data(task, env->NewGlobalRef(jtask));
- const char* alias = env->GetStringUTFChars(jalias, 0);
+ jstring_wrapper alias(env, jalias);
msg_error_t res = MSG_task_send_with_timeout_bounded(task, alias, jtimeout, maxrate);
- env->ReleaseStringUTFChars(jalias, alias);
if (res != MSG_OK)
jmsg_throw_status(env, res);
{
msg_task_t task = nullptr;
- const char *alias = env->GetStringUTFChars(jalias, 0);
+ jstring_wrapper alias(env, jalias);
msg_error_t rv;
if (not simgrid::ForcefulKillException::try_n_catch(
[&rv, &task, &alias, &jtimeout]() { rv = MSG_task_receive_with_timeout(&task, alias, (double)jtimeout); })) {
jxbt_throw_by_name(env, "org/simgrid/msg/ProcessKilledError", "Process killed");
}
- env->ReleaseStringUTFChars(jalias, alias);
if (env->ExceptionOccurred())
return nullptr;
if (rv != MSG_OK) {
jmsg_throw_status(env, rv);
return nullptr;
}
- jobject jtask_global = (jobject) MSG_task_get_data(task);
+ auto jtask_global = (jobject)MSG_task_get_data(task);
/* Convert the global ref into a local ref so that the JVM can free the stuff */
jobject jtask_local = env->NewLocalRef(jtask_global);
return nullptr;
//pointer to store the task object pointer.
- msg_task_t* task = new msg_task_t(nullptr);
+ auto* task = new msg_task_t(nullptr);
/* There should be a cache here */
jobject jcomm = env->NewObject(comm_class, jtask_method_Comm_constructor);
return nullptr;
}
- const char* mailbox = env->GetStringUTFChars(jmailbox, 0);
+ jstring_wrapper mailbox(env, jmailbox);
msg_comm_t comm = MSG_task_irecv(task, mailbox);
- env->ReleaseStringUTFChars(jmailbox, mailbox);
env->SetLongField(jcomm, jtask_field_Comm_bind, (jlong) (uintptr_t)(comm));
env->SetLongField(jcomm, jtask_field_Comm_taskBind, (jlong) (uintptr_t)(task));
{
msg_task_t task = nullptr;
- const char *alias = env->GetStringUTFChars(jalias, 0);
+ jstring_wrapper alias(env, jalias);
msg_error_t res = MSG_task_receive_with_timeout_bounded(&task, alias, jtimeout, rate);
if (env->ExceptionOccurred())
return nullptr;
jmsg_throw_status(env, res);
return nullptr;
}
- jobject jtask_global = (jobject)MSG_task_get_data(task);
+ auto jtask_global = (jobject)MSG_task_get_data(task);
/* Convert the global ref into a local ref so that the JVM can free the stuff */
jobject jtask_local = env->NewLocalRef(jtask_global);
env->DeleteGlobalRef(jtask_global);
MSG_task_set_data(task, nullptr);
- env->ReleaseStringUTFChars(jalias, alias);
-
return (jobject) jtask_local;
}
return nullptr;
// pointer to store the task object pointer.
- msg_task_t* task = new msg_task_t(nullptr);
+ auto* task = new msg_task_t(nullptr);
jobject jcomm = env->NewObject(comm_class, jtask_method_Comm_constructor);
if (not jcomm) {
return nullptr;
}
- const char* mailbox = env->GetStringUTFChars(jmailbox, 0);
+ jstring_wrapper mailbox(env, jmailbox);
msg_comm_t comm = MSG_task_irecv_bounded(task, mailbox, rate);
- env->ReleaseStringUTFChars(jmailbox, mailbox);
env->SetLongField(jcomm, jtask_field_Comm_bind, (jlong) (uintptr_t)(comm));
env->SetLongField(jcomm, jtask_field_Comm_taskBind, (jlong) (uintptr_t)(task));
return nullptr;
jobject jcomm = env->NewObject(comm_class, jtask_method_Comm_constructor);
- const char* mailbox = env->GetStringUTFChars(jmailbox, 0);
+ jstring_wrapper mailbox(env, jmailbox);
msg_task_t task = jtask_to_native(jtask, env);
if (not task) {
- env->ReleaseStringUTFChars(jmailbox, mailbox);
env->DeleteLocalRef(jcomm);
jxbt_throw_notbound(env, "task", jtask);
return nullptr;
}
- MSG_task_set_data(task, (void *) env->NewGlobalRef(jtask));
+ MSG_task_set_data(task, env->NewGlobalRef(jtask));
comm = MSG_task_isend(task,mailbox);
env->SetLongField(jcomm, jtask_field_Comm_bind, (jlong) (uintptr_t)(comm));
env->SetLongField(jcomm, jtask_field_Comm_taskBind, (jlong) (uintptr_t)(nullptr));
env->SetBooleanField(jcomm, jtask_field_Comm_receiving, JNI_FALSE);
- env->ReleaseStringUTFChars(jmailbox, mailbox);
-
return jcomm;
}
msg_task_t task;
jobject jcomm;
msg_comm_t comm;
- const char *mailbox;
jclass comm_class = env->FindClass("org/simgrid/msg/Comm");
if (not comm_class)
return nullptr;
jcomm = env->NewObject(comm_class, jtask_method_Comm_constructor);
- mailbox = env->GetStringUTFChars(jmailbox, 0);
+ jstring_wrapper mailbox(env, jmailbox);
task = jtask_to_native(jtask, env);
if (not task) {
- env->ReleaseStringUTFChars(jmailbox, mailbox);
env->DeleteLocalRef(jcomm);
jxbt_throw_notbound(env, "task", jtask);
return nullptr;
}
- MSG_task_set_data(task, (void *) env->NewGlobalRef(jtask));
+ MSG_task_set_data(task, env->NewGlobalRef(jtask));
comm = MSG_task_isend_bounded(task,mailbox,maxrate);
env->SetLongField(jcomm, jtask_field_Comm_bind, (jlong) (uintptr_t)(comm));
env->SetLongField(jcomm, jtask_field_Comm_taskBind, (jlong) (uintptr_t)(nullptr));
env->SetBooleanField(jcomm, jtask_field_Comm_receiving, JNI_FALSE);
- env->ReleaseStringUTFChars(jmailbox, mailbox);
-
return jcomm;
}
}
static void msg_task_cancel_on_failed_dsend(void*t) {
- msg_task_t task = (msg_task_t) t;
+ auto task = (msg_task_t)t;
JNIEnv* env = get_current_thread_env();
if (env) {
- jobject jtask_global = (jobject)MSG_task_get_data(task);
+ auto jtask_global = (jobject)MSG_task_get_data(task);
/* Destroy the global ref so that the JVM can free the stuff */
env->DeleteGlobalRef(jtask_global);
/* Don't free the C data here, to avoid a race condition with the GC also sometimes doing so.
JNIEXPORT void JNICALL Java_org_simgrid_msg_Task_dsend(JNIEnv * env, jobject jtask, jstring jalias)
{
- const char *alias = env->GetStringUTFChars(jalias, 0);
+ jstring_wrapper alias(env, jalias);
msg_task_t task = jtask_to_native(jtask, env);
if (not task) {
- env->ReleaseStringUTFChars(jalias, alias);
jxbt_throw_notbound(env, "task", jtask);
return;
}
/* Pass a global ref to the Jtask into the Ctask so that the receiver can use it */
- MSG_task_set_data(task, (void *) env->NewGlobalRef(jtask));
+ MSG_task_set_data(task, env->NewGlobalRef(jtask));
MSG_task_dsend(task, alias, msg_task_cancel_on_failed_dsend);
-
- env->ReleaseStringUTFChars(jalias, alias);
}
JNIEXPORT void JNICALL Java_org_simgrid_msg_Task_dsendBounded(JNIEnv * env, jobject jtask, jstring jalias,
jdouble maxrate)
{
- const char *alias = env->GetStringUTFChars(jalias, 0);
+ jstring_wrapper alias(env, jalias);
msg_task_t task = jtask_to_native(jtask, env);
if (not task) {
- env->ReleaseStringUTFChars(jalias, alias);
jxbt_throw_notbound(env, "task", jtask);
return;
}
/* Pass a global ref to the Jtask into the Ctask so that the receiver can use it */
- MSG_task_set_data(task, (void *) env->NewGlobalRef(jtask));
+ MSG_task_set_data(task, env->NewGlobalRef(jtask));
MSG_task_dsend_bounded(task, alias, msg_task_cancel_on_failed_dsend, maxrate);
-
- env->ReleaseStringUTFChars(jalias, alias);
}
JNIEXPORT jboolean JNICALL Java_org_simgrid_msg_Task_listen(JNIEnv * env, jclass cls, jstring jalias)
{
- const char *alias = env->GetStringUTFChars(jalias, 0);
- int rv = MSG_task_listen(alias);
- env->ReleaseStringUTFChars(jalias, alias);
-
- return (jboolean) rv;
+ jstring_wrapper alias(env, jalias);
+ return (jboolean)MSG_task_listen(alias);
}
JNIEXPORT jint JNICALL Java_org_simgrid_msg_Task_listenFrom(JNIEnv * env, jclass cls, jstring jalias)
{
- const char *alias = env->GetStringUTFChars(jalias, 0);
- int rv = MSG_task_listen_from(alias);
- env->ReleaseStringUTFChars(jalias, alias);
-
- return (jint) rv;
+ jstring_wrapper alias(env, jalias);
+ return (jint)MSG_task_listen_from(alias);
}
