#include "simgrid/plugins/energy.h"
#include "simgrid/simix.hpp"
-#include "src/surf/plugins/energy.hpp"
+#include "src/plugins/vm/VirtualMachineImpl.hpp"
#include "src/surf/cpu_interface.hpp"
-#include "src/surf/virtual_machine.hpp"
-
+#include "src/surf/plugins/energy.hpp"
#include <utility>
/** @addtogroup SURF_plugin_energy
/* Computes the consumption so far. Called lazily on need. */
void HostEnergy::update()
{
- simgrid::surf::HostImpl* surf_host = host->extension<simgrid::surf::HostImpl>();
double start_time = this->last_updated;
double finish_time = surf_get_clock();
double cpu_load;
- if (surf_host->cpu_->getPstateSpeedCurrent() <= 0)
+ if (host->pimpl_cpu->getPstateSpeedCurrent() <= 0)
// Some users declare a pstate of speed 0 flops (e.g., to model boot time).
// We consider that the machine is then fully loaded. That's arbitrary but it avoids a NaN
cpu_load = 1;
else
- cpu_load = lmm_constraint_get_usage(surf_host->cpu_->getConstraint()) / surf_host->cpu_->getPstateSpeedCurrent();
+ cpu_load = lmm_constraint_get_usage(host->pimpl_cpu->constraint()) / host->pimpl_cpu->getPstateSpeedCurrent();
/** Divide by the number of cores here **/
- cpu_load /= surf_host->cpu_->coreCount();
+ cpu_load /= host->pimpl_cpu->coreCount();
if (cpu_load > 1) // A machine with a load > 1 consumes as much as a fully loaded machine, not more
cpu_load = 1;
*
* X/(X+Y)*W_idle + Y/(X+Y)*W_burn
*
- * where X is the amount of ideling cores, and Y the amount of computing cores.
+ * where X is the amount of idling cores, and Y the amount of computing cores.
*/
double previous_energy = this->total_energy;
this->total_energy = previous_energy + energy_this_step;
this->last_updated = finish_time;
- XBT_DEBUG("[update_energy of %s] period=[%.2f-%.2f]; current power peak=%.0E flop/s; consumption change: %.2f J -> %.2f J",
- surf_host->getName(), start_time, finish_time, surf_host->cpu_->speed_.peak, previous_energy, energy_this_step);
+ XBT_DEBUG(
+ "[update_energy of %s] period=[%.2f-%.2f]; current power peak=%.0E flop/s; consumption change: %.2f J -> %.2f J",
+ host->cname(), start_time, finish_time, host->pimpl_cpu->speed_.peak, previous_energy, energy_this_step);
}
HostEnergy::HostEnergy(simgrid::s4u::Host *ptr) : host(ptr), last_updated(surf_get_clock())
{
initWattsRangeList();
- if (host->properties() != nullptr) {
- char* off_power_str = (char*)xbt_dict_get_or_null(host->properties(), "watt_off");
- if (off_power_str != nullptr) {
- char *msg = bprintf("Invalid value for property watt_off of host %s: %%s",host->name().c_str());
- watts_off = xbt_str_parse_double(off_power_str, msg);
- xbt_free(msg);
- }
- else
- watts_off = 0;
+ const char* off_power_str = host->property("watt_off");
+ if (off_power_str != nullptr) {
+ char* msg = bprintf("Invalid value for property watt_off of host %s: %%s", host->cname());
+ this->watts_off = xbt_str_parse_double(off_power_str, msg);
+ xbt_free(msg);
}
+ /* watts_off is 0 by default */
}
HostEnergy::~HostEnergy()=default;
double HostEnergy::getWattMinAt(int pstate)
{
- xbt_assert(!power_range_watts_list.empty(), "No power range properties specified for host %s", host->name().c_str());
+ xbt_assert(!power_range_watts_list.empty(), "No power range properties specified for host %s", host->cname());
return power_range_watts_list[pstate].min;
}
double HostEnergy::getWattMaxAt(int pstate)
{
- xbt_assert(!power_range_watts_list.empty(), "No power range properties specified for host %s", host->name().c_str());
+ xbt_assert(!power_range_watts_list.empty(), "No power range properties specified for host %s", host->cname());
return power_range_watts_list[pstate].max;
}
/** @brief Computes the power consumed by the host according to the current pstate and processor load */
double HostEnergy::getCurrentWattsValue(double cpu_load)
{
- xbt_assert(!power_range_watts_list.empty(), "No power range properties specified for host %s", host->name().c_str());
+ xbt_assert(!power_range_watts_list.empty(), "No power range properties specified for host %s", host->cname());
/* min_power corresponds to the idle power (cpu load = 0) */
/* max_power is the power consumed at 100% cpu load */
if (cpu_load > 0) { /* Something is going on, the machine is not idle */
double min_power = range.min;
double max_power = range.max;
- double power_slope = max_power - min_power;
- current_power = min_power + cpu_load * power_slope;
+
+ /**
+ * The min_power states how much we consume when only one single
+ * core is working. This means that when cpu_load == 1/coreCount, then
+ * current_power == min_power.
+ *
+ * The maximum must be reached when all cores are working (but 1 core was
+ * already accounted for by min_power)
+ * i.e., we need min_power + (maxCpuLoad-1/coreCount)*power_slope == max_power
+ * (maxCpuLoad is by definition 1)
+ */
+ double power_slope;
+ int coreCount = host->coreCount();
+ double coreReciprocal = static_cast<double>(1) / static_cast<double>(coreCount);
+ if (coreCount > 1)
+ power_slope = (max_power - min_power) / (1 - coreReciprocal);
+ else
+ power_slope = 0; // Should be 0, since max_power == min_power (in this case)
+
+ current_power = min_power + (cpu_load - coreReciprocal) * power_slope;
}
else { /* Our machine is idle, take the dedicated value! */
current_power = range.idle;
void HostEnergy::initWattsRangeList()
{
- if (host->properties() == nullptr)
- return;
- char* all_power_values_str = static_cast<char*>(xbt_dict_get_or_null(host->properties(), "watt_per_state"));
+ const char* all_power_values_str = host->property("watt_per_state");
if (all_power_values_str == nullptr)
return;
for (int i=0; i< pstate_nb; i++) {
/* retrieve the power values associated with the current pstate */
xbt_dynar_t current_power_values = xbt_str_split(xbt_dynar_get_as(all_power_values, i, char*), ":");
- xbt_assert(xbt_dynar_length(current_power_values) > 1,
- "Power properties incorrectly defined - could not retrieve min and max power values for host %s",
- host->name().c_str());
+ xbt_assert(xbt_dynar_length(current_power_values) == 3,
+ "Power properties incorrectly defined - could not retrieve idle, min and max power values for host %s",
+ host->cname());
/* min_power corresponds to the idle power (cpu load = 0) */
/* max_power is the power consumed at 100% cpu load */
- char *msg_idle = bprintf("Invalid idle value for pstate %d on host %s: %%s", i, host->name().c_str());
- char *msg_min = bprintf("Invalid min value for pstate %d on host %s: %%s", i, host->name().c_str());
- char *msg_max = bprintf("Invalid max value for pstate %d on host %s: %%s", i, host->name().c_str());
+ char* msg_idle = bprintf("Invalid idle value for pstate %d on host %s: %%s", i, host->cname());
+ char* msg_min = bprintf("Invalid min value for pstate %d on host %s: %%s", i, host->cname());
+ char* msg_max = bprintf("Invalid max value for pstate %d on host %s: %%s", i, host->cname());
PowerRange range(
xbt_str_parse_double(xbt_dynar_get_as(current_power_values, 0, char*), msg_idle),
xbt_str_parse_double(xbt_dynar_get_as(current_power_values, 1, char*), msg_min),
xbt_str_parse_double(xbt_dynar_get_as(current_power_values, 2, char*), msg_max)
);
power_range_watts_list.push_back(range);
+ xbt_free(msg_idle);
xbt_free(msg_min);
xbt_free(msg_max);
/* **************************** events callback *************************** */
static void onCreation(simgrid::s4u::Host& host) {
- simgrid::surf::HostImpl* surf_host = host.extension<simgrid::surf::HostImpl>();
- if (dynamic_cast<simgrid::surf::VirtualMachine*>(surf_host)) // Ignore virtual machines
+ if (dynamic_cast<simgrid::s4u::VirtualMachine*>(&host)) // Ignore virtual machines
return;
host.extension_set(new HostEnergy(&host));
}
static void onActionStateChange(simgrid::surf::CpuAction *action, simgrid::surf::Action::State previous) {
- for(simgrid::surf::Cpu* cpu : action->cpus()) {
- const char *name = cpu->getName();
- sg_host_t sghost = sg_host_by_name(name);
- if(sghost == nullptr)
+ for (simgrid::surf::Cpu* cpu : action->cpus()) {
+ simgrid::s4u::Host* host = cpu->getHost();
+ if (host == nullptr)
continue;
- simgrid::surf::HostImpl *host = sghost->extension<simgrid::surf::HostImpl>();
- simgrid::surf::VirtualMachine *vm = dynamic_cast<simgrid::surf::VirtualMachine*>(host);
+
+ // If it's a VM, take the corresponding PM
+ simgrid::s4u::VirtualMachine* vm = dynamic_cast<simgrid::s4u::VirtualMachine*>(host);
if (vm) // If it's a VM, take the corresponding PM
- host = vm->getPm()->extension<simgrid::surf::HostImpl>();
+ host = vm->pimpl_vm_->getPm();
- HostEnergy *host_energy = host->piface_->extension<HostEnergy>();
+ // Get the host_energy extension for the relevant host
+ HostEnergy* host_energy = host->extension<HostEnergy>();
- if(host_energy->last_updated < surf_get_clock())
+ if (host_energy->last_updated < surf_get_clock())
host_energy->update();
}
}
static void onHostStateChange(simgrid::s4u::Host &host) {
- simgrid::surf::HostImpl* surf_host = host.extension<simgrid::surf::HostImpl>();
- if (dynamic_cast<simgrid::surf::VirtualMachine*>(surf_host)) // Ignore virtual machines
+ if (dynamic_cast<simgrid::s4u::VirtualMachine*>(&host)) // Ignore virtual machines
return;
HostEnergy *host_energy = host.extension<HostEnergy>();
}
static void onHostDestruction(simgrid::s4u::Host& host) {
- // Ignore virtual machines
- simgrid::surf::HostImpl* surf_host = host.extension<simgrid::surf::HostImpl>();
- if (dynamic_cast<simgrid::surf::VirtualMachine*>(surf_host))
+ if (dynamic_cast<simgrid::s4u::VirtualMachine*>(&host)) // Ignore virtual machines
return;
+
HostEnergy *host_energy = host.extension<HostEnergy>();
host_energy->update();
- XBT_INFO("Total energy of host %s: %f Joules", host.name().c_str(), host_energy->getConsumedEnergy());
+ XBT_INFO("Total energy of host %s: %f Joules", host.cname(), host_energy->getConsumedEnergy());
}
/* **************************** Public interface *************************** */
