more explicit messages when failing in RMA comms

[simgrid.git] / src / smpi / mpi / smpi_win.cpp

diff --git a/src/smpi/mpi/smpi_win.cpp b/src/smpi/mpi/smpi_win.cpp
index 09b5e3c..6c95f11 100644 (file)
--- a/src/smpi/mpi/smpi_win.cpp
+++ b/src/smpi/mpi/smpi_win.cpp
@@ -209,8 +209,10 @@ int Win::put(const void *origin_addr, int origin_count, MPI_Datatype origin_data
       return MPI_ERR_WIN;
   }
 
-  if(target_count*target_datatype->get_extent()>recv_win->size_)
-    return MPI_ERR_ARG;
+  if(target_count*target_datatype->get_extent()>recv_win->size_){
+    XBT_WARN("Trying to put more than the window size - Bailing out.");
+    return MPI_ERR_RMA_RANGE;
+  }
 
   void* recv_addr = static_cast<char*>(recv_win->base_) + target_disp * recv_win->disp_unit_;
 
@@ -269,8 +271,10 @@ int Win::get( void *origin_addr, int origin_count, MPI_Datatype origin_datatype,
       return MPI_ERR_WIN;
   }
 
-  if(target_count*target_datatype->get_extent()>send_win->size_)
-    return MPI_ERR_ARG;
+  if(target_count*target_datatype->get_extent()>send_win->size_){
+    XBT_WARN("Trying to get more than the window size - Bailing out.");
+    return MPI_ERR_RMA_RANGE;
+  }
 
   const void* send_addr = static_cast<void*>(static_cast<char*>(send_win->base_) + target_disp * send_win->disp_unit_);
   XBT_DEBUG("Entering MPI_Get from %d", target_rank);
@@ -329,8 +333,10 @@ int Win::accumulate(const void *origin_addr, int origin_count, MPI_Datatype orig
   }
   //FIXME: local version
 
-  if(target_count*target_datatype->get_extent()>recv_win->size_)
-    return MPI_ERR_ARG;
+  if(target_count*target_datatype->get_extent()>recv_win->size_){
+    XBT_WARN("Trying to accumulate more than the window size - Bailing out.");
+    return MPI_ERR_RMA_RANGE;
+  }
 
   void* recv_addr = static_cast<char*>(recv_win->base_) + target_disp * recv_win->disp_unit_;
   XBT_DEBUG("Entering MPI_Accumulate to %d", target_rank);
@@ -384,8 +390,11 @@ int Win::get_accumulate(const void* origin_addr, int origin_count, MPI_Datatype
       return MPI_ERR_WIN;
   }
 
-  if(target_count*target_datatype->get_extent()>send_win->size_)
-    return MPI_ERR_ARG;
+  if(target_count*target_datatype->get_extent()>send_win->size_){
+    XBT_WARN("Trying to get_accumulate more than the window size - Bailing out.");
+    return MPI_ERR_RMA_RANGE;
+  }
+
 
   XBT_DEBUG("Entering MPI_Get_accumulate from %d", target_rank);
   //need to be sure ops are correctly ordered, so finish request here ? slow.