shellcheck tools/jenkins scripts.

[simgrid.git] / tools / jenkins / DynamicAnalysis.sh

diff --git a/tools/jenkins/DynamicAnalysis.sh b/tools/jenkins/DynamicAnalysis.sh
index e0a87b8..f3e2930 100755 (executable)
--- a/tools/jenkins/DynamicAnalysis.sh
+++ b/tools/jenkins/DynamicAnalysis.sh
@@ -12,7 +12,7 @@ die() {
 pkg_check() {
   for pkg
   do
-    if command -v $pkg
+    if command -v "$pkg"
     then
        echo "$pkg is installed. Good."
     else
@@ -25,7 +25,7 @@ pkg_check valgrind pcregrep
 
 ### Cleanup previous runs
 
-! [ -z "$WORKSPACE" ] || die "No WORKSPACE"
+[ -n "$WORKSPACE" ] || die "No WORKSPACE"
 [ -d "$WORKSPACE" ] || die "WORKSPACE ($WORKSPACE) does not exist"
 
 do_cleanup() {
@@ -37,14 +37,14 @@ do_cleanup() {
     fi
     mkdir "$d" || die "Could not create $d"
   done
-  find $WORKSPACE -name "memcheck_test_*.memcheck" -exec rm {} \;
+  find "$WORKSPACE" -name "memcheck_test_*.memcheck" -exec rm {} \;
 }
 
 do_cleanup "$WORKSPACE/build" "$WORKSPACE/memcheck"
 
 NUMPROC="$(nproc)" || NUMPROC=1
 
-cd $WORKSPACE/build
+cd "$WORKSPACE"/build
 
 ### Proceed with the tests
 ctest -D ExperimentalStart || true
@@ -53,17 +53,16 @@ cmake -Denable_documentation=OFF -Denable_lua=OFF -Denable_python=OFF \
       -Denable_compile_optimizations=OFF -Denable_compile_warnings=ON \
       -Denable_jedule=OFF -Denable_mallocators=OFF \
       -Denable_smpi=ON -Denable_smpi_MPICH3_testsuite=OFF -Denable_model-checking=OFF \
-      -Denable_memcheck_xml=ON -DLTO_EXTRA_FLAG="auto" $WORKSPACE
+      -Denable_memcheck_xml=ON -DLTO_EXTRA_FLAG="auto" "$WORKSPACE"
 
 
 make -j$NUMPROC tests
 ctest --no-compress-output -D ExperimentalTest -j$NUMPROC || true
 
-cd $WORKSPACE/build
+cd "$WORKSPACE"/build
 if [ -f Testing/TAG ] ; then
-   find $WORKSPACE -iname "*.memcheck" -exec mv {} $WORKSPACE/memcheck \;
+   find "$WORKSPACE" -iname "*.memcheck" -exec mv {} "$WORKSPACE"/memcheck \;
    #remove all "empty" files
-   grep -r -L "error>" $WORKSPACE/memcheck | xargs rm -f
-   mv Testing/$(head -n 1 < Testing/TAG)/Test.xml  $WORKSPACE/DynamicAnalysis.xml
+   grep -r -L "error>" "$WORKSPACE"/memcheck | xargs rm -f
+   mv Testing/"$(head -n 1 < Testing/TAG)"/Test.xml  "$WORKSPACE"/DynamicAnalysis.xml
 fi
-