/* This program is free software; you can redistribute it and/or modify it
* under the terms of the license (GNU LGPL) which comes with this package. */
-#include "src/mc/checker/CommunicationDeterminismChecker.hpp"
#include "src/kernel/activity/MailboxImpl.hpp"
#include "src/mc/Session.hpp"
+#include "src/mc/api/TransitionComm.hpp"
+#include "src/mc/checker/SafetyChecker.hpp"
#include "src/mc/mc_config.hpp"
#include "src/mc/mc_exit.hpp"
#include "src/mc/mc_private.hpp"
XBT_LOG_NEW_DEFAULT_SUBCATEGORY(mc_comm_determinism, mc, "Logging specific to MC communication determinism detection");
-/********** Global variables **********/
+namespace simgrid {
+namespace mc {
+
+enum class CallType { NONE, SEND, RECV, WAIT, WAITANY };
+enum class CommPatternDifference { NONE, TYPE, MBOX, TAG, SRC_PROC, DST_PROC, DATA_SIZE };
+enum class PatternCommunicationType {
+ none = 0,
+ send = 1,
+ receive = 2,
+};
+
+class PatternCommunication {
+public:
+ int num = 0;
+ uintptr_t comm_addr = 0;
+ PatternCommunicationType type = PatternCommunicationType::send;
+ unsigned long src_proc = 0;
+ unsigned long dst_proc = 0;
+ unsigned mbox = 0;
+ unsigned size = 0;
+ int tag = 0;
+ int index = 0;
+
+ PatternCommunication dup() const
+ {
+ simgrid::mc::PatternCommunication res;
+ // num?
+ res.comm_addr = this->comm_addr;
+ res.type = this->type;
+ res.src_proc = this->src_proc;
+ res.dst_proc = this->dst_proc;
+ res.mbox = this->mbox;
+ res.tag = this->tag;
+ res.index = this->index;
+ return res;
+ }
+};
+
+struct PatternCommunicationList {
+ unsigned int index_comm = 0;
+ std::vector<std::unique_ptr<simgrid::mc::PatternCommunication>> list;
+};
-std::vector<simgrid::mc::PatternCommunicationList> initial_communications_pattern;
-std::vector<std::vector<simgrid::mc::PatternCommunication*>> incomplete_communications_pattern;
+/********** Checker extension **********/
-/********** Static functions ***********/
+struct CommDetExtension {
+ static simgrid::xbt::Extension<simgrid::mc::Checker, CommDetExtension> EXTENSION_ID;
+
+ std::vector<simgrid::mc::PatternCommunicationList> initial_communications_pattern;
+ std::vector<std::vector<simgrid::mc::PatternCommunication*>> incomplete_communications_pattern;
+
+ bool initial_communications_pattern_done = false;
+ bool recv_deterministic = true;
+ bool send_deterministic = true;
+ std::string send_diff;
+ std::string recv_diff;
+
+ void exploration_start()
+ {
+ const unsigned long maxpid = api::get().get_maxpid();
+
+ initial_communications_pattern.resize(maxpid);
+ incomplete_communications_pattern.resize(maxpid);
+ }
+ void restore_communications_pattern(const simgrid::mc::State* state);
+ void enforce_deterministic_pattern(aid_t process, const PatternCommunication* comm);
+ void get_comm_pattern(const Transition* transition);
+ void complete_comm_pattern(const CommWaitTransition* transition);
+ void handle_comm_pattern(const Transition* transition);
+};
+simgrid::xbt::Extension<simgrid::mc::Checker, CommDetExtension> CommDetExtension::EXTENSION_ID;
+/********** State Extension ***********/
+
+class StateCommDet {
+ CommDetExtension* checker_;
+
+public:
+ std::vector<std::vector<simgrid::mc::PatternCommunication>> incomplete_comm_pattern_;
+ std::vector<unsigned> communication_indices_;
+
+ static simgrid::xbt::Extension<simgrid::mc::State, StateCommDet> EXTENSION_ID;
+ explicit StateCommDet(CommDetExtension* checker) : checker_(checker)
+ {
+ const unsigned long maxpid = api::get().get_maxpid();
+ for (unsigned long i = 0; i < maxpid; i++) {
+ std::vector<simgrid::mc::PatternCommunication> res;
+ for (auto const& comm : checker_->incomplete_communications_pattern[i])
+ res.push_back(comm->dup());
+ incomplete_comm_pattern_.push_back(std::move(res));
+ }
+
+ for (auto const& list_process_comm : checker_->initial_communications_pattern)
+ this->communication_indices_.push_back(list_process_comm.index_comm);
+ }
+};
+simgrid::xbt::Extension<simgrid::mc::State, StateCommDet> StateCommDet::EXTENSION_ID;
static simgrid::mc::CommPatternDifference compare_comm_pattern(const simgrid::mc::PatternCommunication* comm1,
const simgrid::mc::PatternCommunication* comm2)
using simgrid::mc::CommPatternDifference;
if (comm1->type != comm2->type)
return CommPatternDifference::TYPE;
- if (comm1->rdv != comm2->rdv)
- return CommPatternDifference::RDV;
+ if (comm1->mbox != comm2->mbox)
+ return CommPatternDifference::MBOX;
if (comm1->src_proc != comm2->src_proc)
return CommPatternDifference::SRC_PROC;
if (comm1->dst_proc != comm2->dst_proc)
return CommPatternDifference::DST_PROC;
if (comm1->tag != comm2->tag)
return CommPatternDifference::TAG;
- if (comm1->data.size() != comm2->data.size())
+ if (comm1->size != comm2->size)
return CommPatternDifference::DATA_SIZE;
- if (comm1->data != comm2->data)
- return CommPatternDifference::DATA;
return CommPatternDifference::NONE;
}
-static void patterns_copy(std::vector<simgrid::mc::PatternCommunication*>& dest,
- std::vector<simgrid::mc::PatternCommunication> const& source)
-{
- dest.clear();
- for (simgrid::mc::PatternCommunication const& comm : source) {
- auto* copy_comm = new simgrid::mc::PatternCommunication(comm.dup());
- dest.push_back(copy_comm);
- }
-}
-
-static void restore_communications_pattern(simgrid::mc::State* state)
+void CommDetExtension::restore_communications_pattern(const simgrid::mc::State* state)
{
for (size_t i = 0; i < initial_communications_pattern.size(); i++)
- initial_communications_pattern[i].index_comm = state->communication_indices_[i];
+ initial_communications_pattern[i].index_comm =
+ state->extension<simgrid::mc::StateCommDet>()->communication_indices_[i];
const unsigned long maxpid = api::get().get_maxpid();
- for (unsigned long i = 0; i < maxpid; i++)
- patterns_copy(incomplete_communications_pattern[i], state->incomplete_comm_pattern_[i]);
+ for (unsigned long i = 0; i < maxpid; i++) {
+ incomplete_communications_pattern[i].clear();
+ for (simgrid::mc::PatternCommunication const& comm :
+ state->extension<simgrid::mc::StateCommDet>()->incomplete_comm_pattern_[i])
+ incomplete_communications_pattern[i].push_back(new simgrid::mc::PatternCommunication(comm.dup()));
+ }
}
-static char* print_determinism_result(simgrid::mc::CommPatternDifference diff, aid_t process,
- const simgrid::mc::PatternCommunication* comm, unsigned int cursor)
+static std::string print_determinism_result(simgrid::mc::CommPatternDifference diff, aid_t actor,
+ const simgrid::mc::PatternCommunication* comm, unsigned int cursor)
{
- char* type;
- char* res;
+ std::string type;
+ std::string res;
if (comm->type == simgrid::mc::PatternCommunicationType::send)
- type = bprintf("The send communications pattern of the process %ld is different!", process - 1);
+ type = xbt::string_printf("The send communications pattern of the actor %ld is different!", actor - 1);
else
- type = bprintf("The recv communications pattern of the process %ld is different!", process - 1);
+ type = xbt::string_printf("The recv communications pattern of the actor %ld is different!", actor - 1);
using simgrid::mc::CommPatternDifference;
switch (diff) {
case CommPatternDifference::TYPE:
- res = bprintf("%s Different type for communication #%u", type, cursor);
+ res = xbt::string_printf("%s Different type for communication #%u", type.c_str(), cursor);
break;
- case CommPatternDifference::RDV:
- res = bprintf("%s Different rdv for communication #%u", type, cursor);
+ case CommPatternDifference::MBOX:
+ res = xbt::string_printf("%s Different mailbox for communication #%u", type.c_str(), cursor);
break;
case CommPatternDifference::TAG:
- res = bprintf("%s Different tag for communication #%u", type, cursor);
+ res = xbt::string_printf("%s Different tag for communication #%u", type.c_str(), cursor);
break;
case CommPatternDifference::SRC_PROC:
- res = bprintf("%s Different source for communication #%u", type, cursor);
+ res = xbt::string_printf("%s Different source for communication #%u", type.c_str(), cursor);
break;
case CommPatternDifference::DST_PROC:
- res = bprintf("%s Different destination for communication #%u", type, cursor);
+ res = xbt::string_printf("%s Different destination for communication #%u", type.c_str(), cursor);
break;
case CommPatternDifference::DATA_SIZE:
- res = bprintf("%s Different data size for communication #%u", type, cursor);
- break;
- case CommPatternDifference::DATA:
- res = bprintf("%s Different data for communication #%u", type, cursor);
+ res = xbt::string_printf("%s Different data size for communication #%u", type.c_str(), cursor);
break;
default:
- res = nullptr;
+ res = "";
break;
}
return res;
}
-static void update_comm_pattern(simgrid::mc::PatternCommunication* comm_pattern,
- simgrid::mc::RemotePtr<simgrid::kernel::activity::CommImpl> const& comm_addr)
+void CommDetExtension::enforce_deterministic_pattern(aid_t actor, const PatternCommunication* comm)
{
- auto src_proc = api::get().get_src_actor(comm_addr);
- auto dst_proc = api::get().get_dst_actor(comm_addr);
- comm_pattern->src_proc = src_proc->get_pid();
- comm_pattern->dst_proc = dst_proc->get_pid();
- comm_pattern->src_host = &api::get().get_actor_host_name(src_proc);
- comm_pattern->dst_host = &api::get().get_actor_host_name(dst_proc);
-
- if (comm_pattern->data.empty()) {
- comm_pattern->data = api::get().get_pattern_comm_data(comm_addr);
- }
-}
+ PatternCommunicationList& list = initial_communications_pattern[actor];
+ CommPatternDifference diff = compare_comm_pattern(list.list[list.index_comm].get(), comm);
-namespace simgrid {
-namespace mc {
-
-void CommunicationDeterminismChecker::deterministic_comm_pattern(aid_t process, const PatternCommunication* comm,
- bool backtracking)
-{
- if (not backtracking) {
- PatternCommunicationList& list = initial_communications_pattern[process];
- CommPatternDifference diff = compare_comm_pattern(list.list[list.index_comm].get(), comm);
-
- if (diff != CommPatternDifference::NONE) {
- if (comm->type == PatternCommunicationType::send) {
- this->send_deterministic = false;
- if (this->send_diff != nullptr)
- xbt_free(this->send_diff);
- this->send_diff = print_determinism_result(diff, process, comm, list.index_comm + 1);
- } else {
- this->recv_deterministic = false;
- if (this->recv_diff != nullptr)
- xbt_free(this->recv_diff);
- this->recv_diff = print_determinism_result(diff, process, comm, list.index_comm + 1);
- }
- if (_sg_mc_send_determinism && not this->send_deterministic) {
- XBT_INFO("*********************************************************");
- XBT_INFO("***** Non-send-deterministic communications pattern *****");
- XBT_INFO("*********************************************************");
- XBT_INFO("%s", this->send_diff);
- xbt_free(this->send_diff);
- this->send_diff = nullptr;
- api::get().log_state();
- api::get().mc_exit(SIMGRID_MC_EXIT_NON_DETERMINISM);
- } else if (_sg_mc_comms_determinism && (not this->send_deterministic && not this->recv_deterministic)) {
- XBT_INFO("****************************************************");
- XBT_INFO("***** Non-deterministic communications pattern *****");
- XBT_INFO("****************************************************");
- if (this->send_diff) {
- XBT_INFO("%s", this->send_diff);
- xbt_free(this->send_diff);
- this->send_diff = nullptr;
- }
- if (this->recv_diff) {
- XBT_INFO("%s", this->recv_diff);
- xbt_free(this->recv_diff);
- this->recv_diff = nullptr;
- }
- api::get().log_state();
- api::get().mc_exit(SIMGRID_MC_EXIT_NON_DETERMINISM);
- }
+ if (diff != CommPatternDifference::NONE) {
+ if (comm->type == PatternCommunicationType::send) {
+ send_deterministic = false;
+ send_diff = print_determinism_result(diff, actor, comm, list.index_comm + 1);
+ } else {
+ recv_deterministic = false;
+ if (recv_diff.empty())
+ recv_diff = print_determinism_result(diff, actor, comm, list.index_comm + 1);
+ }
+ if (_sg_mc_send_determinism && not send_deterministic) {
+ XBT_INFO("*********************************************************");
+ XBT_INFO("***** Non-send-deterministic communications pattern *****");
+ XBT_INFO("*********************************************************");
+ XBT_INFO("%s", send_diff.c_str());
+ api::get().log_state();
+ api::get().mc_exit(SIMGRID_MC_EXIT_NON_DETERMINISM);
+ } else if (_sg_mc_comms_determinism && (not send_deterministic && not recv_deterministic)) {
+ XBT_INFO("****************************************************");
+ XBT_INFO("***** Non-deterministic communications pattern *****");
+ XBT_INFO("****************************************************");
+ if (not send_diff.empty())
+ XBT_INFO("%s", send_diff.c_str());
+ if (not recv_diff.empty())
+ XBT_INFO("%s", recv_diff.c_str());
+ api::get().log_state();
+ api::get().mc_exit(SIMGRID_MC_EXIT_NON_DETERMINISM);
}
}
}
/********** Non Static functions ***********/
-void CommunicationDeterminismChecker::get_comm_pattern(smx_simcall_t request, CallType call_type, bool backtracking)
+void CommDetExtension::get_comm_pattern(const Transition* transition)
{
- const smx_actor_t issuer = api::get().simcall_get_issuer(request);
- const mc::PatternCommunicationList& initial_pattern = initial_communications_pattern[issuer->get_pid()];
- const std::vector<PatternCommunication*>& incomplete_pattern = incomplete_communications_pattern[issuer->get_pid()];
+ const mc::PatternCommunicationList& initial_pattern = initial_communications_pattern[transition->aid_];
+ const std::vector<PatternCommunication*>& incomplete_pattern = incomplete_communications_pattern[transition->aid_];
auto pattern = std::make_unique<PatternCommunication>();
pattern->index = initial_pattern.index_comm + incomplete_pattern.size();
- if (call_type == CallType::SEND) {
- /* Create comm pattern */
+ if (transition->type_ == Transition::Type::COMM_SEND) {
+ auto* send = static_cast<const CommSendTransition*>(transition);
+
pattern->type = PatternCommunicationType::send;
- pattern->comm_addr = api::get().get_comm_isend_raw_addr(request);
- pattern->rdv = api::get().get_pattern_comm_rdv(pattern->comm_addr);
- pattern->src_proc = api::get().get_pattern_comm_src_proc(pattern->comm_addr);
- pattern->src_host = &api::get().get_actor_host_name(issuer);
-
-#if HAVE_SMPI
- pattern->tag = api::get().get_smpi_request_tag(request, simgrid::simix::Simcall::COMM_ISEND);
-#endif
- pattern->data = api::get().get_pattern_comm_data(pattern->comm_addr);
-
-#if HAVE_SMPI
- auto send_detached = api::get().check_send_request_detached(request);
- if (send_detached) {
- if (this->initial_communications_pattern_done) {
- /* Evaluate comm determinism */
- this->deterministic_comm_pattern(pattern->src_proc, pattern.get(), backtracking);
- initial_communications_pattern[pattern->src_proc].index_comm++;
- } else {
- /* Store comm pattern */
- initial_communications_pattern[pattern->src_proc].list.push_back(std::move(pattern));
- }
- return;
- }
-#endif
- } else if (call_type == CallType::RECV) {
+ pattern->comm_addr = send->get_comm();
+ pattern->tag = send->get_tag();
+
+ // FIXME: Detached sends should be enforced when the receive is waited
+
+ } else if (transition->type_ == Transition::Type::COMM_RECV) {
+ auto* recv = static_cast<const CommRecvTransition*>(transition);
+
pattern->type = PatternCommunicationType::receive;
- pattern->comm_addr = api::get().get_comm_isend_raw_addr(request);
-
-#if HAVE_SMPI
- pattern->tag = api::get().get_smpi_request_tag(request, simgrid::simix::Simcall::COMM_IRECV);
-#endif
- pattern->rdv = api::get().get_pattern_comm_rdv(pattern->comm_addr);
- pattern->dst_proc = api::get().get_pattern_comm_dst_proc(pattern->comm_addr);
- pattern->dst_host = &api::get().get_actor_host_name(issuer);
- } else
- xbt_die("Unexpected call_type %i", (int)call_type);
-
- XBT_DEBUG("Insert incomplete comm pattern %p for process %ld", pattern.get(), issuer->get_pid());
- incomplete_communications_pattern[issuer->get_pid()].push_back(pattern.release());
+ pattern->comm_addr = recv->get_comm();
+ pattern->tag = recv->get_tag();
+ }
+
+ XBT_DEBUG("Insert incomplete comm pattern %p type:%d for process %ld (comm: %" PRIxPTR ")", pattern.get(),
+ (int)pattern->type, transition->aid_, pattern->comm_addr);
+ incomplete_communications_pattern[transition->aid_].push_back(pattern.release());
}
-void CommunicationDeterminismChecker::complete_comm_pattern(RemotePtr<kernel::activity::CommImpl> const& comm_addr,
- aid_t issuer, bool backtracking)
+void CommDetExtension::complete_comm_pattern(const CommWaitTransition* transition)
{
/* Complete comm pattern */
- std::vector<PatternCommunication*>& incomplete_pattern = incomplete_communications_pattern[issuer];
+ std::vector<PatternCommunication*>& incomplete_pattern = incomplete_communications_pattern[transition->aid_];
+ uintptr_t comm_addr = transition->get_comm();
auto current_comm_pattern =
std::find_if(begin(incomplete_pattern), end(incomplete_pattern),
[&comm_addr](const PatternCommunication* comm) { return (comm->comm_addr == comm_addr); });
xbt_assert(current_comm_pattern != std::end(incomplete_pattern), "Corresponding communication not found!");
-
- update_comm_pattern(*current_comm_pattern, comm_addr);
std::unique_ptr<PatternCommunication> comm_pattern(*current_comm_pattern);
- XBT_DEBUG("Remove incomplete comm pattern for process %ld at cursor %zd", issuer,
+
+ comm_pattern->src_proc = transition->get_sender();
+ comm_pattern->dst_proc = transition->get_receiver();
+ comm_pattern->mbox = transition->get_mailbox();
+
+ XBT_DEBUG("Remove incomplete comm pattern for actor %ld at cursor %zd", transition->aid_,
std::distance(begin(incomplete_pattern), current_comm_pattern));
incomplete_pattern.erase(current_comm_pattern);
- if (this->initial_communications_pattern_done) {
+ if (initial_communications_pattern_done) {
/* Evaluate comm determinism */
- this->deterministic_comm_pattern(issuer, comm_pattern.get(), backtracking);
- initial_communications_pattern[issuer].index_comm++;
+ enforce_deterministic_pattern(transition->aid_, comm_pattern.get());
+ initial_communications_pattern[transition->aid_].index_comm++;
} else {
/* Store comm pattern */
- initial_communications_pattern[issuer].list.push_back(std::move(comm_pattern));
+ initial_communications_pattern[transition->aid_].list.push_back(std::move(comm_pattern));
}
}
-CommunicationDeterminismChecker::CommunicationDeterminismChecker(Session* session) : Checker(session) {}
-
-CommunicationDeterminismChecker::~CommunicationDeterminismChecker() = default;
-
-RecordTrace CommunicationDeterminismChecker::get_record_trace() // override
-{
- RecordTrace res;
- for (auto const& state : stack_)
- res.push_back(*state->get_transition());
- return res;
-}
-
-std::vector<std::string> CommunicationDeterminismChecker::get_textual_trace() // override
-{
- std::vector<std::string> trace;
- for (auto const& state : stack_)
- trace.push_back(state->get_transition()->to_string());
- return trace;
-}
-
-void CommunicationDeterminismChecker::log_state() // override
-{
- if (_sg_mc_comms_determinism) {
- if (this->send_deterministic && not this->recv_deterministic) {
- XBT_INFO("*******************************************************");
- XBT_INFO("**** Only-send-deterministic communication pattern ****");
- XBT_INFO("*******************************************************");
- XBT_INFO("%s", this->recv_diff);
- }
- if (not this->send_deterministic && this->recv_deterministic) {
- XBT_INFO("*******************************************************");
- XBT_INFO("**** Only-recv-deterministic communication pattern ****");
- XBT_INFO("*******************************************************");
- XBT_INFO("%s", this->send_diff);
- }
- }
- XBT_INFO("Expanded states = %lu", expanded_states_count_);
- XBT_INFO("Visited states = %lu", api::get().mc_get_visited_states());
- XBT_INFO("Executed transitions = %lu", Transition::get_executed_transitions());
- XBT_INFO("Send-deterministic : %s", this->send_deterministic ? "Yes" : "No");
- if (_sg_mc_comms_determinism)
- XBT_INFO("Recv-deterministic : %s", this->recv_deterministic ? "Yes" : "No");
-}
-void CommunicationDeterminismChecker::prepare()
+void CommDetExtension::handle_comm_pattern(const Transition* transition)
{
- const unsigned long maxpid = api::get().get_maxpid();
-
- initial_communications_pattern.resize(maxpid);
- incomplete_communications_pattern.resize(maxpid);
-
- ++expanded_states_count_;
- auto initial_state = std::make_unique<State>(expanded_states_count_);
-
- XBT_DEBUG("********* Start communication determinism verification *********");
-
- /* Add all enabled actors to the interleave set of the initial state */
- for (auto& act : api::get().get_actors()) {
- auto actor = act.copy.get_buffer();
- if (get_session().actor_is_enabled(actor->get_pid()))
- initial_state->mark_todo(actor->get_pid());
- }
-
- stack_.push_back(std::move(initial_state));
-}
-
-static inline bool all_communications_are_finished()
-{
- const unsigned long maxpid = api::get().get_maxpid();
- for (size_t current_actor = 1; current_actor < maxpid; current_actor++) {
- if (not incomplete_communications_pattern[current_actor].empty()) {
- XBT_DEBUG("Some communications are not finished, cannot stop the exploration! State not visited.");
- return false;
- }
- }
- return true;
-}
-
-void CommunicationDeterminismChecker::restoreState()
-{
- /* Intermediate backtracking */
- State* last_state = stack_.back().get();
- if (last_state->system_state_) {
- api::get().restore_state(last_state->system_state_);
- restore_communications_pattern(last_state);
+ if (not _sg_mc_comms_determinism && not _sg_mc_send_determinism)
return;
- }
-
- get_session().restore_initial_state();
-
- const unsigned long maxpid = api::get().get_maxpid();
- assert(maxpid == incomplete_communications_pattern.size());
- assert(maxpid == initial_communications_pattern.size());
- for (unsigned long j = 0; j < maxpid; j++) {
- incomplete_communications_pattern[j].clear();
- initial_communications_pattern[j].index_comm = 0;
- }
- /* Traverse the stack from the state at position start and re-execute the transitions */
- for (std::unique_ptr<simgrid::mc::State> const& state : stack_) {
- if (state == stack_.back())
+ switch (transition->type_) {
+ case Transition::Type::COMM_SEND:
+ get_comm_pattern(transition);
break;
-
- int req_num = state->get_transition()->times_considered_;
- const s_smx_simcall* saved_req = &state->executed_req_;
- xbt_assert(saved_req);
-
- /* because we got a copy of the executed request, we have to fetch the
- real one, pointed by the request field of the issuer process */
-
- const smx_actor_t issuer = api::get().simcall_get_issuer(saved_req);
- smx_simcall_t req = &issuer->simcall_;
-
- /* TODO : handle test and testany simcalls */
- CallType call = MC_get_call_type(req);
- state->get_transition()->replay();
- handle_comm_pattern(call, req, req_num, 1);
-
- /* Update statistics */
- api::get().mc_inc_visited_states();
- }
-}
-
-void CommunicationDeterminismChecker::handle_comm_pattern(simgrid::mc::CallType call_type, smx_simcall_t req, int value,
- bool backtracking)
-{
- using simgrid::mc::CallType;
- switch(call_type) {
- case CallType::NONE:
+ case Transition::Type::COMM_RECV:
+ get_comm_pattern(transition);
+ break;
+ case Transition::Type::COMM_WAIT:
+ complete_comm_pattern(static_cast<const CommWaitTransition*>(transition));
+ break;
+ case Transition::Type::WAITANY:
+ // Ignore wait on non-comm
+ if (auto const* wait = dynamic_cast<const CommWaitTransition*>(
+ static_cast<const WaitAnyTransition*>(transition)->get_current_transition()))
+ complete_comm_pattern(wait);
break;
- case CallType::SEND:
- case CallType::RECV:
- get_comm_pattern(req, call_type, backtracking);
+ default: /* Ignore unhandled transition types */
break;
- case CallType::WAIT:
- case CallType::WAITANY: {
- RemotePtr<simgrid::kernel::activity::CommImpl> comm_addr;
- if (call_type == CallType::WAIT)
- comm_addr = remote(simcall_comm_wait__getraw__comm(req));
- else
- comm_addr = api::get().get_comm_waitany_raw_addr(req, value);
- auto simcall_issuer = api::get().simcall_get_issuer(req);
- complete_comm_pattern(comm_addr, simcall_issuer->get_pid(), backtracking);
- } break;
- default:
- xbt_die("Unexpected call type %i", (int)call_type);
}
}
-void CommunicationDeterminismChecker::real_run()
-{
- std::unique_ptr<VisitedState> visited_state = nullptr;
-
- while (not stack_.empty()) {
- /* Get current state */
- State* cur_state = stack_.back().get();
-
- XBT_DEBUG("**************************************************");
- XBT_DEBUG("Exploration depth = %zu (state = %d, interleaved processes = %zu)", stack_.size(), cur_state->num_,
- cur_state->count_todo());
-
- /* Update statistics */
- api::get().mc_inc_visited_states();
-
- int next_transition = -1;
- if (stack_.size() <= (std::size_t)_sg_mc_max_depth)
- next_transition = cur_state->next_transition();
-
- if (next_transition >= 0 && visited_state == nullptr) {
- cur_state->execute_next(next_transition);
-
- aid_t aid = cur_state->get_transition()->aid_;
- int req_num = cur_state->get_transition()->times_considered_;
- smx_simcall_t req = &cur_state->executed_req_;
-
- XBT_DEBUG("Execute: %s", cur_state->get_transition()->to_cstring());
-
- std::string req_str;
- if (dot_output != nullptr)
- req_str = api::get().request_get_dot_output(aid, req_num);
-
- /* TODO : handle test and testany simcalls */
- CallType call = CallType::NONE;
- if (_sg_mc_comms_determinism || _sg_mc_send_determinism)
- call = MC_get_call_type(req);
-
- handle_comm_pattern(call, req, req_num, 0);
-
- /* Create the new expanded state */
- ++expanded_states_count_;
- auto next_state = std::make_unique<State>(expanded_states_count_);
-
- /* If comm determinism verification, we cannot stop the exploration if some communications are not finished (at
- * least, data are transferred). These communications are incomplete and they cannot be analyzed and compared
- * with the initial pattern. */
- bool compare_snapshots = this->initial_communications_pattern_done && all_communications_are_finished();
-
- if (_sg_mc_max_visited_states != 0)
- visited_state = visited_states_.addVisitedState(expanded_states_count_, next_state.get(), compare_snapshots);
- else
- visited_state = nullptr;
-
- if (visited_state == nullptr) {
- /* Add all enabled actors to the interleave set of the next state */
- for (auto& act : api::get().get_actors()) {
- auto actor = act.copy.get_buffer();
- if (get_session().actor_is_enabled(actor->get_pid()))
- next_state->mark_todo(actor->get_pid());
+/* FIXME: CommDet probably don't play nicely with stateful exploration
+ bool all_communications_are_finished = true;
+ for (size_t current_actor = 1; all_communications_are_finished && current_actor < maxpid; current_actor++) {
+ if (not extension->incomplete_communications_pattern[current_actor].empty()) {
+ XBT_DEBUG("Some communications are not finished, cannot stop the exploration! State not visited.");
+ all_communications_are_finished = false;
}
+ }
+ */
- if (dot_output != nullptr)
- fprintf(dot_output, "\"%d\" -> \"%d\" [%s];\n", cur_state->num_, next_state->num_, req_str.c_str());
-
- } else if (dot_output != nullptr)
- fprintf(dot_output, "\"%d\" -> \"%d\" [%s];\n", cur_state->num_,
- visited_state->original_num == -1 ? visited_state->num : visited_state->original_num, req_str.c_str());
-
- stack_.push_back(std::move(next_state));
- } else {
- if (stack_.size() > (std::size_t)_sg_mc_max_depth)
- XBT_WARN("/!\\ Max depth reached! /!\\ ");
- else if (visited_state != nullptr)
- XBT_DEBUG("State already visited (equal to state %d), exploration stopped on this path.",
- visited_state->original_num == -1 ? visited_state->num : visited_state->original_num);
- else
- XBT_DEBUG("There are no more processes to interleave. (depth %zu)", stack_.size());
-
- this->initial_communications_pattern_done = true;
-
- /* Trash the current state, no longer needed */
- XBT_DEBUG("Delete state %d at depth %zu", cur_state->num_, stack_.size());
- stack_.pop_back();
-
- visited_state = nullptr;
-
- api::get().mc_check_deadlock();
-
- while (not stack_.empty()) {
- std::unique_ptr<State> state(std::move(stack_.back()));
- stack_.pop_back();
- if (state->count_todo() && stack_.size() < (std::size_t)_sg_mc_max_depth) {
- /* We found a back-tracking point, let's loop */
- XBT_DEBUG("Back-tracking to state %d at depth %zu", state->num_, stack_.size() + 1);
- stack_.push_back(std::move(state));
-
- this->restoreState();
+Checker* create_communication_determinism_checker(Session* session)
+{
+ CommDetExtension::EXTENSION_ID = simgrid::mc::Checker::extension_create<CommDetExtension>();
+ StateCommDet::EXTENSION_ID = simgrid::mc::State::extension_create<StateCommDet>();
- XBT_DEBUG("Back-tracking to state %d at depth %zu done", stack_.back()->num_, stack_.size());
+ XBT_DEBUG("********* Start communication determinism verification *********");
- break;
- } else {
- XBT_DEBUG("Delete state %d at depth %zu", state->num_, stack_.size() + 1);
- }
+ auto extension = new CommDetExtension();
+
+ SafetyChecker::on_exploration_start([&extension]() {
+ XBT_INFO("Check communication determinism");
+ extension->exploration_start();
+ });
+ SafetyChecker::on_backtracking([&extension]() { extension->initial_communications_pattern_done = true; });
+ SafetyChecker::on_state_creation([&extension](State* state) { state->extension_set(new StateCommDet(extension)); });
+
+ SafetyChecker::on_restore_system_state(
+ [&extension](State* state) { extension->restore_communications_pattern(state); });
+
+ SafetyChecker::on_restore_initial_state([&extension]() {
+ const unsigned long maxpid = api::get().get_maxpid();
+ assert(maxpid == extension->incomplete_communications_pattern.size());
+ assert(maxpid == extension->initial_communications_pattern.size());
+ for (unsigned long j = 0; j < maxpid; j++) {
+ extension->incomplete_communications_pattern[j].clear();
+ extension->initial_communications_pattern[j].index_comm = 0;
+ }
+ });
+
+ SafetyChecker::on_transition_replay([&extension](Transition* t) { extension->handle_comm_pattern(t); });
+ SafetyChecker::on_transition_execute([&extension](Transition* t) { extension->handle_comm_pattern(t); });
+
+ SafetyChecker::on_log_state([&extension]() {
+ if (_sg_mc_comms_determinism) {
+ if (extension->send_deterministic && not extension->recv_deterministic) {
+ XBT_INFO("*******************************************************");
+ XBT_INFO("**** Only-send-deterministic communication pattern ****");
+ XBT_INFO("*******************************************************");
+ XBT_INFO("%s", extension->recv_diff.c_str());
+ }
+ if (not extension->send_deterministic && extension->recv_deterministic) {
+ XBT_INFO("*******************************************************");
+ XBT_INFO("**** Only-recv-deterministic communication pattern ****");
+ XBT_INFO("*******************************************************");
+ XBT_INFO("%s", extension->send_diff.c_str());
}
}
- }
+ XBT_INFO("Send-deterministic : %s", extension->send_deterministic ? "Yes" : "No");
+ if (_sg_mc_comms_determinism)
+ XBT_INFO("Recv-deterministic : %s", extension->recv_deterministic ? "Yes" : "No");
+ });
- api::get().log_state();
-}
-
-void CommunicationDeterminismChecker::run()
-{
- XBT_INFO("Check communication determinism");
- get_session().take_initial_snapshot();
-
- this->prepare();
- this->real_run();
-}
-
-Checker* create_communication_determinism_checker(Session* session)
-{
- return new CommunicationDeterminismChecker(session);
+ return new SafetyChecker(session);
}
} // namespace mc
