Logo AND Algorithmique Numérique Distribuée

Public GIT Repository
changed received messages to use own data structure.
[simgrid.git] / src / smpi / src / smpi_base.c
index 44a1d02..49725ca 100644 (file)
@@ -7,6 +7,10 @@
 #include "simix/private.h"
 #include "smpi.h"
 
+// FIXME: move globals into structure...
+
+xbt_mallocator_t smpi_request_mallocator    = NULL;
+xbt_mallocator_t smpi_message_mallocator    = NULL;
 xbt_fifo_t *smpi_pending_send_requests      = NULL;
 xbt_fifo_t *smpi_pending_recv_requests      = NULL;
 xbt_fifo_t *smpi_received_messages          = NULL;
@@ -47,6 +51,7 @@ int inline smpi_mpi_comm_size(smpi_mpi_communicator_t *comm)
        return comm->size;
 }
 
+// FIXME: smarter algorithm?
 int smpi_mpi_comm_rank(smpi_mpi_communicator_t *comm, smx_host_t host)
 {
        int i;
@@ -61,18 +66,30 @@ int inline smpi_mpi_comm_rank_self(smpi_mpi_communicator_t *comm)
        return smpi_mpi_comm_rank(comm, SIMIX_host_self());
 }
 
+int inline smpi_mpi_comm_world_rank_self()
+{
+       return smpi_mpi_comm_rank(&smpi_mpi_comm_world, SIMIX_host_self())
+}
+
+// FIXME: messages are actually smaller than requests, use them instead?
 int smpi_sender(int argc, char **argv)
 {
-       int rank = smpi_mpi_comm_rank_self(&smpi_mpi_comm_world);
+       smx_process_t self;
+       smx_host_t shost;
+       int rank;
+       xbt_fifo_t request_queue;
        int size;
        int running_hosts = 0;
        smpi_mpi_request_t *request;
-       smx_process_t self;
-       smx_host_t shost, dhost;
+       smx_host_t dhost;
        smx_action_t communicate_action;
+       smpi_mpi_request_t *scratch;
+       int drank;
+       smx_process_t waitproc;
 
-       self = SIMIX_process_self();
+       self  = SIMIX_process_self();
        shost = SIMIX_host_self();
+       rank  = smpi_mpi_comm_rank(&smpi_mpi_comm_world, shost);
 
        // make sure root is done before own initialization
        SIMIX_mutex_lock(init_mutex);
@@ -81,6 +98,7 @@ int smpi_sender(int argc, char **argv)
        }
        SIMIX_mutex_unlock(init_mutex);
 
+       request_queue = smpi_pending_send_requests[rank];
        size = smpi_mpi_comm_size(&smpi_mpi_comm_world);
        smpi_sender_processes[rank] = self;
 
@@ -100,7 +118,8 @@ int smpi_sender(int argc, char **argv)
 
        while (0 < running_hosts) {
 
-               request = xbt_fifo_shift(smpi_pending_send_requests[rank]);
+               // FIXME: mutex?
+               request = xbt_fifo_shift(request_queue);
 
                if (NULL == request) {
                        SIMIX_process_suspend(self);
@@ -118,8 +137,23 @@ int smpi_sender(int argc, char **argv)
 
                        SIMIX_cond_wait(request->cond, request->mutex);
 
-                       // fixme, create new request, copy over to
-                       // should be malloc and memcpy
+                       // copy request to appropriate received queue
+                       scratch = xbt_mallocator_get(smpi_message_mallocator);
+                       scratch->comm = request->comm;
+                       scratch->src  = request->src;
+                       scratch->dst  = request->dst;
+                       scratch->tag  = request->tag;
+                       scratch->buf  = request->buf;
+                       drank = smpi_mpi_comm_rank(&smpi_mpi_comm_world, dhost);
+                       xbt_fifo_push(smpi_received_messages[drank], scratch);
+
+                       request->completed = 1;
+
+                       while(waitproc = xbt_fifo_shift(request->waitlist)) {
+                               if (SIMIX_process_is_suspended(waitproc)) {
+                                       SIMIX_process_resume(waitproc);
+                               }
+                       }
 
                        SIMIX_mutex_unlock(request->mutex);
                }
@@ -134,8 +168,18 @@ int smpi_sender(int argc, char **argv)
 
 int smpi_receiver(int argc, char **argv)
 {
-       int rank = smpi_mpi_comm_rank_self(&smpi_mpi_comm_world);
+       smx_process_t self;
+       int rank;
+       xbt_fifo_t request_queue;
+       xbt_fifo_t message_queue;
        int size;
+       int running_hosts;
+       smpi_mpi_request_t *message;
+       smpi_mpi_request_t *request;
+       smx_process_t waitproc;
+
+       self  = SIMIX_process_self();
+       rank  = smpi_mpi_comm_world_rank_self();
 
        // make sure root is done before own initialization
        SIMIX_mutex_lock(init_mutex);
@@ -144,8 +188,10 @@ int smpi_receiver(int argc, char **argv)
        }
        SIMIX_mutex_unlock(init_mutex);
 
+       request_queue = smpi_pending_receive_requests[rank];
+       message_queue = smpi_received_messages[rank];
        size = smpi_mpi_comm_size(&smpi_mpi_comm_world);
-       smpi_receiver_processes[rank] = SIMIX_process_self();
+       smpi_receiver_processes[rank] = self;
 
        // wait for all nodes to signal initializatin complete
        SIMIX_mutex_lock(init_mutex);
@@ -157,6 +203,38 @@ int smpi_receiver(int argc, char **argv)
        }
        SIMIX_mutex_unlock(init_mutex);
 
+       SIMIX_mutex_lock(smpi_running_hosts_mutex);
+       running_hosts = smpi_running_hosts;
+       SIMIX_mutex_unlock(smpi_running_hosts_mutex);
+
+       while (0 < running_hosts) {
+
+               // FIXME: search for received messages and requests
+               // use stupid algorithm for now
+
+               if (NULL == request) {
+                       SIMIX_process_suspend(self);
+               } else {
+                       SIMIX_mutex_lock(request->mutex);
+                       memcpy(request->buf, message->buf, request->count * request->type->size);
+                       request->src = message->src;
+                       reqeust->completed = 1;
+
+                       while (waitproc = xbt_fifo_shift(request->waitlist)) {
+                               if (SIMIX_process_is_suspended(waitproc)) {
+                                       SIMIX_process_resume(waitproc);
+                               }
+                       }
+
+                       SIMIX_mutex_unlock(request->mutex);
+                       xbt_mallocator_release(smpi_message_mallocator, message);
+               }
+
+               SIMIX_mutex_lock(smpi_running_hosts_mutex);
+               running_hosts = smpi_running_hosts;
+               SIMIX_mutex_unlock(smpi_running_hosts_mutex);
+       }
+
        return 0;
 }
 
@@ -221,6 +299,11 @@ void smpi_mpi_sum_func(void *x, void *y, void *z)
        *(int *)z = *(int *)x + *(int *)y;
 }
 
+smpi_mpi_request_t *smpi_new_request()
+{
+       return xbt_new(smpi_mpi_request_t, 1);
+}
+
 void smpi_mpi_init()
 {
        int i;
@@ -239,8 +322,8 @@ void smpi_mpi_init()
        if (host == hosts[0]) {
 
                // processes
-               smpi_sender_processes             = xbt_new0(smx_process_t, size);
-               smpi_receiver_processes           = xbt_new0(smx_process_t, size);
+               smpi_sender_processes             = xbt_new(smx_process_t, size);
+               smpi_receiver_processes           = xbt_new(smx_process_t, size);
 
                // running hosts
                smpi_running_hosts_mutex          = SIMIX_mutex_init();
@@ -252,7 +335,7 @@ void smpi_mpi_init()
                smpi_mpi_comm_world.barrier_mutex = SIMIX_mutex_init();
                smpi_mpi_comm_world.barrier_cond  = SIMIX_cond_init();
                smpi_mpi_comm_world.hosts         = hosts;
-               smpi_mpi_comm_world.processes     = xbt_new0(smx_process_t, size);
+               smpi_mpi_comm_world.processes     = xbt_new(smx_process_t, size);
                smpi_mpi_comm_world.processes[0]  = SIMIX_process_self();
 
                // mpi datatypes
@@ -265,9 +348,11 @@ void smpi_mpi_init()
                smpi_mpi_sum.func                 = &smpi_mpi_sum_func;
 
                // smpi globals
-               smpi_pending_send_requests        = xbt_new0(xbt_fifo_t, size);
-               smpi_pending_recv_requests        = xbt_new0(xbt_fifo_t, size);
-               smpi_received_messages            = xbt_new0(xbt_fifo_t, size);
+               smpi_request_mallocator           = xbt_mallocator_new(SMPI_REQUEST_MALLOCATOR_SIZE, smpi_new_request, xbt_free, NULL);
+               smpi_message_mallocator           = xbt_mallocator_new(SMPI_MESSAGE_MALLOCATOR_SIZE, smpi_new_message, xbt_free, NULL);
+               smpi_pending_send_requests        = xbt_new(xbt_fifo_t, size);
+               smpi_pending_recv_requests        = xbt_new(xbt_fifo_t, size);
+               smpi_received_messages            = xbt_new(xbt_fifo_t, size);
 
                for(i = 0; i < size; i++) {
                        smpi_pending_send_requests[i] = xbt_fifo_new();
@@ -329,6 +414,8 @@ void smpi_mpi_finalize()
                        xbt_fifo_free(smpi_received_messages[i]);
                }
 
+               xbt_mallocator_free(smpi_request_mallocator);
+               xbt_mallocator_free(smpi_message_mallocator);
                xbt_free(smpi_pending_send_requests);
                xbt_free(smpi_pending_recv_requests);
                xbt_free(smpi_received_messages);
@@ -420,7 +507,7 @@ int smpi_create_request(void *buf, int count, smpi_mpi_datatype_t *datatype,
        } else if (0 > tag) {
                retval = MPI_ERR_TAG;
        } else {
-               *request = xbt_new0(smpi_mpi_request_t, 1);
+               *request = xbt_mallocator_get(smpi_request_mallocator);
                (*request)->buf        = buf;
                (*request)->count      = count;
                (*request)->datatype   = datatype;
@@ -459,14 +546,23 @@ int smpi_irecv(smpi_mpi_request_t *request)
 void smpi_wait(smpi_mpi_request_t *request, smpi_mpi_status_t *status)
 {
        smx_process_t self;
+       int suspend = 0;
+       self = SIMIX_process_self();
 
        if (NULL != request) {
+               SIMIX_mutex_lock(request->mutex);
                if (!request->completed) {
-                       self = SIMIX_process_self();
                        xbt_fifo_push(request->waitlist, self);
-               }       SIMIX_suspend(self);
+                       suspend = 1;
+               }
+               SIMIX_mutex_unlock(request->mutex);
+               if (suspend) {
+                       SIMIX_suspend(self);
+               }
                if (NULL != status && MPI_STATUS_IGNORE != status) {
+                       SIMIX_mutex_lock(request->mutex);
                        status->MPI_SOURCE = request->src;
+                       SIMIX_mutex_unlock(request->mutex);
                }
        }
 }