Fixed small bug when running_actions were empty.

[simgrid.git] / src / surf / network_gtnets.c

diff --git a/src/surf/network_gtnets.c b/src/surf/network_gtnets.c
index a193748..7a89b83 100644 (file)
--- a/src/surf/network_gtnets.c
+++ b/src/surf/network_gtnets.c
@@ -1,4 +1,4 @@
-/*     $Id$     */
+/*     $Id$     */

 
 /* Copyright (c) 2005 Henri Casanova. All rights reserved.                  */
 
 
 /* Copyright (c) 2005 Henri Casanova. All rights reserved.                  */
 


@@ -7,24 +7,11 @@
 
 #include "network_gtnets_private.h"
 #include "gtnets/gtnets_interface.h"
 
 #include "network_gtnets_private.h"
 #include "gtnets/gtnets_interface.h"

+#include "xbt/str.h"

 
 XBT_LOG_NEW_DEFAULT_SUBCATEGORY(surf_network_gtnets, surf,
                                "Logging specific to the SURF network module");
 
 
 XBT_LOG_NEW_DEFAULT_SUBCATEGORY(surf_network_gtnets, surf,
                                "Logging specific to the SURF network module");
 

-/* surf_network_model_t surf_network_model = NULL; */
-/*static xbt_dict_t network_link_set = NULL;*/
-
-/* xbt_dict_t network_card_set = NULL; */
-
-#if 0
-static int card_number = 0;
-static network_link_GTNETS_t **routing_table = NULL;
-static int *routing_table_size = NULL;
-
-#define ROUTE(i,j) routing_table[(i)+(j)*card_number]
-#define ROUTE_SIZE(i,j) routing_table_size[(i)+(j)*card_number]
-#endif
-

 /** QUESTIONS for GTNetS integration
  **   1. Check that we did the right thing with name_service and get_resource_name
  **   2. Right now there is no "kill flow" in our GTNetS implementation. Do we
 /** QUESTIONS for GTNetS integration
  **   1. Check that we did the right thing with name_service and get_resource_name
  **   2. Right now there is no "kill flow" in our GTNetS implementation. Do we


@@ -36,7 +23,7 @@ static int *routing_table_size = NULL;
  **/
 
 /* Free memory for a network link */
  **/
 
 /* Free memory for a network link */

-static void network_link_free(void *nw_link)
+static void link_free(void *nw_link)

 {
   free(((network_link_GTNETS_t) nw_link)->name);
   free(nw_link);
 {
   free(((network_link_GTNETS_t) nw_link)->name);
   free(nw_link);


@@ -46,13 +33,13 @@ static void network_link_free(void *nw_link)
 /* name: some name for the link, from the XML */
 /* bw: The bandwidth value            */
 /* lat: The latency value             */
 /* name: some name for the link, from the XML */
 /* bw: The bandwidth value            */
 /* lat: The latency value             */

-static void network_link_new(char *name, double bw, double lat)
+static void link_new(char *name, double bw, double lat, xbt_dict_t props)

 {
   static int link_count = -1;
   network_link_GTNETS_t gtnets_link;
 
 {
   static int link_count = -1;
   network_link_GTNETS_t gtnets_link;
 

-  /* KF: Check that the link wasn't added before */
-  if (xbt_dict_get_or_null(network_link_set, name)) {
+  /* If link already exists, nothing to do (FIXME: check that multiple definition match?) */
+  if (xbt_dict_get_or_null(link_set, name)) {

     return;
   }
 
     return;
   }
 


@@ -87,7 +74,10 @@ static void network_link_new(char *name, double bw, double lat)
   gtnets_link->bw_current = bw;
   gtnets_link->lat_current = lat;
   gtnets_link->id = link_count;
   gtnets_link->bw_current = bw;
   gtnets_link->lat_current = lat;
   gtnets_link->id = link_count;

-  xbt_dict_set(network_link_set, name, gtnets_link, network_link_free);
+  /* Add the properties */
+  gtnets_link->properties = current_property_set;
+
+  xbt_dict_set(link_set, name, gtnets_link, link_free);

 
   return;
 }
 
   return;
 }


@@ -134,7 +124,7 @@ static void route_new(int src_id, int dst_id, char **links, int nb_link)
   link_list = (ROUTE(src_id, dst_id) =
               xbt_new0(network_link_GTNETS_t, nb_link));
   for (i = 0; i < nb_link; i++) {
   link_list = (ROUTE(src_id, dst_id) =
               xbt_new0(network_link_GTNETS_t, nb_link));
   for (i = 0; i < nb_link; i++) {

-    link_list[i] = xbt_dict_get_or_null(network_link_set, links[i]);
+    link_list[i] = xbt_dict_get_or_null(link_set, links[i]);

     free(links[i]);
   }
   free(links);
     free(links[i]);
   }
   free(links);


@@ -147,7 +137,7 @@ static void route_new(int src_id, int dst_id, char **links, int nb_link)
   for (i = 0; i < nb_link; i++) {
     gtnets_links[i] =
        ((network_link_GTNETS_t)
   for (i = 0; i < nb_link; i++) {
     gtnets_links[i] =
        ((network_link_GTNETS_t)

-        (xbt_dict_get(network_link_set, links[i])))->id;
+        (xbt_dict_get(link_set, links[i])))->id;

   }
 
   /* KF: Create the GTNets route */
   }
 
   /* KF: Create the GTNets route */


@@ -169,7 +159,7 @@ static void route_onehop_new(int src_id, int dst_id, char **links,
   /* KF: Build the list of gtnets link IDs */
   linkid =
       ((network_link_GTNETS_t)
   /* KF: Build the list of gtnets link IDs */
   linkid =
       ((network_link_GTNETS_t)

-       (xbt_dict_get(network_link_set, links[0])))->id;
+       (xbt_dict_get(link_set, links[0])))->id;

 
   /* KF: Create the GTNets route */
   if (gtnets_add_onehop_route(src_id, dst_id, linkid)) {
 
   /* KF: Create the GTNets route */
   if (gtnets_add_onehop_route(src_id, dst_id, linkid)) {


@@ -177,18 +167,20 @@ static void route_onehop_new(int src_id, int dst_id, char **links,
   }
 }
 
   }
 }
 

+
+

 /* Parse the XML for a network link */
 /* Parse the XML for a network link */

-static void parse_network_link(void)
+static void parse_link_init(void)

 {
   char *name;
   double bw;
   double lat;
 {
   char *name;
   double bw;
   double lat;

-  e_surf_network_link_state_t state;
+  e_surf_link_state_t state;

 
 

-  name = xbt_strdup(A_surfxml_network_link_name);
-  surf_parse_get_double(&bw, A_surfxml_network_link_bandwidth);
-  surf_parse_get_double(&lat, A_surfxml_network_link_latency);
-  state = SURF_NETWORK_LINK_ON;
+  name = xbt_strdup(A_surfxml_link_id);
+  surf_parse_get_double(&bw, A_surfxml_link_bandwidth);
+  surf_parse_get_double(&lat, A_surfxml_link_latency);
+  state = SURF_LINK_ON;

 
   /* Print values when no traces are specified */
   {
 
   /* Print values when no traces are specified */
   {


@@ -196,9 +188,9 @@ static void parse_network_link(void)
     tmgr_trace_t state_trace;
     tmgr_trace_t lat_trace;
 
     tmgr_trace_t state_trace;
     tmgr_trace_t lat_trace;
 

-    surf_parse_get_trace(&bw_trace, A_surfxml_network_link_bandwidth_file);
-    surf_parse_get_trace(&lat_trace, A_surfxml_network_link_latency_file);
-    surf_parse_get_trace(&state_trace, A_surfxml_network_link_state_file);
+    surf_parse_get_trace(&bw_trace, A_surfxml_link_bandwidth_file);
+    surf_parse_get_trace(&lat_trace, A_surfxml_link_latency_file);
+    surf_parse_get_trace(&state_trace, A_surfxml_link_state_file);

 
     /*TODO Where is WARNING0 defined??? */
 #if 0
 
     /*TODO Where is WARNING0 defined??? */
 #if 0


@@ -213,10 +205,9 @@ static void parse_network_link(void)
          ("The GTNetS network model doesn't support link state traces");
 #endif
   }
          ("The GTNetS network model doesn't support link state traces");
 #endif
   }

-
-
-  /* KF: remove several arguments to network_link_new */
-  network_link_new(name, bw, lat);
+  /* KF: remove several arguments to link_new */
+  current_property_set = xbt_dict_new();
+  link_new(name, bw, lat, current_property_set);

 }
 
 static int nb_link = 0;
 }
 
 static int nb_link = 0;


@@ -229,14 +220,17 @@ static void parse_route_set_endpoints(void)
 {
   src_id = network_card_new(A_surfxml_route_src);
   dst_id = network_card_new(A_surfxml_route_dst);
 {
   src_id = network_card_new(A_surfxml_route_src);
   dst_id = network_card_new(A_surfxml_route_dst);

-  nb_link = 0;
+
+/*  nb_link = 0;

   link_name = NULL;
   link_name = NULL;

+*/
+  route_link_list = xbt_dynar_new(sizeof(char *), &xbt_free_ref);

 }
 
 /* KF*/
 static void parse_route_set_routers(void)
 {
 }
 
 /* KF*/
 static void parse_route_set_routers(void)
 {

-  int id = network_card_new(A_surfxml_router_name);
+  int id = network_card_new(A_surfxml_router_id);

 
   /* KF: Create the GTNets router */
   if (gtnets_add_router(id)) {
 
   /* KF: Create the GTNets router */
   if (gtnets_add_router(id)) {


@@ -244,21 +238,28 @@ static void parse_route_set_routers(void)
   }
 }
 
   }
 }
 

+//The following is common to all and has been relocated to surfxml_parse

 /* Parses a route element from the XML: UNMODIFIED BY HC */
 /* Parses a route element from the XML: UNMODIFIED BY HC */

-static void parse_route_elem(void)
+/*static void parse_route_elem(void)

 {
   nb_link++;
   link_name = xbt_realloc(link_name, (nb_link) * sizeof(char *));
   link_name[(nb_link) - 1] = xbt_strdup(A_surfxml_route_element_name);
 }
 {
   nb_link++;
   link_name = xbt_realloc(link_name, (nb_link) * sizeof(char *));
   link_name[(nb_link) - 1] = xbt_strdup(A_surfxml_route_element_name);
 }

+*/

 
 /* Create the route (more than one hops): MODIFIED BY KF */
 static void parse_route_set_route(void)
 {
 
 /* Create the route (more than one hops): MODIFIED BY KF */
 static void parse_route_set_route(void)
 {

-  if (nb_link > 1)
+/*  if (nb_link > 1)

     route_new(src_id, dst_id, link_name, nb_link);
     route_new(src_id, dst_id, link_name, nb_link);

+*/
+    char *name = bprintf("%x#%x",src_id, dst_id);
+    xbt_dict_set(route_table, name, route_link_list, NULL);
+    free(name);    

 }
 
 }
 

+//This is not used anymore. one hop routes are created in add_route

 /* Create the one-hope route: BY KF */
 static void parse_route_set_onehop_route(void)
 {
 /* Create the one-hope route: BY KF */
 static void parse_route_set_onehop_route(void)
 {


@@ -266,50 +267,63 @@ static void parse_route_set_onehop_route(void)
     route_onehop_new(src_id, dst_id, link_name, nb_link);
 }
 
     route_onehop_new(src_id, dst_id, link_name, nb_link);
 }
 

+static void add_route()
+{
+  xbt_ex_t e;
+  unsigned int cpt = 0;    
+  int i = 0;
+  xbt_dict_cursor_t cursor = NULL;
+  char *key,*data, *end;
+  const char *sep = "#";
+  xbt_dynar_t links, keys;
+
+  xbt_dict_foreach(route_table, cursor, key, data) {
+    nb_link = 0;
+    links = (xbt_dynar_t)data;
+    keys = xbt_str_split_str(key, sep);
+
+    nb_link = xbt_dynar_length(links);
+    link_name = xbt_realloc(link_name, (nb_link) * sizeof(char *));
+
+    src_id = strtol(xbt_dynar_get_as(keys, 0, char*), &end, 16);
+    dst_id = strtol(xbt_dynar_get_as(keys, 1, char*), &end, 16);
+  
+    i = 0;
+    char* link = NULL;
+    xbt_dynar_foreach (links, cpt, link) {
+      TRY {
+        link_name[i++] = xbt_dict_get(link_set, link);
+      }
+      CATCH(e) {
+        RETHROW1("Link %s not found (dict raised this exception: %s)", link);
+      }     
+    }
+    if (nb_link > 1)
+      route_new(src_id, dst_id, link_name, nb_link);
+    if (nb_link == 1)
+      route_onehop_new(src_id, dst_id, link_name, nb_link);
+   }
+
+   xbt_dict_free(&route_table);
+}
+

 /* Main XML parsing */
 /* Main XML parsing */

-static void parse_file(const char *file)
-{
-  /* Figuring out the network links */
-  surf_parse_reset_parser();
-  ETag_surfxml_network_link_fun = parse_network_link;
-  surf_parse_open(file);
-  xbt_assert1((!surf_parse()), "Parse error in %s", file);
-  surf_parse_close();
-
-  /* Figuring out the network cards used */
-  /* KF
-     surf_parse_reset_parser();
-     STag_surfxml_route_fun=parse_route_set_endpoints;
-     surf_parse_open(file);
-     xbt_assert1((!surf_parse()),"Parse error in %s",file);
-     surf_parse_close();
-   */
-
-  /* KF: Figuring out the router (considered as part of
-     network cards) used. */
-  surf_parse_reset_parser();
-  STag_surfxml_router_fun = parse_route_set_routers;
-  surf_parse_open(file);
-  xbt_assert1((!surf_parse()), "Parse error in %s", file);
-  surf_parse_close();
-
-  /* Building the one-hop routes */
-  surf_parse_reset_parser();
-  STag_surfxml_route_fun = parse_route_set_endpoints;
-  ETag_surfxml_route_element_fun = parse_route_elem;
-  ETag_surfxml_route_fun = parse_route_set_onehop_route;
-  surf_parse_open(file);
-  xbt_assert1((!surf_parse()), "Parse error in %s", file);
-  surf_parse_close();
-
-  /* Building the routes */
-  surf_parse_reset_parser();
-  STag_surfxml_route_fun = parse_route_set_endpoints;
-  ETag_surfxml_route_element_fun = parse_route_elem;
-  ETag_surfxml_route_fun = parse_route_set_route;
-  surf_parse_open(file);
-  xbt_assert1((!surf_parse()), "Parse error in %s", file);
-  surf_parse_close();
+static void define_callbacks(const char *file)
+{
+  surfxml_add_callback(STag_surfxml_prop_cb_list, &parse_properties);
+  surfxml_add_callback(STag_surfxml_router_cb_list, &parse_route_set_routers);
+  surfxml_add_callback(STag_surfxml_link_cb_list, &parse_link_init);
+  surfxml_add_callback(STag_surfxml_route_cb_list, &parse_route_set_endpoints);
+  surfxml_add_callback(ETag_surfxml_link_c_ctn_cb_list, &parse_route_elem);
+/* surfxml_add_callback(ETag_surfxml_route_cb_list, &parse_route_set_onehop_route);*/
+  surfxml_add_callback(STag_surfxml_platform_cb_list, &init_data);
+  surfxml_add_callback(ETag_surfxml_route_cb_list, &parse_route_set_route);
+  surfxml_add_callback(ETag_surfxml_platform_cb_list, &add_route);
+  surfxml_add_callback(STag_surfxml_set_cb_list, &parse_sets);
+  surfxml_add_callback(STag_surfxml_route_c_multi_cb_list, &parse_route_multi_set_endpoints);
+  surfxml_add_callback(ETag_surfxml_route_c_multi_cb_list, &parse_route_multi_set_route);
+  surfxml_add_callback(STag_surfxml_foreach_cb_list, &parse_foreach);
+  surfxml_add_callback(STag_surfxml_cluster_cb_list, &parse_cluster);

 }
 
 static void *name_service(const char *name)
 }
 
 static void *name_service(const char *name)


@@ -322,6 +336,12 @@ static const char *get_resource_name(void *resource_id)
   return ((network_card_GTNETS_t) resource_id)->name;
 }
 
   return ((network_card_GTNETS_t) resource_id)->name;
 }
 

+static xbt_dict_t get_properties(void *link)
+{
+  return ((network_card_GTNETS_t) link)->properties;
+}
+
+

 /* We do not care about this: only used for traces */
 static int resource_used(void *resource_id)
 {
 /* We do not care about this: only used for traces */
 static int resource_used(void *resource_id)
 {


@@ -374,12 +394,11 @@ static void action_change_state(surf_action_t action,
 /* share_resources() */
 static double share_resources(double now)
 {
 /* share_resources() */
 static double share_resources(double now)
 {

-#if 0
-  s_surf_action_network_GTNETS_t s_action;
-  surf_action_network_GTNETS_t action = NULL;
-  xbt_swag_t running_actions =
-      surf_network_model->common_public->states.running_action_set;
-#endif
+  xbt_swag_t running_actions = surf_network_model->common_public->states.running_action_set;
+
+  //get the first relevant value from the running_actions list
+  if (!xbt_swag_size(running_actions))
+    return -1.0;

 
   return gtnets_get_time_to_next_flow_completion();
 }
 
   return gtnets_get_time_to_next_flow_completion();
 }


@@ -393,9 +412,9 @@ static double share_resources(double now)
 
 static void update_actions_state(double now, double delta)
 {
 
 static void update_actions_state(double now, double delta)
 {

-#if 0
+#if 1

   surf_action_network_GTNETS_t action = NULL;
   surf_action_network_GTNETS_t action = NULL;

-  surf_action_network_GTNETS_t next_action = NULL;
+  //  surf_action_network_GTNETS_t next_action = NULL;

   xbt_swag_t running_actions =
       surf_network_model->common_public->states.running_action_set;
 #endif
   xbt_swag_t running_actions =
       surf_network_model->common_public->states.running_action_set;
 #endif


@@ -424,15 +443,34 @@ static void update_actions_state(double now, double delta)
                  "GTNetS simulation couldn't find a flow that would complete");
     }
 
                  "GTNetS simulation couldn't find a flow that would complete");
     }
 

-    for (i = 0; i < num_flows; i++) {
-      surf_action_network_GTNETS_t action =
-         (surf_action_network_GTNETS_t) (metadata[i]);

 
 

-      action->generic_action.remains = 0;
+
+    xbt_swag_foreach(action, running_actions) {
+      DEBUG1("]]]]]]]]] Action remains old value: %f", action->generic_action.remains);
+      double remain = gtnets_get_flow_rx(action);
+      //need to trust this remain value
+      if(remain == 0){
+       action->generic_action.remains=0;
+      }else {
+       action->generic_action.remains-=remain;
+      }
+      DEBUG1("[[[[[[[[[ Action remains new value: %f", action->generic_action.remains);
+    }
+
+    for (i = 0; i < num_flows; i++) {
+      action =  (surf_action_network_GTNETS_t) (metadata[i]);
+      

       action->generic_action.finish = now + time_to_next_flow_completion;
       action_change_state((surf_action_t) action, SURF_ACTION_DONE);
       /* TODO: Anything else here? */
       action->generic_action.finish = now + time_to_next_flow_completion;
       action_change_state((surf_action_t) action, SURF_ACTION_DONE);
       /* TODO: Anything else here? */

+
+      //need to map this action to the gtnets engine
+      DEBUG1("]]]]]]]]] Action remains old value: %f", action->generic_action.remains);
+      action->generic_action.remains -= gtnets_get_flow_rx(metadata[i]);
+      DEBUG1("[[[[[[[[[ Action remains new value: %f", action->generic_action.remains);

     }
     }

+
+

   } else {                     /* run for a given number of seconds */
     if (gtnets_run(delta)) {
       xbt_assert0(0, "Cannot run GTNetS simulation");
   } else {                     /* run for a given number of seconds */
     if (gtnets_run(delta)) {
       xbt_assert0(0, "Cannot run GTNetS simulation");


@@ -445,7 +483,7 @@ static void update_actions_state(double now, double delta)
 /* UNUSED HERE: no traces */
 static void update_resource_state(void *id,
                                  tmgr_trace_event_t event_type,
 /* UNUSED HERE: no traces */
 static void update_resource_state(void *id,
                                  tmgr_trace_event_t event_type,

-                                 double value)
+                                 double value, double date)

 {
   xbt_assert0(0, "Cannot update model state for GTNetS simulation");
   return;
 {
   xbt_assert0(0, "Cannot update model state for GTNetS simulation");
   return;


@@ -520,7 +558,7 @@ static void finalize(void)
   int i, j;
 #endif
   xbt_dict_free(&network_card_set);
   int i, j;
 #endif
   xbt_dict_free(&network_card_set);

-  xbt_dict_free(&network_link_set);
+  xbt_dict_free(&link_set);

   xbt_swag_free(surf_network_model->common_public->states.
                ready_action_set);
   xbt_swag_free(surf_network_model->common_public->states.
   xbt_swag_free(surf_network_model->common_public->states.
                ready_action_set);
   xbt_swag_free(surf_network_model->common_public->states.


@@ -593,8 +631,7 @@ static void surf_network_model_init_internal(void)
   surf_network_model->common_private->share_resources = share_resources;
   surf_network_model->common_private->update_actions_state =
       update_actions_state;
   surf_network_model->common_private->share_resources = share_resources;
   surf_network_model->common_private->update_actions_state =
       update_actions_state;

-  surf_network_model->common_private->update_resource_state =
-      update_resource_state;
+  surf_network_model->common_private->update_resource_state = update_resource_state;

   surf_network_model->common_private->finalize = finalize;
 
   surf_network_model->common_public->suspend = action_suspend;
   surf_network_model->common_private->finalize = finalize;
 
   surf_network_model->common_public->suspend = action_suspend;


@@ -603,7 +640,10 @@ static void surf_network_model_init_internal(void)
 
   surf_network_model->extension_public->communicate = communicate;
 
 
   surf_network_model->extension_public->communicate = communicate;
 

-  network_link_set = xbt_dict_new();
+  /*for the props of the link*/
+  surf_network_model->common_public->get_properties =  get_properties;
+
+  link_set = xbt_dict_new();

   network_card_set = xbt_dict_new();
 
   /* KF: Added the initialization for GTNetS interface */
   network_card_set = xbt_dict_new();
 
   /* KF: Added the initialization for GTNetS interface */


@@ -617,7 +657,7 @@ void surf_network_model_init_GTNETS(const char *filename)
   if (surf_network_model)
     return;
   surf_network_model_init_internal();
   if (surf_network_model)
     return;
   surf_network_model_init_internal();

-  parse_file(filename);
+  define_callbacks(filename);

   xbt_dynar_push(model_list, &surf_network_model);
 
   update_model_description(surf_network_model_description,
   xbt_dynar_push(model_list, &surf_network_model);
 
   update_model_description(surf_network_model_description,