-/* Copyright (c) 2015-2019. The SimGrid Team. All rights reserved. */
+/* Copyright (c) 2015-2020. The SimGrid Team. All rights reserved. */
/* This program is free software; you can redistribute it and/or modify it
* under the terms of the license (GNU LGPL) which comes with this package. */
that.vtable_->move(buffer_, that.buffer_);
else
std::memcpy(static_cast<void*>(&buffer_), static_cast<void*>(&that.buffer_), sizeof(buffer_));
-
- vtable_ = that.vtable_;
+ vtable_ = std::move(that.vtable_);
that.vtable_ = nullptr;
}
Task& operator=(Task const& that) = delete;
that.vtable_->move(buffer_, that.buffer_);
else
std::memcpy(static_cast<void*>(&buffer_), static_cast<void*>(&that.buffer_), sizeof(buffer_));
- vtable_ = that.vtable_;
+ vtable_ = std::move(that.vtable_);
that.vtable_ = nullptr;
return *this;
}
{
const static TaskVtable vtable {
// Call:
- [](TaskUnion& buffer, Args&&... args) {
+ [](TaskUnion& buffer, Args... args) {
F* src = reinterpret_cast<F*>(&buffer);
F code = std::move(*src);
src->~F();
+ // NOTE: std::forward<Args>(args)... is correct.
return code(std::forward<Args>(args)...);
},
// Destroy:
{
const static TaskVtable vtable {
// Call:
- [](TaskUnion& buffer, Args&&... args) {
+ [](TaskUnion& buffer, Args... args) {
// Delete F when we go out of scope:
std::unique_ptr<F> code(*reinterpret_cast<F**>(&buffer));
+ // NOTE: std::forward<Args>(args)... is correct.
return (*code)(std::forward<Args>(args)...);
},
// Destroy:
operator bool() const { return vtable_ != nullptr; }
bool operator!() const { return vtable_ == nullptr; }
- R operator()(Args&&... args)
+ R operator()(Args... args)
{
if (vtable_ == nullptr)
throw std::bad_function_call();
const TaskVtable* vtable = vtable_;
vtable_ = nullptr;
+ // NOTE: std::forward<Args>(args)... is correct.
+ // see C++ [func.wrap.func.inv] for an example
return vtable->call(buffer_, std::forward<Args>(args)...);
}
};