#include "gras/Transport/transport_private.h"
XBT_LOG_EXTERNAL_DEFAULT_CATEGORY(gras_trp);
+/* check transport_private.h for an explanation of this variable */
+gras_socket_t _gras_lastly_selected_socket = NULL;
+
/**
* gras_trp_select:
*
*
* if timeout<0, we ought to implement the adaptative timeout (FIXME)
*
- * if timeout=0, do not wait for new message, only handle the ones already there.
*
* if timeout>0 and no message there, wait at most that amount of time before giving up.
*/
with this tiny optimisation on BillWare */
fd_set FDS;
int ready; /* return of select: number of socket ready to be serviced */
- int fd_setsize; /* FD_SETSIZE not always defined. Get this portably */
+ static int fd_setsize=-1; /* FD_SETSIZE not always defined. Get this portably */
gras_socket_t sock_iter; /* iterating over all sockets */
int cursor; /* iterating over all sockets */
/* Check whether there is more data to read from the socket we selected last time.
This can happen with tcp buffered sockets since we try to get as much data as we can for them */
- static gras_socket_t _lastly_selected_socket = NULL;
- if (_lastly_selected_socket && _lastly_selected_socket->moredata) {
- VERB0("Returning _lastly_selected_socket since there is more data on it");
- return _lastly_selected_socket;
+ if (_gras_lastly_selected_socket && _gras_lastly_selected_socket->moredata) {
+ VERB0("Returning _gras_lastly_selected_socket since there is more data on it");
+ return _gras_lastly_selected_socket;
}
- /* Compute FD_SETSIZE */
+ /* Compute FD_SETSIZE on need */
+ if (fd_setsize < 0) {
#ifdef HAVE_SYSCONF
- fd_setsize = sysconf( _SC_OPEN_MAX );
+ fd_setsize = sysconf( _SC_OPEN_MAX );
#else
# ifdef HAVE_GETDTABLESIZE
- fd_setsize = getdtablesize();
+ fd_setsize = getdtablesize();
# else
- fd_setsize = FD_SETSIZE;
+ fd_setsize = FD_SETSIZE;
# endif /* !USE_SYSCONF */
#endif
+ }
while (done == -1) {
if (timeout > 0) { /* did we timeout already? */
now = gras_os_time();
DEBUG2("wakeup=%f now=%f",wakeup, now);
if (now == -1 || now >= wakeup) {
- /* didn't find anything; no need to update _lastly_selected_socket since its moredata is 0 (or we would have returned it directly) */
+ /* didn't find anything; no need to update _gras_lastly_selected_socket since its moredata is 0 (or we would have returned it directly) */
THROW1(timeout_error,0,
"Timeout (%f) elapsed with selecting for incomming connexions",
timeout);
#ifndef HAVE_WINSOCK_H
if (max_fds < sock_iter->sd)
max_fds = sock_iter->sd;
+#else
+ max_fds = 0;
+
#endif
FD_SET(sock_iter->sd, &FDS);
} else {
DEBUG1("Not considering socket %d for select",sock_iter->sd);
}
}
+
if (max_fds == -1) {
if (timeout > 0) {
/* not a socket but an ear. accept on it and serve next socket */
gras_socket_t accepted=NULL;
+ /* release mutex before accept; it will change the sockets dynar, so we have to break the foreach asap */
+ xbt_dynar_cursor_unlock(sockets);
accepted = (sock_iter->plugin->socket_accept)(sock_iter);
+
DEBUG2("accepted=%p,&accepted=%p",accepted,&accepted);
accepted->meas = sock_iter->meas;
+ break;
} else if (sock_iter->recv_ok) {
/* Make sure the socket is still alive by reading the first byte */
recvd = recv(sock_iter->sd, &lookahead, 1, MSG_PEEK);
if (recvd < 0) {
WARN2("socket %d failed: %s", sock_iter->sd, strerror(errno));
- /* done with this socket */
+ /* done with this socket; remove it and break the foreach since it will change the dynar */
+ xbt_dynar_cursor_unlock(sockets);
gras_socket_close(sock_iter);
- cursor--;
+ break;
} else if (recvd == 0) {
/* Connection reset (=closed) by peer. */
DEBUG1("Connection %d reset by peer", sock_iter->sd);
} else {
/* Got a suited socket ! */
XBT_OUT;
- _lastly_selected_socket = sock_iter;
+ _gras_lastly_selected_socket = sock_iter;
+ /* break sync dynar iteration */
+ xbt_dynar_cursor_unlock(sockets);
return sock_iter;
}
} else {
/* This is a file socket. Cannot recv() on it, but it must be alive */
XBT_OUT;
- _lastly_selected_socket = sock_iter;
+ _gras_lastly_selected_socket = sock_iter;
+ xbt_dynar_cursor_unlock(sockets);
return sock_iter;
}
-
/* if we're here, the socket we found wasn't really ready to be served */
- if (ready == 0) /* exausted all sockets given by select. Request new ones */
- break;
+ if (ready == 0) { /* exausted all sockets given by select. Request new ones */
+
+ xbt_dynar_cursor_unlock(sockets);
+ break;
+ }
}
}
