I don't think it does what it should now but at least it looks better and

[simgrid.git] / src / surf / network_dassf.c

diff --git a/src/surf/network_dassf.c b/src/surf/network_dassf.c
index 23471c9..b307415 100644 (file)
--- a/src/surf/network_dassf.c
+++ b/src/surf/network_dassf.c
@@ -31,8 +31,8 @@ static void create_routing_table(void)
 
 static void network_link_free(void *nw_link)
 {
-  xbt_free(((network_link_DASSF_t)nw_link)->name);
-  xbt_free(nw_link);
+  free(((network_link_DASSF_t)nw_link)->name);
+  free(nw_link);
 }
 
 static network_link_DASSF_t network_link_new(char *name,
@@ -72,15 +72,13 @@ static network_link_DASSF_t network_link_new(char *name,
 
 static void network_card_free(void *nw_card)
 {
-  xbt_free(((network_card_DASSF_t)nw_card)->name);
-  xbt_free(nw_card);
+  free(((network_card_DASSF_t)nw_card)->name);
+  free(nw_card);
 }
 
 static int network_card_new(const char *card_name)
 {
-  network_card_DASSF_t card = NULL;
-
-  xbt_dict_get(network_card_set, card_name, (void *) &card);
+  network_card_DASSF_t card = xbt_dict_get_or_null(network_card_set, card_name);
 
   if (!card) {
     card = xbt_new0(s_network_card_DASSF_t, 1);
@@ -99,10 +97,10 @@ static void route_new(int src_id, int dst_id, char **links, int nb_link)
   ROUTE_SIZE(src_id, dst_id) = nb_link;
   link_list = (ROUTE(src_id, dst_id) = xbt_new0(network_link_DASSF_t, nb_link));
   for (i = 0; i < nb_link; i++) {
-    xbt_dict_get(network_link_set, links[i], (void *) &(link_list[i]));
-    xbt_free(links[i]);
+    link_list[i] = xbt_dict_get_or_null(network_link_set, links[i]);
+    free(links[i]);
   }
-  xbt_free(links);
+  free(links);
 }
 
 static void parse_network_link(void)
@@ -123,7 +121,7 @@ static void parse_network_link(void)
 
   xbt_assert0((A_network_link_state==A_network_link_state_ON)||
              (A_network_link_state==A_network_link_state_OFF),
-             "Invalid state")
+             "Invalid state");
   if (A_network_link_state==A_network_link_state_ON) 
     state_initial = SURF_NETWORK_LINK_ON;
   if (A_network_link_state==A_network_link_state_OFF) 
@@ -189,11 +187,7 @@ static void parse_file(const char *file)
 
 static void *name_service(const char *name)
 {
-  network_card_DASSF_t card = NULL;
-
-  xbt_dict_get(network_card_set, name, (void *) &card);
-
-  return card;
+  return xbt_dict_get_or_null(network_card_set, name);
 }
 
 static const char *get_resource_name(void *resource_id)
@@ -207,14 +201,16 @@ static int resource_used(void *resource_id)
                             ((network_link_DASSF_t) resource_id)->constraint);
 }
 
-static void action_free(surf_action_t action)
+static int action_free(surf_action_t action)
 {
-  xbt_swag_remove(action, action->state_set);
-  if(((surf_action_network_DASSF_t)action)->variable)
-    lmm_variable_free(maxmin_system, ((surf_action_network_DASSF_t)action)->variable);
-  xbt_free(action);
-
-  return;
+  action->using--;
+  if(!action->using) {
+    xbt_swag_remove(action, action->state_set);
+    if(((surf_action_network_DASSF_t)action)->variable)
+      lmm_variable_free(maxmin_system, ((surf_action_network_DASSF_t)action)->variable);
+    free(action);
+  }
+  return 1;
 }
 
 static void action_cancel(surf_action_t action)
@@ -230,11 +226,11 @@ static void action_recycle(surf_action_t action)
 static void action_change_state(surf_action_t action,
                                e_surf_action_state_t state)
 {
-  if((state==SURF_ACTION_DONE) || (state==SURF_ACTION_FAILED))
-    if(((surf_action_network_DASSF_t)action)->variable) {
-      lmm_variable_disable(maxmin_system, ((surf_action_network_DASSF_t)action)->variable);
-      ((surf_action_network_DASSF_t)action)->variable = NULL;
-    }
+/*   if((state==SURF_ACTION_DONE) || (state==SURF_ACTION_FAILED)) */
+/*     if(((surf_action_network_DASSF_t)action)->variable) { */
+/*       lmm_variable_disable(maxmin_system, ((surf_action_network_DASSF_t)action)->variable); */
+/*       ((surf_action_network_DASSF_t)action)->variable = NULL; */
+/*     } */
 
   surf_action_change_state(action, state);
   return;
@@ -265,8 +261,10 @@ static void update_actions_state(double now, double delta)
   surf_action_network_DASSF_t next_action = NULL;
   xbt_swag_t running_actions =
       surf_network_resource->common_public->states.running_action_set;
+  /* KILLME: unused
   xbt_swag_t failed_actions =
       surf_network_resource->common_public->states.failed_action_set;
+  */
 
   xbt_swag_foreach_safe(action, next_action, running_actions) {
     deltap = delta;
@@ -367,8 +365,11 @@ static surf_action_t communicate(void *src, void *dst, double size, double rate)
   network_link_DASSF_t *route = ROUTE(card_src->id, card_dst->id);
   int i;
 
+  xbt_assert2(route_size,"You're trying to send data from %s to %s but there is no connexion between these two cards.", card_src->name, card_dst->name);
+
   action = xbt_new0(s_surf_action_network_DASSF_t, 1);
 
+  action->generic_action.using = 1;
   action->generic_action.cost = size;
   action->generic_action.remains = size;
   action->generic_action.max_duration = NO_MAX_DURATION;
@@ -445,19 +446,19 @@ static void finalize(void)
                failed_action_set);
   xbt_swag_free(surf_network_resource->common_public->states.
                done_action_set);
-  xbt_free(surf_network_resource->common_public);
-  xbt_free(surf_network_resource->common_private);
-  xbt_free(surf_network_resource->extension_public);
+  free(surf_network_resource->common_public);
+  free(surf_network_resource->common_private);
+  free(surf_network_resource->extension_public);
 
-  xbt_free(surf_network_resource);
+  free(surf_network_resource);
   surf_network_resource = NULL;
 
   for (i = 0; i < card_number; i++) 
     for (j = 0; j < card_number; j++) 
-      xbt_free(ROUTE(i,j));
-  xbt_free(routing_table);
+      free(ROUTE(i,j));
+  free(routing_table);
   routing_table = NULL;
-  xbt_free(routing_table_size);
+  free(routing_table_size);
   routing_table_size = NULL;
   card_number = 0;
 }