mmalloc: cosmetics in an error message

[simgrid.git] / src / xbt / mmalloc / mrealloc.c

diff --git a/src/xbt/mmalloc/mrealloc.c b/src/xbt/mmalloc/mrealloc.c
index 186cc66..9e9a877 100644 (file)
--- a/src/xbt/mmalloc/mrealloc.c
+++ b/src/xbt/mmalloc/mrealloc.c
@@ -36,8 +36,8 @@ void *mrealloc(xbt_mheap_t mdp, void *ptr, size_t size)
   }
 
   if ((char *) ptr < (char *) mdp->heapbase || BLOCK(ptr) > mdp->heapsize) {
-    printf("FIXME. Ouch, this pointer is not mine, refusing to proceed (another solution would be to malloc "
-           "it instead of reallocing it, see source code)\n");
+    // Don't trust xbt_assert and friends in malloc-level library, you fool!
+    fprintf(stderr, "This pointer is not mine, refusing to realloc it (maybe you wanted to malloc it instead?)\n");
     abort();
   }
 
@@ -79,9 +79,8 @@ void *mrealloc(xbt_mheap_t mdp, void *ptr, size_t size)
     /* Full blocks -> Full blocks; see if we can hold it in place. */
     blocks = BLOCKIFY(size);
     if (blocks < mdp->heapinfo[block].busy_block.size) {
-      int it;
       /* The new size is smaller; return excess memory to the free list. */
-      for (it= block+blocks; it< mdp->heapinfo[block].busy_block.size ; it++){
+      for (size_t it = block + blocks; it < mdp->heapinfo[block].busy_block.size; it++) {
         mdp->heapinfo[it].type = MMALLOC_TYPE_UNFRAGMENTED; // FIXME that should be useless, type should already be 0 here
         mdp->heapinfo[it].busy_block.ignore = 0;
         mdp->heapinfo[it].busy_block.size = 0;
@@ -125,7 +124,7 @@ void *mrealloc(xbt_mheap_t mdp, void *ptr, size_t size)
 
   default: /* Fragment -> ??; type=logarithm to base two of the fragment size.  */
 
-    if (type < 0) {
+    if (type <= 0) {
       fprintf(stderr, "Unknown mmalloc block type.\n");
       abort();
     }
@@ -134,7 +133,7 @@ void *mrealloc(xbt_mheap_t mdp, void *ptr, size_t size)
       /* The new size is the same kind of fragment.  */
 
       result = ptr;
-      int frag_nb = RESIDUAL(result, BLOCKSIZE) >> type;
+      uintptr_t frag_nb                                 = RESIDUAL(result, BLOCKSIZE) >> type;
       mdp->heapinfo[block].busy_frag.frag_size[frag_nb] = requested_size;
       mdp->heapinfo[block].busy_frag.ignore[frag_nb] = 0;