->create_cpu(this, speeds)
->set_core_count(core_amount)
->seal();
+
if (physical_host->get_pstate() != 0)
set_pstate(physical_host->get_pstate());
- // Real hosts are (only) created through NetZone::create_host(), and this where the on_creation signal is fired.
- // VMs are created directly, thus firing the signal here. The right solution is probably to separate Host and VM.
- simgrid::s4u::Host::on_creation(*this);
+ seal(); // seal this host
}
VirtualMachine::~VirtualMachine()
{
on_destruction(*this);
- XBT_DEBUG("destroy %s", get_cname());
-
/* Don't free these things twice: they are the ones of my physical host */
set_netpoint(nullptr);
}
{
on_start(*this);
- kernel::actor::simcall([this]() {
- vm::VmHostExt::ensureVmExtInstalled();
+ vm::VmHostExt::ensureVmExtInstalled();
+ kernel::actor::simcall([this]() {
Host* pm = this->pimpl_vm_->get_physical_host();
if (pm->extension<vm::VmHostExt>() == nullptr)
pm->extension_set(new vm::VmHostExt());
- long pm_ramsize = pm->extension<vm::VmHostExt>()->ramsize;
- int pm_overcommit = pm->extension<vm::VmHostExt>()->overcommit;
- long vm_ramsize = this->get_ramsize();
-
- if (pm_ramsize && not pm_overcommit) { /* Only verify that we don't overcommit on need */
+ size_t pm_ramsize = pm->extension<vm::VmHostExt>()->ramsize;
+ if (pm_ramsize && not pm->extension<vm::VmHostExt>()->overcommit) { /* Need to verify that we don't overcommit */
/* Retrieve the memory occupied by the VMs on that host. Yep, we have to traverse all VMs of all hosts for that */
- long total_ramsize_of_vms = 0;
+ size_t total_ramsize_of_vms = 0;
for (VirtualMachine* const& ws_vm : vm::VirtualMachineImpl::allVms_)
if (pm == ws_vm->get_pm())
total_ramsize_of_vms += ws_vm->get_ramsize();
- if (vm_ramsize > pm_ramsize - total_ramsize_of_vms) {
- XBT_WARN("cannot start %s@%s due to memory shortage: vm_ramsize %ld, free %ld, pm_ramsize %ld (bytes).",
- this->get_cname(), pm->get_cname(), vm_ramsize, pm_ramsize - total_ramsize_of_vms, pm_ramsize);
+ if (total_ramsize_of_vms + get_ramsize() > pm_ramsize) {
+ XBT_WARN("cannot start %s@%s due to memory shortage: get_ramsize() %zu, free %zu, pm_ramsize %zu (bytes).",
+ get_cname(), pm->get_cname(), get_ramsize(), pm_ramsize - total_ramsize_of_vms, pm_ramsize);
throw VmFailureException(XBT_THROW_POINT,
xbt::string_printf("Memory shortage on host '%s', VM '%s' cannot be started",
- pm->get_cname(), this->get_cname()));
+ pm->get_cname(), get_cname()));
}
}
-
- this->pimpl_vm_->set_state(VirtualMachine::state::RUNNING);
+ this->pimpl_vm_->set_state(State::RUNNING);
});
on_started(*this);
void VirtualMachine::destroy()
{
- /* First, terminate all processes on the VM if necessary */
- shutdown();
-
- /* Then, destroy the VM object */
- get_impl()->destroy();
- delete this;
+ auto destroy_code = [this]() {
+ /* First, terminate all processes on the VM if necessary */
+ shutdown();
+
+ XBT_DEBUG("destroy %s", get_cname());
+
+ /* Then, destroy the VM object */
+ kernel::actor::simcall([this]() {
+ get_impl()->destroy();
+ delete this;
+ });
+ };
+
+ if (this_actor::get_host() == this) {
+ XBT_VERB("Launch another actor on physical host %s to destroy my own VM: %s", get_pm()->get_cname(), get_cname());
+ simgrid::s4u::Actor::create(get_cname() + std::string("-destroy"), get_pm(), destroy_code);
+ simgrid::s4u::this_actor::yield();
+ XBT_CRITICAL("I should be dead now!");
+ DIE_IMPOSSIBLE;
+ }
+
+ destroy_code();
}
simgrid::s4u::Host* VirtualMachine::get_pm() const
return this;
}
-VirtualMachine::state VirtualMachine::get_state() const
+VirtualMachine::State VirtualMachine::get_state() const
{
return kernel::actor::simcall([this]() { return pimpl_vm_->get_state(); });
}
/** @brief Returns whether the given VM has just created, not running. */
int sg_vm_is_created(const_sg_vm_t vm)
{
- return vm->get_state() == simgrid::s4u::VirtualMachine::state::CREATED;
+ return vm->get_state() == simgrid::s4u::VirtualMachine::State::CREATED;
}
/** @brief Returns whether the given VM is currently running */
int sg_vm_is_running(const_sg_vm_t vm)
{
- return vm->get_state() == simgrid::s4u::VirtualMachine::state::RUNNING;
+ return vm->get_state() == simgrid::s4u::VirtualMachine::State::RUNNING;
}
/** @brief Returns whether the given VM is currently suspended, not running. */
int sg_vm_is_suspended(const_sg_vm_t vm)
{
- return vm->get_state() == simgrid::s4u::VirtualMachine::state::SUSPENDED;
+ return vm->get_state() == simgrid::s4u::VirtualMachine::State::SUSPENDED;
}
/** @brief Start a vm (i.e., boot the guest operating system)