-/* Copyright (c) 2007-2019. The SimGrid Team. All rights reserved. */
+/* Copyright (c) 2007-2021. The SimGrid Team. All rights reserved. */
/* This program is free software; you can redistribute it and/or modify it
* under the terms of the license (GNU LGPL) which comes with this package. */
XBT_LOG_NEW_DEFAULT_SUBCATEGORY(simix_mutex, simix_synchro, "Mutex kernel-space implementation");
+#if SIMGRID_HAVE_MC
+#include "simgrid/modelchecker.h"
+#include "src/mc/mc_safety.hpp"
+#define MC_CHECK_NO_DPOR() \
+ xbt_assert(not MC_is_active() || simgrid::mc::reduction_mode != simgrid::mc::ReductionMode::dpor, \
+ "Mutex is currently not supported with DPOR, use --cfg=model-check/reduction:none")
+#else
+#define MC_CHECK_NO_DPOR() (void)0
+#endif
+
namespace simgrid {
namespace kernel {
namespace activity {
void MutexImpl::lock(actor::ActorImpl* issuer)
{
XBT_IN("(%p; %p)", this, issuer);
+ MC_CHECK_NO_DPOR();
/* FIXME: check where to validate the arguments */
RawImplPtr synchro = nullptr;
if (locked_) {
/* FIXME: check if the host is active ? */
/* Somebody using the mutex, use a synchronization to get host failures */
- synchro = RawImplPtr(new RawImpl());
+ synchro = RawImplPtr(new RawImpl([this, issuer]() { this->remove_sleeping_actor(*issuer); }));
(*synchro).set_host(issuer->get_host()).start();
- synchro->simcalls_.push_back(&issuer->simcall);
- issuer->waiting_synchro = synchro;
+ synchro->simcalls_.push_back(&issuer->simcall_);
+ issuer->waiting_synchro_ = synchro;
sleeping_.push_back(*issuer);
} else {
/* mutex free */
bool MutexImpl::try_lock(actor::ActorImpl* issuer)
{
XBT_IN("(%p, %p)", this, issuer);
+ MC_CHECK_NO_DPOR();
if (locked_) {
XBT_OUT();
return false;
owner_->get_cname(), owner_->get_pid());
if (not sleeping_.empty()) {
- /* pick one actor to wake up */
- actor::ActorImpl* act = &sleeping_.front();
+ /* Give the ownership to the first waiting actor */
+ owner_ = &sleeping_.front();
sleeping_.pop_front();
- act->waiting_synchro = nullptr;
- owner_ = act;
- act->simcall_answer();
+ owner_->waiting_synchro_ = nullptr;
+ owner_->simcall_answer();
} else {
/* nobody to wake up */
locked_ = false;
void simcall_HANDLER_mutex_lock(smx_simcall_t simcall, smx_mutex_t mutex)
{
- mutex->lock(simcall->issuer);
-}
-
-int simcall_HANDLER_mutex_trylock(smx_simcall_t simcall, smx_mutex_t mutex)
-{
- return mutex->try_lock(simcall->issuer);
-}
-
-void simcall_HANDLER_mutex_unlock(smx_simcall_t simcall, smx_mutex_t mutex)
-{
- mutex->unlock(simcall->issuer);
+ mutex->lock(simcall->issuer_);
}