// PMPI_Init is call only one time by only by SMPI process
int already_init;
MPI_Initialized(&already_init);
- if(!(already_init)){
+ if(already_init == 0){
smpi_process_init(argc, argv);
smpi_process_mark_as_initialized();
int rank = smpi_process_index();
TRACE_smpi_collective_out(rank, -1, __FUNCTION__);
smpi_bench_begin();
}
+
+ smpi_mpi_init();
+
return MPI_SUCCESS;
}
{
int retval = 0;
- if (!address) {
+ if (address==NULL) {
retval = MPI_ERR_ARG;
} else {
- *address = (MPI_Aint) location;
+ *address = reinterpret_cast<MPI_Aint>(location);
retval = MPI_SUCCESS;
}
return retval;
} else if (size == NULL) {
retval = MPI_ERR_ARG;
} else {
- *size = (int) smpi_datatype_size(datatype);
+ *size = static_cast<int>(smpi_datatype_size(datatype));
retval = MPI_SUCCESS;
}
return retval;
if (function == NULL || op == NULL) {
retval = MPI_ERR_ARG;
} else {
- *op = smpi_op_new(function, commute);
+ *op = smpi_op_new(function, (commute!=0));
retval = MPI_SUCCESS;
}
return retval;
} else if (newgroup == NULL) {
retval = MPI_ERR_ARG;
} else {
- size = size2 = smpi_group_size(group1);
+ size = smpi_group_size(group1);
+ size2 = size;
for (i = 0; i < size2; i++) {
proc1 = smpi_group_index(group1, i);
proc2 = smpi_group_rank(group2, proc1);
retval = MPI_SUCCESS;
}
smpi_bench_begin();
- if (retval != MPI_SUCCESS && request)
+ if (retval != MPI_SUCCESS && request != NULL)
*request = MPI_REQUEST_NULL;
return retval;
}
retval = MPI_SUCCESS;
}
smpi_bench_begin();
- if (retval != MPI_SUCCESS && request)
+ if (retval != MPI_SUCCESS && request != NULL)
*request = MPI_REQUEST_NULL;
return retval;
}
retval = MPI_SUCCESS;
}
smpi_bench_begin();
- if (retval != MPI_SUCCESS && request)
+ if (retval != MPI_SUCCESS && request != NULL)
*request = MPI_REQUEST_NULL;
return retval;
}
retval = MPI_SUCCESS;
} else if (src!=MPI_ANY_SOURCE && (src >= smpi_group_size(smpi_comm_group(comm)) || src <0)){
retval = MPI_ERR_RANK;
- } else if (count < 0) {
- retval = MPI_ERR_COUNT;
- } else if (buf==NULL && count > 0) {
+ } else if ((count < 0) || (buf==NULL && count > 0)) {
retval = MPI_ERR_COUNT;
} else if (!is_datatype_valid(datatype)) {
retval = MPI_ERR_TYPE;
int known=0;
extra->datatype1 = encode_datatype(datatype, &known);
int dt_size_send = 1;
- if(!known)
+ if(known==0)
dt_size_send = smpi_datatype_size(datatype);
extra->send_size = count*dt_size_send;
TRACE_smpi_ptp_in(rank, src_traced, rank, __FUNCTION__, extra);
}
smpi_bench_begin();
- if (retval != MPI_SUCCESS && request)
+ if (retval != MPI_SUCCESS && request != NULL)
*request = MPI_REQUEST_NULL;
return retval;
}
retval = MPI_SUCCESS;
} else if (dst >= smpi_group_size(smpi_comm_group(comm)) || dst <0){
retval = MPI_ERR_RANK;
- } else if (count < 0) {
- retval = MPI_ERR_COUNT;
- } else if (buf==NULL && count > 0) {
+ } else if ((count < 0) || (buf==NULL && count > 0)) {
retval = MPI_ERR_COUNT;
} else if (!is_datatype_valid(datatype)) {
retval = MPI_ERR_TYPE;
int known=0;
extra->datatype1 = encode_datatype(datatype, &known);
int dt_size_send = 1;
- if(!known)
+ if(known==0)
dt_size_send = smpi_datatype_size(datatype);
extra->send_size = count*dt_size_send;
TRACE_smpi_ptp_in(rank, rank, dst_traced, __FUNCTION__, extra);
}
smpi_bench_begin();
- if (retval != MPI_SUCCESS && request)
+ if (retval != MPI_SUCCESS && request!=NULL)
*request = MPI_REQUEST_NULL;
return retval;
}
retval = MPI_SUCCESS;
} else if (dst >= smpi_group_size(smpi_comm_group(comm)) || dst <0){
retval = MPI_ERR_RANK;
- } else if (count < 0) {
- retval = MPI_ERR_COUNT;
- } else if (buf==NULL && count > 0) {
+ } else if ((count < 0)|| (buf==NULL && count > 0)) {
retval = MPI_ERR_COUNT;
} else if (!is_datatype_valid(datatype)) {
retval = MPI_ERR_TYPE;
int known=0;
extra->datatype1 = encode_datatype(datatype, &known);
int dt_size_send = 1;
- if(!known)
+ if(known==0)
dt_size_send = smpi_datatype_size(datatype);
extra->send_size = count*dt_size_send;
TRACE_smpi_ptp_in(rank, rank, dst_traced, __FUNCTION__, extra);
}
smpi_bench_begin();
- if (retval != MPI_SUCCESS && request)
+ if (retval != MPI_SUCCESS && request!=NULL)
*request = MPI_REQUEST_NULL;
return retval;
}
retval = MPI_SUCCESS;
} else if (src!=MPI_ANY_SOURCE && (src >= smpi_group_size(smpi_comm_group(comm)) || src <0)){
retval = MPI_ERR_RANK;
- } else if (count < 0) {
- retval = MPI_ERR_COUNT;
- } else if (buf==NULL && count > 0) {
+ } else if ((count < 0) || (buf==NULL && count > 0)) {
retval = MPI_ERR_COUNT;
} else if (!is_datatype_valid(datatype)) {
retval = MPI_ERR_TYPE;
int known=0;
extra->datatype1 = encode_datatype(datatype, &known);
int dt_size_send = 1;
- if(!known)
+ if(known==0)
dt_size_send = smpi_datatype_size(datatype);
extra->send_size = count*dt_size_send;
TRACE_smpi_ptp_in(rank, src_traced, rank, __FUNCTION__, extra);
retval = MPI_SUCCESS;
} else if (dst >= smpi_group_size(smpi_comm_group(comm)) || dst <0){
retval = MPI_ERR_RANK;
- } else if (count < 0) {
- retval = MPI_ERR_COUNT;
- } else if (buf==NULL && count > 0) {
+ } else if ((count < 0) || (buf == nullptr && count > 0)) {
retval = MPI_ERR_COUNT;
} else if (!is_datatype_valid(datatype)) {
- retval = MPI_ERR_TYPE;
- } else if(tag<0 && tag != MPI_ANY_TAG){
+ retval = MPI_ERR_TYPE;
+ } else if(tag < 0 && tag != MPI_ANY_TAG){
retval = MPI_ERR_TAG;
} else {
-
- int rank = comm != MPI_COMM_NULL ? smpi_process_index() : -1;
- int dst_traced = smpi_group_index(smpi_comm_group(comm), dst);
- instr_extra_data extra = xbt_new0(s_instr_extra_data_t,1);
- extra->type = TRACING_SEND;
- extra->src = rank;
- extra->dst = dst_traced;
- int known=0;
- extra->datatype1 = encode_datatype(datatype, &known);
- int dt_size_send = 1;
- if(!known)
- dt_size_send = smpi_datatype_size(datatype);
- extra->send_size = count*dt_size_send;
- TRACE_smpi_ptp_in(rank, rank, dst_traced, __FUNCTION__, extra);
- if (!TRACE_smpi_view_internals()) {
- TRACE_smpi_send(rank, rank, dst_traced,count*smpi_datatype_size(datatype));
- }
+ int rank = comm != MPI_COMM_NULL ? smpi_process_index() : -1;
+ int dst_traced = smpi_group_index(smpi_comm_group(comm), dst);
+ instr_extra_data extra = xbt_new0(s_instr_extra_data_t,1);
+ extra->type = TRACING_SEND;
+ extra->src = rank;
+ extra->dst = dst_traced;
+ int known = 0;
+ extra->datatype1 = encode_datatype(datatype, &known);
+ int dt_size_send = 1;
+ if (known == 0) {
+ dt_size_send = smpi_datatype_size(datatype);
+ }
+ extra->send_size = count*dt_size_send;
+ TRACE_smpi_ptp_in(rank, rank, dst_traced, __FUNCTION__, extra);
+ if (!TRACE_smpi_view_internals()) {
+ TRACE_smpi_send(rank, rank, dst_traced,count*smpi_datatype_size(datatype));
+ }
smpi_mpi_send(buf, count, datatype, dst, tag, comm);
retval = MPI_SUCCESS;
- TRACE_smpi_ptp_out(rank, rank, dst_traced, __FUNCTION__);
+ TRACE_smpi_ptp_out(rank, rank, dst_traced, __FUNCTION__);
}
smpi_bench_begin();
return retval;
}
-
-
int PMPI_Ssend(void* buf, int count, MPI_Datatype datatype, int dst, int tag, MPI_Comm comm) {
int retval = 0;
- smpi_bench_end();
-
- if (comm == MPI_COMM_NULL) {
- retval = MPI_ERR_COMM;
- } else if (dst == MPI_PROC_NULL) {
- retval = MPI_SUCCESS;
- } else if (dst >= smpi_group_size(smpi_comm_group(comm)) || dst <0){
- retval = MPI_ERR_RANK;
- } else if (count < 0) {
- retval = MPI_ERR_COUNT;
- } else if (buf==NULL && count > 0) {
- retval = MPI_ERR_COUNT;
- } else if (!is_datatype_valid(datatype)){
- retval = MPI_ERR_TYPE;
- } else if(tag<0 && tag != MPI_ANY_TAG){
- retval = MPI_ERR_TAG;
- } else {
-
- int rank = comm != MPI_COMM_NULL ? smpi_process_index() : -1;
- int dst_traced = smpi_group_index(smpi_comm_group(comm), dst);
- instr_extra_data extra = xbt_new0(s_instr_extra_data_t,1);
- extra->type = TRACING_SSEND;
- extra->src = rank;
- extra->dst = dst_traced;
- int known=0;
- extra->datatype1 = encode_datatype(datatype, &known);
- int dt_size_send = 1;
- if(!known)
- dt_size_send = smpi_datatype_size(datatype);
- extra->send_size = count*dt_size_send;
- TRACE_smpi_ptp_in(rank, rank, dst_traced, __FUNCTION__, extra);
- TRACE_smpi_send(rank, rank, dst_traced,count*smpi_datatype_size(datatype));
-
- smpi_mpi_ssend(buf, count, datatype, dst, tag, comm);
- retval = MPI_SUCCESS;
+ smpi_bench_end();
- TRACE_smpi_ptp_out(rank, rank, dst_traced, __FUNCTION__);
- }
+ if (comm == MPI_COMM_NULL) {
+ retval = MPI_ERR_COMM;
+ } else if (dst == MPI_PROC_NULL) {
+ retval = MPI_SUCCESS;
+ } else if (dst >= smpi_group_size(smpi_comm_group(comm)) || dst <0){
+ retval = MPI_ERR_RANK;
+ } else if ((count < 0) || (buf==NULL && count > 0)) {
+ retval = MPI_ERR_COUNT;
+ } else if (!is_datatype_valid(datatype)){
+ retval = MPI_ERR_TYPE;
+ } else if(tag<0 && tag != MPI_ANY_TAG){
+ retval = MPI_ERR_TAG;
+ } else {
+ int rank = comm != MPI_COMM_NULL ? smpi_process_index() : -1;
+ int dst_traced = smpi_group_index(smpi_comm_group(comm), dst);
+ instr_extra_data extra = xbt_new0(s_instr_extra_data_t,1);
+ extra->type = TRACING_SSEND;
+ extra->src = rank;
+ extra->dst = dst_traced;
+ int known = 0;
+ extra->datatype1 = encode_datatype(datatype, &known);
+ int dt_size_send = 1;
+ if(known == 0) {
+ dt_size_send = smpi_datatype_size(datatype);
+ }
+ extra->send_size = count*dt_size_send;
+ TRACE_smpi_ptp_in(rank, rank, dst_traced, __FUNCTION__, extra);
+ TRACE_smpi_send(rank, rank, dst_traced,count*smpi_datatype_size(datatype));
+
+ smpi_mpi_ssend(buf, count, datatype, dst, tag, comm);
+ retval = MPI_SUCCESS;
+
+ TRACE_smpi_ptp_out(rank, rank, dst_traced, __FUNCTION__);
+ }
- smpi_bench_begin();
- return retval;}
+ smpi_bench_begin();
+ return retval;
+}
int PMPI_Sendrecv(void *sendbuf, int sendcount, MPI_Datatype sendtype, int dst, int sendtag, void *recvbuf,
int recvcount, MPI_Datatype recvtype, int src, int recvtag, MPI_Comm comm, MPI_Status * status)
}else if (dst >= smpi_group_size(smpi_comm_group(comm)) || dst <0 ||
(src!=MPI_ANY_SOURCE && (src >= smpi_group_size(smpi_comm_group(comm)) || src <0))){
retval = MPI_ERR_RANK;
- } else if (sendcount < 0 || recvcount<0) {
- retval = MPI_ERR_COUNT;
- } else if ((sendbuf==NULL && sendcount > 0)||(recvbuf==NULL && recvcount>0)) {
+ } else if ((sendcount < 0 || recvcount<0) ||
+ (sendbuf==NULL && sendcount > 0) || (recvbuf==NULL && recvcount>0)) {
retval = MPI_ERR_COUNT;
} else if((sendtag<0 && sendtag != MPI_ANY_TAG)||(recvtag<0 && recvtag != MPI_ANY_TAG)){
retval = MPI_ERR_TAG;
int known=0;
extra->datatype1 = encode_datatype(sendtype, &known);
int dt_size_send = 1;
- if(!known)
+ if(known==0)
dt_size_send = smpi_datatype_size(sendtype);
extra->send_size = sendcount*dt_size_send;
extra->datatype2 = encode_datatype(recvtype, &known);
int dt_size_recv = 1;
- if(!known)
+ if(known==0)
dt_size_recv = smpi_datatype_size(recvtype);
extra->recv_size = recvcount*dt_size_recv;
int PMPI_Sendrecv_replace(void *buf, int count, MPI_Datatype datatype, int dst, int sendtag, int src, int recvtag,
MPI_Comm comm, MPI_Status * status)
{
- //TODO: suboptimal implementation
void *recvbuf;
int retval = 0;
if (!is_datatype_valid(datatype)) {
smpi_empty_status(status);
retval = MPI_SUCCESS;
} else {
- int rank = request && (*request)->comm != MPI_COMM_NULL ? smpi_process_index() : -1;
+ int rank = (request!=NULL && (*request)->comm != MPI_COMM_NULL) ? smpi_process_index() : -1;
instr_extra_data extra = xbt_new0(s_instr_extra_data_t,1);
extra->type = TRACING_TEST;
int retval = 0;
smpi_bench_end();
- if (flag == NULL) {
- retval = MPI_ERR_ARG;
- } else if (status == NULL) {
+ if ((flag == NULL) || (status == NULL)) {
retval = MPI_ERR_ARG;
} else if (comm == MPI_COMM_NULL) {
retval = MPI_ERR_COMM;
retval = MPI_SUCCESS;
} else {
- int rank = request && (*request)->comm != MPI_COMM_NULL ? smpi_process_index() : -1;
+ int rank = (request!=NULL && (*request)->comm != MPI_COMM_NULL) ? smpi_process_index() : -1;
int src_traced = (*request)->src;
int dst_traced = (*request)->dst;
int *valid = xbt_new0(int, count);
MPI_Comm *comms = xbt_new0(MPI_Comm, count);
- //int valid_count = 0;
for (i = 0; i < count; i++) {
MPI_Request req = requests[i];
if(req!=MPI_REQUEST_NULL){
for (i = 0; i < count; i++) {
if(valid[i]){
- //int src_traced = srcs[*index];
//the src may not have been known at the beginning of the recv (MPI_ANY_SOURCE)
int src_traced = srcs[i];
int dst_traced = dsts[i];
int known=0;
extra->datatype1 = encode_datatype(datatype, &known);
int dt_size_send = 1;
- if(!known)
+ if(known==0)
dt_size_send = smpi_datatype_size(datatype);
extra->send_size = count*dt_size_send;
TRACE_smpi_collective_in(rank, root_traced, __FUNCTION__, extra);
-
+ if(smpi_comm_size(comm)>1)
mpi_coll_bcast_fun(buf, count, datatype, root, comm);
- retval = MPI_SUCCESS;
+ retval = MPI_SUCCESS;
- TRACE_smpi_collective_out(rank, root_traced, __FUNCTION__);
+ TRACE_smpi_collective_out(rank, root_traced, __FUNCTION__);
}
smpi_bench_begin();
retval = MPI_ERR_COUNT;
} else {
- char* sendtmpbuf = (char*) sendbuf;
+ char* sendtmpbuf = static_cast<char*>(sendbuf);
int sendtmpcount = sendcount;
MPI_Datatype sendtmptype = sendtype;
if( (smpi_comm_rank(comm) == root) && (sendbuf == MPI_IN_PLACE )) {
int known=0;
extra->datatype1 = encode_datatype(sendtmptype, &known);
int dt_size_send = 1;
- if(!known)
+ if(known==0)
dt_size_send = smpi_datatype_size(sendtmptype);
extra->send_size = sendtmpcount*dt_size_send;
extra->datatype2 = encode_datatype(recvtype, &known);
int dt_size_recv = 1;
- if((smpi_comm_rank(comm)==root) && !known)
+ if((smpi_comm_rank(comm)==root) && known==0)
dt_size_recv = smpi_datatype_size(recvtype);
extra->recv_size = recvcount*dt_size_recv;
} else if (recvcounts == NULL || displs == NULL) {
retval = MPI_ERR_ARG;
} else {
- char* sendtmpbuf = (char*) sendbuf;
+ char* sendtmpbuf = static_cast<char*>(sendbuf);
int sendtmpcount = sendcount;
MPI_Datatype sendtmptype = sendtype;
if( (smpi_comm_rank(comm) == root) && (sendbuf == MPI_IN_PLACE )) {
int known=0;
extra->datatype1 = encode_datatype(sendtmptype, &known);
int dt_size_send = 1;
- if(!known)
+ if(known==0)
dt_size_send = smpi_datatype_size(sendtype);
extra->send_size = sendtmpcount*dt_size_send;
extra->datatype2 = encode_datatype(recvtype, &known);
int dt_size_recv = 1;
- if(!known)
+ if(known==0)
dt_size_recv = smpi_datatype_size(recvtype);
if((smpi_comm_rank(comm)==root)){
extra->recvcounts= xbt_new(int,size);
retval = MPI_ERR_COUNT;
} else {
if(sendbuf == MPI_IN_PLACE) {
- sendbuf=((char*)recvbuf)+smpi_datatype_get_extent(recvtype)*recvcount*smpi_comm_rank(comm);
+ sendbuf=static_cast<char*>(recvbuf)+smpi_datatype_get_extent(recvtype)*recvcount*smpi_comm_rank(comm);
sendcount=recvcount;
sendtype=recvtype;
}
int known=0;
extra->datatype1 = encode_datatype(sendtype, &known);
int dt_size_send = 1;
- if(!known)
+ if(known==0)
dt_size_send = smpi_datatype_size(sendtype);
extra->send_size = sendcount*dt_size_send;
extra->datatype2 = encode_datatype(recvtype, &known);
int dt_size_recv = 1;
- if(!known)
+ if(known==0)
dt_size_recv = smpi_datatype_size(recvtype);
extra->recv_size = recvcount*dt_size_recv;
} else {
if(sendbuf == MPI_IN_PLACE) {
- sendbuf=((char*)recvbuf)+smpi_datatype_get_extent(recvtype)*displs[smpi_comm_rank(comm)];
+ sendbuf=static_cast<char*>(recvbuf)+smpi_datatype_get_extent(recvtype)*displs[smpi_comm_rank(comm)];
sendcount=recvcounts[smpi_comm_rank(comm)];
sendtype=recvtype;
}
int known=0;
extra->datatype1 = encode_datatype(sendtype, &known);
int dt_size_send = 1;
- if(!known)
+ if(known==0)
dt_size_send = smpi_datatype_size(sendtype);
extra->send_size = sendcount*dt_size_send;
extra->datatype2 = encode_datatype(recvtype, &known);
int dt_size_recv = 1;
- if(!known)
+ if(known==0)
dt_size_recv = smpi_datatype_size(recvtype);
extra->recvcounts= xbt_new(int, size);
for(i=0; i< size; i++)//copy data to avoid bad free
int known=0;
extra->datatype1 = encode_datatype(sendtype, &known);
int dt_size_send = 1;
- if((smpi_comm_rank(comm)==root) && !known)
+ if((smpi_comm_rank(comm)==root) && known==0)
dt_size_send = smpi_datatype_size(sendtype);
extra->send_size = sendcount*dt_size_send;
extra->datatype2 = encode_datatype(recvtype, &known);
int dt_size_recv = 1;
- if(!known)
+ if(known==0)
dt_size_recv = smpi_datatype_size(recvtype);
extra->recv_size = recvcount*dt_size_recv;
TRACE_smpi_collective_in(rank, root_traced, __FUNCTION__,extra);
int known=0;
extra->datatype1 = encode_datatype(sendtype, &known);
int dt_size_send = 1;
- if(!known)
+ if(known==0)
dt_size_send = smpi_datatype_size(sendtype);
if((smpi_comm_rank(comm)==root)){
extra->sendcounts= xbt_new(int, size);
}
extra->datatype2 = encode_datatype(recvtype, &known);
int dt_size_recv = 1;
- if(!known)
+ if(known==0)
dt_size_recv = smpi_datatype_size(recvtype);
extra->recv_size = recvcount*dt_size_recv;
TRACE_smpi_collective_in(rank, root_traced, __FUNCTION__,extra);
int known=0;
extra->datatype1 = encode_datatype(datatype, &known);
int dt_size_send = 1;
- if(!known)
+ if(known==0)
dt_size_send = smpi_datatype_size(datatype);
extra->send_size = count*dt_size_send;
extra->root = root_traced;
retval = MPI_ERR_OP;
} else {
- char* sendtmpbuf = (char*) sendbuf;
+ char* sendtmpbuf = static_cast<char*>(sendbuf);
if( sendbuf == MPI_IN_PLACE ) {
- sendtmpbuf = (char *)xbt_malloc(count*smpi_datatype_get_extent(datatype));
+ sendtmpbuf = static_cast<char*>(xbt_malloc(count*smpi_datatype_get_extent(datatype)));
smpi_datatype_copy(recvbuf, count, datatype,sendtmpbuf, count, datatype);
}
int rank = comm != MPI_COMM_NULL ? smpi_process_index() : -1;
int known=0;
extra->datatype1 = encode_datatype(datatype, &known);
int dt_size_send = 1;
- if(!known)
+ if(known==0)
dt_size_send = smpi_datatype_size(datatype);
extra->send_size = count*dt_size_send;
int known=0;
extra->datatype1 = encode_datatype(datatype, &known);
int dt_size_send = 1;
- if(!known)
+ if(known==0)
dt_size_send = smpi_datatype_size(datatype);
extra->send_size = count*dt_size_send;
int known=0;
extra->datatype1 = encode_datatype(datatype, &known);
int dt_size_send = 1;
- if(!known)
+ if(known==0)
dt_size_send = smpi_datatype_size(datatype);
extra->send_size = count*dt_size_send;
TRACE_smpi_collective_in(rank, -1, __FUNCTION__,extra);
int known=0;
extra->datatype1 = encode_datatype(datatype, &known);
int dt_size_send = 1;
- if(!known)
+ if(known==0)
dt_size_send = smpi_datatype_size(datatype);
extra->send_size = 0;
extra->recvcounts= xbt_new(int, size);
int known=0;
extra->datatype1 = encode_datatype(datatype, &known);
int dt_size_send = 1;
- if(!known)
+ if(known==0)
dt_size_send = smpi_datatype_size(datatype);
extra->send_size = 0;
extra->recvcounts= xbt_new(int, count);
TRACE_smpi_collective_in(rank, -1, __FUNCTION__,extra);
- int* recvcounts=(int*)xbt_malloc(count);
- for (i=0; i<count;i++)recvcounts[i]=recvcount;
+ int* recvcounts=static_cast<int*>(xbt_malloc(count));
+ for (i=0; i<count;i++)
+ recvcounts[i]=recvcount;
mpi_coll_reduce_scatter_fun(sendbuf, recvbuf, recvcounts, datatype, op, comm);
xbt_free(recvcounts);
retval = MPI_SUCCESS;
extra->type = TRACING_ALLTOALL;
int known=0;
extra->datatype1 = encode_datatype(sendtype, &known);
- if(!known)
+ if(known==0)
extra->send_size = sendcount*smpi_datatype_size(sendtype);
else
extra->send_size = sendcount;
extra->datatype2 = encode_datatype(recvtype, &known);
- if(!known)
+ if(known==0)
extra->recv_size = recvcount*smpi_datatype_size(recvtype);
else
extra->recv_size = recvcount;
int known=0;
extra->datatype1 = encode_datatype(sendtype, &known);
int dt_size_send = 1;
- if(!known)
+ if(known==0)
dt_size_send = smpi_datatype_size(sendtype);
int dt_size_recv = 1;
extra->datatype2 = encode_datatype(recvtype, &known);
- if(!known)
+ if(known==0)
dt_size_recv = smpi_datatype_size(recvtype);
for(i=0; i< size; i++){//copy data to avoid bad free
extra->send_size += sendcounts[i]*dt_size_send;
} else if (count<0){
retval = MPI_ERR_COUNT;
} else {
- int* blocklens=(int*)xbt_malloc(blocklength*count);
- for (i=0; i<count;i++)blocklens[i]=blocklength;
+ int* blocklens=static_cast<int*>(xbt_malloc(blocklength*count));
+ for (i=0; i<count;i++)
+ blocklens[i]=blocklength;
retval = smpi_datatype_indexed(count, blocklens, indices, old_type, new_type);
xbt_free(blocklens);
}
retval = MPI_ERR_WIN;
}else {
smpi_mpi_win_get_group(win, group);
+ smpi_group_use(*group);
}
return retval;
}
retval = MPI_ERR_RANK;
} else if (target_disp <0){
retval = MPI_ERR_ARG;
- } else if (origin_count < 0 || target_count < 0) {
- retval = MPI_ERR_COUNT;
- } else if (origin_addr==NULL && origin_count > 0){
+ } else if ((origin_count < 0 || target_count < 0) ||
+ (origin_addr==NULL && origin_count > 0)){
retval = MPI_ERR_COUNT;
} else if ((!is_datatype_valid(origin_datatype)) || (!is_datatype_valid(target_datatype))) {
retval = MPI_ERR_TYPE;
retval = MPI_ERR_RANK;
} else if (target_disp <0){
retval = MPI_ERR_ARG;
- } else if (origin_count < 0 || target_count < 0) {
- retval = MPI_ERR_COUNT;
- } else if (origin_addr==NULL && origin_count > 0){
+ } else if ((origin_count < 0 || target_count < 0) ||
+ (origin_addr==NULL && origin_count > 0)){
retval = MPI_ERR_COUNT;
} else if ((!is_datatype_valid(origin_datatype)) || (!is_datatype_valid(target_datatype))) {
retval = MPI_ERR_TYPE;
retval = MPI_ERR_RANK;
} else if (target_disp <0){
retval = MPI_ERR_ARG;
- } else if (origin_count < 0 || target_count < 0) {
- retval = MPI_ERR_COUNT;
- } else if (origin_addr==NULL && origin_count > 0){
+ } else if ((origin_count < 0 || target_count < 0) ||
+ (origin_addr==NULL && origin_count > 0)){
retval = MPI_ERR_COUNT;
} else if ((!is_datatype_valid(origin_datatype)) ||
(!is_datatype_valid(target_datatype))) {
int PMPI_Alloc_mem(MPI_Aint size, MPI_Info info, void *baseptr){
void *ptr = xbt_malloc(size);
- if(!ptr)
+ if(ptr==NULL)
return MPI_ERR_NO_MEM;
else {
- *(void **)baseptr = ptr;
+ *static_cast<void**>(baseptr) = ptr;
return MPI_SUCCESS;
}
}
case MPI_IO:
case MPI_APPNUM:
*flag = 1;
- *(int**)attr_value = &zero;
+ *static_cast<int**>(attr_value) = &zero;
return MPI_SUCCESS;
case MPI_UNIVERSE_SIZE:
*flag = 1;
- *(int**)attr_value = &smpi_universe_size;
+ *static_cast<int**>(attr_value) = &smpi_universe_size;
return MPI_SUCCESS;
case MPI_LASTUSEDCODE:
*flag = 1;
- *(int**)attr_value = &last_used_code;
+ *static_cast<int**>(attr_value) = &last_used_code;
return MPI_SUCCESS;
case MPI_TAG_UB:
*flag=1;
- *(int**)attr_value = &tag_ub;
+ *static_cast<int**>(attr_value) = &tag_ub;
return MPI_SUCCESS;
case MPI_WTIME_IS_GLOBAL:
*flag = 1;
- *(int**)attr_value = &one;
+ *static_cast<int**>(attr_value) = &one;
return MPI_SUCCESS;
default:
return smpi_comm_attr_get(comm, keyval, attr_value, flag);
return MPI_ERR_ARG;
if (value == NULL)
return MPI_ERR_INFO_VALUE;
- char* tmpvalue=(char*)xbt_dict_get_or_null(info->info_dict, key);
+ char* tmpvalue=static_cast<char*>(xbt_dict_get_or_null(info->info_dict, key));
if(tmpvalue){
+ memset(value, 0, valuelen);
memcpy(value,tmpvalue, (strlen(tmpvalue) + 1 < static_cast<size_t>(valuelen)) ? strlen(tmpvalue) + 1 : valuelen);
*flag=true;
}
return MPI_ERR_ARG;
*newinfo = xbt_new(s_smpi_mpi_info_t, 1);
(*newinfo)->info_dict= xbt_dict_new_homogeneous(NULL);
+ (*newinfo)->refcount=1;
xbt_dict_cursor_t cursor = NULL;
int *key;
void* data;
xbt_dict_foreach(info->info_dict,cursor,key,data){
- xbt_dict_set((*newinfo)->info_dict, (char*)key, data, NULL);
+ xbt_dict_set((*newinfo)->info_dict, reinterpret_cast<char*>(key), data, NULL);
}
return MPI_SUCCESS;
}
int num=0;
xbt_dict_foreach(info->info_dict,cursor,keyn,data){
if(num==n){
- strcpy(key,keyn);
+ strncpy(key,keyn,strlen(keyn)+1);
+ xbt_dict_cursor_free(&cursor);
return MPI_SUCCESS;
}
num++;