Don't use pass-by-value for large parameters.

[simgrid.git] / src / surf / PropertyHolder.cpp

diff --git a/src/surf/PropertyHolder.cpp b/src/surf/PropertyHolder.cpp
index 853bcb5..962f86e 100644 (file)
--- a/src/surf/PropertyHolder.cpp
+++ b/src/surf/PropertyHolder.cpp
@@ -1,4 +1,4 @@
-/* Copyright (c) 2015-2018. The SimGrid Team. All rights reserved.          */
+/* Copyright (c) 2015-2019. The SimGrid Team. All rights reserved.          */
 
 /* This program is free software; you can redistribute it and/or modify it
  * under the terms of the license (GNU LGPL) which comes with this package. */
@@ -13,7 +13,7 @@ PropertyHolder::~PropertyHolder() {
 }
 
 /** @brief Return the property associated to the provided key (or nullptr if not existing) */
-const char* PropertyHolder::get_property(std::string key)
+const char* PropertyHolder::get_property(const std::string& key)
 {
   if (properties_ == nullptr)
     return nullptr;
@@ -22,11 +22,11 @@ const char* PropertyHolder::get_property(std::string key)
 }
 
 /** @brief Change the value of a given key in the property set */
-void PropertyHolder::set_property(std::string key, std::string value)
+void PropertyHolder::set_property(const std::string& key, std::string value)
 {
   if (not properties_)
     properties_ = new std::unordered_map<std::string, std::string>;
-  (*properties_)[key] = value;
+  (*properties_)[key] = std::move(value);
 }
 
 /** @brief Return the whole set of properties. Don't mess with it, dude! */