please sonar and use & when creating function pointers

[simgrid.git] / teshsuite / xbt / parmap_bench / parmap_bench.c

diff --git a/teshsuite/xbt/parmap_bench/parmap_bench.c b/teshsuite/xbt/parmap_bench/parmap_bench.c
index ed890de..a3f1b0f 100644 (file)
--- a/teshsuite/xbt/parmap_bench/parmap_bench.c
+++ b/teshsuite/xbt/parmap_bench/parmap_bench.c
@@ -46,7 +46,7 @@ static const char *parmap_mode_name(e_xbt_parmap_mode_t mode)
 static int parmap_skip_mode(e_xbt_parmap_mode_t mode)
 {
   switch (mode) {
-#ifndef HAVE_FUTEX_H
+#if !HAVE_FUTEX_H
   case XBT_PARMAP_FUTEX:
     printf("not available\n");
     return 1;
@@ -78,11 +78,10 @@ static void fun_big_comp(void *arg)
 
 static void array_new(unsigned **a, xbt_dynar_t *data)
 {
-  int i;
   *a = xbt_malloc(ARRAY_SIZE * sizeof **a);
   *data = xbt_dynar_new(sizeof *a, NULL);
   xbt_dynar_shrink(*data, ARRAY_SIZE);
-  for (i = 0 ; i < ARRAY_SIZE ; i++) {
+  for (int i = 0 ; i < ARRAY_SIZE ; i++) {
     (*a)[i] = i;
     xbt_dynar_push_as(*data, void*, &(*a)[i]);
   }
@@ -93,8 +92,7 @@ static void bench_parmap_full(int nthreads, e_xbt_parmap_mode_t mode)
   unsigned *a;
   xbt_dynar_t data;
   xbt_parmap_t parmap;
-  int i;
-  double start_time, elapsed_time;
+  double elapsed_time;
 
   printf("** mode = %-15s ", parmap_mode_name(mode));
   fflush(stdout);
@@ -104,8 +102,8 @@ static void bench_parmap_full(int nthreads, e_xbt_parmap_mode_t mode)
 
   array_new(&a, &data);
 
-  i = 0;
-  start_time = xbt_os_time();
+  int i = 0;
+  double start_time = xbt_os_time();
   do {
     parmap = xbt_parmap_new(nthreads, mode);
     xbt_parmap_apply(parmap, fun_to_apply, data);
@@ -114,8 +112,7 @@ static void bench_parmap_full(int nthreads, e_xbt_parmap_mode_t mode)
     i++;
   } while (elapsed_time < TIMEOUT);
 
-  printf("ran %d times in %g seconds (%g/s)\n",
-         i, elapsed_time, i / elapsed_time);
+  printf("ran %d times in %g seconds (%g/s)\n", i, elapsed_time, i / elapsed_time);
 
   xbt_dynar_free(&data);
   xbt_free(a);
@@ -125,9 +122,7 @@ static void bench_parmap_apply(int nthreads, e_xbt_parmap_mode_t mode)
 {
   unsigned *a;
   xbt_dynar_t data;
-  xbt_parmap_t parmap;
-  int i;
-  double start_time, elapsed_time;
+  double elapsed_time;
 
   printf("** mode = %-15s ", parmap_mode_name(mode));
   fflush(stdout);
@@ -137,9 +132,9 @@ static void bench_parmap_apply(int nthreads, e_xbt_parmap_mode_t mode)
 
   array_new(&a, &data);
 
-  parmap = xbt_parmap_new(nthreads, mode);
-  i = 0;
-  start_time = xbt_os_time();
+  xbt_parmap_t parmap = xbt_parmap_new(nthreads, mode);
+  int i = 0;
+  double start_time = xbt_os_time();
   do {
     xbt_parmap_apply(parmap, fun_to_apply, data);
     elapsed_time = xbt_os_time() - start_time;
@@ -147,8 +142,7 @@ static void bench_parmap_apply(int nthreads, e_xbt_parmap_mode_t mode)
   } while (elapsed_time < TIMEOUT);
   xbt_parmap_destroy(parmap);
 
-  printf("ran %d times in %g seconds (%g/s)\n",
-         i, elapsed_time, i / elapsed_time);
+  printf("ran %d times in %g seconds (%g/s)\n", i, elapsed_time, i / elapsed_time);
 
   xbt_dynar_free(&data);
   xbt_free(a);
@@ -157,12 +151,9 @@ static void bench_parmap_apply(int nthreads, e_xbt_parmap_mode_t mode)
 static void bench_all_modes(void (*bench_fun)(int, e_xbt_parmap_mode_t),
                             int nthreads, unsigned modes)
 {
-  e_xbt_parmap_mode_t all_modes[] = {
-    XBT_PARMAP_POSIX, XBT_PARMAP_FUTEX,
-    XBT_PARMAP_BUSY_WAIT, XBT_PARMAP_DEFAULT
-  };
-  unsigned i;
-  for (i = 0 ; i < sizeof all_modes / sizeof all_modes[0] ; i++) {
+  e_xbt_parmap_mode_t all_modes[] = {XBT_PARMAP_POSIX, XBT_PARMAP_FUTEX, XBT_PARMAP_BUSY_WAIT, XBT_PARMAP_DEFAULT};
+
+  for (unsigned i = 0 ; i < sizeof all_modes / sizeof all_modes[0] ; i++) {
     if (1U << i & modes)
       bench_fun(nthreads, all_modes[i]);
   }
@@ -176,8 +167,7 @@ int main(int argc, char *argv[])
   SIMIX_global_init(&argc, argv);
 
   if (argc != 2 && argc != 3) {
-    fprintf(stderr,
-            "Usage: %s nthreads [modes]\n"
+    fprintf(stderr, "Usage: %s nthreads [modes]\n"
             "    nthreads - number of working threads\n"
             "    modes    - bitmask of modes to test\n",
             argv[0]);
@@ -191,10 +181,9 @@ int main(int argc, char *argv[])
   if (argc == 3)
     modes = strtol(argv[2], NULL, 0);
 
-  printf("Parmap benchmark with %d workers (modes = %#x)...\n\n",
-         nthreads, modes);
+  printf("Parmap benchmark with %d workers (modes = %#x)...\n\n", nthreads, modes);
 
-  fun_to_apply = fun_small_comp;
+  fun_to_apply = &fun_small_comp;
 
   printf("Benchmark for parmap create+apply+destroy (small comp):\n");
   bench_all_modes(bench_parmap_full, nthreads, modes);
@@ -204,7 +193,7 @@ int main(int argc, char *argv[])
   bench_all_modes(bench_parmap_apply, nthreads, modes);
   printf("\n");
 
-  fun_to_apply = fun_big_comp;
+  fun_to_apply = &fun_big_comp;
 
   printf("Benchmark for parmap create+apply+destroy (big comp):\n");
   bench_all_modes(bench_parmap_full, nthreads, modes);