-/* Copyright (c) 2010-2017. The SimGrid Team. All rights reserved. */
+/* Copyright (c) 2010-2021. The SimGrid Team. All rights reserved. */
/* This program is free software; you can redistribute it and/or modify it
* under the terms of the license (GNU LGPL) which comes with this package. */
-#include "smpi_comm.hpp"
+#include "simgrid/s4u/Actor.hpp"
#include "smpi_group.hpp"
+#include "smpi_comm.hpp"
+#include <string>
-XBT_LOG_NEW_DEFAULT_SUBCATEGORY(smpi_group, smpi, "Logging specific to SMPI (group)");
-
-simgrid::smpi::Group mpi_MPI_GROUP_EMPTY;
-MPI_Group MPI_GROUP_EMPTY=&mpi_MPI_GROUP_EMPTY;
+simgrid::smpi::Group smpi_MPI_GROUP_EMPTY;
+extern XBT_PRIVATE MPI_Comm MPI_COMM_UNINITIALIZED;
namespace simgrid{
namespace smpi{
-Group::Group()
+Group::Group(const Group* origin)
{
- size_ = 0; /* size */
- rank_to_index_map_ = nullptr; /* rank_to_index_map_ */
- refcount_ = 1; /* refcount_: start > 0 so that this group never gets freed */
-}
-
-Group::Group(int n) : size_(n)
-{
- rank_to_index_map_ = new int[size_];
- refcount_ = 1;
- for (int i = 0; i < size_; i++)
- rank_to_index_map_[i] = MPI_UNDEFINED;
+ if (origin != MPI_GROUP_NULL && origin != MPI_GROUP_EMPTY) {
+ size_ = origin->size();
+ // FIXME: cheinrich: There is no such thing as an index any more; the two maps should be removed
+ index_to_rank_map_ = origin->index_to_rank_map_;
+ rank_to_actor_map_ = origin->rank_to_actor_map_;
+ actor_to_rank_map_ = origin->actor_to_rank_map_;
+ }
}
-Group::Group(MPI_Group origin)
+void Group::set_mapping(s4u::Actor* actor, int rank)
{
- if (origin != MPI_GROUP_NULL && origin != MPI_GROUP_EMPTY) {
- size_ = origin->size();
- rank_to_index_map_ = new int[size_];
- refcount_ = 1;
- for (int i = 0; i < size_; i++) {
- rank_to_index_map_[i] = origin->rank_to_index_map_[i];
+ if (0 <= rank && rank < size_) {
+ int index = actor->get_pid();
+ if (index != MPI_UNDEFINED) {
+ if ((unsigned)index >= index_to_rank_map_.size())
+ index_to_rank_map_.resize(index + 1, MPI_UNDEFINED);
+ index_to_rank_map_[index] = rank;
}
- for (auto const& elm : origin->index_to_rank_map_) {
- index_to_rank_map_.insert({elm.first, elm.second});
- }
+ rank_to_actor_map_[rank] = actor;
+ actor_to_rank_map_.insert({actor, rank});
}
}
-Group::~Group()
+int Group::rank(int index)
{
- delete[] rank_to_index_map_;
-}
+ int rank;
+ if (0 <= index && (unsigned)index < index_to_rank_map_.size())
+ rank = index_to_rank_map_[index];
+ else
+ rank = MPI_UNDEFINED;
-void Group::set_mapping(int index, int rank)
-{
- if (rank < size_) {
- rank_to_index_map_[rank] = index;
- if (index != MPI_UNDEFINED)
- index_to_rank_map_.insert({index, rank});
- }
+ return rank;
}
-int Group::index(int rank)
+s4u::Actor* Group::actor(int rank)
{
- int index = MPI_UNDEFINED;
-
- if (0 <= rank && rank < size_) {
- index = rank_to_index_map_[rank];
- }
- return index;
+ if (0 <= rank && rank < size_)
+ return rank_to_actor_map_[rank];
+ else
+ return nullptr;
}
-int Group::rank(int index)
+int Group::rank(s4u::Actor* actor)
{
- if (this == MPI_GROUP_EMPTY)
- return MPI_UNDEFINED;
- auto rank = index_to_rank_map_.find(index);
- return rank == index_to_rank_map_.end() ? MPI_UNDEFINED : rank->second;
+ auto iterator = actor_to_rank_map_.find(actor);
+ //I'm not in the communicator ... but maybe my parent is ?
+ if (iterator == actor_to_rank_map_.end())
+ iterator = actor_to_rank_map_.find(s4u::Actor::by_pid(actor->get_ppid()).get());
+ return (iterator == actor_to_rank_map_.end()) ? MPI_UNDEFINED : (*iterator).second;
}
void Group::ref()
{
group->refcount_--;
if (group->refcount_ <= 0) {
+ if (simgrid::smpi::F2C::lookup() != nullptr)
+ F2C::free_f(group->c2f());
delete group;
}
}
-int Group::size()
-{
- return size_;
-}
-
int Group::compare(MPI_Group group2)
{
int result;
if (size_ != group2->size()) {
result = MPI_UNEQUAL;
} else {
- int sz = group2->size();
- for (int i = 0; i < sz; i++) {
- int index = this->index(i);
- int rank = group2->rank(index);
+ for (int i = 0; i < size_; i++) {
+ s4u::Actor* actor = this->actor(i);
+ int rank = group2->rank(actor);
if (rank == MPI_UNDEFINED) {
result = MPI_UNEQUAL;
break;
return result;
}
-int Group::incl(int n, int* ranks, MPI_Group* newgroup)
+int Group::incl(int n, const int* ranks, MPI_Group* newgroup)
{
- int i=0;
- int index=0;
if (n == 0) {
*newgroup = MPI_GROUP_EMPTY;
- } else if (n == size_) {
- *newgroup = this;
- if(this!= MPI_COMM_WORLD->group()
- && this != MPI_COMM_SELF->group()
- && this != MPI_GROUP_EMPTY)
- this->ref();
} else {
*newgroup = new Group(n);
- for (i = 0; i < n; i++) {
- index = this->index(ranks[i]);
- (*newgroup)->set_mapping(index, i);
+ for (int i = 0; i < n; i++) {
+ s4u::Actor* actor = this->actor(ranks[i]); // ranks[] was passed as a param!
+ (*newgroup)->set_mapping(actor, i);
}
+ if((*newgroup)!=MPI_GROUP_EMPTY)
+ (*newgroup)->add_f();
}
return MPI_SUCCESS;
}
int size1 = size_;
int size2 = group2->size();
for (int i = 0; i < size2; i++) {
- int proc2 = group2->index(i);
- int proc1 = this->rank(proc2);
+ s4u::Actor* actor = group2->actor(i);
+ int proc1 = this->rank(actor);
if (proc1 == MPI_UNDEFINED) {
size1++;
}
*newgroup = new Group(size1);
size2 = this->size();
for (int i = 0; i < size2; i++) {
- int proc1 = this->index(i);
- (*newgroup)->set_mapping(proc1, i);
+ s4u::Actor* actor1 = this->actor(i);
+ (*newgroup)->set_mapping(actor1, i);
}
for (int i = size2; i < size1; i++) {
- int proc2 = group2->index(i - size2);
- (*newgroup)->set_mapping(proc2, i);
+ s4u::Actor* actor = group2->actor(i - size2);
+ (*newgroup)->set_mapping(actor, i);
}
+ if((*newgroup)!=MPI_GROUP_EMPTY)
+ (*newgroup)->add_f();
}
return MPI_SUCCESS;
}
{
int size2 = group2->size();
for (int i = 0; i < size2; i++) {
- int proc2 = group2->index(i);
- int proc1 = this->rank(proc2);
+ s4u::Actor* actor = group2->actor(i);
+ int proc1 = this->rank(actor);
if (proc1 == MPI_UNDEFINED) {
size2--;
}
*newgroup = new Group(size2);
int j=0;
for (int i = 0; i < group2->size(); i++) {
- int proc2 = group2->index(i);
- int proc1 = this->rank(proc2);
+ s4u::Actor* actor = group2->actor(i);
+ int proc1 = this->rank(actor);
if (proc1 != MPI_UNDEFINED) {
- (*newgroup)->set_mapping(proc2, j);
+ (*newgroup)->set_mapping(actor, j);
j++;
}
}
+ if((*newgroup)!=MPI_GROUP_EMPTY)
+ (*newgroup)->add_f();
}
return MPI_SUCCESS;
}
int newsize = size_;
int size2 = size_;
for (int i = 0; i < size2; i++) {
- int proc1 = this->index(i);
- int proc2 = group2->rank(proc1);
+ s4u::Actor* actor = this->actor(i);
+ int proc2 = group2->rank(actor);
if (proc2 != MPI_UNDEFINED) {
newsize--;
}
} else {
*newgroup = new Group(newsize);
for (int i = 0; i < size2; i++) {
- int proc1 = this->index(i);
- int proc2 = group2->rank(proc1);
+ s4u::Actor* actor = this->actor(i);
+ int proc2 = group2->rank(actor);
if (proc2 == MPI_UNDEFINED) {
- (*newgroup)->set_mapping(proc1, i);
+ (*newgroup)->set_mapping(actor, i);
}
}
+ if((*newgroup)!=MPI_GROUP_EMPTY)
+ (*newgroup)->add_f();
}
return MPI_SUCCESS;
}
-int Group::excl(int n, int *ranks, MPI_Group * newgroup){
+int Group::excl(int n, const int *ranks, MPI_Group * newgroup){
int oldsize = size_;
int newsize = oldsize - n;
*newgroup = new Group(newsize);
- int* to_exclude=xbt_new0(int, size_);
- for (int i = 0; i < oldsize; i++)
- to_exclude[i]=0;
- for (int i = 0; i < n; i++)
- to_exclude[ranks[i]]=1;
+ std::vector<bool> to_exclude(size_, false);
+ for (int i = 0; i < n; i++)
+ to_exclude[ranks[i]] = true;
int j = 0;
for (int i = 0; i < oldsize; i++) {
- if(to_exclude[i]==0){
- int index = this->index(i);
- (*newgroup)->set_mapping(index, j);
+ if (not to_exclude[i]) {
+ s4u::Actor* actor = this->actor(i);
+ (*newgroup)->set_mapping(actor, j);
j++;
}
}
- xbt_free(to_exclude);
+ if((*newgroup)!=MPI_GROUP_EMPTY)
+ (*newgroup)->add_f();
return MPI_SUCCESS;
+}
+static bool is_rank_in_range(int rank, int first, int last)
+{
+ return (first <= rank && rank <= last) || (first >= rank && rank >= last);
}
-int Group::range_incl(int n, int ranges[][3], MPI_Group * newgroup){
- int newsize = 0;
- for (int i = 0; i < n; i++) {
- for (int rank = ranges[i][0]; /* First */
- rank >= 0 && rank < size_; /* Last */
- ) {
- newsize++;
- if(rank == ranges[i][1]){/*already last ?*/
- break;
- }
- rank += ranges[i][2]; /* Stride */
- if (ranges[i][0] < ranges[i][1]) {
- if (rank > ranges[i][1])
- break;
- } else {
- if (rank < ranges[i][1])
- break;
- }
- }
- }
- *newgroup = new Group(newsize);
- int j = 0;
- for (int i = 0; i < n; i++) {
- for (int rank = ranges[i][0]; /* First */
- rank >= 0 && rank < size_; /* Last */
- ) {
- int index = this->index(rank);
- (*newgroup)->set_mapping(index, j);
- j++;
- if(rank == ranges[i][1]){/*already last ?*/
- break;
- }
- rank += ranges[i][2]; /* Stride */
- if (ranges[i][0] < ranges[i][1]) {
- if (rank > ranges[i][1])
- break;
- } else {
- if (rank < ranges[i][1])
- break;
- }
- }
+int Group::range_incl(int n, int ranges[][3], MPI_Group* newgroup)
+{
+ std::vector<int> to_incl;
+ for (int i = 0; i < n; i++)
+ for (int j = ranges[i][0]; j >= 0 && j < size_ && is_rank_in_range(j, ranges[i][0], ranges[i][1]);
+ j += ranges[i][2])
+ to_incl.push_back(j);
+
+ int newsize = static_cast<int>(to_incl.size());
+ *newgroup = new Group(newsize);
+
+ for (int j = 0; j < newsize; j++) {
+ int rank = to_incl[j];
+ s4u::Actor* actor = this->actor(rank);
+ (*newgroup)->set_mapping(actor, j);
}
+ if((*newgroup)!=MPI_GROUP_EMPTY)
+ (*newgroup)->add_f();
return MPI_SUCCESS;
}
-int Group::range_excl(int n, int ranges[][3], MPI_Group * newgroup){
+int Group::range_excl(int n, int ranges[][3], MPI_Group* newgroup)
+{
+ std::vector<bool> to_excl(size_, false);
int newsize = size_;
for (int i = 0; i < n; i++) {
- for (int rank = ranges[i][0]; /* First */
- rank >= 0 && rank < size_; /* Last */
- ) {
+ for (int j = ranges[i][0]; j >= 0 && j < size_ && is_rank_in_range(j, ranges[i][0], ranges[i][1]);
+ j += ranges[i][2]) {
+ to_excl[j] = true;
newsize--;
- if(rank == ranges[i][1]){/*already last ?*/
- break;
- }
- rank += ranges[i][2]; /* Stride */
- if (ranges[i][0] < ranges[i][1]) {
- if (rank > ranges[i][1])
- break;
- } else {
- if (rank < ranges[i][1])
- break;
- }
}
}
if (newsize == 0) {
*newgroup = MPI_GROUP_EMPTY;
} else {
- *newgroup = new Group(newsize);
- int newrank = 0;
- int oldrank = 0;
- while (newrank < newsize) {
- int add = 1;
- for (int i = 0; i < n; i++) {
- for (int rank = ranges[i][0]; rank >= 0 && rank < size_;) {
- if(rank==oldrank){
- add = 0;
- break;
- }
- if(rank == ranges[i][1]){/*already last ?*/
- break;
- }
- rank += ranges[i][2]; /* Stride */
- if (ranges[i][0]<ranges[i][1]){
- if (rank > ranges[i][1])
- break;
- }else{
- if (rank < ranges[i][1])
- break;
- }
- }
- }
- if(add==1){
- int index = this->index(oldrank);
- (*newgroup)->set_mapping(index, newrank);
- newrank++;
+ *newgroup = new Group(newsize);
+
+ int j = 0;
+ for (int rank = 0; rank < size_; rank++) {
+ if (not to_excl[rank]) {
+ s4u::Actor* actor = this->actor(rank);
+ (*newgroup)->set_mapping(actor, j);
+ j++;
}
- oldrank++;
}
}
+ if((*newgroup)!=MPI_GROUP_EMPTY)
+ (*newgroup)->add_f();
return MPI_SUCCESS;
}
MPI_Group Group::f2c(int id) {
if(id == -2) {
return MPI_GROUP_EMPTY;
- } else if(F2C::f2c_lookup() != nullptr && id >= 0) {
- char key[KEY_SIZE];
- return static_cast<MPI_Group>(F2C::f2c_lookup()->at(get_key(key, id)));
+ } else if (F2C::lookup() != nullptr && id >= 0) {
+ return static_cast<MPI_Group>(F2C::lookup()->at(id));
} else {
- return static_cast<MPI_Group>(MPI_GROUP_NULL);
+ return MPI_GROUP_NULL;
}
}
