-/* Copyright (c) 2013-2020. The SimGrid Team. All rights reserved. */
+/* Copyright (c) 2013-2021. The SimGrid Team. All rights reserved. */
/* This program is free software; you can redistribute it and/or modify it
* under the terms of the license (GNU LGPL) which comes with this package. */
std::string("__mig_stage3:") + vm_->get_cname() + "(" + src_pm_->get_cname() + "-" + dst_pm_->get_cname() + ")";
while (not received_finalize) {
- const std::string* payload = static_cast<std::string*>(mbox->get());
+ auto payload = mbox->get_unique<std::string>();
if (finalize_task_name == *payload)
received_finalize = true;
-
- delete payload;
}
// Here Stage 1, 2 and 3 have been performed.
vm_->resume();
// Now the VM is running on the new host (the migration is completed) (even if the SRC crash)
- vm_->get_impl()->end_migration();
+ vm_->get_vm_impl()->end_migration();
XBT_DEBUG("VM(%s) moved from PM(%s) to PM(%s)", vm_->get_cname(), src_pm_->get_cname(), dst_pm_->get_cname());
if (TRACE_vm_is_enabled()) {
counter++;
// start link
- container_t msg = instr::Container::by_name(vm_->get_name());
+ auto* msg = instr::Container::by_name(vm_->get_name());
instr::Container::get_root()->get_link("VM_LINK")->start_event(msg, "M", key);
// destroy existing container of this vm
instr::Container::get_root()->get_link("VM_LINK")->end_event(msg, "M", key);
}
// Inform the SRC that the migration has been correctly performed
- std::string* payload = new std::string("__mig_stage4:");
- *payload = *payload + vm_->get_cname() + "(" + src_pm_->get_cname() + "-" + dst_pm_->get_cname() + ")";
+ auto* payload = new std::string("__mig_stage4:");
+ *payload = *payload + vm_->get_cname() + "(" + src_pm_->get_cname() + "-" + dst_pm_->get_cname() + ")";
mbox_ctl->put(payload, 0);
static sg_size_t get_updated_size(double computed, double dp_rate, sg_size_t dp_cap)
{
- sg_size_t updated_size = static_cast<sg_size_t>(computed * dp_rate);
+ auto updated_size = static_cast<sg_size_t>(computed * dp_rate);
XBT_DEBUG("updated_size %llu dp_rate %f", updated_size, dp_rate);
if (updated_size > dp_cap) {
updated_size = dp_cap;
sg_size_t MigrationTx::sendMigrationData(sg_size_t size, int stage, int stage2_round, double mig_speed, double timeout)
{
sg_size_t sent = size;
- std::string* msg = new std::string("__mig_stage");
+ auto* msg = new std::string("__mig_stage");
*msg = *msg + std::to_string(stage) + ":" + vm_->get_cname() + "(" + src_pm_->get_cname() + "-" +
dst_pm_->get_cname() + ")";
comm->set_rate(mig_speed);
try {
comm->wait_for(timeout);
- } catch (const simgrid::TimeoutException&) {
- sg_size_t remaining = static_cast<sg_size_t>(comm->get_remaining());
+ } catch (const Exception&) {
+ auto remaining = static_cast<sg_size_t>(comm->get_remaining());
XBT_VERB("timeout (%lf s) in sending_migration_data, remaining %llu bytes of %llu", timeout, remaining, size);
sent -= remaining;
delete msg;
double clock_end = s4u::Engine::get_clock();
double duration = clock_end - clock_sta;
- double actual_speed = size / duration;
+ double actual_speed = static_cast<double>(size) / duration;
if (stage == 2)
XBT_DEBUG("mig-stage%d.%d: sent %llu duration %f actual_speed %f (target %f)", stage, stage2_round, size, duration,
double host_speed = vm_->get_pm()->get_speed();
const sg_size_t ramsize = vm_->get_ramsize();
const double dp_rate =
- host_speed ? (sg_vm_get_migration_speed(vm_) * sg_vm_get_dirty_page_intensity(vm_)) / host_speed : 1;
+ host_speed != 0.0 ? (sg_vm_get_migration_speed(vm_) * sg_vm_get_dirty_page_intensity(vm_)) / host_speed : 1;
const sg_size_t dp_cap = sg_vm_get_working_set_memory(vm_);
const double mig_speed = sg_vm_get_migration_speed(vm_);
double max_downtime = sg_vm_get_max_downtime(vm_);
XBT_CRITICAL("bug");
} catch (const Exception&) {
// hostfailure (if you want to know whether this is the SRC or the DST check directly in send_migration_data code)
- // Stop the dirty page tracking an return (there is no memory space to release)
+ // Stop the dirty page tracking and return (there is no memory space to release)
sg_vm_stop_dirty_page_tracking(vm_);
return;
}
} catch (const Exception&) {
// hostfailure (if you want to know whether this is the SRC or the DST check directly in send_migration_data
// code)
- // Stop the dirty page tracking an return (there is no memory space to release)
+ // Stop the dirty page tracking and return (there is no memory space to release)
sg_vm_stop_dirty_page_tracking(vm_);
return;
}
sendMigrationData(remaining_size, 3, 0, mig_speed, -1);
} catch (const Exception&) {
// hostfailure (if you want to know whether this is the SRC or the DST check directly in send_migration_data code)
- // Stop the dirty page tracking an return (there is no memory space to release)
+ // Stop the dirty page tracking and return (there is no memory space to release)
vm_->resume();
return;
}
static void onVirtualMachineShutdown(simgrid::s4u::VirtualMachine const& vm)
{
- if (vm.get_impl()->is_migrating()) {
+ if (vm.get_vm_impl()->is_migrating()) {
vm.extension<simgrid::vm::VmMigrationExt>()->rx_->kill();
vm.extension<simgrid::vm::VmMigrationExt>()->tx_->kill();
vm.extension<simgrid::vm::VmMigrationExt>()->issuer_->kill();
- vm.get_impl()->end_migration();
+ vm.get_vm_impl()->end_migration();
}
}
/* For the moment, intensity_rate is the percentage against the migration bandwidth */
- sg_vm_t vm = new simgrid::s4u::VirtualMachine(name, pm, coreAmount, static_cast<sg_size_t>(ramsize) * 1024 * 1024);
+ auto* vm = new simgrid::s4u::VirtualMachine(name, pm, coreAmount, static_cast<sg_size_t>(ramsize) * 1024 * 1024);
sg_vm_set_dirty_page_intensity(vm, dp_intensity / 100.0);
sg_vm_set_working_set_memory(vm, vm->get_ramsize() * 0.9); // assume working set memory is 90% of ramsize
sg_vm_set_migration_speed(vm, mig_netspeed * 1024 * 1024.0);
int sg_vm_is_migrating(const simgrid::s4u::VirtualMachine* vm)
{
- return vm->get_impl()->is_migrating();
+ return vm->get_vm_impl()->is_migrating();
}
void sg_vm_migrate(simgrid::s4u::VirtualMachine* vm, simgrid::s4u::Host* dst_pm)
throw simgrid::VmFailureException(
XBT_THROW_POINT,
simgrid::xbt::string_printf("Cannot migrate VM '%s' that is not running yet.", vm->get_cname()));
- if (vm->get_impl()->is_migrating())
+ if (vm->get_vm_impl()->is_migrating())
throw simgrid::VmFailureException(
XBT_THROW_POINT,
simgrid::xbt::string_printf("Cannot migrate VM '%s' that is already migrating.", vm->get_cname()));
- vm->get_impl()->start_migration();
+ vm->get_vm_impl()->start_migration();
simgrid::s4u::VirtualMachine::on_migration_start(*vm);
std::string rx_name =
XBT_DEBUG("wait for reception of the final ACK (i.e. migration has been correctly performed");
simgrid::s4u::Mailbox* mbox_ctl = simgrid::s4u::Mailbox::by_name(
std::string("__mbox_mig_ctl:") + vm->get_cname() + "(" + src_pm->get_cname() + "-" + dst_pm->get_cname() + ")");
- delete static_cast<std::string*>(mbox_ctl->get());
+ mbox_ctl->get_unique<std::string>();
tx->join();
rx->join();
- vm->get_impl()->end_migration();
+ vm->get_vm_impl()->end_migration();
simgrid::s4u::VirtualMachine::on_migration_end(*vm);
}
