// solves the proportional fairness using a Lagrangian optimization with dichotomy step
void lagrange_solve(lmm_system_t sys);
// computes the value of the dichotomy using a initial values, init, with a specific variable or constraint
-static double dichotomy(double init, double diff(double, void*), void* var_cnst, double min_error);
-// computes the value of the differential of constraint param_cnst applied to lambda
-static double partial_diff_lambda(double lambda, void* param_cnst);
+static double dichotomy(double init, double diff(double, const s_lmm_constraint_t&), const s_lmm_constraint_t& cnst,
+ double min_error);
+// computes the value of the differential of constraint cnst applied to lambda
+static double partial_diff_lambda(double lambda, const s_lmm_constraint_t& cnst);
-static int __check_feasible(xbt_swag_t cnst_list, xbt_swag_t var_list, int warn)
+template <class CnstList>
+static int __check_feasible(const CnstList& cnst_list, xbt_swag_t var_list, int warn)
{
- void* _cnst;
void* _elem;
void* _var;
- xbt_swag_t elem_list = nullptr;
+ const_xbt_swag_t elem_list = nullptr;
lmm_element_t elem = nullptr;
- lmm_constraint_t cnst = nullptr;
lmm_variable_t var = nullptr;
- xbt_swag_foreach(_cnst, cnst_list)
- {
- cnst = static_cast<lmm_constraint_t>(_cnst);
+ for (s_lmm_constraint_t const& cnst : cnst_list) {
double tmp = 0;
- elem_list = &(cnst->enabled_element_set);
+ elem_list = &cnst.enabled_element_set;
xbt_swag_foreach(_elem, elem_list)
{
elem = static_cast<lmm_element_t>(_elem);
tmp += var->value;
}
- if (double_positive(tmp - cnst->bound, sg_maxmin_precision)) {
+ if (double_positive(tmp - cnst.bound, sg_maxmin_precision)) {
if (warn)
- XBT_WARN("The link (%p) is over-used. Expected less than %f and got %f", cnst, cnst->bound, tmp);
+ XBT_WARN("The link (%p) is over-used. Expected less than %f and got %f", &cnst, cnst.bound, tmp);
return 0;
}
- XBT_DEBUG("Checking feasability for constraint (%p): sat = %f, lambda = %f ", cnst, tmp - cnst->bound,
- cnst->lambda);
+ XBT_DEBUG("Checking feasability for constraint (%p): sat = %f, lambda = %f ", &cnst, tmp - cnst.bound, cnst.lambda);
}
xbt_swag_foreach(_var, var_list)
return mu_i;
}
-static double dual_objective(xbt_swag_t var_list, xbt_swag_t cnst_list)
+template <class CnstList>
+static double dual_objective(xbt_swag_t var_list, const CnstList& cnst_list)
{
- void* _cnst;
void* _var;
- lmm_constraint_t cnst = nullptr;
lmm_variable_t var = nullptr;
double obj = 0.0;
obj += var->mu * var->bound;
}
- xbt_swag_foreach(_cnst, cnst_list)
- {
- cnst = static_cast<lmm_constraint_t>(_cnst);
- obj += cnst->lambda * cnst->bound;
- }
+ for (s_lmm_constraint_t const& cnst : cnst_list)
+ obj += cnst.lambda * cnst.bound;
return obj;
}
return;
/* Initialize lambda. */
- xbt_swag_t cnst_list = &(sys->active_constraint_set);
- void* _cnst;
- xbt_swag_foreach(_cnst, cnst_list)
- {
- lmm_constraint_t cnst = (lmm_constraint_t)_cnst;
- cnst->lambda = 1.0;
- cnst->new_lambda = 2.0;
- XBT_DEBUG("#### cnst(%p)->lambda : %e", cnst, cnst->lambda);
+ auto& cnst_list = sys->active_constraint_set;
+ for (s_lmm_constraint_t& cnst : cnst_list) {
+ cnst.lambda = 1.0;
+ cnst.new_lambda = 2.0;
+ XBT_DEBUG("#### cnst(%p)->lambda : %e", &cnst, cnst.lambda);
}
/*
}
/* Improve the value of lambda_i */
- xbt_swag_foreach(_cnst, cnst_list)
- {
- lmm_constraint_t cnst = static_cast<lmm_constraint_t>(_cnst);
- XBT_DEBUG("Working on cnst (%p)", cnst);
- cnst->new_lambda = dichotomy(cnst->lambda, partial_diff_lambda, cnst, dichotomy_min_error);
- XBT_DEBUG("Updating lambda : cnst->lambda (%p) : %1.20f -> %1.20f", cnst, cnst->lambda, cnst->new_lambda);
- cnst->lambda = cnst->new_lambda;
+ for (s_lmm_constraint_t& cnst : cnst_list) {
+ XBT_DEBUG("Working on cnst (%p)", &cnst);
+ cnst.new_lambda = dichotomy(cnst.lambda, partial_diff_lambda, cnst, dichotomy_min_error);
+ XBT_DEBUG("Updating lambda : cnst->lambda (%p) : %1.20f -> %1.20f", &cnst, cnst.lambda, cnst.new_lambda);
+ cnst.lambda = cnst.new_lambda;
double new_obj = dual_objective(var_list, cnst_list);
XBT_DEBUG("Improvement for Objective (%g -> %g) : %g", obj, new_obj, obj - new_obj);
*
* @return a double corresponding to the result of the dichotomy process
*/
-static double dichotomy(double init, double diff(double, void*), void* var_cnst, double min_error)
+static double dichotomy(double init, double diff(double, const s_lmm_constraint_t&), const s_lmm_constraint_t& cnst,
+ double min_error)
{
double min = init;
double max = init;
overall_error = 1;
- diff_0 = diff(1e-16, var_cnst);
+ diff_0 = diff(1e-16, cnst);
if (diff_0 >= 0) {
XBT_CDEBUG(surf_lagrange_dichotomy, "returning 0.0 (diff = %e)", diff_0);
XBT_OUT();
return 0.0;
}
- double min_diff = diff(min, var_cnst);
- double max_diff = diff(max, var_cnst);
+ double min_diff = diff(min, cnst);
+ double max_diff = diff(max, cnst);
while (overall_error > min_error) {
XBT_CDEBUG(surf_lagrange_dichotomy, "[min, max] = [%1.20f, %1.20f] || diffmin, diffmax = %1.20f, %1.20f", min, max,
if (min == max) {
XBT_CDEBUG(surf_lagrange_dichotomy, "Decreasing min");
min = min / 2.0;
- min_diff = diff(min, var_cnst);
+ min_diff = diff(min, cnst);
} else {
XBT_CDEBUG(surf_lagrange_dichotomy, "Decreasing max");
max = min;
if (min == max) {
XBT_CDEBUG(surf_lagrange_dichotomy, "Increasing max");
max = max * 2.0;
- max_diff = diff(max, var_cnst);
+ max_diff = diff(max, cnst);
} else {
XBT_CDEBUG(surf_lagrange_dichotomy, "Increasing min");
min = max;
min, max - min, min_diff, max_diff);
break;
}
- middle_diff = diff(middle, var_cnst);
+ middle_diff = diff(middle, cnst);
if (middle_diff < 0) {
XBT_CDEBUG(surf_lagrange_dichotomy, "Increasing min");
return ((min + max) / 2.0);
}
-static double partial_diff_lambda(double lambda, void* param_cnst)
+static double partial_diff_lambda(double lambda, const s_lmm_constraint_t& cnst)
{
- lmm_constraint_t cnst = static_cast<lmm_constraint_t>(param_cnst);
double diff = 0.0;
XBT_IN();
- XBT_CDEBUG(surf_lagrange_dichotomy, "Computing diff of cnst (%p)", cnst);
+ XBT_CDEBUG(surf_lagrange_dichotomy, "Computing diff of cnst (%p)", &cnst);
- xbt_swag_t elem_list = &(cnst->enabled_element_set);
+ const_xbt_swag_t elem_list = &cnst.enabled_element_set;
void* _elem;
xbt_swag_foreach(_elem, elem_list)
{
if (var->bound > 0)
sigma_i += var->mu;
- // replace value of cnst->lambda by the value of parameter lambda
- sigma_i = (sigma_i - cnst->lambda) + lambda;
+ // replace value of cnst.lambda by the value of parameter lambda
+ sigma_i = (sigma_i - cnst.lambda) + lambda;
diff += -var->func_fpi(*var, sigma_i);
}
- diff += cnst->bound;
+ diff += cnst.bound;
- XBT_CDEBUG(surf_lagrange_dichotomy, "d D/d lambda for cnst (%p) at %1.20f = %1.20f", cnst, lambda, diff);
+ XBT_CDEBUG(surf_lagrange_dichotomy, "d D/d lambda for cnst (%p) at %1.20f = %1.20f", &cnst, lambda, diff);
XBT_OUT();
return diff;
}
