optimize this vector traversal

[simgrid.git] / src / surf / network_smpi.cpp

diff --git a/src/surf/network_smpi.cpp b/src/surf/network_smpi.cpp
index 08e8f8b..2e4d420 100644 (file)
--- a/src/surf/network_smpi.cpp
+++ b/src/surf/network_smpi.cpp
@@ -20,14 +20,6 @@ std::vector<s_smpi_factor_t> smpi_lat_factor;
 
 xbt_dict_t gap_lookup = nullptr;
 
-static int factor_cmp(const void *pa, const void *pb)
-{
-  return (((s_smpi_factor_t*)pa)->factor > ((s_smpi_factor_t*)pb)->factor) ? 1 :
-      (((s_smpi_factor_t*)pa)->factor < ((s_smpi_factor_t*)pb)->factor) ? -1 : 0;
-}
-
-#include "src/surf/xml/platf.hpp" // FIXME: move that back to the parsing area
-
 /*********
  * Model *
  *********/
@@ -57,12 +49,13 @@ void surf_network_model_init_SMPI()
 namespace simgrid {
   namespace surf {
 
-    NetworkSmpiModel::NetworkSmpiModel()
-    : NetworkCm02Model() {
-      haveGap_=true;
+  NetworkSmpiModel::NetworkSmpiModel() : NetworkCm02Model()
+  {
+    haveGap_ = true;
     }
 
-    NetworkSmpiModel::~NetworkSmpiModel(){
+    NetworkSmpiModel::~NetworkSmpiModel()
+    {
       xbt_dict_free(&gap_lookup);
     }
 
@@ -131,13 +124,13 @@ namespace simgrid {
       if (smpi_bw_factor.empty())
         smpi_bw_factor = parse_factor(xbt_cfg_get_string("smpi/bw-factor"));
 
-      double current=1.0;
-      for (auto fact: smpi_bw_factor) {
+      double current = 1.0;
+      for (const auto& fact : smpi_bw_factor) {
         if (size <= fact.factor) {
           XBT_DEBUG("%f <= %zu return %f", size, fact.factor, current);
           return current;
-        }else
-          current=fact.values.front();
+        } else
+          current = fact.values.front();
       }
       XBT_DEBUG("%f > %zu return %f", size, smpi_bw_factor.back().factor, current);