fix

[simgrid.git] / src / s4u / s4u_storage.cpp

diff --git a/src/s4u/s4u_storage.cpp b/src/s4u/s4u_storage.cpp
index 6b99ef8..c6e3334 100644 (file)
--- a/src/s4u/s4u_storage.cpp
+++ b/src/s4u/s4u_storage.cpp
@@ -13,27 +13,24 @@ namespace simgrid {
 namespace s4u {
 
 boost::unordered_map <std::string, Storage *> *Storage::storages_ = new boost::unordered_map<std::string, Storage*> ();
-Storage::Storage(std::string name, smx_storage_t inferior) {
-  name_ = name;
-  inferior_ = inferior;
-
+Storage::Storage(std::string name, smx_storage_t inferior) :
+    name_(name), pimpl_(inferior)
+{
   storages_->insert({name, this});
 }
 
-Storage::~Storage() {
-  // TODO Auto-generated destructor stub
-}
+Storage::~Storage() = default;
 
 smx_storage_t Storage::inferior() {
-  return inferior_;
+  return pimpl_;
 }
 Storage &Storage::byName(const char*name) {
-  s4u::Storage *res = NULL;
+  s4u::Storage *res = nullptr;
   try {
     res = storages_->at(name);
   } catch (std::out_of_range& e) {
     smx_storage_t inferior = xbt_lib_get_elm_or_null(storage_lib,name);
-    if (inferior == NULL)
+    if (inferior == nullptr)
       xbt_die("Storage %s does not exist. Please only use the storages that are defined in your platform.", name);
 
     res = new Storage(name,inferior);
@@ -46,13 +43,13 @@ const char*Storage::name() {
 }
 
 sg_size_t Storage::sizeFree() {
-  return simcall_storage_get_free_size(inferior_);
+  return simcall_storage_get_free_size(pimpl_);
 }
 sg_size_t Storage::sizeUsed() {
-  return simcall_storage_get_used_size(inferior_);
+  return simcall_storage_get_used_size(pimpl_);
 }
 sg_size_t Storage::size() {
-  return SIMIX_storage_get_size(inferior_);
+  return SIMIX_storage_get_size(pimpl_);
 }
 
 } /* namespace s4u */