[sonar] fix a few recently introduced smells

[simgrid.git] / src / plugins / vm / VirtualMachineImpl.hpp

diff --git a/src/plugins/vm/VirtualMachineImpl.hpp b/src/plugins/vm/VirtualMachineImpl.hpp
index 031c355..7015fc6 100644 (file)
--- a/src/plugins/vm/VirtualMachineImpl.hpp
+++ b/src/plugins/vm/VirtualMachineImpl.hpp
@@ -28,23 +28,20 @@ namespace vm {
  * @details A VM represent a virtual machine
  */
 class XBT_PUBLIC VirtualMachineImpl : public surf::HostImpl, public simgrid::xbt::Extendable<VirtualMachineImpl> {
+#ifndef DOXYGEN
   friend simgrid::s4u::VirtualMachine;
+#endif
 
 public:
-  /** @brief Callbacks fired after VM creation. Signature: `void(VirtualMachineImpl&)` */
-  static xbt::signal<void(simgrid::vm::VirtualMachineImpl&)> on_creation;
-  /** @brief Callbacks fired after VM destruction. Signature: `void(VirtualMachineImpl const&)` */
-  static xbt::signal<void(simgrid::vm::VirtualMachineImpl const&)> on_destruction;
-
   static std::deque<s4u::VirtualMachine*> allVms_;
 
   explicit VirtualMachineImpl(const std::string& name, s4u::VirtualMachine* piface, s4u::Host* host, int core_amount,
                               size_t ramsize);
-  ~VirtualMachineImpl() override;
 
   void suspend(kernel::actor::ActorImpl* issuer);
   void resume();
   void shutdown(kernel::actor::ActorImpl* issuer);
+  void vm_destroy();
 
   /** @brief Change the physical host on which the given VM is running */
   void set_physical_host(s4u::Host* dest);
@@ -54,8 +51,8 @@ public:
   sg_size_t get_ramsize() const { return ramsize_; }
   void set_ramsize(sg_size_t ramsize) { ramsize_ = ramsize; }
 
-  s4u::VirtualMachine::state get_state() const { return vm_state_; }
-  void set_state(s4u::VirtualMachine::state state) { vm_state_ = state; }
+  s4u::VirtualMachine::State get_state() const { return vm_state_; }
+  void set_state(s4u::VirtualMachine::State state) { vm_state_ = state; }
 
   unsigned int get_core_amount() const { return core_amount_; }
   kernel::resource::Action* get_action() const { return action_; }
@@ -82,7 +79,7 @@ private:
   unsigned int core_amount_;
   double user_bound_                   = std::numeric_limits<double>::max();
   size_t ramsize_                      = 0;
-  s4u::VirtualMachine::state vm_state_ = s4u::VirtualMachine::state::CREATED;
+  s4u::VirtualMachine::State vm_state_ = s4u::VirtualMachine::State::CREATED;
   bool is_migrating_                   = false;
 };