A
lgorithmique
N
umérique
D
istribuée
Public GIT Repository
projects
/
simgrid.git
/ blobdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
|
commitdiff
|
tree
raw
|
inline
| side by side
[sonar] Constify pointer and reference local variables in src/surf/.
[simgrid.git]
/
src
/
surf
/
ptask_L07.cpp
diff --git
a/src/surf/ptask_L07.cpp
b/src/surf/ptask_L07.cpp
index
e296241
..
cf22248
100644
(file)
--- a/
src/surf/ptask_L07.cpp
+++ b/
src/surf/ptask_L07.cpp
@@
-4,6
+4,7
@@
* under the terms of the license (GNU LGPL) which comes with this package. */
#include "ptask_L07.hpp"
* under the terms of the license (GNU LGPL) which comes with this package. */
#include "ptask_L07.hpp"
+#include "src/kernel/resource/profile/Event.hpp"
#include "surf/surf.hpp"
#include "xbt/config.hpp"
#include "surf/surf.hpp"
#include "xbt/config.hpp"
@@
-56,7
+57,8
@@
NetworkL07Model::NetworkL07Model(HostL07Model* hmodel, kernel::lmm::System* sys)
: NetworkModel(Model::UpdateAlgo::FULL), hostModel_(hmodel)
{
set_maxmin_system(sys);
: NetworkModel(Model::UpdateAlgo::FULL), hostModel_(hmodel)
{
set_maxmin_system(sys);
- loopback_ = NetworkL07Model::create_link("__loopback__", 498000000, 0.000015, s4u::Link::SharingPolicy::FATPIPE);
+ loopback_ = NetworkL07Model::create_link("__loopback__", std::vector<double>{498000000}, 0.000015,
+ s4u::Link::SharingPolicy::FATPIPE);
}
NetworkL07Model::~NetworkL07Model()
}
NetworkL07Model::~NetworkL07Model()
@@
-64,9
+66,9
@@
NetworkL07Model::~NetworkL07Model()
set_maxmin_system(nullptr);
}
set_maxmin_system(nullptr);
}
-double HostL07Model::next_occuring_event(double now)
+double HostL07Model::next_occur
r
ing_event(double now)
{
{
- double min = HostModel::next_occuring_event_full(now);
+ double min = HostModel::next_occur
r
ing_event_full(now);
for (kernel::resource::Action const& action : *get_started_action_set()) {
const L07Action& net_action = static_cast<const L07Action&>(action);
if (net_action.latency_ > 0 && (min < 0 || net_action.latency_ < min)) {
for (kernel::resource::Action const& action : *get_started_action_set()) {
const L07Action& net_action = static_cast<const L07Action&>(action);
if (net_action.latency_ > 0 && (min < 0 || net_action.latency_ < min)) {
@@
-92,7
+94,7
@@
void HostL07Model::update_actions_state(double /*now*/, double delta)
}
if ((action.latency_ <= 0.0) && (action.is_suspended() == 0)) {
action.updateBound();
}
if ((action.latency_ <= 0.0) && (action.is_suspended() == 0)) {
action.updateBound();
- get_maxmin_system()->update_variable_
weight
(action.get_variable(), 1.0);
+ get_maxmin_system()->update_variable_
penalty
(action.get_variable(), 1.0);
action.set_last_update();
}
}
action.set_last_update();
}
}
@@
-109,7
+111,7
@@
void HostL07Model::update_actions_state(double /*now*/, double delta)
* If it's not done, it may have failed.
*/
* If it's not done, it may have failed.
*/
- if (((action.get_remains() <= 0) && (action.get_variable()->get_
weight
() > 0)) ||
+ if (((action.get_remains() <= 0) && (action.get_variable()->get_
penalty
() > 0)) ||
((action.get_max_duration() != NO_MAX_DURATION) && (action.get_max_duration() <= 0))) {
action.finish(kernel::resource::Action::State::FINISHED);
continue;
((action.get_max_duration() != NO_MAX_DURATION) && (action.get_max_duration() <= 0))) {
action.finish(kernel::resource::Action::State::FINISHED);
continue;
@@
-117,11
+119,11
@@
void HostL07Model::update_actions_state(double /*now*/, double delta)
/* Need to check that none of the model has failed */
int i = 0;
/* Need to check that none of the model has failed */
int i = 0;
- kernel::lmm::Constraint* cnst = action.get_variable()->get_constraint(i);
+
const
kernel::lmm::Constraint* cnst = action.get_variable()->get_constraint(i);
while (cnst != nullptr) {
i++;
while (cnst != nullptr) {
i++;
-
void
* constraint_id = cnst->get_id();
- if (not
static_cast<simgrid::kernel::resource::Resource*>(constraint_id)
->is_on()) {
+
const kernel::resource::Resource
* constraint_id = cnst->get_id();
+ if (not
constraint_id
->is_on()) {
XBT_DEBUG("Action (%p) Failed!!", &action);
action.finish(kernel::resource::Action::State::FAILED);
break;
XBT_DEBUG("Action (%p) Failed!!", &action);
action.finish(kernel::resource::Action::State::FAILED);
break;
@@
-131,9
+133,9
@@
void HostL07Model::update_actions_state(double /*now*/, double delta)
}
}
}
}
-kernel::resource::Action* HostL07Model::execute_parallel(const std::vector<s4u::Host*>& host_list,
- const double* flops_amount, const double* bytes_amount,
- double rate)
+kernel::resource::
Cpu
Action* HostL07Model::execute_parallel(const std::vector<s4u::Host*>& host_list,
+
const double* flops_amount, const double* bytes_amount,
+
double rate)
{
return new L07Action(this, host_list, flops_amount, bytes_amount, rate);
}
{
return new L07Action(this, host_list, flops_amount, bytes_amount, rate);
}
@@
-179,7
+181,7
@@
L07Action::L07Action(kernel::resource::Model* model, const std::vector<s4u::Host
model->get_maxmin_system()->variable_new(this, 1.0, (rate > 0 ? rate : -1.0), host_list.size() + link_nb));
if (latency_ > 0)
model->get_maxmin_system()->variable_new(this, 1.0, (rate > 0 ? rate : -1.0), host_list.size() + link_nb));
if (latency_ > 0)
- model->get_maxmin_system()->update_variable_
weight
(get_variable(), 0.0);
+ model->get_maxmin_system()->update_variable_
penalty
(get_variable(), 0.0);
/* Expand it for the CPUs even if there is nothing to compute, to make sure that it gets expended even if there is no
* communication either */
/* Expand it for the CPUs even if there is nothing to compute, to make sure that it gets expended even if there is no
* communication either */
@@
-208,7
+210,7
@@
L07Action::L07Action(kernel::resource::Model* model, const std::vector<s4u::Host
kernel::resource::Action* NetworkL07Model::communicate(s4u::Host* src, s4u::Host* dst, double size, double rate)
{
std::vector<s4u::Host*> host_list = {src, dst};
kernel::resource::Action* NetworkL07Model::communicate(s4u::Host* src, s4u::Host* dst, double size, double rate)
{
std::vector<s4u::Host*> host_list = {src, dst};
-
double* flops_amount
= new double[2]();
+
const double* flops_amount
= new double[2]();
double* bytes_amount = new double[4]();
bytes_amount[1] = size;
double* bytes_amount = new double[4]();
bytes_amount[1] = size;
@@
-218,15
+220,16
@@
kernel::resource::Action* NetworkL07Model::communicate(s4u::Host* src, s4u::Host
return res;
}
return res;
}
-
Cpu* CpuL07Model::create_cpu(simgrid::
s4u::Host* host, const std::vector<double>& speed_per_pstate, int core)
+
kernel::resource::Cpu* CpuL07Model::create_cpu(
s4u::Host* host, const std::vector<double>& speed_per_pstate, int core)
{
return new CpuL07(this, host, speed_per_pstate, core);
}
{
return new CpuL07(this, host, speed_per_pstate, core);
}
-kernel::resource::LinkImpl* NetworkL07Model::create_link(const std::string& name,
double bandwidth, double latency
,
- s4u::Link::SharingPolicy policy)
+kernel::resource::LinkImpl* NetworkL07Model::create_link(const std::string& name,
const std::vector<double>& bandwidths
,
+
double latency,
s4u::Link::SharingPolicy policy)
{
{
- return new LinkL07(this, name, bandwidth, latency, policy);
+ xbt_assert(bandwidths.size() == 1, "Non WIFI link must have only 1 bandwidth.");
+ return new LinkL07(this, name, bandwidths[0], latency, policy);
}
/************
}
/************
@@
-251,28
+254,28
@@
LinkL07::LinkL07(NetworkL07Model* model, const std::string& name, double bandwid
if (policy == s4u::Link::SharingPolicy::FATPIPE)
get_constraint()->unshare();
if (policy == s4u::Link::SharingPolicy::FATPIPE)
get_constraint()->unshare();
- s4u::Link::on_creation(
this->piface_
);
+ s4u::Link::on_creation(
*get_iface()
);
}
}
-kernel::resource::Action* CpuL07::execution_start(double size)
+kernel::resource::
Cpu
Action* CpuL07::execution_start(double size)
{
std::vector<s4u::Host*> host_list = {get_host()};
double* flops_amount = new double[host_list.size()]();
flops_amount[0] = size;
{
std::vector<s4u::Host*> host_list = {get_host()};
double* flops_amount = new double[host_list.size()]();
flops_amount[0] = size;
- kernel::resource::Action* res =
+ kernel::resource::
Cpu
Action* res =
static_cast<CpuL07Model*>(get_model())->hostModel_->execute_parallel(host_list, flops_amount, nullptr, -1);
static_cast<L07Action*>(res)->free_arrays_ = true;
return res;
}
static_cast<CpuL07Model*>(get_model())->hostModel_->execute_parallel(host_list, flops_amount, nullptr, -1);
static_cast<L07Action*>(res)->free_arrays_ = true;
return res;
}
-kernel::resource::Action* CpuL07::sleep(double duration)
+kernel::resource::
Cpu
Action* CpuL07::sleep(double duration)
{
L07Action *action = static_cast<L07Action*>(execution_start(1.0));
action->set_max_duration(duration);
{
L07Action *action = static_cast<L07Action*>(execution_start(1.0));
action->set_max_duration(duration);
- action->s
uspended_ = kernel::resource::Action::SuspendStates::sleeping
;
- get_model()->get_maxmin_system()->update_variable_
weight
(action->get_variable(), 0.0);
+ action->s
et_suspend_state(kernel::resource::Action::SuspendStates::SLEEPING)
;
+ get_model()->get_maxmin_system()->update_variable_
penalty
(action->get_variable(), 0.0);
return action;
}
return action;
}
@@
-285,12
+288,12
@@
bool CpuL07::is_used()
/** @brief take into account changes of speed (either load or max) */
void CpuL07::on_speed_change()
{
/** @brief take into account changes of speed (either load or max) */
void CpuL07::on_speed_change()
{
-
kernel::lmm::Variable* var = nullpt
r;
+
const kernel::lmm::Variable* va
r;
const kernel::lmm::Element* elem = nullptr;
get_model()->get_maxmin_system()->update_constraint_bound(get_constraint(), speed_.peak * speed_.scale);
while ((var = get_constraint()->get_variable(&elem))) {
const kernel::lmm::Element* elem = nullptr;
get_model()->get_maxmin_system()->update_constraint_bound(get_constraint(), speed_.peak * speed_.scale);
while ((var = get_constraint()->get_variable(&elem))) {
- kernel::resource::Action* action = static_cast<kernel::resource::Action*>(var->get_id());
+
const
kernel::resource::Action* action = static_cast<kernel::resource::Action*>(var->get_id());
get_model()->get_maxmin_system()->update_variable_bound(action->get_variable(), speed_.scale * speed_.peak);
}
get_model()->get_maxmin_system()->update_variable_bound(action->get_variable(), speed_.scale * speed_.peak);
}
@@
-359,7
+362,7
@@
void LinkL07::set_bandwidth(double value)
void LinkL07::set_latency(double value)
{
void LinkL07::set_latency(double value)
{
-
kernel::lmm::Variable* var = nullpt
r;
+
const kernel::lmm::Variable* va
r;
L07Action *action;
const kernel::lmm::Element* elem = nullptr;
L07Action *action;
const kernel::lmm::Element* elem = nullptr;
@@
-392,7
+395,6
@@
void L07Action::updateBound()
if (communicationAmount_ != nullptr) {
for (size_t i = 0; i < host_count; i++) {
for (size_t j = 0; j < host_count; j++) {
if (communicationAmount_ != nullptr) {
for (size_t i = 0; i < host_count; i++) {
for (size_t j = 0; j < host_count; j++) {
-
if (communicationAmount_[i * host_count + j] > 0) {
double lat = 0.0;
std::vector<kernel::resource::LinkImpl*> route;
if (communicationAmount_[i * host_count + j] > 0) {
double lat = 0.0;
std::vector<kernel::resource::LinkImpl*> route;
@@
-405,7
+407,7
@@
void L07Action::updateBound()
}
double lat_bound = kernel::resource::NetworkModel::cfg_tcp_gamma / (2.0 * lat_current);
XBT_DEBUG("action (%p) : lat_bound = %g", this, lat_bound);
}
double lat_bound = kernel::resource::NetworkModel::cfg_tcp_gamma / (2.0 * lat_current);
XBT_DEBUG("action (%p) : lat_bound = %g", this, lat_bound);
- if ((latency_ <= 0.0) &&
(suspended_ == Action::SuspendStates::not_suspended
)) {
+ if ((latency_ <= 0.0) &&
is_running(
)) {
if (rate_ < 0)
get_model()->get_maxmin_system()->update_variable_bound(get_variable(), lat_bound);
else
if (rate_ < 0)
get_model()->get_maxmin_system()->update_variable_bound(get_variable(), lat_bound);
else