#include <boost/algorithm/string.hpp>
#include <boost/algorithm/string/classification.hpp>
#include <boost/algorithm/string/split.hpp>
-#include <simgrid/msg.h>
#include <simgrid/s4u/Engine.hpp>
#include <string>
#include <utility>
double samplingRate() { return sampling_rate; }
};
+/**
+ * The linux kernel doc describes this governor as follows:
+ * https://www.kernel.org/doc/Documentation/cpu-freq/governors.txt
+ *
+ * > The CPUfreq governor "performance" sets the CPU statically to the
+ * > highest frequency within the borders of scaling_min_freq and
+ * > scaling_max_freq.
+ *
+ * We do not support scaling_min_freq/scaling_max_freq -- we just pick the lowest frequency.
+ */
class Performance : public Governor {
public:
explicit Performance(simgrid::s4u::Host* ptr) : Governor(ptr) {}
std::string getName() override { return "Performance"; }
};
+/**
+ * The linux kernel doc describes this governor as follows:
+ * https://www.kernel.org/doc/Documentation/cpu-freq/governors.txt
+ *
+ * > The CPUfreq governor "powersave" sets the CPU statically to the
+ * > lowest frequency within the borders of scaling_min_freq and
+ * > scaling_max_freq.
+ *
+ * We do not support scaling_min_freq/scaling_max_freq -- we just pick the lowest frequency.
+ */
class Powersave : public Governor {
public:
explicit Powersave(simgrid::s4u::Host* ptr) : Governor(ptr) {}
std::string getName() override { return "Powersave"; }
};
+/**
+ * The linux kernel doc describes this governor as follows:
+ * https://www.kernel.org/doc/Documentation/cpu-freq/governors.txt
+ *
+ * > The CPUfreq governor "ondemand" sets the CPU frequency depending on the
+ * > current system load. [...] when triggered, cpufreq checks
+ * > the CPU-usage statistics over the last period and the governor sets the
+ * > CPU accordingly.
+ */
class OnDemand : public Governor {
- double freq_up_threshold = 0.95;
+ /**
+ * See https://elixir.bootlin.com/linux/v4.15.4/source/drivers/cpufreq/cpufreq_ondemand.c
+ * DEF_FREQUENCY_UP_THRESHOLD and od_update()
+ */
+ double freq_up_threshold = 0.80;
public:
explicit OnDemand(simgrid::s4u::Host* ptr) : Governor(ptr) {}
std::string getName() override { return "OnDemand"; }
void update() override
{
- double load = sg_host_get_current_load(host);
+ double load = host->getCoreCount() * sg_host_get_avg_load(host);
+ sg_host_load_reset(host); // Only consider the period between two calls to this method!
- // FIXME I don't like that we multiply with the getCoreCount() just here...
- if (load*host->getCoreCount() > freq_up_threshold) {
+ if (load > freq_up_threshold) {
host->setPstate(0); /* Run at max. performance! */
- XBT_INFO("Load: %f > threshold: %f --> changed to pstate %i", load * host->getCoreCount(), freq_up_threshold, 0);
+ XBT_INFO("Load: %f > threshold: %f --> changed to pstate %i", load, freq_up_threshold, 0);
} else {
/* The actual implementation uses a formula here: (See Kernel file cpufreq_ondemand.c:158)
*
* lowest_pstate - load*pstatesCount()
*/
int max_pstate = host->getPstatesCount() - 1;
- int new_pstate = max_pstate - load * max_pstate;
+ // Load is now < freq_up_threshold; exclude pstate 0 (the fastest)
+ // because pstate 0 can only be selected if load > freq_up_threshold
+ int new_pstate = max_pstate - load * (max_pstate + 1);
host->setPstate(new_pstate);
- XBT_DEBUG("Load: %f --> changed to pstate %i", load*host->getCoreCount(), new_pstate);
+ XBT_DEBUG("Load: %f < threshold: %f --> changed to pstate %i", load, freq_up_threshold, new_pstate);
}
}
};
+/**
+ * This is the conservative governor, which is very similar to the
+ * OnDemand governor. The Linux Kernel Documentation describes it
+ * very well, see https://www.kernel.org/doc/Documentation/cpu-freq/governors.txt:
+ *
+ * > The CPUfreq governor "conservative", much like the "ondemand"
+ * > governor, sets the CPU frequency depending on the current usage. It
+ * > differs in behaviour in that it gracefully increases and decreases the
+ * > CPU speed rather than jumping to max speed the moment there is any load
+ * > on the CPU. This behaviour is more suitable in a battery powered
+ * > environment.
+ */
class Conservative : public Governor {
double freq_up_threshold = .8;
double freq_down_threshold = .2;
virtual std::string getName() override { return "Conservative"; }
virtual void update() override
{
- double load = sg_host_get_current_load(host)*host->getCoreCount();
+ double load = host->getCoreCount() * sg_host_get_avg_load(host);
int pstate = host->getPstate();
+ sg_host_load_reset(host); // Only consider the period between two calls to this method!
if (load > freq_up_threshold) {
if (pstate != 0) {
}
};
+/**
+ * Add this to your host tag:
+ * - <prop id="plugin/dvfs/governor" value="performance" />
+ *
+ * Valid values as of now are: performance, powersave, ondemand, conservative
+ * It doesn't matter if you use uppercase or lowercase.
+ *
+ * For the sampling rate, use this:
+ *
+ * - <prop id="plugin/dvfs/sampling_rate" value="2" />
+ *
+ * This will run the update() method of the specified governor every 2 seconds
+ * on that host.
+ *
+ * These properties can also be used within the <config> tag to configure
+ * these values globally. Using them within the <host> will overwrite this
+ * global configuration
+ */
class HostDvfs {
public:
static simgrid::xbt::Extension<simgrid::s4u::Host, HostDvfs> EXTENSION_ID;
if (dynamic_cast<simgrid::s4u::VirtualMachine*>(&host)) // Ignore virtual machines
return;
- std::string name = std::string("dvfs-daemon-") + host.getCname();
+ std::string name = std::string("dvfs-daemon-") + host.get_cname();
simgrid::s4u::ActorPtr daemon = simgrid::s4u::Actor::createActor(name.c_str(), &host, []() {
/**
* This lambda function is the function the actor (daemon) will execute
*/
simgrid::s4u::ActorPtr daemonProc = simgrid::s4u::Actor::self();
- XBT_DEBUG("DVFS process on %s is a daemon: %d", daemonProc->getHost()->getName().c_str(), daemonProc->isDaemon());
+ XBT_DEBUG("DVFS process on %s is a daemon: %d", daemonProc->getHost()->get_cname(), daemonProc->isDaemon());
std::string dvfs_governor;
const char* host_conf = daemonProc->getHost()->getProperty(property_governor);
new simgrid::plugin::dvfs::Powersave(daemonProc->getHost()));
} else {
XBT_CRITICAL("No governor specified for host %s, falling back to Performance",
- daemonProc->getHost()->getCname());
+ daemonProc->getHost()->get_cname());
return std::unique_ptr<simgrid::plugin::dvfs::Governor>(
new simgrid::plugin::dvfs::Performance(daemonProc->getHost()));
}
}
/* **************************** Public interface *************************** */
-extern "C" {
/** \ingroup SURF_plugin_load
* \brief Initializes the HostDvfs plugin
xbt_cfg_register_string(property_governor, "performance", nullptr,
"Which Governor should be used that adapts the CPU frequency?");
}
-}