XBT_LOG_EXTERNAL_DEFAULT_CATEGORY(smpi_pmpi);
+#define CHECK_ARGS(test, errcode, ...) \
+ if (test) { \
+ XBT_WARN(__VA_ARGS__); \
+ return errcode; \
+ }
+
/* PMPI User level calls */
int PMPI_Barrier(MPI_Comm comm)
return MPI_ERR_ARG;
smpi_bench_end();
- const char* sendtmpbuf = static_cast<const char*>(sendbuf);
- int sendtmpcount = sendcount;
- MPI_Datatype sendtmptype = sendtype;
+ const void* real_sendbuf = sendbuf;
+ int real_sendcount = sendcount;
+ MPI_Datatype real_sendtype = sendtype;
if ((comm->rank() == root) && (sendbuf == MPI_IN_PLACE)) {
- sendtmpcount = 0;
- sendtmptype = recvtype;
+ real_sendcount = 0;
+ real_sendtype = recvtype;
}
int rank = simgrid::s4u::this_actor::get_pid();
TRACE_smpi_comm_in(rank, request == MPI_REQUEST_IGNORED ? "PMPI_Gather" : "PMPI_Igather",
new simgrid::instr::CollTIData(
request == MPI_REQUEST_IGNORED ? "gather" : "igather", root, -1.0,
- sendtmptype->is_replayable() ? sendtmpcount : sendtmpcount * sendtmptype->size(),
+ real_sendtype->is_replayable() ? real_sendcount : real_sendcount * real_sendtype->size(),
(comm->rank() != root || recvtype->is_replayable()) ? recvcount : recvcount * recvtype->size(),
- simgrid::smpi::Datatype::encode(sendtmptype), simgrid::smpi::Datatype::encode(recvtype)));
+ simgrid::smpi::Datatype::encode(real_sendtype), simgrid::smpi::Datatype::encode(recvtype)));
if (request == MPI_REQUEST_IGNORED)
- simgrid::smpi::Colls::gather(sendtmpbuf, sendtmpcount, sendtmptype, recvbuf, recvcount, recvtype, root, comm);
+ simgrid::smpi::Colls::gather(real_sendbuf, real_sendcount, real_sendtype, recvbuf, recvcount, recvtype, root, comm);
else
- simgrid::smpi::Colls::igather(sendtmpbuf, sendtmpcount, sendtmptype, recvbuf, recvcount, recvtype, root, comm,
+ simgrid::smpi::Colls::igather(real_sendbuf, real_sendcount, real_sendtype, recvbuf, recvcount, recvtype, root, comm,
request);
TRACE_smpi_comm_out(rank);
}
smpi_bench_end();
- const char* sendtmpbuf = static_cast<const char*>(sendbuf);
- int sendtmpcount = sendcount;
- MPI_Datatype sendtmptype = sendtype;
+ const void* real_sendbuf = sendbuf;
+ int real_sendcount = sendcount;
+ MPI_Datatype real_sendtype = sendtype;
if ((comm->rank() == root) && (sendbuf == MPI_IN_PLACE)) {
- sendtmpcount = 0;
- sendtmptype = recvtype;
+ real_sendcount = 0;
+ real_sendtype = recvtype;
}
int rank = simgrid::s4u::this_actor::get_pid();
TRACE_smpi_comm_in(rank, request == MPI_REQUEST_IGNORED ? "PMPI_Gatherv" : "PMPI_Igatherv",
new simgrid::instr::VarCollTIData(
request == MPI_REQUEST_IGNORED ? "gatherv" : "igatherv", root,
- sendtmptype->is_replayable() ? sendtmpcount : sendtmpcount * sendtmptype->size(), nullptr,
- dt_size_recv, trace_recvcounts, simgrid::smpi::Datatype::encode(sendtmptype),
+ real_sendtype->is_replayable() ? real_sendcount : real_sendcount * real_sendtype->size(),
+ nullptr, dt_size_recv, trace_recvcounts, simgrid::smpi::Datatype::encode(real_sendtype),
simgrid::smpi::Datatype::encode(recvtype)));
if (request == MPI_REQUEST_IGNORED)
- simgrid::smpi::Colls::gatherv(sendtmpbuf, sendtmpcount, sendtmptype, recvbuf, recvcounts, displs, recvtype, root,
- comm);
+ simgrid::smpi::Colls::gatherv(real_sendbuf, real_sendcount, real_sendtype, recvbuf, recvcounts, displs, recvtype,
+ root, comm);
else
- simgrid::smpi::Colls::igatherv(sendtmpbuf, sendtmpcount, sendtmptype, recvbuf, recvcounts, displs, recvtype, root,
- comm, request);
+ simgrid::smpi::Colls::igatherv(real_sendbuf, real_sendcount, real_sendtype, recvbuf, recvcounts, displs, recvtype,
+ root, comm, request);
TRACE_smpi_comm_out(rank);
smpi_bench_begin();
int PMPI_Iscatterv(const void* sendbuf, const int* sendcounts, const int* displs, MPI_Datatype sendtype, void* recvbuf, int recvcount,
MPI_Datatype recvtype, int root, MPI_Comm comm, MPI_Request* request)
{
- if (comm == MPI_COMM_NULL)
- return MPI_ERR_COMM;
- if (sendcounts == nullptr || displs == nullptr)
- return MPI_ERR_ARG;
- if (((comm->rank() == root) && (sendtype == MPI_DATATYPE_NULL)) ||
- ((recvbuf != MPI_IN_PLACE) && (recvtype == MPI_DATATYPE_NULL)))
- return MPI_ERR_TYPE;
- if (request == nullptr)
- return MPI_ERR_ARG;
- if (recvbuf != MPI_IN_PLACE && recvcount < 0)
- return MPI_ERR_COUNT;
- if (root < 0 || root >= comm->size())
- return MPI_ERR_ROOT;
+ CHECK_ARGS(comm == MPI_COMM_NULL, MPI_ERR_COMM, "Iscatterv: the communicator cannot be MPI_COMM_NULL");
+ CHECK_ARGS((comm->rank() == root) && (sendcounts == nullptr), MPI_ERR_ARG,
+ "Iscatterv: param 2 sendcounts cannot be NULL on the root rank");
+ CHECK_ARGS((comm->rank() == root) && (displs == nullptr), MPI_ERR_ARG,
+ "Iscatterv: param 3 displs cannot be NULL on the root rank");
+ CHECK_ARGS((comm->rank() == root) && (sendtype == MPI_DATATYPE_NULL), MPI_ERR_TYPE,
+ "Iscatterv: The sendtype cannot be NULL on the root rank");
+ CHECK_ARGS((recvbuf != MPI_IN_PLACE) && (recvtype == MPI_DATATYPE_NULL), MPI_ERR_TYPE,
+ "Iscatterv: the recvtype cannot be NULL when not receiving in place");
+ CHECK_ARGS(request == nullptr, MPI_ERR_ARG, "Iscatterv: param 10 request cannot be NULL");
+ CHECK_ARGS(recvbuf != MPI_IN_PLACE && recvcount < 0, MPI_ERR_COUNT,
+ "Iscatterv: When not receiving in place, the recvcound cannot be negative");
+ CHECK_ARGS(root < 0, MPI_ERR_ROOT, "Iscatterv: root cannot be negative");
+ CHECK_ARGS(root >= comm->size(), MPI_ERR_ROOT, "Iscatterv: root (=%d) is larger than communicator size (=%d)", root,
+ comm->size());
if (comm->rank() == root) {
if (recvbuf == MPI_IN_PLACE) {
recvtype = sendtype;
recvcount = sendcounts[comm->rank()];
}
- for (int i = 0; i < comm->size(); i++) {
- if (sendcounts[i] < 0)
- return MPI_ERR_COUNT;
- }
+ for (int i = 0; i < comm->size(); i++)
+ CHECK_ARGS(sendcounts[i] < 0, MPI_ERR_COUNT, "Iscatterv: sendcounts[%d]=%d but this cannot be negative", i,
+ sendcounts[i]);
}
smpi_bench_end();
return MPI_ERR_ARG;
smpi_bench_end();
- const char* sendtmpbuf = static_cast<const char*>(sendbuf);
+ const void* real_sendbuf = sendbuf;
+ std::unique_ptr<unsigned char[]> tmp_sendbuf;
if (sendbuf == MPI_IN_PLACE) {
- sendtmpbuf = static_cast<char*>(xbt_malloc(count * datatype->get_extent()));
- simgrid::smpi::Datatype::copy(recvbuf, count, datatype, const_cast<char*>(sendtmpbuf), count, datatype);
+ tmp_sendbuf.reset(new unsigned char[count * datatype->get_extent()]);
+ simgrid::smpi::Datatype::copy(recvbuf, count, datatype, tmp_sendbuf.get(), count, datatype);
+ real_sendbuf = tmp_sendbuf.get();
}
int rank = simgrid::s4u::this_actor::get_pid();
simgrid::smpi::Datatype::encode(datatype), ""));
if (request == MPI_REQUEST_IGNORED)
- simgrid::smpi::Colls::allreduce(sendtmpbuf, recvbuf, count, datatype, op, comm);
+ simgrid::smpi::Colls::allreduce(real_sendbuf, recvbuf, count, datatype, op, comm);
else
- simgrid::smpi::Colls::iallreduce(sendtmpbuf, recvbuf, count, datatype, op, comm, request);
-
- if (sendbuf == MPI_IN_PLACE)
- xbt_free(const_cast<char*>(sendtmpbuf));
+ simgrid::smpi::Colls::iallreduce(real_sendbuf, recvbuf, count, datatype, op, comm, request);
TRACE_smpi_comm_out(rank);
smpi_bench_begin();
smpi_bench_end();
int rank = simgrid::s4u::this_actor::get_pid();
- const void* sendtmpbuf = sendbuf;
+ const void* real_sendbuf = sendbuf;
+ std::unique_ptr<unsigned char[]> tmp_sendbuf;
if (sendbuf == MPI_IN_PLACE) {
- sendtmpbuf = static_cast<const void*>(xbt_malloc(count * datatype->size()));
- memcpy(const_cast<void*>(sendtmpbuf), recvbuf, count * datatype->size());
+ tmp_sendbuf.reset(new unsigned char[count * datatype->size()]);
+ real_sendbuf = memcpy(tmp_sendbuf.get(), recvbuf, count * datatype->size());
}
TRACE_smpi_comm_in(rank, request == MPI_REQUEST_IGNORED ? "PMPI_Scan" : "PMPI_Iscan",
new simgrid::instr::Pt2PtTIData(request == MPI_REQUEST_IGNORED ? "scan" : "iscan", -1,
int retval;
if (request == MPI_REQUEST_IGNORED)
- retval = simgrid::smpi::Colls::scan(sendtmpbuf, recvbuf, count, datatype, op, comm);
+ retval = simgrid::smpi::Colls::scan(real_sendbuf, recvbuf, count, datatype, op, comm);
else
- retval = simgrid::smpi::Colls::iscan(sendtmpbuf, recvbuf, count, datatype, op, comm, request);
+ retval = simgrid::smpi::Colls::iscan(real_sendbuf, recvbuf, count, datatype, op, comm, request);
TRACE_smpi_comm_out(rank);
- if (sendbuf == MPI_IN_PLACE)
- xbt_free(const_cast<void*>(sendtmpbuf));
smpi_bench_begin();
return retval;
}
smpi_bench_end();
int rank = simgrid::s4u::this_actor::get_pid();
- const void* sendtmpbuf = sendbuf;
+ const void* real_sendbuf = sendbuf;
+ std::unique_ptr<unsigned char[]> tmp_sendbuf;
if (sendbuf == MPI_IN_PLACE) {
- sendtmpbuf = static_cast<const void*>(xbt_malloc(count * datatype->size()));
- memcpy(const_cast<void*>(sendtmpbuf), recvbuf, count * datatype->size());
+ tmp_sendbuf.reset(new unsigned char[count * datatype->size()]);
+ real_sendbuf = memcpy(tmp_sendbuf.get(), recvbuf, count * datatype->size());
}
TRACE_smpi_comm_in(rank, request == MPI_REQUEST_IGNORED ? "PMPI_Exscan" : "PMPI_Iexscan",
int retval;
if (request == MPI_REQUEST_IGNORED)
- retval = simgrid::smpi::Colls::exscan(sendtmpbuf, recvbuf, count, datatype, op, comm);
+ retval = simgrid::smpi::Colls::exscan(real_sendbuf, recvbuf, count, datatype, op, comm);
else
- retval = simgrid::smpi::Colls::iexscan(sendtmpbuf, recvbuf, count, datatype, op, comm, request);
+ retval = simgrid::smpi::Colls::iexscan(real_sendbuf, recvbuf, count, datatype, op, comm, request);
TRACE_smpi_comm_out(rank);
- if (sendbuf == MPI_IN_PLACE)
- xbt_free(const_cast<void*>(sendtmpbuf));
smpi_bench_begin();
return retval;
}
totalcount += recvcounts[i];
}
- const void* sendtmpbuf = sendbuf;
+ const void* real_sendbuf = sendbuf;
+ std::unique_ptr<unsigned char[]> tmp_sendbuf;
if (sendbuf == MPI_IN_PLACE) {
- sendtmpbuf = static_cast<const void*>(xbt_malloc(totalcount * datatype->size()));
- memcpy(const_cast<void*>(sendtmpbuf), recvbuf, totalcount * datatype->size());
+ tmp_sendbuf.reset(new unsigned char[totalcount * datatype->size()]);
+ real_sendbuf = memcpy(tmp_sendbuf.get(), recvbuf, totalcount * datatype->size());
}
TRACE_smpi_comm_in(rank, request == MPI_REQUEST_IGNORED ? "PMPI_Reduce_scatter" : "PMPI_Ireduce_scatter",
-1, trace_recvcounts, simgrid::smpi::Datatype::encode(datatype), ""));
if (request == MPI_REQUEST_IGNORED)
- simgrid::smpi::Colls::reduce_scatter(sendtmpbuf, recvbuf, recvcounts, datatype, op, comm);
+ simgrid::smpi::Colls::reduce_scatter(real_sendbuf, recvbuf, recvcounts, datatype, op, comm);
else
- simgrid::smpi::Colls::ireduce_scatter(sendtmpbuf, recvbuf, recvcounts, datatype, op, comm, request);
+ simgrid::smpi::Colls::ireduce_scatter(real_sendbuf, recvbuf, recvcounts, datatype, op, comm, request);
TRACE_smpi_comm_out(rank);
- if (sendbuf == MPI_IN_PLACE)
- xbt_free(const_cast<void*>(sendtmpbuf));
smpi_bench_begin();
return MPI_SUCCESS;
}
int dt_send_size = datatype->is_replayable() ? 1 : datatype->size();
std::vector<int>* trace_recvcounts = new std::vector<int>(recvcount * dt_send_size); // copy data to avoid bad free
- const void* sendtmpbuf = sendbuf;
+ const void* real_sendbuf = sendbuf;
+ std::unique_ptr<unsigned char[]> tmp_sendbuf;
if (sendbuf == MPI_IN_PLACE) {
- sendtmpbuf = static_cast<const void*>(xbt_malloc(recvcount * count * datatype->size()));
- memcpy(const_cast<void*>(sendtmpbuf), recvbuf, recvcount * count * datatype->size());
+ tmp_sendbuf.reset(new unsigned char[recvcount * count * datatype->size()]);
+ real_sendbuf = memcpy(tmp_sendbuf.get(), recvbuf, recvcount * count * datatype->size());
}
TRACE_smpi_comm_in(
for (int i = 0; i < count; i++)
recvcounts[i] = recvcount;
if (request == MPI_REQUEST_IGNORED)
- simgrid::smpi::Colls::reduce_scatter(sendtmpbuf, recvbuf, recvcounts, datatype, op, comm);
+ simgrid::smpi::Colls::reduce_scatter(real_sendbuf, recvbuf, recvcounts, datatype, op, comm);
else
- simgrid::smpi::Colls::ireduce_scatter(sendtmpbuf, recvbuf, recvcounts, datatype, op, comm, request);
+ simgrid::smpi::Colls::ireduce_scatter(real_sendbuf, recvbuf, recvcounts, datatype, op, comm, request);
delete[] recvcounts;
TRACE_smpi_comm_out(rank);
- if (sendbuf == MPI_IN_PLACE)
- xbt_free(const_cast<void*>(sendtmpbuf));
smpi_bench_begin();
return MPI_SUCCESS;
}
smpi_bench_end();
int rank = simgrid::s4u::this_actor::get_pid();
- const void* sendtmpbuf = static_cast<const char*>(sendbuf);
- int sendtmpcount = sendcount;
- MPI_Datatype sendtmptype = sendtype;
+ const void* real_sendbuf = sendbuf;
+ int real_sendcount = sendcount;
+ MPI_Datatype real_sendtype = sendtype;
+ std::unique_ptr<unsigned char[]> tmp_sendbuf;
if (sendbuf == MPI_IN_PLACE) {
- sendtmpbuf = static_cast<void*>(xbt_malloc(recvcount * comm->size() * recvtype->size()));
+ tmp_sendbuf.reset(new unsigned char[recvcount * comm->size() * recvtype->size()]);
// memcpy(??,nullptr,0) is actually undefined behavor, even if harmless.
if (recvbuf != nullptr)
- memcpy(const_cast<void*>(sendtmpbuf), recvbuf, recvcount * comm->size() * recvtype->size());
- sendtmpcount = recvcount;
- sendtmptype = recvtype;
+ memcpy(tmp_sendbuf.get(), recvbuf, recvcount * comm->size() * recvtype->size());
+ real_sendbuf = tmp_sendbuf.get();
+ real_sendcount = recvcount;
+ real_sendtype = recvtype;
}
TRACE_smpi_comm_in(rank, request == MPI_REQUEST_IGNORED ? "PMPI_Alltoall" : "PMPI_Ialltoall",
new simgrid::instr::CollTIData(
request == MPI_REQUEST_IGNORED ? "alltoall" : "ialltoall", -1, -1.0,
- sendtmptype->is_replayable() ? sendtmpcount : sendtmpcount * sendtmptype->size(),
+ real_sendtype->is_replayable() ? real_sendcount : real_sendcount * real_sendtype->size(),
recvtype->is_replayable() ? recvcount : recvcount * recvtype->size(),
- simgrid::smpi::Datatype::encode(sendtmptype), simgrid::smpi::Datatype::encode(recvtype)));
+ simgrid::smpi::Datatype::encode(real_sendtype), simgrid::smpi::Datatype::encode(recvtype)));
int retval;
if (request == MPI_REQUEST_IGNORED)
- retval = simgrid::smpi::Colls::alltoall(sendtmpbuf, sendtmpcount, sendtmptype, recvbuf, recvcount, recvtype, comm);
+ retval =
+ simgrid::smpi::Colls::alltoall(real_sendbuf, real_sendcount, real_sendtype, recvbuf, recvcount, recvtype, comm);
else
- retval = simgrid::smpi::Colls::ialltoall(sendtmpbuf, sendtmpcount, sendtmptype, recvbuf, recvcount, recvtype, comm,
- request);
+ retval = simgrid::smpi::Colls::ialltoall(real_sendbuf, real_sendcount, real_sendtype, recvbuf, recvcount, recvtype,
+ comm, request);
TRACE_smpi_comm_out(rank);
- if (sendbuf == MPI_IN_PLACE)
- xbt_free(const_cast<void*>(sendtmpbuf));
smpi_bench_begin();
return retval;
}
std::vector<int>* trace_recvcounts = new std::vector<int>;
int dt_size_recv = recvtype->size();
- const void* sendtmpbuf = static_cast<const char*>(sendbuf);
- const int* sendtmpcounts = sendcounts;
- const int* sendtmpdisps = senddisps;
- MPI_Datatype sendtmptype = sendtype;
+ const void* real_sendbuf = sendbuf;
+ const int* real_sendcounts = sendcounts;
+ const int* real_senddisps = senddisps;
+ MPI_Datatype real_sendtype = sendtype;
int maxsize = 0;
for (int i = 0; i < size; i++) { // copy data to avoid bad free
recv_size += recvcounts[i] * dt_size_recv;
maxsize = (recvdisps[i] + recvcounts[i]) * dt_size_recv;
}
+ std::unique_ptr<unsigned char[]> tmp_sendbuf;
+ std::unique_ptr<int[]> tmp_sendcounts;
+ std::unique_ptr<int[]> tmp_senddisps;
if (sendbuf == MPI_IN_PLACE) {
- sendtmpbuf = static_cast<void*>(xbt_malloc(maxsize));
- memcpy(const_cast<void*>(sendtmpbuf), recvbuf, maxsize);
- sendtmpcounts = static_cast<int*>(xbt_malloc(size * sizeof(int)));
- memcpy(const_cast<int*>(sendtmpcounts), recvcounts, size * sizeof(int));
- sendtmpdisps = static_cast<int*>(xbt_malloc(size * sizeof(int)));
- memcpy(const_cast<int*>(sendtmpdisps), recvdisps, size * sizeof(int));
- sendtmptype = recvtype;
+ tmp_sendbuf.reset(new unsigned char[maxsize]);
+ real_sendbuf = memcpy(tmp_sendbuf.get(), recvbuf, maxsize);
+ tmp_sendcounts.reset(new int[size]);
+ std::copy(recvcounts, recvcounts + size, tmp_sendcounts.get());
+ real_sendcounts = tmp_sendcounts.get();
+ tmp_senddisps.reset(new int[size]);
+ std::copy(recvdisps, recvdisps + size, tmp_senddisps.get());
+ real_senddisps = tmp_senddisps.get();
+ real_sendtype = recvtype;
}
- int dt_size_send = sendtmptype->size();
+ int dt_size_send = real_sendtype->size();
for (int i = 0; i < size; i++) { // copy data to avoid bad free
- send_size += sendtmpcounts[i] * dt_size_send;
- trace_sendcounts->push_back(sendtmpcounts[i] * dt_size_send);
+ send_size += real_sendcounts[i] * dt_size_send;
+ trace_sendcounts->push_back(real_sendcounts[i] * dt_size_send);
}
TRACE_smpi_comm_in(rank, request == MPI_REQUEST_IGNORED ? "PMPI_Alltoallv" : "PMPI_Ialltoallv",
new simgrid::instr::VarCollTIData(request == MPI_REQUEST_IGNORED ? "alltoallv" : "ialltoallv", -1,
send_size, trace_sendcounts, recv_size, trace_recvcounts,
- simgrid::smpi::Datatype::encode(sendtmptype),
+ simgrid::smpi::Datatype::encode(real_sendtype),
simgrid::smpi::Datatype::encode(recvtype)));
int retval;
if (request == MPI_REQUEST_IGNORED)
- retval = simgrid::smpi::Colls::alltoallv(sendtmpbuf, sendtmpcounts, sendtmpdisps, sendtmptype, recvbuf, recvcounts,
- recvdisps, recvtype, comm);
+ retval = simgrid::smpi::Colls::alltoallv(real_sendbuf, real_sendcounts, real_senddisps, real_sendtype, recvbuf,
+ recvcounts, recvdisps, recvtype, comm);
else
- retval = simgrid::smpi::Colls::ialltoallv(sendtmpbuf, sendtmpcounts, sendtmpdisps, sendtmptype, recvbuf, recvcounts,
- recvdisps, recvtype, comm, request);
+ retval = simgrid::smpi::Colls::ialltoallv(real_sendbuf, real_sendcounts, real_senddisps, real_sendtype, recvbuf,
+ recvcounts, recvdisps, recvtype, comm, request);
TRACE_smpi_comm_out(rank);
- if (sendbuf == MPI_IN_PLACE) {
- xbt_free(const_cast<void*>(sendtmpbuf));
- xbt_free(const_cast<int*>(sendtmpcounts));
- xbt_free(const_cast<int*>(sendtmpdisps));
- }
smpi_bench_begin();
return retval;
}
std::vector<int>* trace_sendcounts = new std::vector<int>;
std::vector<int>* trace_recvcounts = new std::vector<int>;
- const void* sendtmpbuf = static_cast<const char*>(sendbuf);
- const int* sendtmpcounts = sendcounts;
- const int* sendtmpdisps = senddisps;
- const MPI_Datatype* sendtmptypes = sendtypes;
+ const void* real_sendbuf = sendbuf;
+ const int* real_sendcounts = sendcounts;
+ const int* real_senddisps = senddisps;
+ const MPI_Datatype* real_sendtypes = sendtypes;
unsigned long maxsize = 0;
for (int i = 0; i < size; i++) { // copy data to avoid bad free
if (recvtypes[i] == MPI_DATATYPE_NULL) {
maxsize = recvdisps[i] + (recvcounts[i] * recvtypes[i]->size());
}
+ std::unique_ptr<unsigned char[]> tmp_sendbuf;
+ std::unique_ptr<int[]> tmp_sendcounts;
+ std::unique_ptr<int[]> tmp_senddisps;
+ std::unique_ptr<MPI_Datatype[]> tmp_sendtypes;
if (sendbuf == MPI_IN_PLACE) {
- sendtmpbuf = static_cast<void*>(xbt_malloc(maxsize));
- memcpy(const_cast<void*>(sendtmpbuf), recvbuf, maxsize);
- sendtmpcounts = static_cast<int*>(xbt_malloc(size * sizeof(int)));
- memcpy(const_cast<int*>(sendtmpcounts), recvcounts, size * sizeof(int));
- sendtmpdisps = static_cast<int*>(xbt_malloc(size * sizeof(int)));
- memcpy(const_cast<int*>(sendtmpdisps), recvdisps, size * sizeof(int));
- sendtmptypes = static_cast<MPI_Datatype*>(xbt_malloc(size * sizeof(MPI_Datatype)));
- memcpy(const_cast<MPI_Datatype*>(sendtmptypes), recvtypes, size * sizeof(MPI_Datatype));
+ tmp_sendbuf.reset(new unsigned char[maxsize]);
+ real_sendbuf = memcpy(tmp_sendbuf.get(), recvbuf, maxsize);
+ tmp_sendcounts.reset(new int[size]);
+ std::copy(recvcounts, recvcounts + size, tmp_sendcounts.get());
+ real_sendcounts = tmp_sendcounts.get();
+ tmp_senddisps.reset(new int[size]);
+ std::copy(recvdisps, recvdisps + size, tmp_senddisps.get());
+ real_senddisps = tmp_senddisps.get();
+ tmp_sendtypes.reset(new MPI_Datatype[size]);
+ std::copy(recvtypes, recvtypes + size, tmp_sendtypes.get());
+ real_sendtypes = tmp_sendtypes.get();
}
for (int i = 0; i < size; i++) { // copy data to avoid bad free
- send_size += sendtmpcounts[i] * sendtmptypes[i]->size();
- trace_sendcounts->push_back(sendtmpcounts[i] * sendtmptypes[i]->size());
+ send_size += real_sendcounts[i] * real_sendtypes[i]->size();
+ trace_sendcounts->push_back(real_sendcounts[i] * real_sendtypes[i]->size());
}
TRACE_smpi_comm_in(rank, request == MPI_REQUEST_IGNORED ? "PMPI_Alltoallw" : "PMPI_Ialltoallw",
new simgrid::instr::VarCollTIData(request == MPI_REQUEST_IGNORED ? "alltoallv" : "ialltoallv", -1,
send_size, trace_sendcounts, recv_size, trace_recvcounts,
- simgrid::smpi::Datatype::encode(sendtmptypes[0]),
+ simgrid::smpi::Datatype::encode(real_sendtypes[0]),
simgrid::smpi::Datatype::encode(recvtypes[0])));
int retval;
if (request == MPI_REQUEST_IGNORED)
- retval = simgrid::smpi::Colls::alltoallw(sendtmpbuf, sendtmpcounts, sendtmpdisps, sendtmptypes, recvbuf, recvcounts,
- recvdisps, recvtypes, comm);
+ retval = simgrid::smpi::Colls::alltoallw(real_sendbuf, real_sendcounts, real_senddisps, real_sendtypes, recvbuf,
+ recvcounts, recvdisps, recvtypes, comm);
else
- retval = simgrid::smpi::Colls::ialltoallw(sendtmpbuf, sendtmpcounts, sendtmpdisps, sendtmptypes, recvbuf,
+ retval = simgrid::smpi::Colls::ialltoallw(real_sendbuf, real_sendcounts, real_senddisps, real_sendtypes, recvbuf,
recvcounts, recvdisps, recvtypes, comm, request);
TRACE_smpi_comm_out(rank);
- if (sendbuf == MPI_IN_PLACE) {
- xbt_free(const_cast<void*>(sendtmpbuf));
- xbt_free(const_cast<int*>(sendtmpcounts));
- xbt_free(const_cast<int*>(sendtmpdisps));
- xbt_free(const_cast<MPI_Datatype*>(sendtmptypes));
- }
smpi_bench_begin();
return retval;
}
