give access to disk's read and write (nomimal) bandwidth values

[simgrid.git] / include / simgrid / s4u / Disk.hpp

diff --git a/include/simgrid/s4u/Disk.hpp b/include/simgrid/s4u/Disk.hpp
index 70c5bf2..78c4115 100644 (file)
--- a/include/simgrid/s4u/Disk.hpp
+++ b/include/simgrid/s4u/Disk.hpp
@@ -26,38 +26,35 @@ namespace s4u {
  */
 
 class XBT_PUBLIC Disk : public xbt::Extendable<Disk> {
+  kernel::resource::DiskImpl* const pimpl_;
+  std::string name_;
   friend Engine;
   friend Io;
   friend kernel::resource::DiskImpl;
 
-public:
-  explicit Disk(const std::string& name, kernel::resource::DiskImpl* pimpl) : pimpl_(pimpl), name_(name) {}
-
 protected:
   virtual ~Disk() = default;
 
 public:
-  /** @brief Callback signal fired when a new Storage is created */
+  explicit Disk(const std::string& name, kernel::resource::DiskImpl* pimpl) : pimpl_(pimpl), name_(name) {}
+
+  /** @brief Callback signal fired when a new Disk is created */
   static xbt::signal<void(Disk&)> on_creation;
-  /** @brief Callback signal fired when a Storage is destroyed */
+  /** @brief Callback signal fired when a Disk is destroyed */
   static xbt::signal<void(Disk const&)> on_destruction;
-  /** @brief Callback signal fired when a Storage's state changes */
+  /** @brief Callback signal fired when a Disk's state changes */
   static xbt::signal<void(Disk const&)> on_state_change;
 
-  /** @brief Retrieves the name of that storage as a C++ string */
+  /** @brief Retrieves the name of that disk as a C++ string */
   std::string const& get_name() const { return name_; }
-  /** @brief Retrieves the name of that storage as a C string */
+  /** @brief Retrieves the name of that disk as a C string */
   const char* get_cname() const { return name_.c_str(); }
-
-  Host* get_host() { return attached_to_; };
-  void set_host(Host* host) { attached_to_ = host; }
-
+  double get_read_bandwidth() const;
+  double get_write_bandwidth();
   const std::unordered_map<std::string, std::string>* get_properties() const;
   const char* get_property(const std::string& key) const;
   void set_property(const std::string&, const std::string& value);
-
-  void set_data(void* data) { userdata_ = data; }
-  void* get_data() { return userdata_; }
+  Host* get_host();
 
   IoPtr io_init(sg_size_t size, s4u::Io::OpType type);
 
@@ -67,12 +64,6 @@ public:
   IoPtr write_async(sg_size_t size);
   sg_size_t write(sg_size_t size);
   kernel::resource::DiskImpl* get_impl() const { return pimpl_; }
-
-private:
-  Host* attached_to_ = nullptr;
-  kernel::resource::DiskImpl* const pimpl_;
-  std::string name_;
-  void* userdata_ = nullptr;
 };
 
 } // namespace s4u