sonar: throw static exceptions

[simgrid.git] / src / kernel / activity / ExecImpl.cpp

diff --git a/src/kernel/activity/ExecImpl.cpp b/src/kernel/activity/ExecImpl.cpp
index 95a4e38..9dba149 100644 (file)
--- a/src/kernel/activity/ExecImpl.cpp
+++ b/src/kernel/activity/ExecImpl.cpp
@@ -21,32 +21,44 @@ simgrid::kernel::activity::ExecImpl::ExecImpl(const char* name, sg_host_t host)
 
 simgrid::kernel::activity::ExecImpl::~ExecImpl()
 {
-  if (surf_exec)
-    surf_exec->unref();
+  if (surfAction_)
+    surfAction_->unref();
   if (timeoutDetector)
     timeoutDetector->unref();
   XBT_DEBUG("Destroy exec %p", this);
 }
 void simgrid::kernel::activity::ExecImpl::suspend()
 {
-  XBT_VERB("This exec is suspended (remain: %f)", surf_exec->getRemains());
-  if (surf_exec)
-    surf_exec->suspend();
+  XBT_VERB("This exec is suspended (remain: %f)", surfAction_->getRemains());
+  if (surfAction_)
+    surfAction_->suspend();
 }
 
 void simgrid::kernel::activity::ExecImpl::resume()
 {
-  XBT_VERB("This exec is resumed (remain: %f)", surf_exec->getRemains());
-  if (surf_exec)
-    surf_exec->resume();
+  XBT_VERB("This exec is resumed (remain: %f)", surfAction_->getRemains());
+  if (surfAction_)
+    surfAction_->resume();
 }
 
 double simgrid::kernel::activity::ExecImpl::remains()
 {
-  if (state == SIMIX_RUNNING)
-    return surf_exec->getRemains();
+  static std::logic_error e(
+      "The remaining work on parallel tasks cannot be defined as a scalar amount of flops (it's a vector). "
+      "So parallel_task->remains() is not defined. "
+      "You are probably looking for parallel_task->remainingRatio().");
 
-  return 0;
+  if (host_ == nullptr) // parallel task: their remain is not in flops (we'd need a vector for that, not a scalar)
+    throw &e;
+  else // sequential task: everything's fine
+    return surfAction_->getRemains();
+}
+double simgrid::kernel::activity::ExecImpl::remainingRatio()
+{
+  if (host_ == nullptr) // parallel task: their remain is already between 0 and 1 (see comment in ExecImpl::remains())
+    return surfAction_->getRemains();
+  else // Actually compute the ratio for sequential tasks
+    return surfAction_->getRemains() / surfAction_->getCost();
 }
 
 void simgrid::kernel::activity::ExecImpl::post()
@@ -55,7 +67,7 @@ void simgrid::kernel::activity::ExecImpl::post()
                                  /* If the host running the synchro failed, notice it. This way, the asking
                                   * process can be killed if it runs on that host itself */
     state = SIMIX_FAILED;
-  } else if (surf_exec->getState() == simgrid::surf::Action::State::failed) {
+  } else if (surfAction_->getState() == simgrid::surf::Action::State::failed) {
     /* If the host running the synchro didn't fail, then the synchro was canceled */
     state = SIMIX_CANCELED;
   } else if (timeoutDetector && timeoutDetector->getState() == simgrid::surf::Action::State::done) {
@@ -64,9 +76,9 @@ void simgrid::kernel::activity::ExecImpl::post()
     state = SIMIX_DONE;
   }
 
-  if (surf_exec) {
-    surf_exec->unref();
-    surf_exec = nullptr;
+  if (surfAction_) {
+    surfAction_->unref();
+    surfAction_ = nullptr;
   }
   if (timeoutDetector) {
     timeoutDetector->unref();