A
lgorithmique
N
umérique
D
istribuée
Public GIT Repository
projects
/
simgrid.git
/ blobdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
|
commitdiff
|
tree
raw
|
inline
| side by side
Workaround for errors given by Asan (certainly false positives).
[simgrid.git]
/
src
/
surf
/
cpu_ti.cpp
diff --git
a/src/surf/cpu_ti.cpp
b/src/surf/cpu_ti.cpp
index 997b716ae3599ed4a8597a2fe2359c16f092411b..6810cf3a4bda1ef8d2365b626facba997fafc1e0 100644
(file)
--- a/
src/surf/cpu_ti.cpp
+++ b/
src/surf/cpu_ti.cpp
@@
-1,10
+1,11
@@
-/* Copyright (c) 2013-20
19
. The SimGrid Team. All rights reserved. */
+/* Copyright (c) 2013-20
20
. The SimGrid Team. All rights reserved. */
/* This program is free software; you can redistribute it and/or modify it
* under the terms of the license (GNU LGPL) which comes with this package. */
#include "cpu_ti.hpp"
/* This program is free software; you can redistribute it and/or modify it
* under the terms of the license (GNU LGPL) which comes with this package. */
#include "cpu_ti.hpp"
-#include "src/kernel/resource/profile/trace_mgr.hpp"
+#include "src/kernel/resource/profile/Event.hpp"
+#include "src/kernel/resource/profile/Profile.hpp"
#include "src/surf/surf_interface.hpp"
#include "surf/surf.hpp"
#include "src/surf/surf_interface.hpp"
#include "surf/surf.hpp"
@@
-22,7
+23,7
@@
namespace resource {
* Trace *
*********/
* Trace *
*********/
-CpuTiProfile::CpuTiProfile(profile::Profile* profile)
+CpuTiProfile::CpuTiProfile(
const
profile::Profile* profile)
{
double integral = 0;
double time = 0;
{
double integral = 0;
double time = 0;
@@
-221,7
+222,6
@@
CpuTiTmgr::CpuTiTmgr(kernel::profile::Profile* speed_profile, double value) : sp
/* no availability file, fixed trace */
if (not speed_profile) {
/* no availability file, fixed trace */
if (not speed_profile) {
- type_ = Type::FIXED;
value_ = value;
XBT_DEBUG("No availability trace. Constant value = %f", value);
return;
value_ = value;
XBT_DEBUG("No availability trace. Constant value = %f", value);
return;
@@
-229,7
+229,6
@@
CpuTiTmgr::CpuTiTmgr(kernel::profile::Profile* speed_profile, double value) : sp
/* only one point available, fixed trace */
if (speed_profile->event_list.size() == 1) {
/* only one point available, fixed trace */
if (speed_profile->event_list.size() == 1) {
- type_ = Type::FIXED;
value_ = speed_profile->event_list.front().value_;
return;
}
value_ = speed_profile->event_list.front().value_;
return;
}
@@
-271,8
+270,8
@@
void CpuTiModel::create_pm_vm_models()
xbt_assert(surf_cpu_model_pm == nullptr, "CPU model already initialized. This should not happen.");
xbt_assert(surf_cpu_model_vm == nullptr, "CPU model already initialized. This should not happen.");
xbt_assert(surf_cpu_model_pm == nullptr, "CPU model already initialized. This should not happen.");
xbt_assert(surf_cpu_model_vm == nullptr, "CPU model already initialized. This should not happen.");
- surf_cpu_model_pm = new
simgrid::kernel::resource::
CpuTiModel();
- surf_cpu_model_vm = new
simgrid::kernel::resource::
CpuTiModel();
+ surf_cpu_model_pm = new CpuTiModel();
+ surf_cpu_model_vm = new CpuTiModel();
}
CpuTiModel::CpuTiModel() : CpuModel(Model::UpdateAlgo::FULL)
}
CpuTiModel::CpuTiModel() : CpuModel(Model::UpdateAlgo::FULL)
@@
-285,12
+284,12
@@
CpuTiModel::~CpuTiModel()
surf_cpu_model_pm = nullptr;
}
surf_cpu_model_pm = nullptr;
}
-
kernel::resource::
Cpu* CpuTiModel::create_cpu(s4u::Host* host, const std::vector<double>& speed_per_pstate, int core)
+Cpu* CpuTiModel::create_cpu(s4u::Host* host, const std::vector<double>& speed_per_pstate, int core)
{
return new CpuTi(this, host, speed_per_pstate, core);
}
{
return new CpuTi(this, host, speed_per_pstate, core);
}
-double CpuTiModel::next_occuring_event(double now)
+double CpuTiModel::next_occur
r
ing_event(double now)
{
double min_action_duration = -1;
{
double min_action_duration = -1;
@@
-313,9
+312,9
@@
double CpuTiModel::next_occuring_event(double now)
void CpuTiModel::update_actions_state(double now, double /*delta*/)
{
while (not get_action_heap().empty() && double_equals(get_action_heap().top_date(), now, sg_surf_precision)) {
void CpuTiModel::update_actions_state(double now, double /*delta*/)
{
while (not get_action_heap().empty() && double_equals(get_action_heap().top_date(), now, sg_surf_precision)) {
-
CpuTiAction
* action = static_cast<CpuTiAction*>(get_action_heap().pop());
+
auto
* action = static_cast<CpuTiAction*>(get_action_heap().pop());
XBT_DEBUG("Action %p: finish", action);
XBT_DEBUG("Action %p: finish", action);
- action->finish(
kernel::resource::
Action::State::FINISHED);
+ action->finish(Action::State::FINISHED);
/* update remaining amount of all actions */
action->cpu_->update_remaining_amount(surf_get_clock());
}
/* update remaining amount of all actions */
action->cpu_->update_remaining_amount(surf_get_clock());
}
@@
-324,7
+323,7
@@
void CpuTiModel::update_actions_state(double now, double /*delta*/)
/************
* Resource *
************/
/************
* Resource *
************/
-CpuTi::CpuTi(CpuTiModel* model, s
imgrid::s
4u::Host* host, const std::vector<double>& speed_per_pstate, int core)
+CpuTi::CpuTi(CpuTiModel* model, s4u::Host* host, const std::vector<double>& speed_per_pstate, int core)
: Cpu(model, host, speed_per_pstate, core)
{
xbt_assert(core == 1, "Multi-core not handled by this model yet");
: Cpu(model, host, speed_per_pstate, core)
{
xbt_assert(core == 1, "Multi-core not handled by this model yet");
@@
-340,6
+339,7
@@
CpuTi::~CpuTi()
set_modified(false);
delete speed_integrated_trace_;
}
set_modified(false);
delete speed_integrated_trace_;
}
+
void CpuTi::set_speed_profile(kernel::profile::Profile* profile)
{
delete speed_integrated_trace_;
void CpuTi::set_speed_profile(kernel::profile::Profile* profile)
{
delete speed_integrated_trace_;
@@
-349,8
+349,8
@@
void CpuTi::set_speed_profile(kernel::profile::Profile* profile)
if (profile && profile->event_list.size() > 1) {
kernel::profile::DatedValue val = profile->event_list.back();
if (val.date_ < 1e-12) {
if (profile && profile->event_list.size() > 1) {
kernel::profile::DatedValue val = profile->event_list.back();
if (val.date_ < 1e-12) {
-
simgrid::kernel::profile::Profile* prof = new simgrid::
kernel::profile::Profile();
- speed_.event
= prof->schedule(&
future_evt_set, this);
+
auto* prof = new
kernel::profile::Profile();
+ speed_.event
= prof->schedule(&profile::
future_evt_set, this);
}
}
}
}
}
}
@@
-383,11
+383,10
@@
void CpuTi::apply_event(kernel::profile::Event* event, double value)
/* put all action running on cpu to failed */
for (CpuTiAction& action : action_set_) {
/* put all action running on cpu to failed */
for (CpuTiAction& action : action_set_) {
- if (action.get_state() == kernel::resource::Action::State::INITED ||
- action.get_state() == kernel::resource::Action::State::STARTED ||
- action.get_state() == kernel::resource::Action::State::IGNORED) {
+ if (action.get_state() == Action::State::INITED || action.get_state() == Action::State::STARTED ||
+ action.get_state() == Action::State::IGNORED) {
action.set_finish_time(date);
action.set_finish_time(date);
- action.set_state(
kernel::resource::
Action::State::FAILED);
+ action.set_state(Action::State::FAILED);
get_model()->get_action_heap().remove(&action);
}
}
get_model()->get_action_heap().remove(&action);
}
}
@@
-413,14
+412,14
@@
void CpuTi::update_actions_finish_time(double now)
continue;
/* bogus priority, skip it */
continue;
/* bogus priority, skip it */
- if (action.get_
priori
ty() <= 0)
+ if (action.get_
sharing_penal
ty() <= 0)
continue;
/* action suspended, skip it */
if (not action.is_running())
continue;
continue;
/* action suspended, skip it */
if (not action.is_running())
continue;
- sum_priority_ += 1.0 / action.get_
priori
ty();
+ sum_priority_ += 1.0 / action.get_
sharing_penal
ty();
}
for (CpuTiAction& action : action_set_) {
}
for (CpuTiAction& action : action_set_) {
@@
-430,9
+429,9
@@
void CpuTi::update_actions_finish_time(double now)
continue;
/* verify if the action is really running on cpu */
continue;
/* verify if the action is really running on cpu */
- if (action.is_running() && action.get_
priori
ty() > 0) {
+ if (action.is_running() && action.get_
sharing_penal
ty() > 0) {
/* total area needed to finish the action. Used in trace integration */
/* total area needed to finish the action. Used in trace integration */
- double total_area = (action.get_remains() * sum_priority_ * action.get_
priori
ty()) / speed_.peak;
+ double total_area = (action.get_remains() * sum_priority_ * action.get_
sharing_penal
ty()) / speed_.peak;
action.set_finish_time(speed_integrated_trace_->solve(now, total_area));
/* verify which event will happen before (max_duration or finish time) */
action.set_finish_time(speed_integrated_trace_->solve(now, total_area));
/* verify which event will happen before (max_duration or finish time) */
@@
-448,7
+447,7
@@
void CpuTi::update_actions_finish_time(double now)
}
/* add in action heap */
if (min_finish != NO_MAX_DURATION)
}
/* add in action heap */
if (min_finish != NO_MAX_DURATION)
- get_model()->get_action_heap().update(&action, min_finish,
kernel::resource::
ActionHeap::Type::unset);
+ get_model()->get_action_heap().update(&action, min_finish, ActionHeap::Type::unset);
else
get_model()->get_action_heap().remove(&action);
else
get_model()->get_action_heap().remove(&action);
@@
-486,7
+485,7
@@
void CpuTi::update_remaining_amount(double now)
continue;
/* bogus priority, skip it */
continue;
/* bogus priority, skip it */
- if (action.get_
priori
ty() <= 0)
+ if (action.get_
sharing_penal
ty() <= 0)
continue;
/* action suspended, skip it */
continue;
/* action suspended, skip it */
@@
-502,16
+501,16
@@
void CpuTi::update_remaining_amount(double now)
continue;
/* update remaining */
continue;
/* update remaining */
- action.update_remains(area_total / (sum_priority_ * action.get_
priori
ty()));
+ action.update_remains(area_total / (sum_priority_ * action.get_
sharing_penal
ty()));
XBT_DEBUG("Update remaining action(%p) remaining %f", &action, action.get_remains_no_update());
}
last_update_ = now;
}
XBT_DEBUG("Update remaining action(%p) remaining %f", &action, action.get_remains_no_update());
}
last_update_ = now;
}
-
kernel::resource::
CpuAction* CpuTi::execution_start(double size)
+CpuAction* CpuTi::execution_start(double size)
{
XBT_IN("(%s,%g)", get_cname(), size);
{
XBT_IN("(%s,%g)", get_cname(), size);
-
CpuTiAction
* action = new CpuTiAction(this, size);
+
auto
* action = new CpuTiAction(this, size);
action_set_.push_back(*action); // Actually start the action
action_set_.push_back(*action); // Actually start the action
@@
-519,18
+518,18
@@
kernel::resource::CpuAction* CpuTi::execution_start(double size)
return action;
}
return action;
}
-
kernel::resource::
CpuAction* CpuTi::sleep(double duration)
+CpuAction* CpuTi::sleep(double duration)
{
if (duration > 0)
duration = std::max(duration, sg_surf_precision);
XBT_IN("(%s,%g)", get_cname(), duration);
{
if (duration > 0)
duration = std::max(duration, sg_surf_precision);
XBT_IN("(%s,%g)", get_cname(), duration);
-
CpuTiAction
* action = new CpuTiAction(this, 1.0);
+
auto
* action = new CpuTiAction(this, 1.0);
action->set_max_duration(duration);
action->set_max_duration(duration);
- action->set_suspend_state(
kernel::resource::
Action::SuspendStates::SLEEPING);
+ action->set_suspend_state(Action::SuspendStates::SLEEPING);
if (duration == NO_MAX_DURATION)
if (duration == NO_MAX_DURATION)
- action->set_state(
simgrid::kernel::resource::
Action::State::IGNORED);
+ action->set_state(Action::State::IGNORED);
action_set_.push_back(*action);
action_set_.push_back(*action);
@@
-547,7
+546,7
@@
void CpuTi::set_modified(bool modified)
}
} else {
if (cpu_ti_hook.is_linked())
}
} else {
if (cpu_ti_hook.is_linked())
-
simgrid::
xbt::intrusive_erase(modified_cpus, *this);
+ xbt::intrusive_erase(modified_cpus, *this);
}
}
}
}
@@
-563,7
+562,7
@@
CpuTiAction::~CpuTiAction()
{
/* remove from action_set */
if (action_ti_hook.is_linked())
{
/* remove from action_set */
if (action_ti_hook.is_linked())
-
simgrid::
xbt::intrusive_erase(cpu_->action_set_, *this);
+ xbt::intrusive_erase(cpu_->action_set_, *this);
/* remove from heap */
get_model()->get_action_heap().remove(this);
cpu_->set_modified(true);
/* remove from heap */
get_model()->get_action_heap().remove(this);
cpu_->set_modified(true);
@@
-618,15
+617,15
@@
void CpuTiAction::set_max_duration(double duration)
min_finish = get_finish_time();
/* add in action heap */
min_finish = get_finish_time();
/* add in action heap */
- get_model()->get_action_heap().update(this, min_finish,
kernel::resource::
ActionHeap::Type::unset);
+ get_model()->get_action_heap().update(this, min_finish, ActionHeap::Type::unset);
XBT_OUT();
}
XBT_OUT();
}
-void CpuTiAction::set_
priority(double priori
ty)
+void CpuTiAction::set_
sharing_penalty(double sharing_penal
ty)
{
{
- XBT_IN("(%p,%g)", this,
priori
ty);
- set_
priority_no_update(priori
ty);
+ XBT_IN("(%p,%g)", this,
sharing_penal
ty);
+ set_
sharing_penalty_no_update(sharing_penal
ty);
cpu_->set_modified(true);
XBT_OUT();
}
cpu_->set_modified(true);
XBT_OUT();
}