#define RMA_TAG -1234
-xbt_bar_t creation_bar = NULL;
+xbt_bar_t creation_bar = nullptr;
typedef struct s_smpi_mpi_win{
void* base;
if(info!=MPI_INFO_NULL)
info->refcount++;
win->comm = comm;
- win->name = NULL;
+ win->name = nullptr;
win->opened = 0;
win->group = MPI_GROUP_NULL;
- win->requests = xbt_dynar_new(sizeof(MPI_Request), NULL);
+ win->requests = xbt_dynar_new(sizeof(MPI_Request), nullptr);
win->connected_wins = xbt_new0(MPI_Win, comm_size);
win->connected_wins[rank] = win;
if(rank==0){
win->bar=xbt_barrier_init(comm_size);
}
-
mpi_coll_allgather_fun(&(win->connected_wins[rank]), sizeof(MPI_Win), MPI_BYTE, win->connected_wins, sizeof(MPI_Win),
MPI_BYTE, comm);
xbt_barrier_wait((*win)->bar);
xbt_dynar_free(&(*win)->requests);
xbt_free((*win)->connected_wins);
- if ((*win)->name != NULL){
+ if ((*win)->name != nullptr){
xbt_free((*win)->name);
}
if((*win)->info!=MPI_INFO_NULL){
MPI_Info_free(&(*win)->info);
}
+
+ mpi_coll_barrier_fun((*win)->comm);
+ int rank=smpi_comm_rank((*win)->comm);
+ if(rank == 0)
+ xbt_barrier_destroy((*win)->bar);
xbt_free(*win);
*win = MPI_WIN_NULL;
return MPI_SUCCESS;
}
void smpi_mpi_win_get_name(MPI_Win win, char* name, int* length){
- if(win->name==NULL){
+ if(win->name==nullptr){
*length=0;
- name=NULL;
+ name=nullptr;
return;
}
*length = strlen(win->name);
- strcpy(name, win->name);
+ strncpy(name, win->name, *length+1);
}
void smpi_mpi_win_get_group(MPI_Win win, MPI_Group* group){
if(win->comm != MPI_COMM_NULL){
*group = smpi_comm_group(win->comm);
- smpi_group_use(*group);
}
}
void smpi_mpi_win_set_name(MPI_Win win, char* name){
- win->name = xbt_strdup(name);;
+ win->name = xbt_strdup(name);
}
int smpi_mpi_win_fence( int assert, MPI_Win win){
XBT_DEBUG("Entering fence");
- if(!win->opened)
+ if(win->opened==0)
win->opened=1;
if(assert != MPI_MODE_NOPRECEDE){
xbt_barrier_wait(win->bar);
MPI_Request req;
// start all requests that have been prepared by another process
xbt_dynar_foreach(reqs, cpt, req){
- if (req->flags & PREPARED) smpi_mpi_start(req);
+ if (req->flags & PREPARED)
+ smpi_mpi_start(req);
}
MPI_Request* treqs = static_cast<MPI_Request*>(xbt_dynar_to_array(reqs));
- win->requests=xbt_dynar_new(sizeof(MPI_Request), NULL);
+ win->requests=xbt_dynar_new(sizeof(MPI_Request), nullptr);
smpi_mpi_waitall(size,treqs,MPI_STATUSES_IGNORE);
xbt_free(treqs);
int smpi_mpi_put( void *origin_addr, int origin_count, MPI_Datatype origin_datatype, int target_rank,
MPI_Aint target_disp, int target_count, MPI_Datatype target_datatype, MPI_Win win)
{
- if(!win->opened)//check that post/start has been done
+ if(win->opened==0)//check that post/start has been done
return MPI_ERR_WIN;
//get receiver pointer
MPI_Win recv_win = win->connected_wins[target_rank];
- void* recv_addr = (void*) ( ((char*)recv_win->base) + target_disp * recv_win->disp_unit);
+ void* recv_addr = static_cast<void*> ( static_cast<char*>(recv_win->base) + target_disp * recv_win->disp_unit);
XBT_DEBUG("Entering MPI_Put to %d", target_rank);
if(target_rank != smpi_comm_rank(win->comm)){
int smpi_mpi_get( void *origin_addr, int origin_count, MPI_Datatype origin_datatype, int target_rank,
MPI_Aint target_disp, int target_count, MPI_Datatype target_datatype, MPI_Win win)
{
- if(!win->opened)//check that post/start has been done
+ if(win->opened==0)//check that post/start has been done
return MPI_ERR_WIN;
//get sender pointer
MPI_Win send_win = win->connected_wins[target_rank];
- void* send_addr = (void*)( ((char*)send_win->base) + target_disp * send_win->disp_unit);
+ void* send_addr = static_cast<void*>(static_cast<char*>(send_win->base) + target_disp * send_win->disp_unit);
XBT_DEBUG("Entering MPI_Get from %d", target_rank);
if(target_rank != smpi_comm_rank(win->comm)){
int smpi_mpi_accumulate( void *origin_addr, int origin_count, MPI_Datatype origin_datatype, int target_rank,
MPI_Aint target_disp, int target_count, MPI_Datatype target_datatype, MPI_Op op, MPI_Win win)
{
- if(!win->opened)//check that post/start has been done
+ if(win->opened==0)//check that post/start has been done
return MPI_ERR_WIN;
//FIXME: local version
//get receiver pointer
MPI_Win recv_win = win->connected_wins[target_rank];
- void* recv_addr = (void*)( ((char*)recv_win->base) + target_disp * recv_win->disp_unit);
+ void* recv_addr = static_cast<void*>(static_cast<char*>(recv_win->base) + target_disp * recv_win->disp_unit);
XBT_DEBUG("Entering MPI_Accumulate to %d", target_rank);
//prepare send_request
int size = smpi_group_size(group);
MPI_Request* reqs = xbt_new0(MPI_Request, size);
-// for(i=0;i<size;i++){
while(j!=size){
int src=smpi_group_index(group,j);
if(src!=smpi_process_index()){
- reqs[i]=smpi_irecv_init(NULL, 0, MPI_CHAR, src,RMA_TAG+4, MPI_COMM_WORLD);
+ reqs[i]=smpi_irecv_init(nullptr, 0, MPI_CHAR, src,RMA_TAG+4, MPI_COMM_WORLD);
i++;
}
j++;
while(j!=size){
int dst=smpi_group_index(group,j);
if(dst!=smpi_process_index()){
- reqs[i]=smpi_mpi_send_init(NULL, 0, MPI_CHAR, dst, RMA_TAG+4, MPI_COMM_WORLD);
+ reqs[i]=smpi_mpi_send_init(nullptr, 0, MPI_CHAR, dst, RMA_TAG+4, MPI_COMM_WORLD);
i++;
}
j++;
int smpi_mpi_win_complete(MPI_Win win){
if(win->opened==0)
xbt_die("Complete called on already opened MPI_Win");
-// xbt_barrier_wait(win->bar);
- //MPI_Comm comm = smpi_comm_new(win->group, NULL);
- //mpi_coll_barrier_fun(comm);
- //smpi_comm_destroy(comm);
XBT_DEBUG("Entering MPI_Win_Complete");
int i=0,j=0;
while(j!=size){
int dst=smpi_group_index(win->group,j);
if(dst!=smpi_process_index()){
- reqs[i]=smpi_mpi_send_init(NULL, 0, MPI_CHAR, dst, RMA_TAG+5, MPI_COMM_WORLD);
+ reqs[i]=smpi_mpi_send_init(nullptr, 0, MPI_CHAR, dst, RMA_TAG+5, MPI_COMM_WORLD);
i++;
}
j++;
MPI_Request req;
// start all requests that have been prepared by another process
xbt_dynar_foreach(reqqs, cpt, req){
- if (req->flags & PREPARED) smpi_mpi_start(req);
+ if (req->flags & PREPARED)
+ smpi_mpi_start(req);
}
MPI_Request* treqs = static_cast<MPI_Request*>(xbt_dynar_to_array(reqqs));
- win->requests=xbt_dynar_new(sizeof(MPI_Request), NULL);
+ win->requests=xbt_dynar_new(sizeof(MPI_Request), nullptr);
smpi_mpi_waitall(size,treqs,MPI_STATUSES_IGNORE);
xbt_free(treqs);
smpi_group_unuse(win->group);
}
int smpi_mpi_win_wait(MPI_Win win){
-// xbt_barrier_wait(win->bar);
- //MPI_Comm comm = smpi_comm_new(win->group, NULL);
- //mpi_coll_barrier_fun(comm);
- //smpi_comm_destroy(comm);
//naive, blocking implementation.
XBT_DEBUG("Entering MPI_Win_Wait");
int i=0,j=0;
int size = smpi_group_size(win->group);
MPI_Request* reqs = xbt_new0(MPI_Request, size);
-// for(i=0;i<size;i++){
while(j!=size){
int src=smpi_group_index(win->group,j);
if(src!=smpi_process_index()){
- reqs[i]=smpi_irecv_init(NULL, 0, MPI_CHAR, src,RMA_TAG+5, MPI_COMM_WORLD);
+ reqs[i]=smpi_irecv_init(nullptr, 0, MPI_CHAR, src,RMA_TAG+5, MPI_COMM_WORLD);
i++;
}
j++;
MPI_Request req;
// start all requests that have been prepared by another process
xbt_dynar_foreach(reqqs, cpt, req){
- if (req->flags & PREPARED) smpi_mpi_start(req);
+ if (req->flags & PREPARED)
+ smpi_mpi_start(req);
}
MPI_Request* treqs = static_cast<MPI_Request*>(xbt_dynar_to_array(reqqs));
- win->requests=xbt_dynar_new(sizeof(MPI_Request), NULL);
+ win->requests=xbt_dynar_new(sizeof(MPI_Request), nullptr);
smpi_mpi_waitall(size,treqs,MPI_STATUSES_IGNORE);
xbt_free(treqs);
smpi_group_unuse(win->group);