Use a reference as parameter for signal callbacks.

[simgrid.git] / src / kernel / activity / ExecImpl.hpp

diff --git a/src/kernel/activity/ExecImpl.hpp b/src/kernel/activity/ExecImpl.hpp
index 607e671..bf99187 100644 (file)
--- a/src/kernel/activity/ExecImpl.hpp
+++ b/src/kernel/activity/ExecImpl.hpp
@@ -15,7 +15,8 @@ namespace kernel {
 namespace activity {
 
 class XBT_PUBLIC ExecImpl : public ActivityImpl {
-  ~ExecImpl() override;
+  resource::Action* timeout_detector_ = nullptr;
+  ~ExecImpl();
 
 public:
   explicit ExecImpl(const std::string& name, const std::string& tracing_category);
@@ -28,7 +29,7 @@ public:
   void cancel();
   void post() override;
   void finish() override;
-  double get_remaining();
+  double get_remaining() const;
   double get_seq_remaining_ratio();
   double get_par_remaining_ratio();
   void set_bound(double bound);       // deprecated. To be removed in v3.25
@@ -38,15 +39,11 @@ public:
   /* The host where the execution takes place. nullptr means this is a parallel exec (and only surf knows the hosts) */
   s4u::Host* host_ = nullptr;
 
-private:
-  resource::Action* timeout_detector_ = nullptr;
-
-public:
-  static simgrid::xbt::signal<void(ExecImplPtr)> on_creation;
-  static simgrid::xbt::signal<void(ExecImplPtr)> on_completion;
-  static simgrid::xbt::signal<void(ExecImplPtr, simgrid::s4u::Host*)> on_migration;
+  static xbt::signal<void(ExecImpl&)> on_creation;
+  static xbt::signal<void(ExecImpl const&)> on_completion;
+  static xbt::signal<void(ExecImpl const&, s4u::Host*)> on_migration;
 };
-}
-}
-} // namespace simgrid::kernel::activity
+} // namespace activity
+} // namespace kernel
+} // namespace simgrid
 #endif