Logo AND Algorithmique Numérique Distribuée

Public GIT Repository
s/TRY/TRYOLD/ I'd like to introduce a TRY macro in the exception mecanism, but this...
[simgrid.git] / src / amok / Bandwidth / bandwidth.c
index 2c2835c..ae19bdb 100644 (file)
@@ -14,7 +14,7 @@ XBT_LOG_NEW_DEFAULT_SUBCATEGORY(bw,amok,"Bandwidth testing");
 
 static short _amok_bw_initialized = 0;
 
-/**** code ****/
+/** @brief module initialization; all participating nodes must run this */
 void amok_bw_init(void) {
   gras_datadesc_type_t bw_request_desc, bw_res_desc, sat_request_desc;
 
@@ -51,10 +51,10 @@ void amok_bw_init(void) {
      sat_request_desc = gras_datadesc_ref("sat_request_t",sat_request_desc);
      
      /* Register the bandwidth messages */
-     gras_msgtype_declare("BW request",       bw_request_desc);
-     gras_msgtype_declare("BW result",        bw_res_desc);
      gras_msgtype_declare("BW handshake",     bw_request_desc);
      gras_msgtype_declare("BW handshake ACK", bw_request_desc);
+     gras_msgtype_declare("BW request",       bw_request_desc);
+     gras_msgtype_declare("BW result",        bw_res_desc);
      
      /* Register the saturation messages */
      gras_msgtype_declare("SAT start",   sat_request_desc);
@@ -81,6 +81,7 @@ void amok_bw_init(void) {
   _amok_bw_initialized =1;
 }
 
+/** @brief module finalization */
 void amok_bw_exit(void) {
   if (! _amok_bw_initialized)
     return;
@@ -98,15 +99,23 @@ void amok_bw_exit(void) {
   _amok_bw_initialized = 0;
 }
 
-   
-
 /* ***************************************************************************
  * Bandwidth tests
  * ***************************************************************************/
 
 /**
- * \brief bandwidth measurement between localhost and @peer
+ * \brief bandwidth measurement between localhost and \e peer
  * 
+ * \arg peer: A (regular) socket at which the the host with which we should conduct the experiment can be contacted
+ * \arg buf_size: Size of the socket buffer
+ * \arg exp_size: Total size of data sent across the network
+ * \arg msg_size: Size of each message sent. Ie, (\e expSize % \e msgSize) messages will be sent.
+ * \arg sec: where the result (in seconds) should be stored.
+ * \arg bw: observed Bandwidth (in kb/s) 
+ *
+ * Conduct a bandwidth test from the local process to the given peer.
+ * This call is blocking until the end of the experiment.
+ *
  * Results are reported in last args, and sizes are in kb.
  */
 xbt_error_t amok_bw_test(gras_socket_t peer,
@@ -117,7 +126,6 @@ xbt_error_t amok_bw_test(gras_socket_t peer,
 
   /* Measurement sockets for the experiments */
   gras_socket_t measMasterIn,measIn,measOut;
-  gras_socket_t sock_dummy; /* ignored arg to msg_wait */
   int port;
   xbt_error_t errcode;
   bw_request_t request,request_ack;
@@ -145,15 +153,15 @@ xbt_error_t amok_bw_test(gras_socket_t peer,
     ERROR1("Error %s encountered while sending the BW request.", xbt_error_name(errcode));
     return errcode;
   }
-  TRY(gras_socket_meas_accept(measMasterIn,&measIn));
+  TRYOLD(gras_socket_meas_accept(measMasterIn,&measIn));
 
   if ((errcode=gras_msg_wait(60,gras_msgtype_by_name("BW handshake ACK"),
-                            &sock_dummy,&request_ack))) {
+                            NULL,&request_ack))) {
     ERROR1("Error %s encountered while waiting for the answer to BW request.\n",
            xbt_error_name(errcode));
     return errcode;
   }
-   
+  
   /* FIXME: What if there is a remote error? */
    
   if((errcode=gras_socket_client_ext(gras_socket_peer_name(peer),
@@ -166,8 +174,8 @@ xbt_error_t amok_bw_test(gras_socket_t peer,
   DEBUG1("Got ACK; conduct the experiment (msg_size=%ld)",request->msg_size);
 
   *sec=gras_os_time();
-  TRY(gras_socket_meas_send(measOut,120,request->exp_size,request->msg_size));
-  TRY(gras_socket_meas_recv(measIn,120,1,1));
+  TRYOLD(gras_socket_meas_send(measOut,120,request->exp_size,request->msg_size));
+  TRYOLD(gras_socket_meas_recv(measIn,120,1,1));
 
   /*catch
     ERROR1("Error %s encountered while sending the BW experiment.",
@@ -248,12 +256,12 @@ int amok_bw_cb_bw_handshake(gras_socket_t  expeditor,
     /* FIXME: tell error to remote */
     return 1;
   }
-  TRY(gras_socket_meas_accept(measMasterIn,&measIn));
+  TRYOLD(gras_socket_meas_accept(measMasterIn,&measIn));
   DEBUG4("BW handshake answered. buf_size=%lu exp_size=%lu msg_size=%lu port=%d",
        answer->buf_size,answer->exp_size,answer->msg_size,answer->host.port);
 
-  TRY(gras_socket_meas_recv(measIn, 120,request->exp_size,request->msg_size));
-  TRY(gras_socket_meas_send(measOut,120,1,1));
+  TRYOLD(gras_socket_meas_recv(measIn, 120,request->exp_size,request->msg_size));
+  TRYOLD(gras_socket_meas_send(measOut,120,1,1));
 
   /*catch
     ERROR1("Error %s encountered while receiving the experiment.",
@@ -275,89 +283,89 @@ int amok_bw_cb_bw_handshake(gras_socket_t  expeditor,
   return 1;
 }
 
-int amok_bw_cb_bw_request(gras_socket_t    expeditor,
-                         void            *payload) {
-   CRITICAL0("Not implemented");
-   return 1;
-}
-
-int amok_bw_cb_sat_start(gras_socket_t     expeditor,
-                        void             *payload) {
-   CRITICAL0("Not implemented");
-   return 1;
-} 
-int amok_bw_cb_sat_begin(gras_socket_t     expeditor,
-                        void             *payload) {
-   CRITICAL0("Not implemented");
-   return 1;
-}
-
-#if 0
-/* function to request a BW test between two external hosts */
-xbt_error_t grasbw_request(const char* from_name,unsigned int from_port,
-                          const char* to_name,unsigned int to_port,
-                          unsigned int bufSize,unsigned int expSize,unsigned int msgSize,
-                          /*OUT*/ double *sec, double*bw) {
+/**
+ * \brief request a bandwidth measurement between two remote hosts
+ *
+ * \arg from_name: Name of the first host 
+ * \arg from_port: port on which the first process is listening for messages
+ * \arg to_name: Name of the second host 
+ * \arg to_port: port on which the second process is listening (for messages, do not 
+ * give a measurement socket here. The needed measurement sockets will be created 
+ * automatically and negociated between the peers)
+ * \arg buf_size: Size of the socket buffer
+ * \arg exp_size: Total size of data sent across the network
+ * \arg msg_size: Size of each message sent. (\e expSize % \e msgSize) messages will be sent.
+ * \arg sec: where the result (in seconds) should be stored.
+ * \arg bw: observed Bandwidth (in kb/s)
+ *
+ * Conduct a bandwidth test from the process from_host:from_port to to_host:to_port.
+ * This call is blocking until the end of the experiment.
+ *
+ * Results are reported in last args, and sizes are in kb.
+ */
+xbt_error_t amok_bw_request(const char* from_name,unsigned int from_port,
+                           const char* to_name,unsigned int to_port,
+                           unsigned long int buf_size,
+                           unsigned long int exp_size,
+                           unsigned long int msg_size,
+                           /*OUT*/ double *sec, double*bw) {
   
-  gras_sock_t *sock;
-  gras_msg_t *answer;
+  gras_socket_t sock;
   xbt_error_t errcode;
   /* The request */
-  BwExp_t *request;
-  msgHost_t *target;
+  bw_request_t request;
+  bw_res_t result;
 
-  if((errcode=gras_sock_client_open(from_name,from_port,&sock))) {
-    fprintf(stderr,"grasbw_request(): Error %s encountered while contacting the actuator\n",
-           xbt_error_name(errcode));
-    return errcode;
-  }
-  if (!(request=(BwExp_t *)malloc(sizeof(BwExp_t))) ||
-      !(target=(msgHost_t*)malloc(sizeof(msgHost_t)))) {
-    fprintf(stderr,"grasbw_test(): Malloc error\n");
-    gras_sock_close(sock);
-    return malloc_error;    
-  }
+  request=xbt_new0(s_bw_request_t,1);
+  request->buf_size=buf_size;
+  request->exp_size=exp_size;
+  request->msg_size=msg_size;
 
-  request->bufSize=bufSize;
-  request->expSize=expSize;
-  request->msgSize=msgSize;
-  strcpy(target->host,to_name);
-  target->port=to_port;
-  
-  if ((errcode=gras_msg_new_and_send(sock,GRASMSG_BW_REQUEST, 2, 
-                             target,1,
-                             request,1))) {
-    fprintf(stderr,"grasbw_request(): Error %s encountered while sending the request.\n",
-           xbt_error_name(errcode));
-    gras_sock_close(sock);
-    return errcode;
-  }
-  if ((errcode=gras_msg_wait(240,GRASMSG_BW_RESULT,&answer))) {
-    fprintf(stderr,"grasbw_request(): Error %s encountered while waiting for the answer.\n",
-           xbt_error_name(errcode));
-    gras_sock_close(sock);
-    return errcode;
-  }
+  request->host.name = (char*)to_name;
+  request->host.port = to_port;
 
-  if((errcode=gras_msg_ctn(answer,0,0,msgError_t).errcode)) {
-    fprintf(stderr,"grasbw_request(): Peer reported error %s (%s).\n",
-           xbt_error_name(errcode),gras_msg_ctn(answer,0,0,msgError_t).errmsg);
-    gras_msg_free(answer);
-    gras_sock_close(sock);
-    return errcode;
-  }
+  TRYOLD(gras_socket_client(from_name,from_port,&sock));
+  TRYOLD(gras_msg_send(sock,gras_msgtype_by_name("BW request"),&request));
+  free(request);
 
-  /*  fprintf(stderr,"sec=%p",gras_msg_ctn(answer,1,0,msgResult_t)); */
-  *sec=gras_msg_ctn(answer,1,0,msgResult_t).value;
-  *bw=gras_msg_ctn(answer,1,1,msgResult_t).value;
+  TRYOLD(gras_msg_wait(240,gras_msgtype_by_name("BW result"),NULL, &result));
+  
+  *sec=result->sec;
+  *bw =result->bw;
 
-  gras_msg_free(answer);
-  gras_sock_close(sock);
+  VERB6("BW test between %s:%d and %s:%d took %f sec, achieving %f kb/s",
+       from_name,from_port, to_name,to_port,
+       *sec,*bw);
+
+  gras_socket_close(sock);
+  free(result);
   return no_error;
 }
 
-int grasbw_cbBWRequest(gras_msg_t *msg) {
-  /* specification of the test to run */
+int amok_bw_cb_bw_request(gras_socket_t    expeditor,
+                         void            *payload) {
+                         
+  xbt_error_t errcode;                   
+  /* specification of the test to run, and our answer */
+  bw_request_t request = *(bw_request_t*)payload;
+  bw_res_t result = xbt_new0(s_bw_res,1);
+  gras_socket_t peer;
+
+  TRYOLD(gras_socket_client(request->host.name,request->host.port,&peer));
+  TRYOLD(amok_bw_test(peer,
+                  request->buf_size,request->exp_size,request->msg_size,
+                  &(result->sec),&(result->bw)));
+
+  TRYOLD(gras_msg_send(expeditor,gras_msgtype_by_name("BW result"),&result));
+
+  gras_os_sleep(1);
+  gras_socket_close(peer);
+  free(request);
+  free(result);
+  
+  return 1;
+
+#if 0
   char* to_name=gras_msg_ctn(msg,0,0,msgHost_t).host;
   unsigned int to_port=gras_msg_ctn(msg,0,0,msgHost_t).port;
 
@@ -368,12 +376,6 @@ int grasbw_cbBWRequest(gras_msg_t *msg) {
   msgError_t *error;
   msgResult_t *res;
 
-  if (!(error=(msgError_t *)malloc(sizeof(msgError_t))) ||
-      !(res=(msgResult_t *)malloc(sizeof(msgResult_t) * 2))) {
-    fprintf(stderr,"%s:%d:grasbw_cbRequest: Malloc error\n",__FILE__,__LINE__);
-    return malloc_error;    
-  }
-
   if ((error->errcode=grasbw_test(to_name,to_port,bufSize,expSize,msgSize,
                                  &(res[0].value),&(res[1].value) ))) {
     fprintf(stderr,
@@ -392,8 +394,20 @@ int grasbw_cbBWRequest(gras_msg_t *msg) {
                 res,2);
   gras_msg_free(msg);
   return 1;
+#endif
 }
 
+int amok_bw_cb_sat_start(gras_socket_t     expeditor,
+                        void             *payload) {
+   CRITICAL0("amok_bw_cb_sat_start; not implemented");
+   return 1;
+} 
+int amok_bw_cb_sat_begin(gras_socket_t     expeditor,
+                        void             *payload) {
+   CRITICAL0("amok_bw_cb_sat_begin: not implemented");
+   return 1;
+}
+#if 0
 /* ***************************************************************************
  * Link saturation
  * ***************************************************************************/