auto* zone = dynamic_cast<simgrid::kernel::routing::VivaldiZone*>(current_routing);
xbt_assert(zone, "<peer> tag can only be used in Vivaldi netzones.");
- const auto* peer = zone->create_host(args->id, std::vector<double>{args->speed})
+ const auto* peer = zone->create_host(args->id, {args->speed})
->set_state_profile(args->state_trace)
->set_speed_profile(args->speed_trace)
->set_coordinates(args->coord)
simgrid::kernel::routing::NetPoint* sg_platf_new_router(const std::string& name, const std::string& coords)
{
auto* netpoint = current_routing->create_router(name)->set_coordinates(coords);
- XBT_DEBUG("Router '%s' has the id %u", netpoint->get_cname(), netpoint->id());
+ XBT_DEBUG("Router '%s' has the id %lu", netpoint->get_cname(), netpoint->id());
return netpoint;
}
if (args->policy == simgrid::s4u::Link::SharingPolicy::SPLITDUPLEX) {
link = current_routing->create_split_duplex_link(args->id, args->bandwidths);
} else {
- link = current_routing->create_link(args->id, args->bandwidths)->set_sharing_policy(args->policy);
+ link = current_routing->create_link(args->id, args->bandwidths);
+ link->get_impl()->set_sharing_policy(args->policy, {});
}
sg_platf_set_link_properties(link, args);
link->seal();
/** @brief Auxiliary function to create hosts */
static std::pair<simgrid::kernel::routing::NetPoint*, simgrid::kernel::routing::NetPoint*>
sg_platf_cluster_create_host(const simgrid::kernel::routing::ClusterCreationArgs* cluster, simgrid::s4u::NetZone* zone,
- const std::vector<unsigned int>& /*coord*/, int id)
+ const std::vector<unsigned long>& /*coord*/, unsigned long id)
{
xbt_assert(static_cast<unsigned long>(id) < cluster->radicals.size(),
- "Zone(%s): error when creating host number %d in the zone. Insufficient number of radicals available "
+ "Zone(%s): error when creating host number %lu in the zone. Insufficient number of radicals available "
"(total = %zu). Check the 'radical' parameter in XML",
cluster->id.c_str(), id, cluster->radicals.size());
/** @brief Auxiliary function to create loopback links */
static simgrid::s4u::Link*
sg_platf_cluster_create_loopback(const simgrid::kernel::routing::ClusterCreationArgs* cluster,
- simgrid::s4u::NetZone* zone, const std::vector<unsigned int>& /*coord*/, int id)
+ simgrid::s4u::NetZone* zone, const std::vector<unsigned long>& /*coord*/,
+ unsigned long id)
{
xbt_assert(static_cast<unsigned long>(id) < cluster->radicals.size(),
- "Zone(%s): error when creating loopback for host number %d in the zone. Insufficient number of radicals "
- "available "
+ "Zone(%s): error when creating loopback for host number %lu in the zone. Insufficient number of "
+ "radicals available "
"(total = %zu). Check the 'radical' parameter in XML",
cluster->id.c_str(), id, cluster->radicals.size());
/** @brief Auxiliary function to create limiter links */
static simgrid::s4u::Link* sg_platf_cluster_create_limiter(const simgrid::kernel::routing::ClusterCreationArgs* cluster,
simgrid::s4u::NetZone* zone,
- const std::vector<unsigned int>& /*coord*/, int id)
+ const std::vector<unsigned long>& /*coord*/,
+ unsigned long id)
{
std::string link_id = std::string(cluster->id) + "_link_" + std::to_string(id) + "_limiter";
XBT_DEBUG("Cluster: creating limiter link=%s bw=%f", link_id.c_str(), cluster->limiter_link);
zone->set_property(elm.first, elm.second);
/* Make the backbone */
- simgrid::s4u::Link* backbone = nullptr;
+ const simgrid::s4u::Link* backbone = nullptr;
if ((cluster->bb_bw > 0) || (cluster->bb_lat > 0)) {
std::string bb_name = std::string(cluster->id) + "_backbone";
XBT_DEBUG("<link\tid=\"%s\" bw=\"%f\" lat=\"%f\"/> <!--backbone -->", bb_name.c_str(), cluster->bb_bw,
cluster->bb_lat);
- backbone = zone->create_link(bb_name, std::vector<double>{cluster->bb_bw})
+ backbone = zone->create_link(bb_name, cluster->bb_bw)
->set_sharing_policy(cluster->bb_sharing_policy)
->set_latency(cluster->bb_lat)
->seal();
std::string loopback_name = link_id + "_loopback";
XBT_DEBUG("<loopback\tid=\"%s\"\tbw=\"%f\"/>", loopback_name.c_str(), cluster->loopback_bw);
- auto* loopback = zone->create_link(loopback_name, std::vector<double>{cluster->loopback_bw})
- ->set_sharing_policy(simgrid::s4u::Link::SharingPolicy::FATPIPE)
- ->set_latency(cluster->loopback_lat)
- ->seal();
+ const auto* loopback = zone->create_link(loopback_name, cluster->loopback_bw)
+ ->set_sharing_policy(simgrid::s4u::Link::SharingPolicy::FATPIPE)
+ ->set_latency(cluster->loopback_lat)
+ ->seal();
zone->add_route(host->get_netpoint(), host->get_netpoint(), nullptr, nullptr,
- std::vector<simgrid::s4u::LinkInRoute>{loopback});
+ {simgrid::s4u::LinkInRoute(loopback)});
}
// add a limiter link (shared link to account for maximal bandwidth of the node)
- simgrid::s4u::Link* limiter = nullptr;
+ const simgrid::s4u::Link* limiter = nullptr;
if (cluster->limiter_link > 0) {
std::string limiter_name = std::string(link_id) + "_limiter";
XBT_DEBUG("<limiter\tid=\"%s\"\tbw=\"%f\"/>", limiter_name.c_str(), cluster->limiter_link);
- limiter = zone->create_link(limiter_name, std::vector<double>{cluster->limiter_link})->seal();
+ limiter = zone->create_link(limiter_name, cluster->limiter_link)->seal();
}
// create link
- simgrid::s4u::Link* link;
+ const simgrid::s4u::Link* link;
if (cluster->sharing_policy == simgrid::s4u::Link::SharingPolicy::SPLITDUPLEX) {
link = zone->create_split_duplex_link(link_id, cluster->bw)->set_latency(cluster->lat)->seal();
} else {
- link = zone->create_link(link_id, std::vector<double>{cluster->bw})->set_latency(cluster->lat)->seal();
+ link = zone->create_link(link_id, cluster->bw)->set_latency(cluster->lat)->seal();
}
/* adding routes */
std::vector<simgrid::s4u::LinkInRoute> links;
if (limiter)
- links.push_back(limiter);
- links.push_back(simgrid::s4u::LinkInRoute(link, simgrid::s4u::LinkInRoute::Direction::UP));
+ links.emplace_back(limiter);
+ links.emplace_back(link, simgrid::s4u::LinkInRoute::Direction::UP);
if (backbone)
- links.push_back(backbone);
+ links.emplace_back(backbone);
zone->add_route(host->get_netpoint(), nullptr, nullptr, nullptr, links, true);
}
static void sg_platf_cluster_set_hostlink(simgrid::kernel::routing::StarZone* zone,
simgrid::kernel::routing::NetPoint* netpoint,
const simgrid::s4u::Link* link_up, const simgrid::s4u::Link* link_down,
- simgrid::s4u::Link* backbone)
+ const simgrid::s4u::Link* backbone)
{
- XBT_DEBUG("Push Host_link for host '%s' to position %u", netpoint->get_cname(), netpoint->id());
+ XBT_DEBUG("Push Host_link for host '%s' to position %lu", netpoint->get_cname(), netpoint->id());
+ simgrid::s4u::LinkInRoute linkUp{link_up};
+ simgrid::s4u::LinkInRoute linkDown{link_down};
if (backbone) {
- zone->add_route(netpoint, nullptr, nullptr, nullptr, {link_up, backbone}, false);
- zone->add_route(nullptr, netpoint, nullptr, nullptr, {backbone, link_down}, false);
+ simgrid::s4u::LinkInRoute linkBB{backbone};
+ zone->add_route(netpoint, nullptr, nullptr, nullptr, {linkUp, linkBB}, false);
+ zone->add_route(nullptr, netpoint, nullptr, nullptr, {linkBB, linkDown}, false);
} else {
- zone->add_route(netpoint, nullptr, nullptr, nullptr, {link_up}, false);
- zone->add_route(nullptr, netpoint, nullptr, nullptr, {link_down}, false);
+ zone->add_route(netpoint, nullptr, nullptr, nullptr, {linkUp}, false);
+ zone->add_route(nullptr, netpoint, nullptr, nullptr, {linkDown}, false);
}
}
/** @brief Add a link connecting a host to the rest of its StarZone */
static void sg_platf_build_hostlink(simgrid::kernel::routing::StarZone* zone,
const simgrid::kernel::routing::HostLinkCreationArgs* hostlink,
- simgrid::s4u::Link* backbone)
+ const simgrid::s4u::Link* backbone)
{
simgrid::kernel::routing::NetPoint* netpoint = simgrid::s4u::Host::by_name(hostlink->id)->get_netpoint();
xbt_assert(netpoint, "Host '%s' not found!", hostlink->id.c_str());
/** @brief Create a cabinet (set of hosts) inside a Cluster(StarZone) */
static void sg_platf_build_cabinet(simgrid::kernel::routing::StarZone* zone,
const simgrid::kernel::routing::CabinetCreationArgs* args,
- simgrid::s4u::Link* backbone)
+ const simgrid::s4u::Link* backbone)
{
for (int const& radical : args->radicals) {
std::string id = args->prefix + std::to_string(radical) + args->suffix;
- auto const* host = zone->create_host(id, std::vector<double>{args->speed})->seal();
+ auto const* host = zone->create_host(id, {args->speed})->seal();
- const auto* link_up =
- zone->create_link("link_" + id + "_UP", std::vector<double>{args->bw})->set_latency(args->lat)->seal();
- const auto* link_down =
- zone->create_link("link_" + id + "_DOWN", std::vector<double>{args->bw})->set_latency(args->lat)->seal();
+ const auto* link_up = zone->create_link("link_" + id + "_UP", {args->bw})->set_latency(args->lat)->seal();
+ const auto* link_down = zone->create_link("link_" + id + "_DOWN", {args->bw})->set_latency(args->lat)->seal();
sg_platf_cluster_set_hostlink(zone, host->get_netpoint(), link_up, link_down, backbone);
}
auto* zone = dynamic_cast<simgrid::kernel::routing::StarZone*>(current_routing);
xbt_assert(zone, "Host_links are only valid for Cluster(Star)");
- simgrid::s4u::Link* backbone = nullptr;
+ const simgrid::s4u::Link* backbone = nullptr;
/* create backbone */
if (cluster->backbone) {
sg_platf_new_link(cluster->backbone.get());
/**
* @brief Auxiliary function to build the object NetZoneImpl
*
- * Builds the objects, setting its father properties and root netzone if needed
+ * Builds the objects, setting its parent properties and root netzone if needed
* @param zone the parameters defining the Zone to build.
* @return Pointer to recently created netzone
*/