-/* Copyright (c) 2013-2017. The SimGrid Team.
+/* Copyright (c) 2013-2019. The SimGrid Team.
* All rights reserved. */
/* This program is free software; you can redistribute it and/or modify it
* under the terms of the license (GNU LGPL) which comes with this package. */
-#include "../colls_private.h"
+#include "../colls_private.hpp"
namespace simgrid{
namespace smpi{
-int Coll_allreduce_rab_rdb::allreduce(void *sbuff, void *rbuff, int count,
- MPI_Datatype dtype, MPI_Op op,
- MPI_Comm comm)
+int allreduce__rab_rdb(const void *sbuff, void *rbuff, int count,
+ MPI_Datatype dtype, MPI_Op op,
+ MPI_Comm comm)
{
int tag = COLL_TAG_ALLREDUCE;
unsigned int mask, pof2, i, recv_idx, last_idx, send_idx, send_cnt;
- int dst, newrank, rem, newdst,
- recv_cnt, *cnts, *disps;
+ int dst, newrank, rem, newdst, recv_cnt;
MPI_Aint extent;
MPI_Status status;
- void *tmp_buf = NULL;
unsigned int nprocs = comm->size();
int rank = comm->rank();
extent = dtype->get_extent();
- tmp_buf = (void *) smpi_get_tmp_sendbuffer(count * extent);
+ unsigned char* tmp_buf = smpi_get_tmp_sendbuffer(count * extent);
Datatype::copy(sbuff, count, dtype, rbuff, count, dtype);
// processes of rank < 2*rem send their data to
// (rank+1). These even-numbered processes no longer
// participate in the algorithm until the very end. The
- // remaining processes form a nice power-of-two.
+ // remaining processes form a nice power-of-two.
if (rank < 2 * rem) {
- // even
+ // even
if (rank % 2 == 0) {
Request::send(rbuff, count, dtype, rank + 1, tag, comm);
// temporarily set the rank to -1 so that this
- // process does not pariticipate in recursive
+ // process does not participate in recursive
// doubling
newrank = -1;
} else // odd
// the operation is commutative or not.
if(op!=MPI_OP_NULL) op->apply( tmp_buf, rbuff, &count, dtype);
- // change the rank
+ // change the rank
newrank = rank / 2;
}
}
- else // rank >= 2 * rem
+ else // rank >= 2 * rem
newrank = rank - rem;
// If op is user-defined or count is less than pof2, use
// datatypes on one process and derived on another as long as
// the type maps are the same. Breaking up derived
// datatypes to do the reduce-scatter is tricky, therefore
- // using recursive doubling in that case.)
+ // using recursive doubling in that case.)
if (newrank != -1) {
// do a reduce-scatter followed by allgather. for the
// reduce-scatter, calculate the count that each process receives
- // and the displacement within the buffer
+ // and the displacement within the buffer
- cnts = (int *) xbt_malloc(pof2 * sizeof(int));
- disps = (int *) xbt_malloc(pof2 * sizeof(int));
+ int* cnts = new int[pof2];
+ int* disps = new int[pof2];
for (i = 0; i < (pof2 - 1); i++)
cnts[i] = count / pof2;
last_idx = pof2;
while (mask < pof2) {
newdst = newrank ^ mask;
- // find real rank of dest
+ // find real rank of dest
dst = (newdst < rem) ? newdst * 2 + 1 : newdst + rem;
send_cnt = recv_cnt = 0;
recv_cnt += cnts[i];
}
- // Send data from recvbuf. Recv into tmp_buf
- Request::sendrecv((char *) rbuff + disps[send_idx] * extent, send_cnt,
- dtype, dst, tag,
- (char *) tmp_buf + disps[recv_idx] * extent, recv_cnt,
- dtype, dst, tag, comm, &status);
+ // Send data from recvbuf. Recv into tmp_buf
+ Request::sendrecv(static_cast<char*>(rbuff) + disps[send_idx] * extent, send_cnt, dtype, dst, tag,
+ tmp_buf + disps[recv_idx] * extent, recv_cnt, dtype, dst, tag, comm, &status);
// tmp_buf contains data received in this step.
- // recvbuf contains data accumulated so far
+ // recvbuf contains data accumulated so far
// This algorithm is used only for predefined ops
// and predefined ops are always commutative.
- if(op!=MPI_OP_NULL) op->apply( (char *) tmp_buf + disps[recv_idx] * extent,
- (char *) rbuff + disps[recv_idx] * extent, &recv_cnt, dtype);
+ if (op != MPI_OP_NULL)
+ op->apply(tmp_buf + disps[recv_idx] * extent, static_cast<char*>(rbuff) + disps[recv_idx] * extent, &recv_cnt,
+ dtype);
- // update send_idx for next iteration
+ // update send_idx for next iteration
send_idx = recv_idx;
mask <<= 1;
// update last_idx, but not in last iteration because the value
- // is needed in the allgather step below.
+ // is needed in the allgather step below.
if (mask < pof2)
last_idx = recv_idx + pof2 / mask;
}
- // now do the allgather
+ // now do the allgather
mask >>= 1;
while (mask > 0) {
send_cnt = recv_cnt = 0;
if (newrank < newdst) {
- // update last_idx except on first iteration
+ // update last_idx except on first iteration
if (mask != pof2 / 2)
last_idx = last_idx + pof2 / (mask * 2);
mask >>= 1;
}
- free(cnts);
- free(disps);
-
+ delete[] cnts;
+ delete[] disps;
}
// In the non-power-of-two case, all odd-numbered processes of
// rank < 2 * rem send the result to (rank-1), the ranks who didn't
// participate above.
if (rank < 2 * rem) {
- if (rank % 2) // odd
+ if (rank % 2) // odd
Request::send(rbuff, count, dtype, rank - 1, tag, comm);
- else // even
+ else // even
Request::recv(rbuff, count, dtype, rank + 1, tag, comm, &status);
}
