A
lgorithmique
N
umérique
D
istribuée
Public GIT Repository
projects
/
simgrid.git
/ blobdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
|
commitdiff
|
tree
raw
|
inline
| side by side
[sonar] Constify pointer and reference local variables in src/s4u/.
[simgrid.git]
/
src
/
s4u
/
s4u_Host.cpp
diff --git
a/src/s4u/s4u_Host.cpp
b/src/s4u/s4u_Host.cpp
index
02698af
..
73195c5
100644
(file)
--- a/
src/s4u/s4u_Host.cpp
+++ b/
src/s4u/s4u_Host.cpp
@@
-9,7
+9,6
@@
#include "simgrid/s4u/Exec.hpp"
#include "simgrid/s4u/VirtualMachine.hpp"
#include "src/plugins/vm/VirtualMachineImpl.hpp"
#include "simgrid/s4u/Exec.hpp"
#include "simgrid/s4u/VirtualMachine.hpp"
#include "src/plugins/vm/VirtualMachineImpl.hpp"
-#include "src/simix/smx_private.hpp"
#include "src/surf/HostImpl.hpp"
#include <algorithm>
#include "src/surf/HostImpl.hpp"
#include <algorithm>
@@
-18,8
+17,6
@@
XBT_LOG_NEW_DEFAULT_SUBCATEGORY(s4u_host, s4u, "Logging specific to the S4U hosts");
XBT_LOG_EXTERNAL_CATEGORY(surf_route);
XBT_LOG_NEW_DEFAULT_SUBCATEGORY(s4u_host, s4u, "Logging specific to the S4U hosts");
XBT_LOG_EXTERNAL_CATEGORY(surf_route);
-int USER_HOST_LEVEL = -1;
-
namespace simgrid {
namespace xbt {
template class Extendable<s4u::Host>;
namespace simgrid {
namespace xbt {
template class Extendable<s4u::Host>;
@@
-44,8
+41,8
@@
Host::~Host()
xbt_assert(currently_destroying_, "Please call h->destroy() instead of manually deleting it.");
delete pimpl_;
xbt_assert(currently_destroying_, "Please call h->destroy() instead of manually deleting it.");
delete pimpl_;
- if (pimpl_netpoint != nullptr) // not removed yet by a children class
- Engine::get_instance()->netpoint_unregister(pimpl_netpoint);
+ if (pimpl_netpoint
_
!= nullptr) // not removed yet by a children class
+ Engine::get_instance()->netpoint_unregister(pimpl_netpoint
_
);
delete pimpl_cpu;
delete mounts_;
}
delete pimpl_cpu;
delete mounts_;
}
@@
-78,7
+75,7
@@
Host* Host::by_name_or_null(const std::string& name)
Host* Host::current()
{
Host* Host::current()
{
- kernel::actor::ActorImpl* self =
SIMIX_process_
self();
+ kernel::actor::ActorImpl* self =
kernel::actor::ActorImpl::
self();
if (self == nullptr)
xbt_die("Cannot call Host::current() from the maestro context");
return self->get_host();
if (self == nullptr)
xbt_die("Cannot call Host::current() from the maestro context");
return self->get_host();
@@
-99,14
+96,15
@@
void Host::turn_on()
void Host::turn_off()
{
if (is_on()) {
void Host::turn_off()
{
if (is_on()) {
- kernel::actor::simcall([this] {
+ kernel::actor::ActorImpl* self = kernel::actor::ActorImpl::self();
+ kernel::actor::simcall([this, self] {
for (VirtualMachine* const& vm : vm::VirtualMachineImpl::allVms_)
if (vm->get_pm() == this) {
vm->shutdown();
vm->turn_off();
}
this->pimpl_cpu->turn_off();
for (VirtualMachine* const& vm : vm::VirtualMachineImpl::allVms_)
if (vm->get_pm() == this) {
vm->shutdown();
vm->turn_off();
}
this->pimpl_cpu->turn_off();
- this->pimpl_->turn_off();
+ this->pimpl_->turn_off(
self
);
on_state_change(*this);
});
on_state_change(*this);
});
@@
-156,13
+154,13
@@
void Host::route_to(Host* dest, std::vector<Link*>& links, double* latency)
std::vector<kernel::resource::LinkImpl*> linkImpls;
this->route_to(dest, linkImpls, latency);
for (kernel::resource::LinkImpl* const& l : linkImpls)
std::vector<kernel::resource::LinkImpl*> linkImpls;
this->route_to(dest, linkImpls, latency);
for (kernel::resource::LinkImpl* const& l : linkImpls)
- links.push_back(
&l->piface_
);
+ links.push_back(
l->get_iface()
);
}
/** @brief Just like Host::routeTo, but filling an array of link implementations */
void Host::route_to(Host* dest, std::vector<kernel::resource::LinkImpl*>& links, double* latency)
{
}
/** @brief Just like Host::routeTo, but filling an array of link implementations */
void Host::route_to(Host* dest, std::vector<kernel::resource::LinkImpl*>& links, double* latency)
{
- kernel::routing::NetZoneImpl::get_global_route(pimpl_netpoint
, dest->pimpl_netpoint
, links, latency);
+ kernel::routing::NetZoneImpl::get_global_route(pimpl_netpoint
_, dest->get_netpoint()
, links, latency);
if (XBT_LOG_ISENABLED(surf_route, xbt_log_priority_debug)) {
XBT_CDEBUG(surf_route, "Route from '%s' to '%s' (latency: %f):", get_cname(), dest->get_cname(),
(latency == nullptr ? -1 : *latency));
if (XBT_LOG_ISENABLED(surf_route, xbt_log_priority_debug)) {
XBT_CDEBUG(surf_route, "Route from '%s' to '%s' (latency: %f):", get_cname(), dest->get_cname(),
(latency == nullptr ? -1 : *latency));
@@
-174,7
+172,7
@@
void Host::route_to(Host* dest, std::vector<kernel::resource::LinkImpl*>& links,
/** @brief Returns the networking zone englobing that host */
NetZone* Host::get_englobing_zone()
{
/** @brief Returns the networking zone englobing that host */
NetZone* Host::get_englobing_zone()
{
- return pimpl_netpoint->get_englobing_zone()->get_iface();
+ return pimpl_netpoint
_
->get_englobing_zone()->get_iface();
}
void Host::send_to(Host* dest, double byte_amount)
}
void Host::send_to(Host* dest, double byte_amount)
@@
-288,6
+286,16
@@
std::vector<Disk*> Host::get_disks() const
{
return kernel::actor::simcall([this] { return this->pimpl_->get_disks(); });
}
{
return kernel::actor::simcall([this] { return this->pimpl_->get_disks(); });
}
+
+void Host::add_disk(Disk* disk)
+{
+ kernel::actor::simcall([this, disk] { this->pimpl_->add_disk(disk); });
+}
+
+void Host::remove_disk(const std::string& disk_name)
+{
+ kernel::actor::simcall([this, disk_name] { this->pimpl_->remove_disk(disk_name); });
+}
/**
* @ingroup simix_storage_management
* @brief Returns the list of storages attached to a host.
/**
* @ingroup simix_storage_management
* @brief Returns the list of storages attached to a host.
@@
-303,7
+311,7
@@
std::unordered_map<std::string, Storage*> const& Host::get_mounted_storages()
if (mounts_ == nullptr) {
mounts_ = new std::unordered_map<std::string, Storage*>();
for (auto const& m : this->pimpl_->storage_) {
if (mounts_ == nullptr) {
mounts_ = new std::unordered_map<std::string, Storage*>();
for (auto const& m : this->pimpl_->storage_) {
- mounts_->insert({m.first,
&m.second->piface_
});
+ mounts_->insert({m.first,
m.second->get_iface()
});
}
}
return *mounts_;
}
}
return *mounts_;
@@
-378,7
+386,7
@@
xbt_dynar_t sg_hosts_as_dynar()
std::vector<simgrid::s4u::Host*> list = simgrid::s4u::Engine::get_instance()->get_all_hosts();
auto last = std::remove_if(begin(list), end(list), [](const simgrid::s4u::Host* host) {
std::vector<simgrid::s4u::Host*> list = simgrid::s4u::Engine::get_instance()->get_all_hosts();
auto last = std::remove_if(begin(list), end(list), [](const simgrid::s4u::Host* host) {
- return not host || not host->
pimpl_netpoint || not host->pimpl_netpoint
->is_host();
+ return not host || not host->
get_netpoint() || not host->get_netpoint()
->is_host();
});
std::sort(begin(list), last,
[](const simgrid::s4u::Host* a, const simgrid::s4u::Host* b) { return a->get_name() < b->get_name(); });
});
std::sort(begin(list), last,
[](const simgrid::s4u::Host* a, const simgrid::s4u::Host* b) { return a->get_name() < b->get_name(); });
@@
-391,17
+399,25
@@
xbt_dynar_t sg_hosts_as_dynar()
// ========= Layering madness ==============*
// ========== User data Layer ==========
// ========= Layering madness ==============*
// ========== User data Layer ==========
-void* sg_host_
user
(sg_host_t host)
+void* sg_host_
data
(sg_host_t host)
{
{
- return host->
extension(USER_HOST_LEVEL
);
+ return host->
get_data(
);
}
}
-void sg_host_
user
_set(sg_host_t host, void* userdata)
+void sg_host_
data
_set(sg_host_t host, void* userdata)
{
{
- host->
extension_set(USER_HOST_LEVEL,
userdata);
+ host->
set_data(
userdata);
}
}
-void
sg_host_user_destroy(sg_host_t host)
+void
* sg_host_user(sg_host_t host) // deprecated
{
{
- host->extension_set(USER_HOST_LEVEL, nullptr);
+ return host->get_data();
+}
+void sg_host_user_set(sg_host_t host, void* userdata) // deprecated
+{
+ host->set_data(userdata);
+}
+void sg_host_user_destroy(sg_host_t host) // deprecated
+{
+ host->set_data(nullptr);
}
// ========= storage related functions ============
}
// ========= storage related functions ============
@@
-411,8
+427,8
@@
xbt_dict_t sg_host_get_mounted_storage_list(sg_host_t host)
xbt_dict_t res = xbt_dict_new_homogeneous(nullptr);
for (auto const& elm : host->get_mounted_storages()) {
const char* mount_name = elm.first.c_str();
xbt_dict_t res = xbt_dict_new_homogeneous(nullptr);
for (auto const& elm : host->get_mounted_storages()) {
const char* mount_name = elm.first.c_str();
-
sg_storage_t storage
= elm.second;
- xbt_dict_set(res, mount_name, (void*)storage->get_cname()
, nullptr
);
+
const simgrid::s4u::Storage* storage
= elm.second;
+ xbt_dict_set(res, mount_name, (void*)storage->get_cname());
}
return res;
}
return res;
@@
-526,12
+542,6
@@
int sg_host_is_on(sg_host_t host)
return host->is_on();
}
return host->is_on();
}
-/** @deprecated */
-int sg_host_is_off(sg_host_t host)
-{
- return not host->is_on();
-}
-
/** @brief Get the properties of a host */
xbt_dict_t sg_host_get_properties(sg_host_t host)
{
/** @brief Get the properties of a host */
xbt_dict_t sg_host_get_properties(sg_host_t host)
{
@@
-540,7
+550,7
@@
xbt_dict_t sg_host_get_properties(sg_host_t host)
if (props == nullptr)
return nullptr;
for (auto const& elm : *props) {
if (props == nullptr)
return nullptr;
for (auto const& elm : *props) {
- xbt_dict_set(as_dict, elm.first.c_str(), xbt_strdup(elm.second.c_str())
, nullptr
);
+ xbt_dict_set(as_dict, elm.first.c_str(), xbt_strdup(elm.second.c_str()));
}
return as_dict;
}
}
return as_dict;
}
@@
-590,7
+600,7
@@
double sg_host_route_latency(sg_host_t from, sg_host_t to)
return res;
}
/**
return res;
}
/**
- * @brief Find the bandwi
td
h of the route between two hosts
+ * @brief Find the bandwi
dt
h of the route between two hosts
*
* @param from where from
* @param to where to
*
* @param from where from
* @param to where to
@@
-637,25
+647,20
@@
void sg_host_dump(sg_host_t host)
*/
void sg_host_get_actor_list(sg_host_t host, xbt_dynar_t whereto)
{
*/
void sg_host_get_actor_list(sg_host_t host, xbt_dynar_t whereto)
{
- auto actors = host->get_all_actors();
- for (auto& actor : actors)
+ auto
const
actors = host->get_all_actors();
+ for (auto
const
& actor : actors)
xbt_dynar_push(whereto, &actor);
}
sg_host_t sg_host_self()
{
xbt_dynar_push(whereto, &actor);
}
sg_host_t sg_host_self()
{
- smx_actor_t process = SIMIX_process_self();
- return (process == nullptr) ? nullptr : process->get_host();
+ return SIMIX_is_maestro() ? nullptr : simgrid::kernel::actor::ActorImpl::self()->get_host();
}
/* needs to be public and without simcall for exceptions and logging events */
const char* sg_host_self_get_name()
{
}
/* needs to be public and without simcall for exceptions and logging events */
const char* sg_host_self_get_name()
{
- sg_host_t host = sg_host_self();
- if (host == nullptr || SIMIX_process_self() == simix_global->maestro_process)
- return "";
-
- return host->get_cname();
+ return SIMIX_is_maestro() ? "" : simgrid::kernel::actor::ActorImpl::self()->get_host()->get_cname();
}
double sg_host_load(sg_host_t host)
}
double sg_host_load(sg_host_t host)