Logo AND Algorithmique Numérique Distribuée

Public GIT Repository
Order of these error messages was inverted
[simgrid.git] / src / surf / surf_interface.cpp
index 24a8f2c..8213e7b 100644 (file)
-#include "surf.hpp"
-#include "workstation.hpp"
-#include "vm_workstation.hpp"
-#include "network.hpp"
-#include "surf_routing_cluster.hpp"
-#include "instr/instr_private.h"
-
-XBT_LOG_EXTERNAL_DEFAULT_CATEGORY(surf_kernel);
+/* Copyright (c) 2004-2015. The SimGrid Team.
+ * All rights reserved.                                                     */
+
+/* This program is free software; you can redistribute it and/or modify it
+ * under the terms of the license (GNU LGPL) which comes with this package. */
+
+#include "src/internal_config.h"
+#include "surf_private.h"
+#include "surf_interface.hpp"
+#include "network_interface.hpp"
+#include "cpu_interface.hpp"
+#include "src/surf/HostImpl.hpp"
+#include "src/simix/smx_host_private.h"
+#include "surf_routing.hpp"
+#include "simgrid/sg_config.h"
+#include "mc/mc.h"
+#include "virtual_machine.hpp"
+#include "src/instr/instr_private.h" // TRACE_is_enabled(). FIXME: remove by subscribing tracing to the surf signals
+#include "simgrid/s4u/engine.hpp"
+
+XBT_LOG_NEW_CATEGORY(surf, "All SURF categories");
+XBT_LOG_NEW_DEFAULT_SUBCATEGORY(surf_kernel, surf, "Logging specific to SURF (kernel)");
 
 /*********
- * TOOLS *
+ * Utils *
  *********/
 
-static CpuPtr get_casted_cpu(surf_resource_t resource){
-  return dynamic_cast<CpuPtr>(static_cast<ResourcePtr>(surf_cpu_resource_priv(resource)));
-}
+/* model_list_invoke contains only surf_host and surf_vm.
+ * The callback functions of cpu_model and network_model will be called from those of these host models. */
+xbt_dynar_t all_existing_models = nullptr; /* to destroy models correctly */
+xbt_dynar_t model_list_invoke = nullptr;  /* to invoke callbacks */
 
-static WorkstationCLM03Ptr get_casted_workstation(surf_resource_t resource){
-  return dynamic_cast<WorkstationCLM03Ptr>(static_cast<ResourcePtr>(surf_workstation_resource_priv(resource)));
-}
+simgrid::trace_mgr::future_evt_set *future_evt_set = nullptr;
+xbt_dynar_t surf_path = nullptr;
+xbt_dynar_t host_that_restart = xbt_dynar_new(sizeof(char*), nullptr);
+xbt_dict_t watched_hosts_lib;
 
-static WorkstationVM2013Ptr get_casted_vm_workstation(surf_resource_t resource){
-  return dynamic_cast<WorkstationVM2013Ptr>(static_cast<ResourcePtr>(surf_workstation_resource_priv(resource)));
-}
+namespace simgrid {
+namespace surf {
+
+simgrid::xbt::signal<void(void)> surfExitCallbacks;
 
-char *surf_routing_edge_name(sg_routing_edge_t edge){
-  return edge->p_name;
+}
 }
 
-#ifdef CONTEXT_THREADS
-static xbt_parmap_t surf_parmap = NULL; /* parallel map on models */
-#endif
+#include <simgrid/plugins/energy.h> // FIXME: this plugin should not be linked to the core
 
-extern double NOW;
-extern double *surf_mins; /* return value of share_resources for each model */
-extern int surf_min_index;       /* current index in surf_mins */
-extern double surf_min;               /* duration determined by surf_solve */
+s_surf_model_description_t surf_plugin_description[] = {
+    {"Energy", "Cpu energy consumption.", sg_energy_plugin_init},
+     {nullptr, nullptr,  nullptr}      /* this array must be nullptr terminated */
+};
 
-void surf_presolve(void)
-{
-  double next_event_date = -1.0;
-  tmgr_trace_event_t event = NULL;
-  double value = -1.0;
-  ResourcePtr resource = NULL;
-  ModelPtr model = NULL;
-  unsigned int iter;
+/* Don't forget to update the option description in smx_config when you change this */
+s_surf_model_description_t surf_network_model_description[] = {
+  {"LV08", "Realistic network analytic model (slow-start modeled by multiplying latency by 10.4, bandwidth by .92; bottleneck sharing uses a payload of S=8775 for evaluating RTT). ",
+   surf_network_model_init_LegrandVelho},
+  {"Constant",
+   "Simplistic network model where all communication take a constant time (one second). This model provides the lowest realism, but is (marginally) faster.",
+   surf_network_model_init_Constant},
+  {"SMPI", "Realistic network model specifically tailored for HPC settings (accurate modeling of slow start with correction factors on three intervals: < 1KiB, < 64 KiB, >= 64 KiB)",
+   surf_network_model_init_SMPI},
+  {"IB", "Realistic network model specifically tailored for HPC settings, with Infiniband contention model",
+   surf_network_model_init_IB},
+  {"CM02", "Legacy network analytic model (Very similar to LV08, but without corrective factors. The timings of small messages are thus poorly modeled).",
+   surf_network_model_init_CM02},
+#if HAVE_NS3
+  {"NS3", "Network pseudo-model using the NS3 tcp model instead of an analytic model", surf_network_model_init_NS3},
+#endif
+  {"Reno",  "Model from Steven H. Low using lagrange_solve instead of lmm_solve (experts only; check the code for more info).",
+   surf_network_model_init_Reno},
+  {"Reno2", "Model from Steven H. Low using lagrange_solve instead of lmm_solve (experts only; check the code for more info).",
+   surf_network_model_init_Reno2},
+  {"Vegas", "Model from Steven H. Low using lagrange_solve instead of lmm_solve (experts only; check the code for more info).",
+   surf_network_model_init_Vegas},
+  {nullptr, nullptr, nullptr}      /* this array must be nullptr terminated */
+};
+
+s_surf_model_description_t surf_cpu_model_description[] = {
+  {"Cas01", "Simplistic CPU model (time=size/power).", surf_cpu_model_init_Cas01},
+  {nullptr, nullptr,  nullptr}      /* this array must be nullptr terminated */
+};
+
+s_surf_model_description_t surf_host_model_description[] = {
+  {"default",   "Default host model. Currently, CPU:Cas01 and network:LV08 (with cross traffic enabled)", surf_host_model_init_current_default},
+  {"compound",  "Host model that is automatically chosen if you change the network and CPU models", surf_host_model_init_compound},
+  {"ptask_L07", "Host model somehow similar to Cas01+CM02 but allowing parallel tasks", surf_host_model_init_ptask_L07},
+  {nullptr, nullptr, nullptr}      /* this array must be nullptr terminated */
+};
+
+s_surf_model_description_t surf_vm_model_description[] = {
+  {"default", "Default vm model.", surf_vm_model_init_HL13},
+  {nullptr, nullptr, nullptr}      /* this array must be nullptr terminated */
+};
+
+s_surf_model_description_t surf_optimization_mode_description[] = {
+  {"Lazy", "Lazy action management (partial invalidation in lmm + heap in action remaining).", nullptr},
+  {"TI",   "Trace integration. Highly optimized mode when using availability traces (only available for the Cas01 CPU model for now).", nullptr},
+  {"Full", "Full update of remaining and variables. Slow but may be useful when debugging.", nullptr},
+  {nullptr, nullptr, nullptr}      /* this array must be nullptr terminated */
+};
+
+s_surf_model_description_t surf_storage_model_description[] = {
+  {"default", "Simplistic storage model.", surf_storage_model_init_default},
+  {nullptr, nullptr,  nullptr}      /* this array must be nullptr terminated */
+};
+
+#if HAVE_THREAD_CONTEXTS
+static xbt_parmap_t surf_parmap = nullptr; /* parallel map on models */
+#endif
 
-  XBT_DEBUG
-      ("First Run! Let's \"purge\" events and put models in the right state");
-  while ((next_event_date = tmgr_history_next_date(history)) != -1.0) {
-    if (next_event_date > NOW)
-      break;
-    while ((event =
-            tmgr_history_get_next_event_leq(history, next_event_date,
-                                            &value,
-                                            (void **) &resource))) {
-      if (value >= 0){
-        resource->updateState(event, value, NOW);
-      }
-    }
-  }
-  xbt_dynar_foreach(model_list, iter, model)
-      model->updateActionsState(NOW, 0.0);
-}
+double NOW = 0;
 
-static void surf_share_resources(surf_model_t model)
+double surf_get_clock(void)
 {
-  double next_action_end = -1.0;
-  int i = __sync_fetch_and_add(&surf_min_index, 1);
-  if (strcmp(model->m_name.c_str(), "network NS3")) {
-    XBT_DEBUG("Running for Resource [%s]", model->m_name.c_str());
-    next_action_end = model->shareResources(NOW);
-    XBT_DEBUG("Resource [%s] : next action end = %f",
-        model->m_name.c_str(), next_action_end);
-  }
-  surf_mins[i] = next_action_end;
+  return NOW;
 }
 
-static void surf_update_actions_state(surf_model_t model)
-{
-  model->updateActionsState(NOW, surf_min);
-}
+#ifdef _WIN32
+# define FILE_DELIM "\\"
+#else
+# define FILE_DELIM "/"         /* FIXME: move to better location */
+#endif
 
-double surf_solve(double max_date)
+FILE *surf_fopen(const char *name, const char *mode)
 {
-  surf_min = -1.0; /* duration */
-  double next_event_date = -1.0;
-  double model_next_action_end = -1.0;
-  double value = -1.0;
-  ResourcePtr resource = NULL;
-  ModelPtr model = NULL;
-  tmgr_trace_event_t event = NULL;
-  unsigned int iter;
+  unsigned int cpt;
+  char *path_elm = nullptr;
+  char *buff;
+  FILE *file = nullptr;
 
-  if(!host_that_restart)
-    host_that_restart = xbt_dynar_new(sizeof(char*), NULL);
+  xbt_assert(name);
 
-  if (max_date != -1.0 && max_date != NOW) {
-    surf_min = max_date - NOW;
-  }
+  if (__surf_is_absolute_file_path(name))       /* don't mess with absolute file names */
+    return fopen(name, mode);
 
-  XBT_DEBUG("Looking for next action end for all models except NS3");
+  /* search relative files in the path */
+  xbt_dynar_foreach(surf_path, cpt, path_elm) {
+    buff = bprintf("%s" FILE_DELIM "%s", path_elm, name);
+    file = fopen(buff, mode);
+    free(buff);
 
-  if (surf_mins == NULL) {
-    surf_mins = xbt_new(double, xbt_dynar_length(model_list_invoke));
+    if (file)
+      return file;
   }
-  surf_min_index = 0;
+  return nullptr;
+}
 
-  /* sequential version */
-  xbt_dynar_foreach(model_list_invoke, iter, model) {
-    surf_share_resources(static_cast<ModelPtr>(model));
-  }
+#ifdef _WIN32
+#include <windows.h>
+#define MAX_DRIVE 26
+static const char *disk_drives_letter_table[MAX_DRIVE] = {
+  "A:\\","B:\\","C:\\","D:\\","E:\\","F:\\","G:\\","H:\\","I:\\","J:\\","K:\\","L:\\","M:\\",
+  "N:\\","O:\\","P:\\","Q:\\","R:\\","S:\\","T:\\","U:\\","V:\\","W:\\","X:\\","Y:\\","Z:\\"
+};
+#endif
+
+/*
+ * Returns the initial path. On Windows the initial path is
+ * the current directory for the current process in the other
+ * case the function returns "./" that represents the current
+ * directory on Unix/Linux platforms.
+ */
 
+const char *__surf_get_initial_path(void)
+{
+
+#ifdef _WIN32
   unsigned i;
-  for (i = 0; i < xbt_dynar_length(model_list_invoke); i++) {
-    if ((surf_min < 0.0 || surf_mins[i] < surf_min)
-        && surf_mins[i] >= 0.0) {
-      surf_min = surf_mins[i];
-    }
+  char current_directory[MAX_PATH + 1] = { 0 };
+  unsigned int len = GetCurrentDirectory(MAX_PATH + 1, current_directory);
+  char root[4] = { 0 };
+
+  if (!len)
+    return nullptr;
+
+  strncpy(root, current_directory, 3);
+
+  for (i = 0; i < MAX_DRIVE; i++) {
+    if (toupper(root[0]) == disk_drives_letter_table[i][0])
+      return disk_drives_letter_table[i];
   }
 
-  XBT_DEBUG("Min for resources (remember that NS3 don't update that value) : %f", surf_min);
+  return nullptr;
+#else
+  return "./";
+#endif
+}
 
-  XBT_DEBUG("Looking for next trace event");
+/* The __surf_is_absolute_file_path() returns 1 if
+ * file_path is a absolute file path, in the other
+ * case the function returns 0.
+ */
+int __surf_is_absolute_file_path(const char *file_path)
+{
+#ifdef _WIN32
+  WIN32_FIND_DATA wfd = { 0 };
+  HANDLE hFile = FindFirstFile(file_path, &wfd);
 
-  do {
-    XBT_DEBUG("Next TRACE event : %f", next_event_date);
+  if (INVALID_HANDLE_VALUE == hFile)
+    return 0;
 
-    next_event_date = tmgr_history_next_date(history);
+  FindClose(hFile);
+  return 1;
+#else
+  return (file_path[0] == '/');
+#endif
+}
 
-    if(!strcmp(surf_network_model->m_name.c_str(), "network NS3")){//FIXME: add surf_network_model->m_name &&
-      if(next_event_date!=-1.0 && surf_min!=-1.0) {
-        surf_min = MIN(next_event_date - NOW, surf_min);
-      } else{
-        surf_min = MAX(next_event_date - NOW, surf_min);
-      }
+/** Displays the long description of all registered models, and quit */
+void model_help(const char *category, s_surf_model_description_t * table)
+{
+  printf("Long description of the %s models accepted by this simulator:\n", category);
+  for (int i = 0; table[i].name; i++)
+    printf("  %s: %s\n", table[i].name, table[i].description);
+}
 
-      XBT_DEBUG("Run for network at most %f", surf_min);
-      // run until min or next flow
-      model_next_action_end = surf_network_model->shareResources(surf_min);
+int find_model_description(s_surf_model_description_t * table,
+                           const char *name)
+{
+  int i;
+  char *name_list = nullptr;
 
-      XBT_DEBUG("Min for network : %f", model_next_action_end);
-      if(model_next_action_end>=0.0)
-        surf_min = model_next_action_end;
+  for (i = 0; table[i].name; i++)
+    if (!strcmp(name, table[i].name)) {
+      return i;
     }
+  if (!table[0].name)
+    xbt_die("No model is valid! This is a bug.");
+  name_list = xbt_strdup(table[0].name);
+  for (i = 1; table[i].name; i++) {
+    name_list = (char *) xbt_realloc(name_list, strlen(name_list) + strlen(table[i].name) + 3);
+    strncat(name_list, ", ", 2);
+    strncat(name_list, table[i].name, strlen(table[i].name));
+  }
+  xbt_die("Model '%s' is invalid! Valid models are: %s.", name, name_list);
+  return -1;
+}
 
-    if (next_event_date < 0.0) {
-      XBT_DEBUG("no next TRACE event. Stop searching for it");
-      break;
-    }
+static inline void surf_storage_free(void *r)
+{
+  delete static_cast<simgrid::surf::Storage*>(r);
+}
 
-    if ((surf_min == -1.0) || (next_event_date > NOW + surf_min)) break;
-
-    XBT_DEBUG("Updating models (min = %g, NOW = %g, next_event_date = %g)", surf_min, NOW, next_event_date);
-    while ((event =
-            tmgr_history_get_next_event_leq(history, next_event_date,
-                                            &value,
-                                            (void **) &resource))) {
-      if (resource->isUsed() || xbt_dict_get_or_null(watched_hosts_lib, resource->m_name)) {
-        surf_min = next_event_date - NOW;
-        XBT_DEBUG
-            ("This event will modify model state. Next event set to %f",
-             surf_min);
-      }
-      /* update state of model_obj according to new value. Does not touch lmm.
-         It will be modified if needed when updating actions */
-      XBT_DEBUG("Calling update_resource_state for resource %s with min %lf",
-             resource->m_name, surf_min);
-      resource->updateState(event, value, next_event_date);
+void sg_version_check(int lib_version_major,int lib_version_minor,int lib_version_patch) {
+    if ((lib_version_major != SIMGRID_VERSION_MAJOR) || (lib_version_minor != SIMGRID_VERSION_MINOR)) {
+      fprintf(stderr,
+          "FATAL ERROR: Your program was compiled with SimGrid version %d.%d.%d, "
+          "and then linked against SimGrid %d.%d.%d. Please fix this.\n",
+          lib_version_major,lib_version_minor,lib_version_patch,
+          SIMGRID_VERSION_MAJOR,SIMGRID_VERSION_MINOR,SIMGRID_VERSION_PATCH);
+      abort();
     }
-  } while (1);
+    if (lib_version_patch != SIMGRID_VERSION_PATCH) {
+        fprintf(stderr,
+            "Warning: Your program was compiled with SimGrid version %d.%d.%d, "
+            "and then linked against SimGrid %d.%d.%d. Proceeding anyway.\n",
+            lib_version_major,lib_version_minor,lib_version_patch,
+            SIMGRID_VERSION_MAJOR,SIMGRID_VERSION_MINOR,SIMGRID_VERSION_PATCH);
+    }
+}
 
-  /* FIXME: Moved this test to here to avoid stopping simulation if there are actions running on cpus and all cpus are with availability = 0.
-   * This may cause an infinite loop if one cpu has a trace with periodicity = 0 and the other a trace with periodicity > 0.
-   * The options are: all traces with same periodicity(0 or >0) or we need to change the way how the events are managed */
-  if (surf_min == -1.0) {
-  XBT_DEBUG("No next event at all. Bail out now.");
-    return -1.0;
-  }
+void sg_version(int *ver_major,int *ver_minor,int *ver_patch) {
+  *ver_major = SIMGRID_VERSION_MAJOR;
+  *ver_minor = SIMGRID_VERSION_MINOR;
+  *ver_patch = SIMGRID_VERSION_PATCH;
+}
 
-  XBT_DEBUG("Duration set to %f", surf_min);
+void surf_init(int *argc, char **argv)
+{
+  if (host_list != nullptr) // Already initialized
+    return;
+
+  XBT_DEBUG("Create all Libs");
+  host_list = xbt_dict_new_homogeneous([](void*p) {
+    simgrid::s4u::Host* host = static_cast<simgrid::s4u::Host*>(p);
+    simgrid::s4u::Host::onDestruction(*host);
+    delete host;
+  });
+  USER_HOST_LEVEL = simgrid::s4u::Host::extension_create(nullptr);
+
+  as_router_lib = xbt_lib_new();
+  storage_lib = xbt_lib_new();
+  storage_type_lib = xbt_lib_new();
+  file_lib = xbt_lib_new();
+  watched_hosts_lib = xbt_dict_new_homogeneous(nullptr);
+
+  XBT_DEBUG("Add routing levels");
+  ROUTING_PROP_ASR_LEVEL = xbt_lib_add_level(as_router_lib, nullptr);
+  ROUTING_ASR_LEVEL = xbt_lib_add_level(as_router_lib, [](void* p) {
+    delete static_cast<simgrid::kernel::routing::NetCard*>(p);
+  });
+
+  XBT_DEBUG("Add SURF levels");
+  simgrid::surf::HostImpl::classInit();
+  SURF_STORAGE_LEVEL = xbt_lib_add_level(storage_lib,surf_storage_free);
+
+  xbt_init(argc, argv);
+  if (!all_existing_models)
+    all_existing_models = xbt_dynar_new(sizeof(simgrid::surf::Model*), nullptr);
+  if (!model_list_invoke)
+    model_list_invoke = xbt_dynar_new(sizeof(simgrid::surf::Model*), nullptr);
+  if (!future_evt_set)
+    future_evt_set = new simgrid::trace_mgr::future_evt_set();
+
+  TRACE_add_start_function(TRACE_surf_alloc);
+  TRACE_add_end_function(TRACE_surf_release);
+
+  sg_config_init(argc, argv);
+
+  if (MC_is_active())
+    MC_memory_init();
+}
+
+void surf_exit(void)
+{
+  unsigned int iter;
+  simgrid::surf::Model *model = nullptr;
+
+  TRACE_end();                  /* Just in case it was not called by the upper
+                                 * layer (or there is no upper layer) */
+
+  sg_config_finalize();
+
+  xbt_dynar_free(&host_that_restart);
+  xbt_dynar_free(&surf_path);
 
-  NOW = NOW + surf_min;
-  /* FIXME: model_list or model_list_invoke? revisit here later */
-  /* sequential version */
-  xbt_dynar_foreach(model_list, iter, model) {
-    surf_update_actions_state(model);
+  xbt_dict_free(&host_list);
+  xbt_lib_free(&as_router_lib);
+  xbt_lib_free(&storage_lib);
+  sg_link_exit();
+  xbt_lib_free(&storage_type_lib);
+  xbt_lib_free(&file_lib);
+  xbt_dict_free(&watched_hosts_lib);
+
+  xbt_dynar_foreach(all_existing_models, iter, model)
+    delete model;
+  xbt_dynar_free(&all_existing_models);
+  xbt_dynar_free(&model_list_invoke);
+  routing_exit();
+
+  simgrid::surf::surfExitCallbacks();
+
+  if (future_evt_set) {
+    delete future_evt_set;
+    future_evt_set = nullptr;
   }
 
-#ifdef HAVE_TRACING
-  TRACE_paje_dump_buffer (0);
+#if HAVE_THREAD_CONTEXTS
+  xbt_parmap_destroy(surf_parmap);
 #endif
 
-  return surf_min;
-}
+  tmgr_finalize();
+  sg_platf_exit();
+  simgrid::s4u::Engine::shutdown();
 
-XBT_INLINE double surf_get_clock(void)
-{
-  return NOW;
-}
-
-void routing_get_route_and_latency(sg_routing_edge_t src, sg_routing_edge_t dst,
-                              xbt_dynar_t * route, double *latency){
-  routing_platf->getRouteAndLatency(src, dst, route, latency);
+  NOW = 0;                      /* Just in case the user plans to restart the simulation afterward */
 }
 
 /*********
- * MODEL *
+ * Model *
  *********/
 
-surf_model_t surf_resource_model(const void *host, int level) {
-  /* If level is SURF_WKS_LEVEL, ws is a workstation_CLM03 object. It has
-   * surf_resource at the generic_resource field. */
-  ResourcePtr ws = static_cast<ResourcePtr>(xbt_lib_get_level((xbt_dictelm_t) host, level));
-  return ws->p_model;
-}
+namespace simgrid {
+namespace surf {
 
-void *surf_as_cluster_get_backbone(AS_t as){
-  return static_cast<AsClusterPtr>(as)->p_backbone;
-}
+Model::Model()
+  : maxminSystem_(nullptr)
+{
+  readyActionSet_ = new ActionList();
+  runningActionSet_ = new ActionList();
+  failedActionSet_ = new ActionList();
+  doneActionSet_ = new ActionList();
 
-void surf_as_cluster_set_backbone(AS_t as, void* backbone){
-  static_cast<AsClusterPtr>(as)->p_backbone = dynamic_cast<NetworkCm02LinkPtr>(static_cast<ResourcePtr>(backbone));
+  modifiedSet_ = nullptr;
+  actionHeap_ = nullptr;
+  updateMechanism_ = UM_UNDEFINED;
+  selectiveUpdate_ = 0;
 }
 
-const char *surf_model_name(surf_model_t model){
-  return model->m_name.c_str();
+Model::~Model(){
+  delete readyActionSet_;
+  delete runningActionSet_;
+  delete failedActionSet_;
+  delete doneActionSet_;
 }
 
-xbt_swag_t surf_model_done_action_set(surf_model_t model){
-  return model->p_doneActionSet;
+double Model::next_occuring_event(double now)
+{
+  //FIXME: set the good function once and for all
+  if (updateMechanism_ == UM_LAZY)
+    return next_occuring_event_lazy(now);
+  else if (updateMechanism_ == UM_FULL)
+    return next_occuring_event_full(now);
+  else
+    xbt_die("Invalid cpu update mechanism!");
 }
 
-xbt_swag_t surf_model_failed_action_set(surf_model_t model){
-  return model->p_failedActionSet;
-}
+double Model::next_occuring_event_lazy(double now)
+{
+  Action *action = nullptr;
+  double min = -1;
+  double share;
 
-xbt_swag_t surf_model_ready_action_set(surf_model_t model){
-  return model->p_readyActionSet;
-}
+  XBT_DEBUG
+      ("Before share resources, the size of modified actions set is %zd",
+       modifiedSet_->size());
 
-xbt_swag_t surf_model_running_action_set(surf_model_t model){
-  return model->p_runningActionSet;
-}
+  lmm_solve(maxminSystem_);
 
-surf_action_t surf_workstation_model_execute_parallel_task(surf_workstation_model_t model,
-                                                   int workstation_nb,
-                                            void **workstation_list,
-                                            double *computation_amount,
-                                            double *communication_amount,
-                                            double rate){
-  return static_cast<ActionPtr>(model->executeParallelTask(workstation_nb, workstation_list, computation_amount, communication_amount, rate));
-}
+  XBT_DEBUG
+      ("After share resources, The size of modified actions set is %zd",
+       modifiedSet_->size());
 
-surf_action_t surf_workstation_model_communicate(surf_workstation_model_t model, surf_resource_t src, surf_resource_t dst, double size, double rate){
-  return model->communicate(get_casted_workstation(src), get_casted_workstation(dst), size, rate);
-}
+  while(!modifiedSet_->empty()) {
+    action = &(modifiedSet_->front());
+    modifiedSet_->pop_front();
+    int max_dur_flag = 0;
 
-xbt_dynar_t surf_workstation_model_get_route(surf_workstation_model_t model,
-                                                    surf_resource_t src, surf_resource_t dst){
-  return model->getRoute(get_casted_workstation(src), get_casted_workstation(dst));
-}
+    if (action->getStateSet() != runningActionSet_)
+      continue;
 
-void surf_vm_workstation_model_create(const char *name, surf_resource_t ind_phys_host){
-  surf_vm_workstation_model->createResource(name, ind_phys_host);
-}
+    /* bogus priority, skip it */
+    if (action->getPriority() <= 0 || action->getHat()==LATENCY)
+      continue;
 
-surf_action_t surf_network_model_communicate(surf_network_model_t model, sg_routing_edge_t src, sg_routing_edge_t dst, double size, double rate){
-  return model->communicate(src, dst, size, rate);
-}
+    action->updateRemainingLazy(now);
 
-const char *surf_resource_name(surf_cpp_resource_t resource){
-  return resource->m_name;
-}
+    min = -1;
+    share = lmm_variable_getvalue(action->getVariable());
 
-xbt_dict_t surf_resource_get_properties(surf_cpp_resource_t resource){
-  return resource->getProperties();
-}
+    if (share > 0) {
+      double time_to_completion;
+      if (action->getRemains() > 0) {
+        time_to_completion = action->getRemainsNoUpdate() / share;
+      } else {
+        time_to_completion = 0.0;
+      }
+      min = now + time_to_completion; // when the task will complete if nothing changes
+    }
 
-e_surf_resource_state_t surf_resource_get_state(surf_cpp_resource_t resource){
-  return resource->getState();
-}
+    if ((action->getMaxDuration() != NO_MAX_DURATION)
+        && (min == -1
+            || action->getStartTime() +
+            action->getMaxDuration() < min)) {
+      min = action->getStartTime() +
+          action->getMaxDuration();  // when the task will complete anyway because of the deadline if any
+      max_dur_flag = 1;
+    }
 
-void surf_resource_set_state(surf_cpp_resource_t resource, e_surf_resource_state_t state){
-  resource->setState(state);
-}
 
-surf_action_t surf_workstation_sleep(surf_resource_t resource, double duration){
-  return get_casted_workstation(resource)->sleep(duration);
-}
+    XBT_DEBUG("Action(%p) corresponds to variable %d", action, action->getVariable()->id_int);
 
-double surf_workstation_get_speed(surf_resource_t resource, double load){
-  return get_casted_workstation(resource)->getSpeed(load);
-}
+    XBT_DEBUG("Action(%p) Start %f. May finish at %f (got a share of %f). Max_duration %f", action,
+        action->getStartTime(), min, share,
+        action->getMaxDuration());
 
-double surf_workstation_get_available_speed(surf_resource_t resource){
-  return get_casted_workstation(resource)->getAvailableSpeed();
-}
+    if (min != -1) {
+      action->heapUpdate(actionHeap_, min, max_dur_flag ? MAX_DURATION : NORMAL);
+      XBT_DEBUG("Insert at heap action(%p) min %f now %f", action, min,
+                now);
+    } else DIE_IMPOSSIBLE;
+  }
 
-int surf_workstation_get_core(surf_resource_t resource){
-  return get_casted_workstation(resource)->getCore();
-}
+  //hereafter must have already the min value for this resource model
+  if (xbt_heap_size(actionHeap_) > 0)
+    min = xbt_heap_maxkey(actionHeap_) - now;
+  else
+    min = -1;
 
-surf_action_t surf_workstation_execute(surf_resource_t resource, double size){
-  return get_casted_workstation(resource)->execute(size);
-}
+  XBT_DEBUG("The minimum with the HEAP %f", min);
 
-double surf_workstation_get_current_power_peak(surf_resource_t resource){
-  return get_casted_workstation(resource)->getCurrentPowerPeak();
+  return min;
 }
 
-double surf_workstation_get_power_peak_at(surf_resource_t resource, int pstate_index){
-  return get_casted_workstation(resource)->getPowerPeakAt(pstate_index);
+double Model::next_occuring_event_full(double /*now*/) {
+  THROW_UNIMPLEMENTED;
+  return 0.0;
 }
 
-int surf_workstation_get_nb_pstates(surf_resource_t resource){
-  return get_casted_workstation(resource)->getNbPstates();
-}
+double Model::shareResourcesMaxMin(ActionList *running_actions,
+                          lmm_system_t sys,
+                          void (*solve) (lmm_system_t))
+{
+  Action *action = nullptr;
+  double min = -1;
+  double value = -1;
 
-void surf_workstation_set_power_peak_at(surf_resource_t resource, int pstate_index){
-  return get_casted_workstation(resource)->setPowerPeakAt(pstate_index);
-}
+  solve(sys);
 
-double surf_workstation_get_consumed_energy(surf_resource_t resource){
-  return get_casted_workstation(resource)->getConsumedEnergy();
-}
+  ActionList::iterator it(running_actions->begin()), itend(running_actions->end());
+  for(; it != itend ; ++it) {
+    action = &*it;
+    value = lmm_variable_getvalue(action->getVariable());
+    if ((value > 0) || (action->getMaxDuration() >= 0))
+      break;
+  }
 
-xbt_dict_t surf_workstation_get_storage_list(surf_resource_t workstation){
-  return get_casted_workstation(workstation)->getStorageList();
-}
+  if (!action)
+    return -1.0;
 
-surf_action_t surf_workstation_open(surf_resource_t workstation, const char* mount, const char* path){
-  return get_casted_workstation(workstation)->open(mount, path);
-}
+  if (value > 0) {
+    if (action->getRemains() > 0)
+      min = action->getRemainsNoUpdate() / value;
+    else
+      min = 0.0;
+    if ((action->getMaxDuration() >= 0) && (action->getMaxDuration() < min))
+      min = action->getMaxDuration();
+  } else
+    min = action->getMaxDuration();
+
+
+  for (++it; it != itend; ++it) {
+  action = &*it;
+    value = lmm_variable_getvalue(action->getVariable());
+    if (value > 0) {
+      if (action->getRemains() > 0)
+        value = action->getRemainsNoUpdate() / value;
+      else
+        value = 0.0;
+      if (value < min) {
+        min = value;
+        XBT_DEBUG("Updating min (value) with %p: %f", action, min);
+      }
+    }
+    if ((action->getMaxDuration() >= 0) && (action->getMaxDuration() < min)) {
+      min = action->getMaxDuration();
+      XBT_DEBUG("Updating min (duration) with %p: %f", action, min);
+    }
+  }
+  XBT_DEBUG("min value : %f", min);
 
-surf_action_t surf_workstation_close(surf_resource_t workstation, surf_file_t fd){
-  return get_casted_workstation(workstation)->close(fd);
+  return min;
 }
 
-int surf_workstation_unlink(surf_resource_t workstation, surf_file_t fd){
-  return get_casted_workstation(workstation)->unlink(fd);
+void Model::updateActionsState(double now, double delta)
+{
+  if (updateMechanism_ == UM_FULL)
+  updateActionsStateFull(now, delta);
+  else if (updateMechanism_ == UM_LAZY)
+  updateActionsStateLazy(now, delta);
+  else
+  xbt_die("Invalid cpu update mechanism!");
 }
 
-surf_action_t surf_workstation_ls(surf_resource_t workstation, const char* mount, const char *path){
-  return get_casted_workstation(workstation)->ls(mount, path);
+void Model::updateActionsStateLazy(double /*now*/, double /*delta*/)
+{
+ THROW_UNIMPLEMENTED;
 }
 
-size_t surf_workstation_get_size(surf_resource_t workstation, surf_file_t fd){
-  return get_casted_workstation(workstation)->getSize(fd);
+void Model::updateActionsStateFull(double /*now*/, double /*delta*/)
+{
+  THROW_UNIMPLEMENTED;
 }
 
-surf_action_t surf_workstation_read(surf_resource_t resource, surf_file_t fd, sg_size_t size){
-  return get_casted_workstation(resource)->read(fd, size);
 }
-
-surf_action_t surf_workstation_write(surf_resource_t resource, surf_file_t fd, sg_size_t size){
-  return get_casted_workstation(resource)->write(fd, size);
 }
 
-xbt_dynar_t surf_workstation_get_info(surf_resource_t resource, surf_file_t fd){
-  return get_casted_workstation(resource)->getInfo(fd);
-}
+/************
+ * Resource *
+ ************/
 
-sg_size_t surf_workstation_get_free_size(surf_resource_t resource, const char* name){
-  return get_casted_workstation(resource)->getFreeSize(name);
-}
+namespace simgrid {
+namespace surf {
 
-sg_size_t surf_workstation_get_used_size(surf_resource_t resource, const char* name){
-  return get_casted_workstation(resource)->getUsedSize(name);
-}
+Resource::Resource(Model *model, const char *name)
+  : name_(xbt_strdup(name))
+  , model_(model)
+{}
 
-xbt_dynar_t surf_workstation_get_vms(surf_resource_t resource){
-  return get_casted_workstation(resource)->getVms();
-}
+Resource::Resource(Model *model, const char *name, lmm_constraint_t constraint)
+  : name_(xbt_strdup(name))
+  , model_(model)
+  , constraint_(constraint)
+{}
 
-void surf_workstation_get_params(surf_resource_t resource, ws_params_t params){
-  get_casted_workstation(resource)->getParams(params);
+Resource::~Resource() {
+  xbt_free((void*)name_);
 }
 
-void surf_workstation_set_params(surf_resource_t resource, ws_params_t params){
-  get_casted_workstation(resource)->setParams(params);
+bool Resource::isOn() const {
+  return isOn_;
 }
-
-void surf_vm_workstation_destroy(surf_resource_t resource){
-  delete get_casted_vm_workstation(resource);
+bool Resource::isOff() const {
+  return ! isOn_;
 }
 
-void surf_vm_workstation_suspend(surf_resource_t resource){
-  get_casted_vm_workstation(resource)->suspend();
+void Resource::turnOn()
+{
+  isOn_ = true;
 }
 
-void surf_vm_workstation_resume(surf_resource_t resource){
-  get_casted_vm_workstation(resource)->resume();
+void Resource::turnOff()
+{
+  isOn_ = false;
 }
 
-void surf_vm_workstation_save(surf_resource_t resource){
-  get_casted_vm_workstation(resource)->save();
+Model *Resource::getModel() const {
+  return model_;
 }
 
-void surf_vm_workstation_restore(surf_resource_t resource){
-  get_casted_vm_workstation(resource)->restore();
+const char *Resource::getName() const {
+  return name_;
 }
 
-void surf_vm_workstation_migrate(surf_resource_t resource, surf_resource_t ind_vm_ws_dest){
-  get_casted_vm_workstation(resource)->migrate(ind_vm_ws_dest);
+bool Resource::operator==(const Resource &other) const {
+  return strcmp(name_, other.name_);
 }
 
-surf_resource_t surf_vm_workstation_get_pm(surf_resource_t resource){
-  return get_casted_vm_workstation(resource)->getPm();
+lmm_constraint_t Resource::getConstraint() const {
+  return constraint_;
 }
 
-void surf_vm_workstation_set_bound(surf_resource_t resource, double bound){
-  return get_casted_vm_workstation(resource)->setBound(bound);
 }
+}
+
+/**********
+ * Action *
+ **********/
 
-void surf_vm_workstation_set_affinity(surf_resource_t resource, surf_resource_t cpu, unsigned long mask){
-  return get_casted_vm_workstation(resource)->setAffinity(dynamic_cast<CpuLmmPtr>(get_casted_cpu(cpu)), mask);
+const char *surf_action_state_names[6] = {
+  "SURF_ACTION_READY",
+  "SURF_ACTION_RUNNING",
+  "SURF_ACTION_FAILED",
+  "SURF_ACTION_DONE",
+  "SURF_ACTION_TO_FREE",
+  "SURF_ACTION_NOT_IN_THE_SYSTEM"
+};
+
+/* added to manage the communication action's heap */
+void surf_action_lmm_update_index_heap(void *action, int i) {
+  static_cast<simgrid::surf::Action*>(action)->updateIndexHeap(i);
 }
 
-int surf_network_link_is_shared(surf_cpp_resource_t link){
-  return dynamic_cast<NetworkCm02LinkPtr>(link)->isShared();
+namespace simgrid {
+namespace surf {
+
+void Action::initialize(simgrid::surf::Model *model, double cost, bool failed,
+                        lmm_variable_t var)
+{
+  remains_ = cost;
+  start_ = surf_get_clock();
+  cost_ = cost;
+  model_ = model;
+  variable_ = var;
+  if (failed)
+    stateSet_ = getModel()->getFailedActionSet();
+  else
+    stateSet_ = getModel()->getRunningActionSet();
+
+  stateSet_->push_back(*this);
 }
 
-double surf_network_link_get_bandwidth(surf_cpp_resource_t link){
-  return dynamic_cast<NetworkCm02LinkPtr>(link)->getBandwidth();
+Action::Action(simgrid::surf::Model *model, double cost, bool failed)
+{
+  initialize(model, cost, failed);
 }
 
-double surf_network_link_get_latency(surf_cpp_resource_t link){
-  return dynamic_cast<NetworkCm02LinkPtr>(link)->getLatency();
+Action::Action(simgrid::surf::Model *model, double cost, bool failed, lmm_variable_t var)
+{
+  initialize(model, cost, failed, var);
 }
 
-xbt_dict_t surf_storage_get_content(surf_resource_t resource){
-  return dynamic_cast<StoragePtr>(static_cast<ResourcePtr>(surf_storage_resource_priv(resource)))->getContent();
+Action::~Action() {
+  xbt_free(category_);
 }
 
-sg_size_t surf_storage_get_size(surf_resource_t resource){
-  return dynamic_cast<StoragePtr>(static_cast<ResourcePtr>(surf_storage_resource_priv(resource)))->getSize();
+void Action::finish() {
+    finishTime_ = surf_get_clock();
 }
 
-void surf_storage_rename(surf_resource_t resource, const char* src, const char* dest){
-  dynamic_cast<StoragePtr>(static_cast<ResourcePtr>(surf_storage_resource_priv(resource)))->rename(src, dest);
+Action::State Action::getState()
+{
+  if (stateSet_ ==  getModel()->getReadyActionSet())
+    return Action::State::ready;
+  if (stateSet_ ==  getModel()->getRunningActionSet())
+    return Action::State::running;
+  if (stateSet_ ==  getModel()->getFailedActionSet())
+    return Action::State::failed;
+  if (stateSet_ ==  getModel()->getDoneActionSet())
+    return Action::State::done;
+  return Action::State::not_in_the_system;
+}
+
+void Action::setState(Action::State state)
+{
+  stateSet_->erase(stateSet_->iterator_to(*this));
+  switch (state) {
+  case Action::State::ready:
+    stateSet_ = getModel()->getReadyActionSet();
+    break;
+  case Action::State::running:
+    stateSet_ = getModel()->getRunningActionSet();
+    break;
+  case Action::State::failed:
+    stateSet_ = getModel()->getFailedActionSet();
+    break;
+  case Action::State::done:
+    stateSet_ = getModel()->getDoneActionSet();
+    break;
+  default:
+    stateSet_ = nullptr;
+    break;
+  }
+  if (stateSet_)
+    stateSet_->push_back(*this);
 }
 
-surf_action_t surf_cpu_execute(surf_resource_t cpu, double size){
-  return get_casted_cpu(cpu)->execute(size);
+double Action::getBound()
+{
+  return (variable_) ? lmm_variable_getbound(variable_) : 0;
 }
 
-surf_action_t surf_cpu_sleep(surf_resource_t cpu, double duration){
-  return get_casted_cpu(cpu)->sleep(duration);
+void Action::setBound(double bound)
+{
+  XBT_IN("(%p,%g)", this, bound);
+  if (variable_)
+    lmm_update_variable_bound(getModel()->getMaxminSystem(), variable_, bound);
+
+  if (getModel()->getUpdateMechanism() == UM_LAZY && getLastUpdate()!=surf_get_clock())
+    heapRemove(getModel()->getActionHeap());
+  XBT_OUT();
 }
 
-double surf_action_get_start_time(surf_action_t action){
-  return action->m_start;
+double Action::getStartTime()
+{
+  return start_;
 }
 
-double surf_action_get_finish_time(surf_action_t action){
-  return action->m_finish;
+double Action::getFinishTime()
+{
+  /* keep the function behavior, some models (cpu_ti) change the finish time before the action end */
+  return remains_ == 0 ? finishTime_ : -1;
 }
 
-double surf_action_get_remains(surf_action_t action){
-  return action->getRemains();
+void Action::setData(void* data)
+{
+  data_ = data;
 }
 
-void surf_action_unref(surf_action_t action){
-  action->unref();
+void Action::setCategory(const char *category)
+{
+  XBT_IN("(%p,%s)", this, category);
+  category_ = xbt_strdup(category);
+  XBT_OUT();
 }
 
-void surf_action_suspend(surf_action_t action){
-  action->suspend();
+void Action::ref(){
+  refcount_++;
 }
 
-void surf_action_resume(surf_action_t action){
-  action->resume();
+void Action::setMaxDuration(double duration)
+{
+  XBT_IN("(%p,%g)", this, duration);
+  maxDuration_ = duration;
+  if (getModel()->getUpdateMechanism() == UM_LAZY)      // remove action from the heap
+    heapRemove(getModel()->getActionHeap());
+  XBT_OUT();
 }
 
-void surf_action_cancel(surf_action_t action){
-  action->cancel();
+void Action::gapRemove() {}
+
+void Action::setPriority(double priority)
+{
+  XBT_IN("(%p,%g)", this, priority);
+  priority_ = priority;
+  lmm_update_variable_weight(getModel()->getMaxminSystem(), getVariable(), priority);
+
+  if (getModel()->getUpdateMechanism() == UM_LAZY)
+    heapRemove(getModel()->getActionHeap());
+  XBT_OUT();
 }
 
-void surf_action_set_priority(surf_action_t action, double priority){
-  action->setPriority(priority);
+void Action::cancel(){
+  setState(Action::State::failed);
+  if (getModel()->getUpdateMechanism() == UM_LAZY) {
+    if (action_lmm_hook.is_linked())
+      getModel()->getModifiedSet()->erase(getModel()->getModifiedSet()->iterator_to(*this));
+    heapRemove(getModel()->getActionHeap());
+  }
 }
 
-void surf_action_set_category(surf_action_t action, const char *category){
-  action->setCategory(category);
+int Action::unref(){
+  refcount_--;
+  if (!refcount_) {
+    if (action_hook.is_linked())
+      stateSet_->erase(stateSet_->iterator_to(*this));
+    if (getVariable())
+      lmm_variable_free(getModel()->getMaxminSystem(), getVariable());
+    if (getModel()->getUpdateMechanism() == UM_LAZY) {
+      /* remove from heap */
+      heapRemove(getModel()->getActionHeap());
+      if (action_lmm_hook.is_linked())
+        getModel()->getModifiedSet()->erase(getModel()->getModifiedSet()->iterator_to(*this));
+    }
+    delete this;
+    return 1;
+  }
+  return 0;
 }
 
-void *surf_action_get_data(surf_action_t action){
-  return action->p_data;
+void Action::suspend()
+{
+  XBT_IN("(%p)", this);
+  if (suspended_ != 2) {
+    lmm_update_variable_weight(getModel()->getMaxminSystem(), getVariable(), 0.0);
+    suspended_ = 1;
+    if (getModel()->getUpdateMechanism() == UM_LAZY)
+      heapRemove(getModel()->getActionHeap());
+  }
+  XBT_OUT();
 }
 
-void surf_action_set_data(surf_action_t action, void *data){
-  action->p_data = data;
+void Action::resume()
+{
+  XBT_IN("(%p)", this);
+  if (suspended_ != 2) {
+    lmm_update_variable_weight(getModel()->getMaxminSystem(), getVariable(), priority_);
+    suspended_ = 0;
+    if (getModel()->getUpdateMechanism() == UM_LAZY)
+      heapRemove(getModel()->getActionHeap());
+  }
+  XBT_OUT();
 }
 
-e_surf_action_state_t surf_action_get_state(surf_action_t action){
-  return action->getState();
+bool Action::isSuspended()
+{
+  return suspended_ == 1;
+}
+/* insert action on heap using a given key and a hat (heap_action_type)
+ * a hat can be of three types for communications:
+ *
+ * NORMAL = this is a normal heap entry stating the date to finish transmitting
+ * LATENCY = this is a heap entry to warn us when the latency is payed
+ * MAX_DURATION =this is a heap entry to warn us when the max_duration limit is reached
+ */
+void Action::heapInsert(xbt_heap_t heap, double key, enum heap_action_type hat)
+{
+  hat_ = hat;
+  xbt_heap_push(heap, this, key);
 }
 
-int surf_action_get_cost(surf_action_t action){
-  return action->m_cost;
+void Action::heapRemove(xbt_heap_t heap)
+{
+  hat_ = NOTSET;
+  if (indexHeap_ >= 0) {
+    xbt_heap_remove(heap, indexHeap_);
+  }
 }
 
-void surf_cpu_action_set_affinity(surf_action_t action, surf_resource_t cpu, unsigned long mask) {
-  dynamic_cast<CpuActionPtr>(action)->setAffinity(get_casted_cpu(cpu), mask);
+void Action::heapUpdate(xbt_heap_t heap, double key, enum heap_action_type hat)
+{
+  hat_ = hat;
+  if (indexHeap_ >= 0) {
+    xbt_heap_update(heap, indexHeap_, key);
+  }else{
+    xbt_heap_push(heap, this, key);
+  }
 }
 
-void surf_cpu_action_set_bound(surf_action_t action, double bound) {
-  dynamic_cast<CpuActionPtr>(action)->setBound(bound);
+void Action::updateIndexHeap(int i) {
+  indexHeap_ = i;
 }
 
-surf_file_t surf_storage_action_get_file(surf_action_t action){
-  return dynamic_cast<StorageActionPtr>(action)->p_file;
+double Action::getRemains()
+{
+  XBT_IN("(%p)", this);
+  /* update remains before return it */
+  if (getModel()->getUpdateMechanism() == UM_LAZY)      /* update remains before return it */
+    updateRemainingLazy(surf_get_clock());
+  XBT_OUT();
+  return remains_;
 }
 
-xbt_dict_t surf_storage_action_get_ls_dict(surf_action_t action){
-  return dynamic_cast<StorageActionPtr>(action)->p_lsDict;
+double Action::getRemainsNoUpdate()
+{
+  return remains_;
 }
 
+//FIXME split code in the right places
+void Action::updateRemainingLazy(double now)
+{
+  double delta = 0.0;
+
+  if(getModel() == surf_network_model)
+  {
+    if (suspended_ != 0)
+      return;
+  }
+  else
+  {
+    xbt_assert(stateSet_ == getModel()->getRunningActionSet(), "You're updating an action that is not running.");
+    xbt_assert(priority_ > 0, "You're updating an action that seems suspended.");
+  }
+
+  delta = now - lastUpdate_;
+
+  if (remains_ > 0) {
+    XBT_DEBUG("Updating action(%p): remains was %f, last_update was: %f", this, remains_, lastUpdate_);
+    double_update(&remains_, lastValue_ * delta, sg_surf_precision*sg_maxmin_precision);
 
+    if (getModel() == surf_cpu_model_pm && TRACE_is_enabled()) {
+      simgrid::surf::Resource *cpu = static_cast<simgrid::surf::Resource*>(
+        lmm_constraint_id(lmm_get_cnst_from_var(getModel()->getMaxminSystem(), getVariable(), 0)));
+      TRACE_surf_host_set_utilization(cpu->getName(), getCategory(), lastValue_, lastUpdate_, now - lastUpdate_);
+    }
+    XBT_DEBUG("Updating action(%p): remains is now %f", this, remains_);
+  }
+
+  if(getModel() == surf_network_model)
+  {
+    if (maxDuration_ != NO_MAX_DURATION)
+      double_update(&maxDuration_, delta, sg_surf_precision);
+
+    //FIXME: duplicated code
+    if ((remains_ <= 0) &&
+        (lmm_get_variable_weight(getVariable()) > 0)) {
+      finish();
+      setState(Action::State::done);
+      heapRemove(getModel()->getActionHeap());
+    } else if (((maxDuration_ != NO_MAX_DURATION)
+        && (maxDuration_ <= 0))) {
+      finish();
+      setState(Action::State::done);
+      heapRemove(getModel()->getActionHeap());
+    }
+  }
+
+  lastUpdate_ = now;
+  lastValue_ = lmm_variable_getvalue(getVariable());
+}
+
+}
+}