Logo AND Algorithmique Numérique Distribuée

Public GIT Repository
Better fix to the comparison between signed and unsigned int around dynar size: chang...
[simgrid.git] / src / surf / workstation_KCCFLN05.c
index 729f3e4..727c460 100644 (file)
@@ -11,6 +11,7 @@
 
 XBT_LOG_NEW_DEFAULT_SUBCATEGORY(surf_workstation, surf,
                                "Logging specific to the SURF workstation module (KCCFLN05)");
+XBT_LOG_EXTERNAL_CATEGORY(surf_parse);
 
 typedef enum {
   SURF_WORKSTATION_RESOURCE_CPU,
@@ -31,9 +32,10 @@ typedef struct router_KCCFLN05 {
 /********* cpu object *****************/
 /**************************************/
 typedef struct cpu_KCCFLN05 {
-  surf_model_t model;
-  e_surf_workstation_model_type_t type;        /* Do not move this field */
-  char *name;                                  /* Do not move this field */
+  surf_model_t model;                   /* Do not move this field: must match model_obj_t */
+  xbt_dict_t properties;                /* Do not move this field: must match link_KCCFLN05_t */
+  e_surf_workstation_model_type_t type;        /* Do not move this field: must match link_KCCFLN05_t */
+  char *name;                          /* Do not move this field: must match link_KCCFLN05_t */
   lmm_constraint_t constraint;
   lmm_constraint_t bus;
   double power_scale;
@@ -47,8 +49,6 @@ typedef struct cpu_KCCFLN05 {
   int id;                      /* cpu and network card are a single object... */
   xbt_dynar_t incomming_communications;
   xbt_dynar_t outgoing_communications;
-  /*Handles the properties that can be added to cpu's*/
-  xbt_dict_t properties;
 } s_cpu_KCCFLN05_t, *cpu_KCCFLN05_t;
 
 /**************************************/
@@ -56,9 +56,10 @@ typedef struct cpu_KCCFLN05 {
 /**************************************/
 
 typedef struct link_KCCFLN05 {
-  surf_model_t model;
-  e_surf_workstation_model_type_t type;        /* Do not move this field */
-  char *name;                                  /* Do not move this field */
+  surf_model_t model;                   /* Do not move this field: must match model_obj_t */
+  xbt_dict_t properties;                /* Do not move this field: must match cpu_KCCFLN05_t */
+  e_surf_workstation_model_type_t type;        /* Do not move this field: must match cpu_KCCFLN05_t */
+  char *name;                          /* Do not move this field: must match cpu_KCCFLN05_t */
   lmm_constraint_t constraint;
   double lat_current;
   tmgr_trace_event_t lat_event;
@@ -66,8 +67,6 @@ typedef struct link_KCCFLN05 {
   tmgr_trace_event_t bw_event;
   e_surf_link_state_t state_current;
   tmgr_trace_event_t state_event;
-  /*holds the properties that can be attached to the link*/
-  xbt_dict_t properties;
 } s_link_KCCFLN05_t, *link_KCCFLN05_t;
 
 
@@ -105,13 +104,12 @@ static xbt_dict_t parallel_task_link_set = NULL;
 //added to work with GTNETS
 static xbt_dict_t router_set = NULL;
 static lmm_system_t maxmin_system = NULL;
-/*xbt_dict_t link_set = NULL;*/
 
 
 /* convenient function */
 static void __update_cpu_usage(cpu_KCCFLN05_t cpu)
 {
-  int cpt;
+  unsigned int cpt;
   surf_action_workstation_KCCFLN05_t action = NULL;
   if ((!xbt_dynar_length(cpu->incomming_communications)) &&
       (!xbt_dynar_length(cpu->outgoing_communications))) {
@@ -194,6 +192,13 @@ static const char *get_resource_name(void *resource_id)
   return ((cpu_KCCFLN05_t) resource_id)->name;
 }
 
+static xbt_dict_t get_properties(void *resource)
+{
+  /* We can freely cast as a cpu_KCCFLN05_t because it has the same
+     prefix as link_KCCFLN05_t. */
+  return ((cpu_KCCFLN05_t) resource)->properties;
+}
+
 /* action_get_state is inherited from the surf module */
 
 static void action_use(surf_action_t action)
@@ -204,7 +209,7 @@ static void action_use(surf_action_t action)
 
 static int action_free(surf_action_t action)
 {
-  int cpt;
+  unsigned int cpt;
   surf_action_t act = NULL;
   cpu_KCCFLN05_t src = ((surf_action_workstation_KCCFLN05_t) action)->src;
   cpu_KCCFLN05_t dst = ((surf_action_workstation_KCCFLN05_t) action)->dst;
@@ -635,11 +640,6 @@ static double get_available_speed(void *cpu)
   return ((cpu_KCCFLN05_t) cpu)->power_current;
 }
 
-static xbt_dict_t get_property_list(void *cpu)
-{
-  return ((cpu_KCCFLN05_t) cpu)->properties;
-}
-
 static surf_action_t communicate(void *src, void *dst, double size,
                                 double rate)
 {
@@ -860,12 +860,6 @@ static double get_link_latency(const void *link)
   return ((link_KCCFLN05_t) link)->lat_current;
 }
 
-static xbt_dict_t get_link_property_list(void *link)
-{
- return ((link_KCCFLN05_t) link)->properties;
-}
-
-
 /**************************************/
 /*** Resource Creation & Destruction **/
 /**************************************/
@@ -916,7 +910,12 @@ static cpu_KCCFLN05_t cpu_new(const char *name, double power_scale,
                              xbt_dict_t cpu_properties_k)
 {
   cpu_KCCFLN05_t cpu = xbt_new0(s_cpu_KCCFLN05_t, 1);
+  xbt_assert1(! xbt_dict_get_or_null(workstation_set, name),
+             "Host '%s' declared several times in the platform file.",name);
 
+  CDEBUG8(surf_parse, "cpu_new(%s,power_scale=%.2f,power_initial=%.2f,state_init=%d,isend=%.2f,irecv=%.2f,isendrev=%.2f) -> %p",
+         name,power_scale,power_initial,state_initial,interference_send,interference_recv,interference_send_recv,cpu);
+   
   cpu->model = (surf_model_t) surf_workstation_model;
   cpu->type = SURF_WORKSTATION_RESOURCE_CPU;
   cpu->name = xbt_strdup(name);
@@ -999,7 +998,7 @@ static void parse_cpu_init(void)
   current_property_set = xbt_dict_new();
   cpu_new(A_surfxml_host_id, power_scale, power_initial, power_trace,
          state_initial, state_trace, interference_send, interference_recv,
-         interference_send_recv, max_outgoing_rate,/*add the properties*/current_property_set);
+         interference_send_recv, max_outgoing_rate,current_property_set);
 }
 
 static void link_free(void *nw_link)
@@ -1009,15 +1008,15 @@ static void link_free(void *nw_link)
 }
 
 static link_KCCFLN05_t link_new(char *name,
-                                               double bw_initial,
-                                               tmgr_trace_t bw_trace,
-                                               double lat_initial,
-                                               tmgr_trace_t lat_trace,
-                                               e_surf_link_state_t
-                                               state_initial,
-                                               tmgr_trace_t state_trace,
-                                               e_surf_link_sharing_policy_t
-                                               policy, xbt_dict_t network_properties_k)
+                               double bw_initial,
+                               tmgr_trace_t bw_trace,
+                               double lat_initial,
+                               tmgr_trace_t lat_trace,
+                               e_surf_link_state_t
+                               state_initial,
+                               tmgr_trace_t state_trace,
+                               e_surf_link_sharing_policy_t
+                               policy, xbt_dict_t properties_args)
 {
   link_KCCFLN05_t nw_link = xbt_new0(s_link_KCCFLN05_t, 1);
 
@@ -1045,7 +1044,7 @@ static link_KCCFLN05_t link_new(char *name,
     lmm_constraint_shared(nw_link->constraint);
 
   /*add the property set*/
-  nw_link->properties = network_properties_k;
+  nw_link->properties = properties_args;
 
   xbt_dict_set(link_set, name, nw_link, link_free);
 
@@ -1198,6 +1197,8 @@ static void parse_file(const char *file)
 {
   int i;
 
+  CDEBUG0(surf_parse, "Use the KCCFKN05 model");
+                                  
   /* Adding callback functions */
   surf_parse_reset_parser();
   surfxml_add_callback(STag_surfxml_host_cb_list, &parse_cpu_init);
@@ -1299,8 +1300,7 @@ static void model_init_internal(void)
   surf_workstation_model->extension_public->get_available_speed =
       get_available_speed;
 
-  surf_workstation_model->common_public->get_cpu_properties = get_property_list;
-  surf_workstation_model->common_public->get_link_properties = get_link_property_list;
+  surf_workstation_model->common_public->get_properties = get_properties;
 
   surf_workstation_model->extension_public->communicate = communicate;
   surf_workstation_model->extension_public->execute_parallel_task =