Fix null pointer dereference.

[simgrid.git] / src / s4u / s4u_Actor.cpp

diff --git a/src/s4u/s4u_Actor.cpp b/src/s4u/s4u_Actor.cpp
index 005dc0b..d4ecc67 100644 (file)
--- a/src/s4u/s4u_Actor.cpp
+++ b/src/s4u/s4u_Actor.cpp
@@ -8,11 +8,12 @@
 #include "simgrid/s4u/Actor.hpp"
 #include "simgrid/s4u/Exec.hpp"
 #include "simgrid/s4u/Host.hpp"
 #include "simgrid/s4u/Actor.hpp"
 #include "simgrid/s4u/Exec.hpp"
 #include "simgrid/s4u/Host.hpp"

+#include "simgrid/s4u/VirtualMachine.hpp"

 #include "src/kernel/activity/ExecImpl.hpp"
 #include "src/kernel/activity/ExecImpl.hpp"

-#include "src/simix/smx_host_private.hpp"

 #include "src/simix/smx_private.hpp"
 #include "src/surf/HostImpl.hpp"
 
 #include "src/simix/smx_private.hpp"
 #include "src/surf/HostImpl.hpp"
 

+#include <algorithm>

 #include <sstream>
 
 XBT_LOG_NEW_DEFAULT_CATEGORY(s4u_actor, "S4U actors");
 #include <sstream>
 
 XBT_LOG_NEW_DEFAULT_CATEGORY(s4u_actor, "S4U actors");


@@ -38,11 +39,25 @@ ActorPtr Actor::self()
 
   return self_context->get_actor()->iface();
 }
 
   return self_context->get_actor()->iface();
 }

+ActorPtr Actor::init(std::string name, s4u::Host* host)
+{
+  smx_actor_t self = SIMIX_process_self();
+  simgrid::kernel::actor::ActorImpl* actor =
+      simgrid::simix::simcall([self, name, host] { return self->init(std::move(name), host).get(); });
+  return actor->ciface();
+}
+
+ActorPtr Actor::start(std::function<void()> code)
+{
+  simgrid::simix::simcall([this, code] { pimpl_->start(code); });
+  return this;
+}

 
 ActorPtr Actor::create(std::string name, s4u::Host* host, std::function<void()> code)
 {
   simgrid::kernel::actor::ActorImpl* actor =
       simcall_process_create(std::move(name), std::move(code), nullptr, host, nullptr);
 
 ActorPtr Actor::create(std::string name, s4u::Host* host, std::function<void()> code)
 {
   simgrid::kernel::actor::ActorImpl* actor =
       simcall_process_create(std::move(name), std::move(code), nullptr, host, nullptr);

+

   return actor->iface();
 }
 
   return actor->iface();
 }
 


@@ -92,10 +107,10 @@ void Actor::on_exit(int_f_pvoid_pvoid_t fun,
   simgrid::simix::simcall([this, fun, data] { SIMIX_process_on_exit(pimpl_, fun, data); });
 }
 
   simgrid::simix::simcall([this, fun, data] { SIMIX_process_on_exit(pimpl_, fun, data); });
 }
 

-void Actor::on_exit(std::function<void(bool /*failed*/)> fun)
+void Actor::on_exit(std::function<void(bool /*failed*/)> const fun)

 {
   simgrid::simix::simcall(
 {
   simgrid::simix::simcall(

-      [this, fun] { SIMIX_process_on_exit(pimpl_, [fun](int a, void* data) { fun(a != 0); }, nullptr); });
+      [this, fun] { SIMIX_process_on_exit(pimpl_, [fun](int a, void* /*data*/) { fun(a != 0); }, nullptr); });

 }
 
 void Actor::migrate(Host* new_host)
 }
 
 void Actor::migrate(Host* new_host)


@@ -315,15 +330,21 @@ void parallel_execute(const std::vector<s4u::Host*>& hosts, const std::vector<do
   xbt_assert(hosts.size() * hosts.size() == bytes_amounts.size() || bytes_amounts.empty(),
              "bytes_amounts must be a matrix of size host_count * host_count (%zu*%zu), but it's of size %zu.",
              hosts.size(), hosts.size(), flops_amounts.size());
   xbt_assert(hosts.size() * hosts.size() == bytes_amounts.size() || bytes_amounts.empty(),
              "bytes_amounts must be a matrix of size host_count * host_count (%zu*%zu), but it's of size %zu.",
              hosts.size(), hosts.size(), flops_amounts.size());

-
-  /* The vectors live as parameter of parallel_execute. No copy is created for simcall_execution_parallel_start(),
-   * but that's OK because simcall_execution_wait() is called from here too.
-   */
-  smx_activity_t s = simcall_execution_parallel_start("", hosts.size(), hosts.data(),
-                                                      (flops_amounts.empty() ? nullptr : flops_amounts.data()),
-                                                      (bytes_amounts.empty() ? nullptr : bytes_amounts.data()),
-                                                      /* rate */ -1, timeout);
-  simcall_execution_wait(s);
+  /* Check that we are not mixing VMs and PMs in the parallel task */
+  bool is_a_vm = (nullptr != dynamic_cast<simgrid::s4u::VirtualMachine*>(hosts.front()));
+  xbt_assert(std::all_of(hosts.begin(), hosts.end(),
+                         [is_a_vm](s4u::Host* elm) {
+                           bool tmp_is_a_vm = (nullptr != dynamic_cast<simgrid::s4u::VirtualMachine*>(elm));
+                           return is_a_vm == tmp_is_a_vm;
+                         }),
+             "parallel_execute: mixing VMs and PMs is not supported (yet).");
+  /* checking for infinite values */
+  xbt_assert(std::all_of(flops_amounts.begin(), flops_amounts.end(), [](double elm) { return std::isfinite(elm); }),
+             "flops_amounts comprises infinite values!");
+  xbt_assert(std::all_of(bytes_amounts.begin(), bytes_amounts.end(), [](double elm) { return std::isfinite(elm); }),
+             "flops_amounts comprises infinite values!");
+
+  exec_init(hosts, flops_amounts, bytes_amounts)->set_timeout(timeout)->wait();

 }
 
 // deprecated
 }
 
 // deprecated


@@ -349,7 +370,13 @@ void parallel_execute(int host_nb, s4u::Host* const* host_list, const double* fl
 
 ExecPtr exec_init(double flops_amount)
 {
 
 ExecPtr exec_init(double flops_amount)
 {

-  return ExecPtr(new Exec(get_host(), flops_amount));
+  return ExecPtr(new ExecSeq(get_host(), flops_amount));
+}
+
+ExecPtr exec_init(const std::vector<s4u::Host*>& hosts, const std::vector<double>& flops_amounts,
+                  const std::vector<double>& bytes_amounts)
+{
+  return ExecPtr(new ExecPar(hosts, flops_amounts, bytes_amounts));

 }
 
 ExecPtr exec_async(double flops)
 }
 
 ExecPtr exec_async(double flops)


@@ -405,12 +432,12 @@ void exit()
   simgrid::simix::simcall([actor] { actor->exit(); });
 }
 
   simgrid::simix::simcall([actor] { actor->exit(); });
 }
 

-void on_exit(std::function<void(bool)> fun)
+void on_exit(std::function<void(bool)> const fun)

 {
   SIMIX_process_self()->iface()->on_exit(fun);
 }
 
 {
   SIMIX_process_self()->iface()->on_exit(fun);
 }
 

-void on_exit(std::function<void(int, void*)> fun, void* data) /* deprecated */
+void on_exit(std::function<void(int, void*)> const fun, void* data) /* deprecated */

 {
   SIMIX_process_self()->iface()->on_exit([fun, data](bool exit) { fun(exit, data); });
 }
 {
   SIMIX_process_self()->iface()->on_exit([fun, data](bool exit) { fun(exit, data); });
 }