#include <algorithm>
#include <memory>
+#include <list>
#include <unistd.h>
#include <sys/wait.h>
#include <xbt/automaton.h>
#include <xbt/dynar.h>
#include <xbt/dynar.hpp>
-#include <xbt/fifo.h>
#include <xbt/log.h>
#include <xbt/sysdep.h>
/********* Global variables *********/
-xbt_dynar_t acceptance_pairs;
-
/********* Static functions *********/
namespace simgrid {
namespace mc {
-VisitedPair::VisitedPair(int pair_num, xbt_automaton_state_t automaton_state, xbt_dynar_t atomic_propositions, mc_state_t graph_state)
+std::list<VisitedPair*> LivenessChecker::acceptance_pairs;
+std::list<Pair*> LivenessChecker::liveness_stack;
+xbt_dynar_t LivenessChecker::visited_pairs;
+
+VisitedPair::VisitedPair(int pair_num, xbt_automaton_state_t automaton_state, xbt_dynar_t atomic_propositions, std::shared_ptr<simgrid::mc::State> graph_state)
{
simgrid::mc::Process* process = &(mc_model_checker->process());
- this->graph_state = graph_state;
+ this->graph_state = std::move(graph_state);
if(this->graph_state->system_state == nullptr)
this->graph_state->system_state = simgrid::mc::take_snapshot(pair_num);
this->heap_bytes_used = mmalloc_get_bytes_used_remote(
xbt_dynar_push_as(this->atomic_propositions.get(), int, value);
}
-static int is_exploration_stack_pair(simgrid::mc::VisitedPair* pair){
- xbt_fifo_item_t item = xbt_fifo_get_first_item(mc_stack);
- while (item) {
- if (((simgrid::mc::Pair*)xbt_fifo_get_item_content(item))->num == pair->num){
- ((simgrid::mc::Pair*)xbt_fifo_get_item_content(item))->visited_pair_removed = 1;
- return 1;
- }
- item = xbt_fifo_get_next_item(item);
- }
- return 0;
-}
-
VisitedPair::~VisitedPair()
{
- if( !is_exploration_stack_pair(this))
- MC_state_delete(this->graph_state, 1);
}
static int MC_automaton_evaluate_label(xbt_automaton_exp_label_t l,
}
}
-static xbt_dynar_t visited_pairs;
-
-Pair::Pair() : num(++mc_stats->expanded_pairs),
- visited_pair_removed(_sg_mc_visited > 0 ? 0 : 1)
+Pair::Pair() : num(++mc_stats->expanded_pairs)
{}
-Pair::~Pair() {
- if (this->visited_pair_removed)
- MC_state_delete(this->graph_state, 1);
-}
+Pair::~Pair() {}
simgrid::xbt::unique_ptr<s_xbt_dynar_t> LivenessChecker::getPropositionValues()
{
int res = xbt_automaton_propositional_symbol_evaluate(ps);
xbt_dynar_push_as(values.get(), int, res);
}
- return std::move(values);
+ return values;
}
int LivenessChecker::compare(simgrid::mc::VisitedPair* state1, simgrid::mc::VisitedPair* state2)
{
- simgrid::mc::Snapshot* s1 = state1->graph_state->system_state;
- simgrid::mc::Snapshot* s2 = state2->graph_state->system_state;
+ simgrid::mc::Snapshot* s1 = state1->graph_state->system_state.get();
+ simgrid::mc::Snapshot* s2 = state2->graph_state->system_state.get();
int num1 = state1->num;
int num2 = state2->num;
return simgrid::mc::snapshot_compare(num1, s1, num2, s2);
simgrid::mc::VisitedPair* LivenessChecker::insertAcceptancePair(simgrid::mc::Pair* pair)
{
- auto acceptance_pairs = simgrid::xbt::range<simgrid::mc::VisitedPair*>(::acceptance_pairs);
auto new_pair =
std::unique_ptr<simgrid::mc::VisitedPair>(new VisitedPair(
pair->num, pair->automaton_state, pair->atomic_propositions.get(),
new_pair->atomic_propositions.get()) == 0) {
if (this->compare(pair_test, new_pair.get()) == 0) {
XBT_INFO("Pair %d already reached (equal to pair %d) !", new_pair->num, pair_test->num);
- xbt_fifo_shift(mc_stack);
+ liveness_stack.pop_back();
if (dot_output != nullptr)
fprintf(dot_output, "\"%d\" -> \"%d\" [%s];\n", initial_global_state->prev_pair, pair_test->num, initial_global_state->prev_req);
return nullptr;
}
auto new_raw_pair = new_pair.release();
- xbt_dynar_insert_at(
- ::acceptance_pairs, res.first - acceptance_pairs.begin(), &new_raw_pair);
+ acceptance_pairs.insert(res.first, new_raw_pair);
return new_raw_pair;
}
void LivenessChecker::removeAcceptancePair(int pair_num)
{
- unsigned int cursor = 0;
- simgrid::mc::VisitedPair* pair_test = nullptr;
- int pair_found = 0;
-
- xbt_dynar_foreach(acceptance_pairs, cursor, pair_test)
- if (pair_test->num == pair_num) {
- pair_found = 1;
+ for (auto i = acceptance_pairs.begin(); i != acceptance_pairs.end(); ++i)
+ if ((*i)->num == pair_num) {
+ acceptance_pairs.erase(i);
+ (*i)->acceptance_removed = 1;
+ if (_sg_mc_visited == 0 || (*i)->visited_removed == 1)
+ delete *i;
break;
}
-
- if(pair_found == 1) {
- xbt_dynar_remove_at(acceptance_pairs, cursor, &pair_test);
-
- pair_test->acceptance_removed = 1;
-
- if (_sg_mc_visited == 0 || pair_test->visited_removed == 1)
- delete pair_test;
-
- }
}
void LivenessChecker::prepare(void)
{
simgrid::mc::Pair* initial_pair = nullptr;
mc_model_checker->wait_for_requests();
- acceptance_pairs = xbt_dynar_new(sizeof(simgrid::mc::VisitedPair*), nullptr);
+ acceptance_pairs.clear();
if(_sg_mc_visited > 0)
- simgrid::mc::visited_pairs = xbt_dynar_new(sizeof(simgrid::mc::VisitedPair*), nullptr);
+ LivenessChecker::visited_pairs = xbt_dynar_new(sizeof(simgrid::mc::VisitedPair*), nullptr);
initial_global_state->snapshot = simgrid::mc::take_snapshot(0);
initial_global_state->prev_pair = 0;
initial_pair = new Pair();
initial_pair->automaton_state = automaton_state;
- initial_pair->graph_state = MC_state_new();
+ initial_pair->graph_state = std::shared_ptr<simgrid::mc::State>(MC_state_new());
initial_pair->atomic_propositions = this->getPropositionValues();
initial_pair->depth = 1;
/* Get enabled processes and insert them in the interleave set of the graph_state */
for (auto& p : mc_model_checker->process().simix_processes())
if (simgrid::mc::process_is_enabled(&p.copy))
- MC_state_interleave_process(initial_pair->graph_state, &p.copy);
+ MC_state_interleave_process(initial_pair->graph_state.get(), &p.copy);
- initial_pair->requests = MC_state_interleave_size(initial_pair->graph_state);
+ initial_pair->requests = MC_state_interleave_size(initial_pair->graph_state.get());
initial_pair->search_cycle = 0;
- xbt_fifo_unshift(mc_stack, initial_pair);
+ liveness_stack.push_back(initial_pair);
}
}
}
-void LivenessChecker::replay(xbt_fifo_t stack)
+void LivenessChecker::replay()
{
- xbt_fifo_item_t item;
- simgrid::mc::Pair* pair = nullptr;
- mc_state_t state = nullptr;
smx_simcall_t req = nullptr, saved_req = NULL;
int value, depth = 1;
char *req_str;
/* Intermediate backtracking */
if(_sg_mc_checkpoint > 0) {
- item = xbt_fifo_get_first_item(stack);
- pair = (simgrid::mc::Pair*) xbt_fifo_get_item_content(item);
+ simgrid::mc::Pair* pair = liveness_stack.back();
if(pair->graph_state->system_state){
simgrid::mc::restore_snapshot(pair->graph_state->system_state);
return;
/* Restore the initial state */
simgrid::mc::restore_snapshot(initial_global_state->snapshot);
- /* Traverse the stack from the initial state and re-execute the transitions */
- for (item = xbt_fifo_get_last_item(stack);
- item != xbt_fifo_get_first_item(stack);
- item = xbt_fifo_get_prev_item(item)) {
-
- pair = (simgrid::mc::Pair*) xbt_fifo_get_item_content(item);
+ /* Traverse the stack from the initial state and re-execute the transitions */
+ for (simgrid::mc::Pair* pair : liveness_stack) {
+ if (pair == liveness_stack.back())
+ break;
- state = (mc_state_t) pair->graph_state;
+ std::shared_ptr<State> state = pair->graph_state;
if (pair->exploration_started) {
- saved_req = MC_state_get_executed_request(state, &value);
+ saved_req = MC_state_get_executed_request(state.get(), &value);
if (saved_req != nullptr) {
/* because we got a copy of the executed request, we have to fetch the
/* Debug information */
if (XBT_LOG_ISENABLED(mc_liveness, xbt_log_priority_debug)) {
req_str = simgrid::mc::request_to_string(req, value, simgrid::mc::RequestType::simix);
- XBT_DEBUG("Replay (depth = %d) : %s (%p)", depth, req_str, state);
+ XBT_DEBUG("Replay (depth = %d) : %s (%p)", depth, req_str, state.get());
xbt_free(req_str);
}
depth++;
- }
+ }
XBT_DEBUG("**** End Replay ****");
}
else
new_visited_pair = visited_pair;
- auto visited_pairs = simgrid::xbt::range<simgrid::mc::VisitedPair*>(simgrid::mc::visited_pairs);
+ auto visited_pairs = simgrid::xbt::range<simgrid::mc::VisitedPair*>(LivenessChecker::visited_pairs);
auto range = std::equal_range(visited_pairs.begin(), visited_pairs.end(),
new_visited_pair, simgrid::mc::DerefAndCompareByNbProcessesAndUsedHeap());
XBT_DEBUG("Pair %d already visited ! (equal to pair %d)", new_visited_pair->num, pair_test->num);
else
XBT_DEBUG("Pair %d already visited ! (equal to pair %d (pair %d in dot_output))", new_visited_pair->num, pair_test->num, new_visited_pair->other_num);
- xbt_dynar_remove_at(simgrid::mc::visited_pairs, cursor, &pair_test);
- xbt_dynar_insert_at(simgrid::mc::visited_pairs, cursor, &new_visited_pair);
+ xbt_dynar_remove_at(LivenessChecker::visited_pairs, cursor, &pair_test);
+ xbt_dynar_insert_at(LivenessChecker::visited_pairs, cursor, &new_visited_pair);
pair_test->visited_removed = 1;
if (!pair_test->acceptance_pair
|| pair_test->acceptance_removed == 1)
}
}
- xbt_dynar_insert_at(simgrid::mc::visited_pairs, range.first - visited_pairs.begin(), &new_visited_pair);
+ xbt_dynar_insert_at(LivenessChecker::visited_pairs, range.first - visited_pairs.begin(), &new_visited_pair);
if ((ssize_t) visited_pairs.size() > _sg_mc_visited) {
int min2 = mc_stats->expanded_pairs;
unsigned int index2 = 0;
for (std::size_t i = 0; i != (std::size_t) visited_pairs.size(); ++i) {
simgrid::mc::VisitedPair* pair_test = visited_pairs[i];
- if (!mc_model_checker->is_important_snapshot(*pair_test->graph_state->system_state)
- && pair_test->num < min2) {
+ if (pair_test->num < min2) {
index2 = i;
min2 = pair_test->num;
}
}
simgrid::mc::VisitedPair* pair_test = nullptr;
- xbt_dynar_remove_at(simgrid::mc::visited_pairs, index2, &pair_test);
+ xbt_dynar_remove_at(LivenessChecker::visited_pairs, index2, &pair_test);
pair_test->visited_removed = 1;
if (!pair_test->acceptance_pair || pair_test->acceptance_removed)
delete pair_test;
RecordTrace LivenessChecker::getRecordTrace() // override
{
RecordTrace res;
-
- xbt_fifo_item_t start = xbt_fifo_get_last_item(mc_stack);
- for (xbt_fifo_item_t item = start; item; item = xbt_fifo_get_prev_item(item)) {
- simgrid::mc::Pair* pair = (simgrid::mc::Pair*) xbt_fifo_get_item_content(item);
+ for (simgrid::mc::Pair* pair : liveness_stack) {
int value;
- smx_simcall_t req = MC_state_get_executed_request(pair->graph_state, &value);
+ smx_simcall_t req = MC_state_get_executed_request(pair->graph_state.get(), &value);
if (req && req->call != SIMCALL_NONE) {
smx_process_t issuer = MC_smx_simcall_get_issuer(req);
const int pid = issuer->pid;
res.push_back(RecordTraceElement(pid, value));
}
}
-
- return std::move(res);
+ return res;
}
void LivenessChecker::showAcceptanceCycle(std::size_t depth)
std::vector<std::string> LivenessChecker::getTextualTrace() // override
{
std::vector<std::string> trace;
- for (xbt_fifo_item_t item = xbt_fifo_get_last_item(mc_stack);
- item; item = xbt_fifo_get_prev_item(item)) {
- simgrid::mc::Pair* pair = (simgrid::mc::Pair*) xbt_fifo_get_item_content(item);
+ for (simgrid::mc::Pair* pair : liveness_stack) {
int value;
- smx_simcall_t req = MC_state_get_executed_request(pair->graph_state, &value);
+ smx_simcall_t req = MC_state_get_executed_request(pair->graph_state.get(), &value);
if (req && req->call != SIMCALL_NONE) {
char* req_str = simgrid::mc::request_to_string(req, value, simgrid::mc::RequestType::executed);
trace.push_back(std::string(req_str));
xbt_free(req_str);
}
}
- return std::move(trace);
+ return trace;
}
int LivenessChecker::main(void)
smx_simcall_t req = nullptr;
xbt_automaton_transition_t transition_succ = nullptr;
int cursor = 0;
- simgrid::mc::Pair* next_pair = nullptr;
simgrid::xbt::unique_ptr<s_xbt_dynar_t> prop_values;
simgrid::mc::VisitedPair* reached_pair = nullptr;
- while(xbt_fifo_size(mc_stack) > 0){
+ while (!liveness_stack.empty()){
/* Get current pair */
- current_pair = (simgrid::mc::Pair*) xbt_fifo_get_item_content(xbt_fifo_get_first_item(mc_stack));
+ current_pair = liveness_stack.back();
/* Update current state in buchi automaton */
simgrid::mc::property_automaton->current_state = current_pair->automaton_state;
XBT_DEBUG("********************* ( Depth = %d, search_cycle = %d, interleave size = %d, pair_num = %d, requests = %d)",
current_pair->depth, current_pair->search_cycle,
- MC_state_interleave_size(current_pair->graph_state), current_pair->num,
+ MC_state_interleave_size(current_pair->graph_state.get()), current_pair->num,
current_pair->requests);
if (current_pair->requests > 0) {
}else{
- req = MC_state_get_request(current_pair->graph_state, &value);
+ req = MC_state_get_request(current_pair->graph_state.get(), &value);
if (dot_output != nullptr) {
if (initial_global_state->prev_pair != 0 && initial_global_state->prev_pair != current_pair->num) {
xbt_free(req_str);
/* Set request as executed */
- MC_state_set_executed_request(current_pair->graph_state, req, value);
+ MC_state_set_executed_request(current_pair->graph_state.get(), req, value);
/* Update mc_stats */
mc_stats->executed_transitions++;
transition_succ = (xbt_automaton_transition_t)xbt_dynar_get_as(current_pair->automaton_state->out, cursor, xbt_automaton_transition_t);
res = MC_automaton_evaluate_label(transition_succ->label, prop_values.get());
if (res == 1 || res == 2) { /* 1 = True transition (always enabled), 2 = enabled transition according to atomic prop values */
- next_pair = new Pair();
- next_pair->graph_state = MC_state_new();
+ Pair* next_pair = new Pair();
+ next_pair->graph_state = std::shared_ptr<simgrid::mc::State>(MC_state_new());
next_pair->automaton_state = transition_succ->dst;
next_pair->atomic_propositions = this->getPropositionValues();
next_pair->depth = current_pair->depth + 1;
/* Get enabled processes and insert them in the interleave set of the next graph_state */
for (auto& p : mc_model_checker->process().simix_processes())
if (simgrid::mc::process_is_enabled(&p.copy))
- MC_state_interleave_process(next_pair->graph_state, &p.copy);
+ MC_state_interleave_process(next_pair->graph_state.get(), &p.copy);
- next_pair->requests = MC_state_interleave_size(next_pair->graph_state);
+ next_pair->requests = MC_state_interleave_size(next_pair->graph_state.get());
/* FIXME : get search_cycle value for each acceptant state */
if (next_pair->automaton_state->type == 1 || current_pair->search_cycle)
next_pair->search_cycle = 1;
/* Add new pair to the exploration stack */
- xbt_fifo_unshift(mc_stack, next_pair);
+ liveness_stack.push_back(next_pair);
}
cursor--;
/* Traverse the stack backwards until a pair with a non empty interleave
set is found, deleting all the pairs that have it empty in the way. */
- while ((current_pair = (simgrid::mc::Pair*) xbt_fifo_shift(mc_stack)) != nullptr) {
+ while (!liveness_stack.empty()) {
+ current_pair = liveness_stack.back();
+ liveness_stack.pop_back();
if (current_pair->requests > 0) {
/* We found a backtracking point */
XBT_DEBUG("Backtracking to depth %d", current_pair->depth);
- xbt_fifo_unshift(mc_stack, current_pair);
- this->replay(mc_stack);
+ liveness_stack.push_back(current_pair);
+ this->replay();
XBT_DEBUG("Backtracking done");
break;
}else{
} /* End of if (current_pair->requests > 0) else ... */
- } /* End of while(xbt_fifo_size(mc_stack) > 0) */
+ }
XBT_INFO("No property violation found.");
MC_print_statistics(mc_stats);
_sg_mc_liveness = 1;
/* Create exploration stack */
- mc_stack = xbt_fifo_new();
+ liveness_stack.clear();
/* Create the initial state */
- initial_global_state = xbt_new0(s_mc_global_t, 1);
+ simgrid::mc::initial_global_state = std::unique_ptr<s_mc_global_t>(new s_mc_global_t());
this->prepare();
- return this->main();
+ int res = this->main();
+ simgrid::mc::initial_global_state = nullptr;
+ return res;
}
}