Apply the default settings of 'smpi/buffering' too

[simgrid.git] / src / xbt / config.cpp

diff --git a/src/xbt/config.cpp b/src/xbt/config.cpp
index 6c2cc3a..e51a1ba 100644 (file)
--- a/src/xbt/config.cpp
+++ b/src/xbt/config.cpp
@@ -12,6 +12,7 @@
 
 #include <functional>
 #include <map>
+#include <memory>
 #include <stdexcept>
 #include <string>
 #include <string>
@@ -252,14 +253,13 @@ template <class T> const char* TypedConfigurationElement<T>::get_type_name() //
 class Config {
 private:
   // name -> ConfigElement:
-  std::map<std::string, simgrid::config::ConfigurationElement*> options;
+  std::map<std::string, std::unique_ptr<ConfigurationElement>> options;
   // alias -> ConfigElement from options:
-  std::map<std::string, simgrid::config::ConfigurationElement*> aliases;
+  std::map<std::string, ConfigurationElement*> aliases;
   bool warn_for_aliases = true;
 
 public:
   Config();
-  ~Config();
 
   // No copy:
   Config(Config const&) = delete;
@@ -268,15 +268,14 @@ public:
   ConfigurationElement& operator[](const std::string& name);
   void alias(const std::string& realname, const std::string& aliasname);
 
-  template <class T, class... A>
-  simgrid::config::TypedConfigurationElement<T>* register_option(const std::string& name, A&&... a)
+  template <class T, class... A> TypedConfigurationElement<T>* register_option(const std::string& name, A&&... a)
   {
     xbt_assert(options.find(name) == options.end(), "Refusing to register the config element '%s' twice.",
                name.c_str());
     TypedConfigurationElement<T>* variable = new TypedConfigurationElement<T>(name, std::forward<A>(a)...);
     XBT_DEBUG("Register cfg elm %s (%s) of type %s @%p in set %p)", name.c_str(), variable->get_description().c_str(),
               variable->get_type_name(), variable, this);
-    options.insert({name, variable});
+    options[name].reset(variable);
     variable->update();
     return variable;
   }
@@ -294,18 +293,12 @@ Config::Config()
 {
   atexit(&sg_config_finalize);
 }
-Config::~Config()
-{
-  XBT_DEBUG("Frees cfg set %p", this);
-  for (auto const& elm : options)
-    delete elm.second;
-}
 
 inline ConfigurationElement* Config::get_dict_element(const std::string& name)
 {
   auto opt = options.find(name);
   if (opt != options.end()) {
-    return opt->second;
+    return opt->second.get();
   } else {
     auto als = aliases.find(name);
     if (als != aliases.end()) {
@@ -314,7 +307,10 @@ inline ConfigurationElement* Config::get_dict_element(const std::string& name)
         XBT_INFO("Option %s has been renamed to %s. Consider switching.", name.c_str(), res->get_key().c_str());
       return res;
     } else {
-      THROWF(not_found_error, 0, "Bad config key: %s", name.c_str());
+      std::string msg = "Bad config key: " + name + "\nExisting config keys:\n";
+      for (auto const& elm : options)
+        msg += "  " + elm.first + ": (" + elm.second->get_type_name() + ")" + elm.second->get_string_value() + "\n";
+      throw std::out_of_range(msg);
     }
   }
 }
@@ -362,7 +358,7 @@ void Config::show_aliases()
 void Config::help()
 {
   for (auto const& elm : options) {
-    simgrid::config::ConfigurationElement* variable = this->options.at(elm.first);
+    simgrid::config::ConfigurationElement* variable = elm.second.get();
     XBT_HELP("   %s: %s", elm.first.c_str(), variable->get_description().c_str());
     XBT_HELP("       Type: %s; Current value: %s", variable->get_type_name(), variable->get_string_value().c_str());
   }
@@ -502,6 +498,11 @@ void help()
  * @param value the value of the variable
  */
 void xbt_cfg_set_int(const char *key, int value)
+{
+  sg_cfg_set_int(key, value);
+}
+
+void sg_cfg_set_int(const char* key, int value)
 {
   (*simgrid_config)[key].set_value<int>(value);
 }
@@ -512,6 +513,11 @@ void xbt_cfg_set_int(const char *key, int value)
  * @param value the double to set
  */
 void xbt_cfg_set_double(const char *key, double value)
+{
+  sg_cfg_set_double(key, value);
+}
+
+void sg_cfg_set_double(const char* key, double value)
 {
   (*simgrid_config)[key].set_value<double>(value);
 }
@@ -523,6 +529,11 @@ void xbt_cfg_set_double(const char *key, double value)
  *
  */
 void xbt_cfg_set_string(const char* key, const char* value)
+{
+  sg_cfg_set_string(key, value);
+}
+
+void sg_cfg_set_string(const char* key, const char* value)
 {
   (*simgrid_config)[key].set_value<std::string>(value);
 }
@@ -533,6 +544,11 @@ void xbt_cfg_set_string(const char* key, const char* value)
  * @param value the value of the variable
  */
 void xbt_cfg_set_boolean(const char *key, const char *value)
+{
+  sg_cfg_set_boolean(key, value);
+}
+
+void sg_cfg_set_boolean(const char* key, const char* value)
 {
   (*simgrid_config)[key].set_value<bool>(simgrid::config::parse_bool(value));
 }
@@ -545,6 +561,11 @@ void xbt_cfg_set_boolean(const char *key, const char *value)
  * Returns the first value from the config set under the given name.
  */
 int xbt_cfg_get_int(const char *key)
+{
+  return sg_cfg_get_int(key);
+}
+
+int sg_cfg_get_int(const char* key)
 {
   return (*simgrid_config)[key].get_value<int>();
 }
@@ -556,6 +577,11 @@ int xbt_cfg_get_int(const char *key)
  * Returns the first value from the config set under the given name.
  */
 double xbt_cfg_get_double(const char *key)
+{
+  return sg_cfg_get_double(key);
+}
+
+double sg_cfg_get_double(const char* key)
 {
   return (*simgrid_config)[key].get_value<double>();
 }
@@ -568,6 +594,11 @@ double xbt_cfg_get_double(const char *key)
  * If there is more than one value, it will issue a warning.
  */
 int xbt_cfg_get_boolean(const char *key)
+{
+  return sg_cfg_get_boolean(key);
+}
+
+int sg_cfg_get_boolean(const char* key)
 {
   return (*simgrid_config)[key].get_value<bool>() ? 1 : 0;
 }