A
lgorithmique
N
umérique
D
istribuée
Public GIT Repository
projects
/
simgrid.git
/ blobdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
|
commitdiff
|
tree
raw
|
inline
| side by side
[sonar] initialization lists and co.
[simgrid.git]
/
src
/
xbt
/
config.cpp
diff --git
a/src/xbt/config.cpp
b/src/xbt/config.cpp
index
6c2cc3a
..
758650c
100644
(file)
--- a/
src/xbt/config.cpp
+++ b/
src/xbt/config.cpp
@@
-12,6
+12,7
@@
#include <functional>
#include <map>
#include <functional>
#include <map>
+#include <memory>
#include <stdexcept>
#include <string>
#include <string>
#include <stdexcept>
#include <string>
#include <string>
@@
-140,14
+141,7
@@
private:
bool isdefault = true;
public:
bool isdefault = true;
public:
- /* Callback */
- xbt_cfg_cb_t old_callback = nullptr;
-
ConfigurationElement(const std::string& key, const std::string& desc) : key(key), desc(desc) {}
ConfigurationElement(const std::string& key, const std::string& desc) : key(key), desc(desc) {}
- ConfigurationElement(const std::string& key, const std::string& desc, xbt_cfg_cb_t cb)
- : key(key), desc(desc), old_callback(cb)
- {
- }
virtual ~ConfigurationElement() = default;
virtual ~ConfigurationElement() = default;
@@
-187,9
+181,6
@@
public:
TypedConfigurationElement(const std::string& key, const std::string& desc, T value = T())
: ConfigurationElement(key, desc), content(std::move(value))
{}
TypedConfigurationElement(const std::string& key, const std::string& desc, T value = T())
: ConfigurationElement(key, desc), content(std::move(value))
{}
- TypedConfigurationElement(const std::string& key, const std::string& desc, T value, xbt_cfg_cb_t cb)
- : ConfigurationElement(key, desc, cb), content(std::move(value))
- {}
TypedConfigurationElement(const std::string& key, const std::string& desc, T value, std::function<void(T&)> callback)
: ConfigurationElement(key, desc), content(std::move(value)), callback(std::move(callback))
{}
TypedConfigurationElement(const std::string& key, const std::string& desc, T value, std::function<void(T&)> callback)
: ConfigurationElement(key, desc), content(std::move(value)), callback(std::move(callback))
{}
@@
-201,8
+192,6
@@
public:
void update()
{
void update()
{
- if (old_callback)
- this->old_callback(get_key().c_str());
if (this->callback)
this->callback(this->content);
}
if (this->callback)
this->callback(this->content);
}
@@
-252,14
+241,13
@@
template <class T> const char* TypedConfigurationElement<T>::get_type_name() //
class Config {
private:
// name -> ConfigElement:
class Config {
private:
// name -> ConfigElement:
- std::map<std::string, s
imgrid::config::ConfigurationElement*
> options;
+ std::map<std::string, s
td::unique_ptr<ConfigurationElement>
> options;
// alias -> ConfigElement from options:
// alias -> ConfigElement from options:
- std::map<std::string,
simgrid::config::
ConfigurationElement*> aliases;
+ std::map<std::string, ConfigurationElement*> aliases;
bool warn_for_aliases = true;
public:
Config();
bool warn_for_aliases = true;
public:
Config();
- ~Config();
// No copy:
Config(Config const&) = delete;
// No copy:
Config(Config const&) = delete;
@@
-268,15
+256,14
@@
public:
ConfigurationElement& operator[](const std::string& name);
void alias(const std::string& realname, const std::string& aliasname);
ConfigurationElement& operator[](const std::string& name);
void alias(const std::string& realname, const std::string& aliasname);
- template <class T, class... A>
- simgrid::config::TypedConfigurationElement<T>* register_option(const std::string& name, A&&... a)
+ template <class T, class... A> TypedConfigurationElement<T>* register_option(const std::string& name, A&&... a)
{
xbt_assert(options.find(name) == options.end(), "Refusing to register the config element '%s' twice.",
name.c_str());
TypedConfigurationElement<T>* variable = new TypedConfigurationElement<T>(name, std::forward<A>(a)...);
XBT_DEBUG("Register cfg elm %s (%s) of type %s @%p in set %p)", name.c_str(), variable->get_description().c_str(),
variable->get_type_name(), variable, this);
{
xbt_assert(options.find(name) == options.end(), "Refusing to register the config element '%s' twice.",
name.c_str());
TypedConfigurationElement<T>* variable = new TypedConfigurationElement<T>(name, std::forward<A>(a)...);
XBT_DEBUG("Register cfg elm %s (%s) of type %s @%p in set %p)", name.c_str(), variable->get_description().c_str(),
variable->get_type_name(), variable, this);
- options
.insert({name, variable}
);
+ options
[name].reset(variable
);
variable->update();
return variable;
}
variable->update();
return variable;
}
@@
-294,18
+281,12
@@
Config::Config()
{
atexit(&sg_config_finalize);
}
{
atexit(&sg_config_finalize);
}
-Config::~Config()
-{
- XBT_DEBUG("Frees cfg set %p", this);
- for (auto const& elm : options)
- delete elm.second;
-}
inline ConfigurationElement* Config::get_dict_element(const std::string& name)
{
auto opt = options.find(name);
if (opt != options.end()) {
inline ConfigurationElement* Config::get_dict_element(const std::string& name)
{
auto opt = options.find(name);
if (opt != options.end()) {
- return opt->second;
+ return opt->second
.get()
;
} else {
auto als = aliases.find(name);
if (als != aliases.end()) {
} else {
auto als = aliases.find(name);
if (als != aliases.end()) {
@@
-314,7
+295,10
@@
inline ConfigurationElement* Config::get_dict_element(const std::string& name)
XBT_INFO("Option %s has been renamed to %s. Consider switching.", name.c_str(), res->get_key().c_str());
return res;
} else {
XBT_INFO("Option %s has been renamed to %s. Consider switching.", name.c_str(), res->get_key().c_str());
return res;
} else {
- THROWF(not_found_error, 0, "Bad config key: %s", name.c_str());
+ std::string msg = "Bad config key: " + name + "\nExisting config keys:\n";
+ for (auto const& elm : options)
+ msg += " " + elm.first + ": (" + elm.second->get_type_name() + ")" + elm.second->get_string_value() + "\n";
+ throw std::out_of_range(msg);
}
}
}
}
}
}
@@
-332,7
+316,7
@@
void Config::alias(const std::string& realname, const std::string& aliasname)
this->aliases.insert({aliasname, element});
}
this->aliases.insert({aliasname, element});
}
-/** @brief Dump a config set for debuging purpose
+/** @brief Dump a config set for debug
g
ing purpose
*
* @param name The name to give to this config set
* @param indent what to write at the beginning of each line (right number of spaces)
*
* @param name The name to give to this config set
* @param indent what to write at the beginning of each line (right number of spaces)
@@
-362,7
+346,7
@@
void Config::show_aliases()
void Config::help()
{
for (auto const& elm : options) {
void Config::help()
{
for (auto const& elm : options) {
- simgrid::config::ConfigurationElement* variable =
this->options.at(elm.first
);
+ simgrid::config::ConfigurationElement* variable =
elm.second.get(
);
XBT_HELP(" %s: %s", elm.first.c_str(), variable->get_description().c_str());
XBT_HELP(" Type: %s; Current value: %s", variable->get_type_name(), variable->get_string_value().c_str());
}
XBT_HELP(" %s: %s", elm.first.c_str(), variable->get_description().c_str());
XBT_HELP(" Type: %s; Current value: %s", variable->get_type_name(), variable->get_string_value().c_str());
}
@@
-501,7
+485,7
@@
void help()
* @param key the name of the variable
* @param value the value of the variable
*/
* @param key the name of the variable
* @param value the value of the variable
*/
-void
xbt_cfg_set_int(const char *
key, int value)
+void
sg_cfg_set_int(const char*
key, int value)
{
(*simgrid_config)[key].set_value<int>(value);
}
{
(*simgrid_config)[key].set_value<int>(value);
}
@@
-511,7
+495,7
@@
void xbt_cfg_set_int(const char *key, int value)
* @param key the name of the variable
* @param value the double to set
*/
* @param key the name of the variable
* @param value the double to set
*/
-void
xbt_cfg_set_double(const char *
key, double value)
+void
sg_cfg_set_double(const char*
key, double value)
{
(*simgrid_config)[key].set_value<double>(value);
}
{
(*simgrid_config)[key].set_value<double>(value);
}
@@
-522,7
+506,7
@@
void xbt_cfg_set_double(const char *key, double value)
* @param value the value to be added
*
*/
* @param value the value to be added
*
*/
-void
xbt
_cfg_set_string(const char* key, const char* value)
+void
sg
_cfg_set_string(const char* key, const char* value)
{
(*simgrid_config)[key].set_value<std::string>(value);
}
{
(*simgrid_config)[key].set_value<std::string>(value);
}
@@
-532,7
+516,7
@@
void xbt_cfg_set_string(const char* key, const char* value)
* @param key the name of the variable
* @param value the value of the variable
*/
* @param key the name of the variable
* @param value the value of the variable
*/
-void
xbt_cfg_set_boolean(const char *key, const char *
value)
+void
sg_cfg_set_boolean(const char* key, const char*
value)
{
(*simgrid_config)[key].set_value<bool>(simgrid::config::parse_bool(value));
}
{
(*simgrid_config)[key].set_value<bool>(simgrid::config::parse_bool(value));
}
@@
-544,7
+528,7
@@
void xbt_cfg_set_boolean(const char *key, const char *value)
*
* Returns the first value from the config set under the given name.
*/
*
* Returns the first value from the config set under the given name.
*/
-int
xbt_cfg_get_int(const char *
key)
+int
sg_cfg_get_int(const char*
key)
{
return (*simgrid_config)[key].get_value<int>();
}
{
return (*simgrid_config)[key].get_value<int>();
}
@@
-555,7
+539,7
@@
int xbt_cfg_get_int(const char *key)
*
* Returns the first value from the config set under the given name.
*/
*
* Returns the first value from the config set under the given name.
*/
-double
xbt_cfg_get_double(const char *
key)
+double
sg_cfg_get_double(const char*
key)
{
return (*simgrid_config)[key].get_value<double>();
}
{
return (*simgrid_config)[key].get_value<double>();
}
@@
-567,7
+551,7
@@
double xbt_cfg_get_double(const char *key)
* Returns the first value from the config set under the given name.
* If there is more than one value, it will issue a warning.
*/
* Returns the first value from the config set under the given name.
* If there is more than one value, it will issue a warning.
*/
-int
xbt_cfg_get_boolean(const char *
key)
+int
sg_cfg_get_boolean(const char*
key)
{
return (*simgrid_config)[key].get_value<bool>() ? 1 : 0;
}
{
return (*simgrid_config)[key].get_value<bool>() ? 1 : 0;
}