src/sthread/ObjectAccess.cpp

   1 /* Copyright (c) 2002-2023. The SimGrid Team. All rights reserved.          */
   2
   3 /* This program is free software; you can redistribute it and/or modify it
   4  * under the terms of the license (GNU LGPL) which comes with this package. */
   5
   6 /* Object access checker, for use in sthread. */
   7
   8 #include "simgrid/modelchecker.h"
   9 #include "simgrid/s4u/Actor.hpp"
  10 #include "simgrid/simix.hpp"
  11 #include "src/kernel/actor/ActorImpl.hpp"
  12 #include "src/kernel/actor/SimcallObserver.hpp"
  13 #include "src/sthread/sthread.h"
  14 #include "xbt/string.hpp"
  15
  16 #include <unordered_map>
  17
  18 XBT_LOG_EXTERNAL_DEFAULT_CATEGORY(sthread);
  19
  20 namespace simgrid::sthread {
  21 XBT_DECLARE_ENUM_CLASS(AccessType, ENTER, EXIT, BOTH);
  22
  23 class ObjectAccessObserver final : public simgrid::kernel::actor::SimcallObserver {
  24   AccessType type_;
  25   void* objaddr_;
  26   const char* objname_;
  27   const char* file_;
  28   int line_;
  29
  30 public:
  31   ObjectAccessObserver(simgrid::kernel::actor::ActorImpl* actor, AccessType type, void* objaddr, const char* objname,
  32                        const char* file, int line)
  33       : SimcallObserver(actor), type_(type), objaddr_(objaddr), objname_(objname), file_(file), line_(line)
  34   {
  35   }
  36   void serialize(std::stringstream& stream) const override;
  37   std::string to_string() const override;
  38 };
  39 void ObjectAccessObserver::serialize(std::stringstream& stream) const
  40 {
  41   stream << (short)mc::Transition::Type::OBJECT_ACCESS << ' ';
  42   stream << (short)type_ << ' ' << objaddr_ << ' ' << objname_ << ' ' << file_ << ' ' << line_;
  43 }
  44 std::string ObjectAccessObserver::to_string() const
  45 {
  46   return std::string("AccessObject(") + objname_ + ")";
  47 }
  48 }; // namespace simgrid::sthread
  49
  50 struct ObjectOwner {
  51   simgrid::kernel::actor::ActorImpl* owner = nullptr;
  52   const char* file                         = nullptr;
  53   int line                                 = -1;
  54   int recursive_depth                      = 0;
  55   explicit ObjectOwner(simgrid::kernel::actor::ActorImpl* o) : owner(o) {}
  56 };
  57
  58 std::unordered_map<void*, ObjectOwner*> owners;
  59 static void clean_owners()
  60 {
  61   for (auto it = owners.begin(); it != owners.end();) {
  62     delete it->second;
  63     it = owners.erase(it);
  64   }
  65 }
  66 static ObjectOwner* get_owner(void* object)
  67 {
  68   if (owners.empty())
  69     std::atexit(clean_owners);
  70   if (auto it = owners.find(object); it != owners.end())
  71     return it->second;
  72   auto* o = new ObjectOwner(nullptr);
  73   owners.emplace(object, o);
  74   return o;
  75 }
  76
  77 int sthread_access_begin(void* objaddr, const char* objname, const char* file, int line, const char* func)
  78 {
  79   sthread_disable();
  80   auto* self = simgrid::kernel::actor::ActorImpl::self();
  81   simgrid::sthread::ObjectAccessObserver observer(self, simgrid::sthread::AccessType::ENTER, objaddr, objname, file,
  82                                                   line);
  83   bool success = simgrid::kernel::actor::simcall_answered(
  84       [self, objaddr, objname, file, line]() -> bool {
  85         XBT_INFO("%s takes %s", self->get_cname(), objname);
  86         auto* ownership = get_owner(objaddr);
  87         if (ownership->owner == self) {
  88           ownership->recursive_depth++;
  89           return true;
  90         } else if (ownership->owner != nullptr) {
  91           auto msg = std::string("Unprotected concurent access to ") + objname + ": " + ownership->owner->get_name();
  92           if (not xbt_log_no_loc) {
  93             msg += simgrid::xbt::string_printf(" at %s:%d", ownership->file, ownership->line);
  94             if (ownership->recursive_depth > 1)
  95               msg += simgrid::xbt::string_printf(" (and %d other locations)", ownership->recursive_depth - 1);
  96           } else {
  97             msg += simgrid::xbt::string_printf(" from %d locations (remove --log=no_loc for details)",
  98                                                ownership->recursive_depth);
  99           }
 100           msg += " vs " + self->get_name();
 101           if (xbt_log_no_loc)
 102             msg += std::string(" (locations hidden because of --log=no_loc).");
 103           else
 104             msg += simgrid::xbt::string_printf(" at %s:%d.", file, line);
 105           XBT_CRITICAL("%s", msg.c_str());
 106           return false;
 107         }
 108         ownership->owner = self;
 109         ownership->file  = file;
 110         ownership->line  = line;
 111         ownership->recursive_depth = 1;
 112         return true;
 113       },
 114       &observer);
 115   MC_assert(success);
 116   xbt_assert(success, "Problem detected, bailing out");
 117   sthread_enable();
 118   return true;
 119 }
 120 void sthread_access_end(void* objaddr, const char* objname, const char* file, int line, const char* func)
 121 {
 122   sthread_disable();
 123   auto* self = simgrid::kernel::actor::ActorImpl::self();
 124   simgrid::sthread::ObjectAccessObserver observer(self, simgrid::sthread::AccessType::EXIT, objaddr, objname, file,
 125                                                   line);
 126   simgrid::kernel::actor::simcall_answered(
 127       [self, objaddr, objname]() -> void {
 128         XBT_INFO("%s releases %s", self->get_cname(), objname);
 129         auto* ownership = get_owner(objaddr);
 130         xbt_assert(ownership->owner == self,
 131                    "safety check failed: %s is not owner of the object it's releasing. That object owned by %s.",
 132                    self->get_cname(), (ownership->owner == nullptr ? "nobody" : ownership->owner->get_cname()));
 133         ownership->recursive_depth--;
 134         if (ownership->recursive_depth == 0)
 135           ownership->owner = nullptr;
 136       },
 137       &observer);
 138   sthread_enable();
 139 }